)]}'
{"Gemfile":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"9e6bc9783fc88d2a0fdd342af3caab1dd53f9e12","unresolved":false,"context_lines":[{"line_number":1,"context_line":"source ENV[\u0027GEM_SOURCE\u0027] || \"https://rubygems.org\""},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"group :development, :test, :system_tests do"},{"line_number":4,"context_line":"  gem \u0027puppet-openstack_spec_helper\u0027, :require \u003d\u003e \u0027false\u0027, :git \u003d\u003e \u0027https://git.openstack.org/openstack/puppet-openstack_spec_helper\u0027"},{"line_number":5,"context_line":"end"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"if facterversion \u003d ENV[\u0027FACTER_GEM_VERSION\u0027]"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"9abb7d3a_c9de2bdc","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":2},"updated":"2016-06-01 13:38:16.000000000","message":"can you skip lines to be more easy to read? Like in https://github.com/openstack/puppet-keystone/blob/master/Gemfile","commit_id":"be522d8f7b1caf5f7d8571e4a6a86528db2aa545"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"c6bf3b954de41900bcd5d0e34afe93b7c91524b7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"source ENV[\u0027GEM_SOURCE\u0027] || \"https://rubygems.org\""},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"group :development, :test, :system_tests do"},{"line_number":4,"context_line":"  gem \u0027puppet-openstack_spec_helper\u0027, :require \u003d\u003e \u0027false\u0027, :git \u003d\u003e \u0027https://git.openstack.org/openstack/puppet-openstack_spec_helper\u0027"},{"line_number":5,"context_line":"end"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"if facterversion \u003d ENV[\u0027FACTER_GEM_VERSION\u0027]"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"9abb7d3a_8cb5517f","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":2},"in_reply_to":"9abb7d3a_c9de2bdc","updated":"2016-06-01 13:50:44.000000000","message":"Sure","commit_id":"be522d8f7b1caf5f7d8571e4a6a86528db2aa545"}],"manifests/db.pp":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"9e6bc9783fc88d2a0fdd342af3caab1dd53f9e12","unresolved":false,"context_lines":[{"line_number":43,"context_line":"  $database_max_overflow   \u003d $::os_service_default,"},{"line_number":44,"context_line":") {"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"  $database_connection_real \u003d pick($::watcher::database_connection, $database_connection)"},{"line_number":47,"context_line":"  $database_idle_timeout_real \u003d pick($::watcher::database_idle_timeout, $database_idle_timeout)"},{"line_number":48,"context_line":"  $database_min_pool_size_real \u003d pick($::watcher::database_min_pool_size, $database_min_pool_size)"},{"line_number":49,"context_line":"  $database_max_pool_size_real \u003d pick($::watcher::database_max_pool_size, $database_max_pool_size)"},{"line_number":50,"context_line":"  $database_max_retries_real \u003d pick($::watcher::database_max_retries, $database_max_retries)"},{"line_number":51,"context_line":"  $database_retry_interval_real \u003d pick($::watcher::database_retry_interval, $database_retry_interval)"},{"line_number":52,"context_line":"  $database_max_overflow_real \u003d pick($::watcher::database_max_overflow, $database_max_overflow)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"  validate_re($database_connection_real,"},{"line_number":55,"context_line":"    \u0027^(sqlite|mysql(\\+pymysql)?|postgresql):\\/\\/(\\S+:\\S+@\\S+\\/\\S+)?\u0027)"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9abb7d3a_ec5cdd1a","line":52,"range":{"start_line":46,"start_character":0,"end_line":52,"end_character":95},"updated":"2016-06-01 13:38:16.000000000","message":"you don\u0027t need this because the module is new and all parameters for db should be here \u003d)","commit_id":"be522d8f7b1caf5f7d8571e4a6a86528db2aa545"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"c6bf3b954de41900bcd5d0e34afe93b7c91524b7","unresolved":false,"context_lines":[{"line_number":43,"context_line":"  $database_max_overflow   \u003d $::os_service_default,"},{"line_number":44,"context_line":") {"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"  $database_connection_real \u003d pick($::watcher::database_connection, $database_connection)"},{"line_number":47,"context_line":"  $database_idle_timeout_real \u003d pick($::watcher::database_idle_timeout, $database_idle_timeout)"},{"line_number":48,"context_line":"  $database_min_pool_size_real \u003d pick($::watcher::database_min_pool_size, $database_min_pool_size)"},{"line_number":49,"context_line":"  $database_max_pool_size_real \u003d pick($::watcher::database_max_pool_size, $database_max_pool_size)"},{"line_number":50,"context_line":"  $database_max_retries_real \u003d pick($::watcher::database_max_retries, $database_max_retries)"},{"line_number":51,"context_line":"  $database_retry_interval_real \u003d pick($::watcher::database_retry_interval, $database_retry_interval)"},{"line_number":52,"context_line":"  $database_max_overflow_real \u003d pick($::watcher::database_max_overflow, $database_max_overflow)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"  validate_re($database_connection_real,"},{"line_number":55,"context_line":"    \u0027^(sqlite|mysql(\\+pymysql)?|postgresql):\\/\\/(\\S+:\\S+@\\S+\\/\\S+)?\u0027)"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9abb7d3a_0f6cb39a","line":52,"range":{"start_line":46,"start_character":0,"end_line":52,"end_character":95},"in_reply_to":"9abb7d3a_ec5cdd1a","updated":"2016-06-01 13:50:44.000000000","message":"ok","commit_id":"be522d8f7b1caf5f7d8571e4a6a86528db2aa545"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"9e6bc9783fc88d2a0fdd342af3caab1dd53f9e12","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    \u0027^(sqlite|mysql(\\+pymysql)?|postgresql):\\/\\/(\\S+:\\S+@\\S+\\/\\S+)?\u0027)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"  oslo::db { \u0027watcher_config\u0027:"},{"line_number":58,"context_line":"    connection     \u003d\u003e $database_connection_real,"},{"line_number":59,"context_line":"    idle_timeout   \u003d\u003e $database_idle_timeout_real,"},{"line_number":60,"context_line":"    min_pool_size  \u003d\u003e $database_min_pool_size_real,"},{"line_number":61,"context_line":"    max_retries    \u003d\u003e $database_max_retries_real,"},{"line_number":62,"context_line":"    retry_interval \u003d\u003e $database_retry_interval_real,"},{"line_number":63,"context_line":"    max_pool_size  \u003d\u003e $database_max_pool_size_real,"},{"line_number":64,"context_line":"    max_overflow   \u003d\u003e $database_max_overflow_real,"},{"line_number":65,"context_line":"  }"},{"line_number":66,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9abb7d3a_acadb5ea","line":64,"range":{"start_line":58,"start_character":0,"end_line":64,"end_character":50},"updated":"2016-06-01 13:38:16.000000000","message":"remove the _real from variables to match the class variables","commit_id":"be522d8f7b1caf5f7d8571e4a6a86528db2aa545"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"c6bf3b954de41900bcd5d0e34afe93b7c91524b7","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    \u0027^(sqlite|mysql(\\+pymysql)?|postgresql):\\/\\/(\\S+:\\S+@\\S+\\/\\S+)?\u0027)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"  oslo::db { \u0027watcher_config\u0027:"},{"line_number":58,"context_line":"    connection     \u003d\u003e $database_connection_real,"},{"line_number":59,"context_line":"    idle_timeout   \u003d\u003e $database_idle_timeout_real,"},{"line_number":60,"context_line":"    min_pool_size  \u003d\u003e $database_min_pool_size_real,"},{"line_number":61,"context_line":"    max_retries    \u003d\u003e $database_max_retries_real,"},{"line_number":62,"context_line":"    retry_interval \u003d\u003e $database_retry_interval_real,"},{"line_number":63,"context_line":"    max_pool_size  \u003d\u003e $database_max_pool_size_real,"},{"line_number":64,"context_line":"    max_overflow   \u003d\u003e $database_max_overflow_real,"},{"line_number":65,"context_line":"  }"},{"line_number":66,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9abb7d3a_effdefb1","line":64,"range":{"start_line":58,"start_character":0,"end_line":64,"end_character":50},"in_reply_to":"9abb7d3a_acadb5ea","updated":"2016-06-01 13:50:44.000000000","message":"ok","commit_id":"be522d8f7b1caf5f7d8571e4a6a86528db2aa545"}],"manifests/db/sync.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"c0cb0c7f64da386e775506170d4dbc9b3207bcc2","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  $extra_params  \u003d undef,"},{"line_number":13,"context_line":") {"},{"line_number":14,"context_line":"  exec { \u0027watcher-db-sync\u0027:"},{"line_number":15,"context_line":"    command     \u003d\u003e \"watcher-manage db_sync ${extra_params}\","},{"line_number":16,"context_line":"    path        \u003d\u003e \u0027/usr/bin\u0027,"},{"line_number":17,"context_line":"    user        \u003d\u003e \u0027watcher\u0027,"},{"line_number":18,"context_line":"    refreshonly \u003d\u003e true,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9abb7d3a_38b9fbcc","line":15,"range":{"start_line":15,"start_character":20,"end_line":15,"end_character":58},"updated":"2016-06-01 14:30:02.000000000","message":"just to be sure - is it real command for db sync?","commit_id":"7fbf5773c10348e9e2771ea2b2d09ef84ac086ff"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"c02c18c9cc518d4349be22b8cecd770b3768901f","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  $extra_params  \u003d undef,"},{"line_number":13,"context_line":") {"},{"line_number":14,"context_line":"  exec { \u0027watcher-db-sync\u0027:"},{"line_number":15,"context_line":"    command     \u003d\u003e \"watcher-manage db_sync ${extra_params}\","},{"line_number":16,"context_line":"    path        \u003d\u003e \u0027/usr/bin\u0027,"},{"line_number":17,"context_line":"    user        \u003d\u003e \u0027watcher\u0027,"},{"line_number":18,"context_line":"    refreshonly \u003d\u003e true,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9abb7d3a_fe1c7b6b","line":15,"range":{"start_line":15,"start_character":20,"end_line":15,"end_character":58},"in_reply_to":"9abb7d3a_38b9fbcc","updated":"2016-06-01 14:47:32.000000000","message":"Watcher doesn\u0027t support sync, so this file will be removed.","commit_id":"7fbf5773c10348e9e2771ea2b2d09ef84ac086ff"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"e622aa911428c2de442ba152450a0927c2b6b69e","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  $extra_params  \u003d undef,"},{"line_number":13,"context_line":") {"},{"line_number":14,"context_line":"  exec { \u0027watcher-db-sync\u0027:"},{"line_number":15,"context_line":"    command     \u003d\u003e \"watcher-manage db_sync ${extra_params}\","},{"line_number":16,"context_line":"    path        \u003d\u003e \u0027/usr/bin\u0027,"},{"line_number":17,"context_line":"    user        \u003d\u003e \u0027watcher\u0027,"},{"line_number":18,"context_line":"    refreshonly \u003d\u003e true,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9abb7d3a_d6d68026","line":15,"range":{"start_line":15,"start_character":20,"end_line":15,"end_character":58},"in_reply_to":"9abb7d3a_9edbaf7b","updated":"2016-06-02 14:11:41.000000000","message":"I will leave it for this commit, but in next review this file will be removed and related tests will be changed. Ok?","commit_id":"7fbf5773c10348e9e2771ea2b2d09ef84ac086ff"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"19fcf71fe5229f292d90c6507c53269a248b6cc7","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  $extra_params  \u003d undef,"},{"line_number":13,"context_line":") {"},{"line_number":14,"context_line":"  exec { \u0027watcher-db-sync\u0027:"},{"line_number":15,"context_line":"    command     \u003d\u003e \"watcher-manage db_sync ${extra_params}\","},{"line_number":16,"context_line":"    path        \u003d\u003e \u0027/usr/bin\u0027,"},{"line_number":17,"context_line":"    user        \u003d\u003e \u0027watcher\u0027,"},{"line_number":18,"context_line":"    refreshonly \u003d\u003e true,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9abb7d3a_9edbaf7b","line":15,"range":{"start_line":15,"start_character":20,"end_line":15,"end_character":58},"in_reply_to":"9abb7d3a_fe1c7b6b","updated":"2016-06-01 14:49:28.000000000","message":"Then you can do it in this patch and also you can remove related spec test.","commit_id":"7fbf5773c10348e9e2771ea2b2d09ef84ac086ff"}],"manifests/logging.pp":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"807068ffa92b67a251eb3c0c2bdcb9f41d59acee","unresolved":false,"context_lines":[{"line_number":16,"context_line":"#    (optional) Use stderr for logging"},{"line_number":17,"context_line":"#    Defaults to $::os_service_default"},{"line_number":18,"context_line":"#"},{"line_number":19,"context_line":"#  [*log_facility*]"},{"line_number":20,"context_line":"#    (Optional) Syslog facility to receive log lines."},{"line_number":21,"context_line":"#    Defaults to $::os_service_default"},{"line_number":22,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9abb7d3a_ce9d68bd","line":19,"range":{"start_line":19,"start_character":5,"end_line":19,"end_character":17},"updated":"2016-06-02 03:24:53.000000000","message":"can you change to syslog_log_facility ? modules does not have log_facility and if you take a look at oslo code is syslog_log_facility \u003d)","commit_id":"7fbf5773c10348e9e2771ea2b2d09ef84ac086ff"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"deb55319817f0b26ffde0b79fe13a98c7ae07385","unresolved":false,"context_lines":[{"line_number":16,"context_line":"#    (optional) Use stderr for logging"},{"line_number":17,"context_line":"#    Defaults to $::os_service_default"},{"line_number":18,"context_line":"#"},{"line_number":19,"context_line":"#  [*log_facility*]"},{"line_number":20,"context_line":"#    (Optional) Syslog facility to receive log lines."},{"line_number":21,"context_line":"#    Defaults to $::os_service_default"},{"line_number":22,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9abb7d3a_90b52033","line":19,"range":{"start_line":19,"start_character":5,"end_line":19,"end_character":17},"in_reply_to":"9abb7d3a_bbbf725f","updated":"2016-06-02 13:46:31.000000000","message":"ok","commit_id":"7fbf5773c10348e9e2771ea2b2d09ef84ac086ff"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"aebfd503a9e5310013951ed6d3cce321855cc7e2","unresolved":false,"context_lines":[{"line_number":16,"context_line":"#    (optional) Use stderr for logging"},{"line_number":17,"context_line":"#    Defaults to $::os_service_default"},{"line_number":18,"context_line":"#"},{"line_number":19,"context_line":"#  [*log_facility*]"},{"line_number":20,"context_line":"#    (Optional) Syslog facility to receive log lines."},{"line_number":21,"context_line":"#    Defaults to $::os_service_default"},{"line_number":22,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9abb7d3a_bbbf725f","line":19,"range":{"start_line":19,"start_character":5,"end_line":19,"end_character":17},"in_reply_to":"9abb7d3a_ce9d68bd","updated":"2016-06-02 10:24:57.000000000","message":"Good catch, yes, please remove this parameter.","commit_id":"7fbf5773c10348e9e2771ea2b2d09ef84ac086ff"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"807068ffa92b67a251eb3c0c2bdcb9f41d59acee","unresolved":false,"context_lines":[{"line_number":96,"context_line":"class watcher::logging("},{"line_number":97,"context_line":"  $use_syslog                    \u003d $::os_service_default,"},{"line_number":98,"context_line":"  $use_stderr                    \u003d $::os_service_default,"},{"line_number":99,"context_line":"  $log_facility                  \u003d $::os_service_default,"},{"line_number":100,"context_line":"  $log_dir                       \u003d \u0027/var/log/watcher\u0027,"},{"line_number":101,"context_line":"  $log_file                      \u003d \u0027/var/log/watcher/watcher.log\u0027,"},{"line_number":102,"context_line":"  $debug                         \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9abb7d3a_eea66c0d","line":99,"range":{"start_line":99,"start_character":3,"end_line":99,"end_character":14},"updated":"2016-06-02 03:24:53.000000000","message":"same here","commit_id":"7fbf5773c10348e9e2771ea2b2d09ef84ac086ff"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"deb55319817f0b26ffde0b79fe13a98c7ae07385","unresolved":false,"context_lines":[{"line_number":96,"context_line":"class watcher::logging("},{"line_number":97,"context_line":"  $use_syslog                    \u003d $::os_service_default,"},{"line_number":98,"context_line":"  $use_stderr                    \u003d $::os_service_default,"},{"line_number":99,"context_line":"  $log_facility                  \u003d $::os_service_default,"},{"line_number":100,"context_line":"  $log_dir                       \u003d \u0027/var/log/watcher\u0027,"},{"line_number":101,"context_line":"  $log_file                      \u003d \u0027/var/log/watcher/watcher.log\u0027,"},{"line_number":102,"context_line":"  $debug                         \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9abb7d3a_307b947d","line":99,"range":{"start_line":99,"start_character":3,"end_line":99,"end_character":14},"in_reply_to":"9abb7d3a_eea66c0d","updated":"2016-06-02 13:46:31.000000000","message":"ok","commit_id":"7fbf5773c10348e9e2771ea2b2d09ef84ac086ff"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"807068ffa92b67a251eb3c0c2bdcb9f41d59acee","unresolved":false,"context_lines":[{"line_number":130,"context_line":"    instance_format               \u003d\u003e $instance_format,"},{"line_number":131,"context_line":"    instance_uuid_format          \u003d\u003e $instance_uuid_format,"},{"line_number":132,"context_line":"    log_date_format               \u003d\u003e $log_date_format,"},{"line_number":133,"context_line":"    syslog_log_facility           \u003d\u003e $log_facility,"},{"line_number":134,"context_line":"  }"},{"line_number":135,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9abb7d3a_2ead14e9","line":133,"range":{"start_line":133,"start_character":38,"end_line":133,"end_character":50},"updated":"2016-06-02 03:24:53.000000000","message":"same here","commit_id":"7fbf5773c10348e9e2771ea2b2d09ef84ac086ff"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"aebfd503a9e5310013951ed6d3cce321855cc7e2","unresolved":false,"context_lines":[{"line_number":130,"context_line":"    instance_format               \u003d\u003e $instance_format,"},{"line_number":131,"context_line":"    instance_uuid_format          \u003d\u003e $instance_uuid_format,"},{"line_number":132,"context_line":"    log_date_format               \u003d\u003e $log_date_format,"},{"line_number":133,"context_line":"    syslog_log_facility           \u003d\u003e $log_facility,"},{"line_number":134,"context_line":"  }"},{"line_number":135,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9abb7d3a_bb665227","line":133,"range":{"start_line":133,"start_character":38,"end_line":133,"end_character":50},"in_reply_to":"9abb7d3a_2ead14e9","updated":"2016-06-02 10:24:57.000000000","message":"syslog_log_facility now :)","commit_id":"7fbf5773c10348e9e2771ea2b2d09ef84ac086ff"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"e622aa911428c2de442ba152450a0927c2b6b69e","unresolved":false,"context_lines":[{"line_number":130,"context_line":"    instance_format               \u003d\u003e $instance_format,"},{"line_number":131,"context_line":"    instance_uuid_format          \u003d\u003e $instance_uuid_format,"},{"line_number":132,"context_line":"    log_date_format               \u003d\u003e $log_date_format,"},{"line_number":133,"context_line":"    syslog_log_facility           \u003d\u003e $log_facility,"},{"line_number":134,"context_line":"  }"},{"line_number":135,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9abb7d3a_36aa6c86","line":133,"range":{"start_line":133,"start_character":38,"end_line":133,"end_character":50},"in_reply_to":"9abb7d3a_908c0081","updated":"2016-06-02 14:11:41.000000000","message":"I will change it*","commit_id":"7fbf5773c10348e9e2771ea2b2d09ef84ac086ff"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"deb55319817f0b26ffde0b79fe13a98c7ae07385","unresolved":false,"context_lines":[{"line_number":130,"context_line":"    instance_format               \u003d\u003e $instance_format,"},{"line_number":131,"context_line":"    instance_uuid_format          \u003d\u003e $instance_uuid_format,"},{"line_number":132,"context_line":"    log_date_format               \u003d\u003e $log_date_format,"},{"line_number":133,"context_line":"    syslog_log_facility           \u003d\u003e $log_facility,"},{"line_number":134,"context_line":"  }"},{"line_number":135,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9abb7d3a_908c0081","line":133,"range":{"start_line":133,"start_character":38,"end_line":133,"end_character":50},"in_reply_to":"9abb7d3a_bb665227","updated":"2016-06-02 13:46:31.000000000","message":"I will remove it ;)","commit_id":"7fbf5773c10348e9e2771ea2b2d09ef84ac086ff"}],"manifests/params.pp":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"7b4d8c14d7802d68b54e33e2ae9dc8e3069b2d75","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"  case $::osfamily {"},{"line_number":6,"context_line":"    \u0027RedHat\u0027: {"},{"line_number":7,"context_line":"      $sqlite_package_name  \u003d undef"},{"line_number":8,"context_line":"      $pymysql_package_name \u003d undef"},{"line_number":9,"context_line":"    }"},{"line_number":10,"context_line":"    \u0027Debian\u0027: {"},{"line_number":11,"context_line":"      $sqlite_package_name  \u003d \u0027python-pysqlite2\u0027"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9abb7d3a_5d37914c","line":8,"range":{"start_line":7,"start_character":0,"end_line":8,"end_character":35},"updated":"2016-06-01 14:26:11.000000000","message":"you can remove this since oslo configure the db","commit_id":"7fbf5773c10348e9e2771ea2b2d09ef84ac086ff"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"c02c18c9cc518d4349be22b8cecd770b3768901f","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"  case $::osfamily {"},{"line_number":6,"context_line":"    \u0027RedHat\u0027: {"},{"line_number":7,"context_line":"      $sqlite_package_name  \u003d undef"},{"line_number":8,"context_line":"      $pymysql_package_name \u003d undef"},{"line_number":9,"context_line":"    }"},{"line_number":10,"context_line":"    \u0027Debian\u0027: {"},{"line_number":11,"context_line":"      $sqlite_package_name  \u003d \u0027python-pysqlite2\u0027"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9abb7d3a_e3eb48da","line":8,"range":{"start_line":7,"start_character":0,"end_line":8,"end_character":35},"in_reply_to":"9abb7d3a_5d37914c","updated":"2016-06-01 14:47:32.000000000","message":"ok","commit_id":"7fbf5773c10348e9e2771ea2b2d09ef84ac086ff"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"7b4d8c14d7802d68b54e33e2ae9dc8e3069b2d75","unresolved":false,"context_lines":[{"line_number":8,"context_line":"      $pymysql_package_name \u003d undef"},{"line_number":9,"context_line":"    }"},{"line_number":10,"context_line":"    \u0027Debian\u0027: {"},{"line_number":11,"context_line":"      $sqlite_package_name  \u003d \u0027python-pysqlite2\u0027"},{"line_number":12,"context_line":"      $pymysql_package_name \u003d \u0027python-pymysql\u0027"},{"line_number":13,"context_line":"    }"},{"line_number":14,"context_line":"    default: {"},{"line_number":15,"context_line":"      fail(\"Unsupported osfamily: ${::osfamily} operatingsystem\")"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9abb7d3a_ddec21bd","line":12,"range":{"start_line":11,"start_character":0,"end_line":12,"end_character":46},"updated":"2016-06-01 14:26:11.000000000","message":"you can remove this since oslo configure the db","commit_id":"7fbf5773c10348e9e2771ea2b2d09ef84ac086ff"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"c02c18c9cc518d4349be22b8cecd770b3768901f","unresolved":false,"context_lines":[{"line_number":8,"context_line":"      $pymysql_package_name \u003d undef"},{"line_number":9,"context_line":"    }"},{"line_number":10,"context_line":"    \u0027Debian\u0027: {"},{"line_number":11,"context_line":"      $sqlite_package_name  \u003d \u0027python-pysqlite2\u0027"},{"line_number":12,"context_line":"      $pymysql_package_name \u003d \u0027python-pymysql\u0027"},{"line_number":13,"context_line":"    }"},{"line_number":14,"context_line":"    default: {"},{"line_number":15,"context_line":"      fail(\"Unsupported osfamily: ${::osfamily} operatingsystem\")"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9abb7d3a_43bdf4d6","line":12,"range":{"start_line":11,"start_character":0,"end_line":12,"end_character":46},"in_reply_to":"9abb7d3a_ddec21bd","updated":"2016-06-01 14:47:32.000000000","message":"ok","commit_id":"7fbf5773c10348e9e2771ea2b2d09ef84ac086ff"}],"spec/classes/watcher_keystone_auth_spec.rb":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"3d9b213e03efa83f24495cd625a40855b17bb0c1","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"      it { is_expected.to contain_keystone_service(\u0027watcher::infra-optim\u0027).with("},{"line_number":26,"context_line":"        :ensure      \u003d\u003e \u0027present\u0027,"},{"line_number":27,"context_line":"        :description \u003d\u003e \u0027Infrastructure Optimization service\u0027"},{"line_number":28,"context_line":"      ) }"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"      it { is_expected.to contain_keystone_endpoint(\u0027RegionOne/watcher::infra-optim\u0027).with("}],"source_content_type":"text/x-ruby","patch_set":3,"id":"9abb7d3a_630ef3e6","line":27,"range":{"start_line":27,"start_character":53,"end_line":27,"end_character":54},"updated":"2016-06-02 15:28:20.000000000","message":"why not Service? change s to S","commit_id":"812594b6d9cc879f658660e686a354108d142c42"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"ccaa12cce290ee83d6a5e8de1ec18563b78989be","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"      it { is_expected.to contain_keystone_service(\u0027watcher::infra-optim\u0027).with("},{"line_number":26,"context_line":"        :ensure      \u003d\u003e \u0027present\u0027,"},{"line_number":27,"context_line":"        :description \u003d\u003e \u0027Infrastructure Optimization service\u0027"},{"line_number":28,"context_line":"      ) }"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"      it { is_expected.to contain_keystone_endpoint(\u0027RegionOne/watcher::infra-optim\u0027).with("}],"source_content_type":"text/x-ruby","patch_set":3,"id":"9abb7d3a_8b8209c7","line":27,"range":{"start_line":27,"start_character":53,"end_line":27,"end_character":54},"in_reply_to":"9abb7d3a_630ef3e6","updated":"2016-06-02 16:14:43.000000000","message":"Description is taken from documentation: https://factory.b-com.com/www/watcher/doc/watcher/deploy/configuration.html \n\nI will ask watcher team to change description and later I will change it here.","commit_id":"812594b6d9cc879f658660e686a354108d142c42"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"3d9b213e03efa83f24495cd625a40855b17bb0c1","unresolved":false,"context_lines":[{"line_number":89,"context_line":"      it { is_expected.to contain_keystone_user_role(\u0027watcher@services\u0027) }"},{"line_number":90,"context_line":"      it { is_expected.to contain_keystone_service(\u0027watcher::infra-optim\u0027).with("},{"line_number":91,"context_line":"        :ensure      \u003d\u003e \u0027present\u0027,"},{"line_number":92,"context_line":"        :description \u003d\u003e \u0027Infrastructure Optimization service\u0027"},{"line_number":93,"context_line":"      ) }"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"9abb7d3a_d9750c33","line":92,"range":{"start_line":92,"start_character":53,"end_line":92,"end_character":54},"updated":"2016-06-02 15:28:20.000000000","message":"same here","commit_id":"812594b6d9cc879f658660e686a354108d142c42"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"ccaa12cce290ee83d6a5e8de1ec18563b78989be","unresolved":false,"context_lines":[{"line_number":89,"context_line":"      it { is_expected.to contain_keystone_user_role(\u0027watcher@services\u0027) }"},{"line_number":90,"context_line":"      it { is_expected.to contain_keystone_service(\u0027watcher::infra-optim\u0027).with("},{"line_number":91,"context_line":"        :ensure      \u003d\u003e \u0027present\u0027,"},{"line_number":92,"context_line":"        :description \u003d\u003e \u0027Infrastructure Optimization service\u0027"},{"line_number":93,"context_line":"      ) }"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"9abb7d3a_0be579a7","line":92,"range":{"start_line":92,"start_character":53,"end_line":92,"end_character":54},"in_reply_to":"9abb7d3a_d9750c33","updated":"2016-06-02 16:14:43.000000000","message":"as above","commit_id":"812594b6d9cc879f658660e686a354108d142c42"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"3d9b213e03efa83f24495cd625a40855b17bb0c1","unresolved":false,"context_lines":[{"line_number":108,"context_line":"      it { is_expected.not_to contain_keystone_user_role(\u0027watcher@services\u0027) }"},{"line_number":109,"context_line":"      it { is_expected.to contain_keystone_service(\u0027watcher::infra-optim\u0027).with("},{"line_number":110,"context_line":"        :ensure      \u003d\u003e \u0027present\u0027,"},{"line_number":111,"context_line":"        :description \u003d\u003e \u0027Infrastructure Optimization service\u0027"},{"line_number":112,"context_line":"      ) }"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"9abb7d3a_5998fc6a","line":111,"range":{"start_line":111,"start_character":53,"end_line":111,"end_character":54},"updated":"2016-06-02 15:28:20.000000000","message":"same here","commit_id":"812594b6d9cc879f658660e686a354108d142c42"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"ccaa12cce290ee83d6a5e8de1ec18563b78989be","unresolved":false,"context_lines":[{"line_number":108,"context_line":"      it { is_expected.not_to contain_keystone_user_role(\u0027watcher@services\u0027) }"},{"line_number":109,"context_line":"      it { is_expected.to contain_keystone_service(\u0027watcher::infra-optim\u0027).with("},{"line_number":110,"context_line":"        :ensure      \u003d\u003e \u0027present\u0027,"},{"line_number":111,"context_line":"        :description \u003d\u003e \u0027Infrastructure Optimization service\u0027"},{"line_number":112,"context_line":"      ) }"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"9abb7d3a_2bf2fd6f","line":111,"range":{"start_line":111,"start_character":53,"end_line":111,"end_character":54},"in_reply_to":"9abb7d3a_5998fc6a","updated":"2016-06-02 16:14:43.000000000","message":"as above","commit_id":"812594b6d9cc879f658660e686a354108d142c42"}]}