)]}'
{"manifests/init.pp":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"0612ca05d140caa1afbacb77a7f27e30a263d6e5","unresolved":false,"context_lines":[{"line_number":420,"context_line":"  $kombu_compression                    \u003d $::os_service_default,"},{"line_number":421,"context_line":"  $amqp_durable_queues                  \u003d $::os_service_default,"},{"line_number":422,"context_line":"  $watcher_planner                      \u003d undef,"},{"line_number":423,"context_line":"  # logging"},{"line_number":424,"context_line":"  $use_syslog                           \u003d $::os_service_default,"},{"line_number":425,"context_line":"  $use_stderr                           \u003d $::os_service_default,"},{"line_number":426,"context_line":"  $log_facility                         \u003d $::os_service_default,"},{"line_number":427,"context_line":"  $log_dir                              \u003d $::os_service_default,"},{"line_number":428,"context_line":"  $verbose                              \u003d $::os_service_default,"},{"line_number":429,"context_line":"  $debug                                \u003d $::os_service_default,"},{"line_number":430,"context_line":"  $logging_context_format_string        \u003d $::os_service_default,"},{"line_number":431,"context_line":"  $logging_default_format_string        \u003d $::os_service_default,"},{"line_number":432,"context_line":"  $logging_debug_format_suffix          \u003d $::os_service_default,"},{"line_number":433,"context_line":"  $logging_exception_prefix             \u003d $::os_service_default,"},{"line_number":434,"context_line":"  $log_config_append                    \u003d $::os_service_default,"},{"line_number":435,"context_line":"  $default_log_levels                   \u003d $::os_service_default,"},{"line_number":436,"context_line":"  $publish_errors                       \u003d $::os_service_default,"},{"line_number":437,"context_line":"  $fatal_deprecations                   \u003d $::os_service_default,"},{"line_number":438,"context_line":"  $instance_format                      \u003d $::os_service_default,"},{"line_number":439,"context_line":"  $instance_uuid_format                 \u003d $::os_service_default,"},{"line_number":440,"context_line":"  $log_date_format                      \u003d $::os_service_default,"},{"line_number":441,"context_line":"  # amqp"},{"line_number":442,"context_line":"  $amqp_username                        \u003d $::os_service_default,"},{"line_number":443,"context_line":"  $amqp_password                        \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7aa08908_60a8288e","line":440,"range":{"start_line":423,"start_character":1,"end_line":440,"end_character":64},"updated":"2016-06-07 20:41:31.000000000","message":"you don\u0027t need this information because you have in logging class, ok? ^^","commit_id":"b7f126b65ace6531e8695dd020009e761cd5a415"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"a956add1821d19cd4489fe03ec38067e52c06ae3","unresolved":false,"context_lines":[{"line_number":420,"context_line":"  $kombu_compression                    \u003d $::os_service_default,"},{"line_number":421,"context_line":"  $amqp_durable_queues                  \u003d $::os_service_default,"},{"line_number":422,"context_line":"  $watcher_planner                      \u003d undef,"},{"line_number":423,"context_line":"  # logging"},{"line_number":424,"context_line":"  $use_syslog                           \u003d $::os_service_default,"},{"line_number":425,"context_line":"  $use_stderr                           \u003d $::os_service_default,"},{"line_number":426,"context_line":"  $log_facility                         \u003d $::os_service_default,"},{"line_number":427,"context_line":"  $log_dir                              \u003d $::os_service_default,"},{"line_number":428,"context_line":"  $verbose                              \u003d $::os_service_default,"},{"line_number":429,"context_line":"  $debug                                \u003d $::os_service_default,"},{"line_number":430,"context_line":"  $logging_context_format_string        \u003d $::os_service_default,"},{"line_number":431,"context_line":"  $logging_default_format_string        \u003d $::os_service_default,"},{"line_number":432,"context_line":"  $logging_debug_format_suffix          \u003d $::os_service_default,"},{"line_number":433,"context_line":"  $logging_exception_prefix             \u003d $::os_service_default,"},{"line_number":434,"context_line":"  $log_config_append                    \u003d $::os_service_default,"},{"line_number":435,"context_line":"  $default_log_levels                   \u003d $::os_service_default,"},{"line_number":436,"context_line":"  $publish_errors                       \u003d $::os_service_default,"},{"line_number":437,"context_line":"  $fatal_deprecations                   \u003d $::os_service_default,"},{"line_number":438,"context_line":"  $instance_format                      \u003d $::os_service_default,"},{"line_number":439,"context_line":"  $instance_uuid_format                 \u003d $::os_service_default,"},{"line_number":440,"context_line":"  $log_date_format                      \u003d $::os_service_default,"},{"line_number":441,"context_line":"  # amqp"},{"line_number":442,"context_line":"  $amqp_username                        \u003d $::os_service_default,"},{"line_number":443,"context_line":"  $amqp_password                        \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7aa08908_c6fc9474","line":440,"range":{"start_line":423,"start_character":1,"end_line":440,"end_character":64},"in_reply_to":"7aa08908_60a8288e","updated":"2016-06-07 21:04:28.000000000","message":"ok, I will remove it in next commit ;)","commit_id":"b7f126b65ace6531e8695dd020009e761cd5a415"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"0612ca05d140caa1afbacb77a7f27e30a263d6e5","unresolved":false,"context_lines":[{"line_number":491,"context_line":"  include ::watcher::db"},{"line_number":492,"context_line":"  include ::watcher::logging"},{"line_number":493,"context_line":""},{"line_number":494,"context_line":"  package { \u0027python-watcher\u0027:"},{"line_number":495,"context_line":"    ensure \u003d\u003e $ensure_package,"},{"line_number":496,"context_line":"    tag    \u003d\u003e [\u0027openstack\u0027, \u0027watcher-package\u0027],"},{"line_number":497,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7aa08908_dba2b198","line":494,"range":{"start_line":494,"start_character":13,"end_line":494,"end_character":28},"updated":"2016-06-07 20:41:31.000000000","message":"this is the same for RedHat and Debian?","commit_id":"b7f126b65ace6531e8695dd020009e761cd5a415"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"a956add1821d19cd4489fe03ec38067e52c06ae3","unresolved":false,"context_lines":[{"line_number":491,"context_line":"  include ::watcher::db"},{"line_number":492,"context_line":"  include ::watcher::logging"},{"line_number":493,"context_line":""},{"line_number":494,"context_line":"  package { \u0027python-watcher\u0027:"},{"line_number":495,"context_line":"    ensure \u003d\u003e $ensure_package,"},{"line_number":496,"context_line":"    tag    \u003d\u003e [\u0027openstack\u0027, \u0027watcher-package\u0027],"},{"line_number":497,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7aa08908_660b208f","line":494,"range":{"start_line":494,"start_character":13,"end_line":494,"end_character":28},"in_reply_to":"7aa08908_dba2b198","updated":"2016-06-07 21:04:28.000000000","message":"as below","commit_id":"b7f126b65ace6531e8695dd020009e761cd5a415"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"0612ca05d140caa1afbacb77a7f27e30a263d6e5","unresolved":false,"context_lines":[{"line_number":498,"context_line":""},{"line_number":499,"context_line":"  package { \u0027watcher-common\u0027:"},{"line_number":500,"context_line":"    ensure  \u003d\u003e $ensure_package,"},{"line_number":501,"context_line":"    name    \u003d\u003e $::watcher::params::common_package_name,"},{"line_number":502,"context_line":"    require \u003d\u003e Package[\u0027python-watcher\u0027],"},{"line_number":503,"context_line":"    tag     \u003d\u003e [\u0027openstack\u0027, \u0027watcher-common\u0027, \u0027watcher-package\u0027],"},{"line_number":504,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7aa08908_0075e462","line":501,"range":{"start_line":501,"start_character":15,"end_line":501,"end_character":54},"updated":"2016-06-07 20:41:31.000000000","message":"you don\u0027t have this, this should be in params.pp","commit_id":"b7f126b65ace6531e8695dd020009e761cd5a415"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"a956add1821d19cd4489fe03ec38067e52c06ae3","unresolved":false,"context_lines":[{"line_number":498,"context_line":""},{"line_number":499,"context_line":"  package { \u0027watcher-common\u0027:"},{"line_number":500,"context_line":"    ensure  \u003d\u003e $ensure_package,"},{"line_number":501,"context_line":"    name    \u003d\u003e $::watcher::params::common_package_name,"},{"line_number":502,"context_line":"    require \u003d\u003e Package[\u0027python-watcher\u0027],"},{"line_number":503,"context_line":"    tag     \u003d\u003e [\u0027openstack\u0027, \u0027watcher-common\u0027, \u0027watcher-package\u0027],"},{"line_number":504,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7aa08908_06cdfc65","line":501,"range":{"start_line":501,"start_character":15,"end_line":501,"end_character":54},"in_reply_to":"7aa08908_0075e462","updated":"2016-06-07 21:04:28.000000000","message":"I forgot to add new params file, but if I don\u0027t know what are the packages names, I suggest to remove it and add it later in new commit with new params.pp file.","commit_id":"b7f126b65ace6531e8695dd020009e761cd5a415"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"0612ca05d140caa1afbacb77a7f27e30a263d6e5","unresolved":false,"context_lines":[{"line_number":504,"context_line":"  }"},{"line_number":505,"context_line":""},{"line_number":506,"context_line":"  watcher_config {"},{"line_number":507,"context_line":"    \u0027ceilometer_client/api_version\u0027:    value \u003d\u003e $ceilometer_client_api_version;"},{"line_number":508,"context_line":"    \u0027cinder_client/api_version\u0027:        value \u003d\u003e $cinder_client_api_version;"},{"line_number":509,"context_line":"    \u0027glance_client/api_version\u0027:        value \u003d\u003e $glance_client_api_version;"},{"line_number":510,"context_line":"    \u0027neutron_client/api_version\u0027:       value \u003d\u003e $neutron_client_api_version;"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7aa08908_e0537869","line":507,"range":{"start_line":507,"start_character":37,"end_line":507,"end_character":40},"updated":"2016-06-07 20:41:31.000000000","message":"nit comment: some extra spaces that you don\u0027t need (do the same for the below parameters)","commit_id":"b7f126b65ace6531e8695dd020009e761cd5a415"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"0612ca05d140caa1afbacb77a7f27e30a263d6e5","unresolved":false,"context_lines":[{"line_number":567,"context_line":"      sasl_config_name       \u003d\u003e $amqp_sasl_config_name,"},{"line_number":568,"context_line":"    }"},{"line_number":569,"context_line":"  } elsif $rpc_backend \u003d\u003d \u0027zmq\u0027 {"},{"line_number":570,"context_line":"    watcher_config {"},{"line_number":571,"context_line":"      \u0027DEFAULT/zmq_target_expire\u0027:            value \u003d\u003e $zmq_target_expire;"},{"line_number":572,"context_line":"      \u0027DEFAULT/rpc_zmq_min_port\u0027:             value \u003d\u003e $rpc_zmq_min_port;"},{"line_number":573,"context_line":"      \u0027DEFAULT/rpc_zmq_bind_port_retries\u0027:    value \u003d\u003e $rpc_zmq_bind_port_retries;"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7aa08908_801a747b","line":570,"range":{"start_line":570,"start_character":4,"end_line":570,"end_character":18},"updated":"2016-06-07 20:41:31.000000000","message":"strange we don\u0027t have zmq for our puppet-oslo i\u0027ll ask Ivan if we can provide support \u003d). You don\u0027t need to change this for now.","commit_id":"b7f126b65ace6531e8695dd020009e761cd5a415"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"fe9fff135689833d19a5e44a2f1fffdcc8978c0e","unresolved":false,"context_lines":[{"line_number":567,"context_line":"      sasl_config_name       \u003d\u003e $amqp_sasl_config_name,"},{"line_number":568,"context_line":"    }"},{"line_number":569,"context_line":"  } elsif $rpc_backend \u003d\u003d \u0027zmq\u0027 {"},{"line_number":570,"context_line":"    watcher_config {"},{"line_number":571,"context_line":"      \u0027DEFAULT/zmq_target_expire\u0027:            value \u003d\u003e $zmq_target_expire;"},{"line_number":572,"context_line":"      \u0027DEFAULT/rpc_zmq_min_port\u0027:             value \u003d\u003e $rpc_zmq_min_port;"},{"line_number":573,"context_line":"      \u0027DEFAULT/rpc_zmq_bind_port_retries\u0027:    value \u003d\u003e $rpc_zmq_bind_port_retries;"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7aa08908_3a70ecdb","line":570,"range":{"start_line":570,"start_character":4,"end_line":570,"end_character":18},"in_reply_to":"7aa08908_801a747b","updated":"2016-06-08 10:10:07.000000000","message":"That\u0027s not strange, we have zmq in sahara. In oslo we have common rpc_backends and zmq was missed :)","commit_id":"b7f126b65ace6531e8695dd020009e761cd5a415"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"0612ca05d140caa1afbacb77a7f27e30a263d6e5","unresolved":false,"context_lines":[{"line_number":609,"context_line":""},{"line_number":610,"context_line":"  # Remove deprecated options from section [DEFAULT]."},{"line_number":611,"context_line":"  watcher_config {"},{"line_number":612,"context_line":"    \u0027DEFAULT/log_config\u0027:                   ensure \u003d\u003e absent;"},{"line_number":613,"context_line":"    \u0027DEFAULT/logfile\u0027:                      ensure \u003d\u003e absent;"},{"line_number":614,"context_line":"    \u0027DEFAULT/logdir\u0027:                       ensure \u003d\u003e absent;"},{"line_number":615,"context_line":"    \u0027DEFAULT/rpc_thread_pool_size\u0027:         ensure \u003d\u003e absent;"},{"line_number":616,"context_line":"    \u0027DEFAULT/rpc_conn_pool_size\u0027:           ensure \u003d\u003e absent;"},{"line_number":617,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7aa08908_bbdb654e","line":614,"range":{"start_line":612,"start_character":4,"end_line":614,"end_character":22},"updated":"2016-06-07 20:41:31.000000000","message":"log options will be in logging","commit_id":"b7f126b65ace6531e8695dd020009e761cd5a415"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"a956add1821d19cd4489fe03ec38067e52c06ae3","unresolved":false,"context_lines":[{"line_number":609,"context_line":""},{"line_number":610,"context_line":"  # Remove deprecated options from section [DEFAULT]."},{"line_number":611,"context_line":"  watcher_config {"},{"line_number":612,"context_line":"    \u0027DEFAULT/log_config\u0027:                   ensure \u003d\u003e absent;"},{"line_number":613,"context_line":"    \u0027DEFAULT/logfile\u0027:                      ensure \u003d\u003e absent;"},{"line_number":614,"context_line":"    \u0027DEFAULT/logdir\u0027:                       ensure \u003d\u003e absent;"},{"line_number":615,"context_line":"    \u0027DEFAULT/rpc_thread_pool_size\u0027:         ensure \u003d\u003e absent;"},{"line_number":616,"context_line":"    \u0027DEFAULT/rpc_conn_pool_size\u0027:           ensure \u003d\u003e absent;"},{"line_number":617,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7aa08908_c6a93492","line":614,"range":{"start_line":612,"start_character":4,"end_line":614,"end_character":22},"in_reply_to":"7aa08908_bbdb654e","updated":"2016-06-07 21:04:28.000000000","message":"ok, I will remove it in next commit ;)","commit_id":"b7f126b65ace6531e8695dd020009e761cd5a415"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"0612ca05d140caa1afbacb77a7f27e30a263d6e5","unresolved":false,"context_lines":[{"line_number":617,"context_line":"  }"},{"line_number":618,"context_line":""},{"line_number":619,"context_line":"  # Remove deprecated options from section [oslo_messaging_rabbit]."},{"line_number":620,"context_line":"  watcher_config {"},{"line_number":621,"context_line":"    \u0027DEFAULT/rabbit_use_ssl\u0027:               ensure \u003d\u003e absent;"},{"line_number":622,"context_line":"    \u0027DEFAULT/fake_rabbit\u0027:                  ensure \u003d\u003e absent;"},{"line_number":623,"context_line":"    \u0027DEFAULT/rabbit_userid\u0027:                ensure \u003d\u003e absent;"},{"line_number":624,"context_line":"    \u0027DEFAULT/rabbit_host\u0027:                  ensure \u003d\u003e absent;"},{"line_number":625,"context_line":"    \u0027DEFAULT/rabbit_password\u0027:              ensure \u003d\u003e absent;"},{"line_number":626,"context_line":"    \u0027DEFAULT/amqp_durable_queues\u0027:          ensure \u003d\u003e absent;"},{"line_number":627,"context_line":"    \u0027DEFAULT/rabbit_durable_queues\u0027:        ensure \u003d\u003e absent;"},{"line_number":628,"context_line":"    \u0027DEFAULT/rabbit_login_method\u0027:          ensure \u003d\u003e absent;"},{"line_number":629,"context_line":"    \u0027DEFAULT/rabbit_max_retries\u0027:           ensure \u003d\u003e absent;"},{"line_number":630,"context_line":"    \u0027DEFAULT/amqp_auto_delete\u0027:             ensure \u003d\u003e absent;"},{"line_number":631,"context_line":"    \u0027DEFAULT/rabbit_virtual_host\u0027:          ensure \u003d\u003e absent;"},{"line_number":632,"context_line":"    \u0027DEFAULT/rabbit_retry_backoff\u0027:         ensure \u003d\u003e absent;"},{"line_number":633,"context_line":"    \u0027DEFAULT/kombu_reconnect_delay\u0027:        ensure \u003d\u003e absent;"},{"line_number":634,"context_line":"    \u0027DEFAULT/rabbit_ha_queues\u0027:             ensure \u003d\u003e absent;"},{"line_number":635,"context_line":"    \u0027DEFAULT/kombu_reconnect_timeout\u0027:      ensure \u003d\u003e absent;"},{"line_number":636,"context_line":"    \u0027DEFAULT/rabbit_port\u0027:                  ensure \u003d\u003e absent;"},{"line_number":637,"context_line":"    \u0027DEFAULT/rabbit_hosts\u0027:                 ensure \u003d\u003e absent;"},{"line_number":638,"context_line":"  }"},{"line_number":639,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7aa08908_bb3fe585","line":638,"range":{"start_line":620,"start_character":0,"end_line":638,"end_character":3},"updated":"2016-06-07 20:41:31.000000000","message":"You don\u0027t need to ensure absent if the parameter is $::os_service_default","commit_id":"b7f126b65ace6531e8695dd020009e761cd5a415"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"a956add1821d19cd4489fe03ec38067e52c06ae3","unresolved":false,"context_lines":[{"line_number":617,"context_line":"  }"},{"line_number":618,"context_line":""},{"line_number":619,"context_line":"  # Remove deprecated options from section [oslo_messaging_rabbit]."},{"line_number":620,"context_line":"  watcher_config {"},{"line_number":621,"context_line":"    \u0027DEFAULT/rabbit_use_ssl\u0027:               ensure \u003d\u003e absent;"},{"line_number":622,"context_line":"    \u0027DEFAULT/fake_rabbit\u0027:                  ensure \u003d\u003e absent;"},{"line_number":623,"context_line":"    \u0027DEFAULT/rabbit_userid\u0027:                ensure \u003d\u003e absent;"},{"line_number":624,"context_line":"    \u0027DEFAULT/rabbit_host\u0027:                  ensure \u003d\u003e absent;"},{"line_number":625,"context_line":"    \u0027DEFAULT/rabbit_password\u0027:              ensure \u003d\u003e absent;"},{"line_number":626,"context_line":"    \u0027DEFAULT/amqp_durable_queues\u0027:          ensure \u003d\u003e absent;"},{"line_number":627,"context_line":"    \u0027DEFAULT/rabbit_durable_queues\u0027:        ensure \u003d\u003e absent;"},{"line_number":628,"context_line":"    \u0027DEFAULT/rabbit_login_method\u0027:          ensure \u003d\u003e absent;"},{"line_number":629,"context_line":"    \u0027DEFAULT/rabbit_max_retries\u0027:           ensure \u003d\u003e absent;"},{"line_number":630,"context_line":"    \u0027DEFAULT/amqp_auto_delete\u0027:             ensure \u003d\u003e absent;"},{"line_number":631,"context_line":"    \u0027DEFAULT/rabbit_virtual_host\u0027:          ensure \u003d\u003e absent;"},{"line_number":632,"context_line":"    \u0027DEFAULT/rabbit_retry_backoff\u0027:         ensure \u003d\u003e absent;"},{"line_number":633,"context_line":"    \u0027DEFAULT/kombu_reconnect_delay\u0027:        ensure \u003d\u003e absent;"},{"line_number":634,"context_line":"    \u0027DEFAULT/rabbit_ha_queues\u0027:             ensure \u003d\u003e absent;"},{"line_number":635,"context_line":"    \u0027DEFAULT/kombu_reconnect_timeout\u0027:      ensure \u003d\u003e absent;"},{"line_number":636,"context_line":"    \u0027DEFAULT/rabbit_port\u0027:                  ensure \u003d\u003e absent;"},{"line_number":637,"context_line":"    \u0027DEFAULT/rabbit_hosts\u0027:                 ensure \u003d\u003e absent;"},{"line_number":638,"context_line":"  }"},{"line_number":639,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7aa08908_26ed98ef","line":638,"range":{"start_line":620,"start_character":0,"end_line":638,"end_character":3},"in_reply_to":"7aa08908_bb3fe585","updated":"2016-06-07 21:04:28.000000000","message":"Ok, good to know. I will remove it in next commit.","commit_id":"b7f126b65ace6531e8695dd020009e761cd5a415"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"1f0316a2f471a7cdf741d676ef19c91a59c1afd8","unresolved":false,"context_lines":[{"line_number":380,"context_line":"  $sentinel_group_name                  \u003d $::os_service_default,"},{"line_number":381,"context_line":"  $wait_timeout                         \u003d $::os_service_default,"},{"line_number":382,"context_line":"  $check_timeout                        \u003d $::os_service_default,"},{"line_number":383,"context_line":"  $zmq_target_expire                    \u003d $::os_service_default,"},{"line_number":384,"context_line":"  $socket_timeout                       \u003d $::os_service_default,"},{"line_number":385,"context_line":"  $use_pub_sub                          \u003d $::os_service_default,"},{"line_number":386,"context_line":"  $rpc_cast_timeout                     \u003d $::os_service_default,"},{"line_number":387,"context_line":"  $rpc_poll_timeout                     \u003d $::os_service_default,"},{"line_number":388,"context_line":"  $rpc_zmq_min_port                     \u003d $::os_service_default,"},{"line_number":389,"context_line":"  $rpc_zmq_max_port                     \u003d $::os_service_default,"},{"line_number":390,"context_line":"  $rpc_zmq_bind_port_retries            \u003d $::os_service_default,"},{"line_number":391,"context_line":"  $rpc_zmq_bind_address                 \u003d $::os_service_default,"},{"line_number":392,"context_line":"  $rpc_zmq_matchmaker                   \u003d $::os_service_default,"},{"line_number":393,"context_line":"  $rpc_zmq_concurrency                  \u003d $::os_service_default,"},{"line_number":394,"context_line":"  $rpc_zmq_contexts                     \u003d $::os_service_default,"},{"line_number":395,"context_line":"  $rpc_zmq_topic_backlog                \u003d $::os_service_default,"},{"line_number":396,"context_line":"  $rpc_zmq_ipc_dir                      \u003d $::os_service_default,"},{"line_number":397,"context_line":"  $rpc_zmq_host                         \u003d $::os_service_default,"},{"line_number":398,"context_line":"  $notification_transport_url           \u003d $::os_service_default,"},{"line_number":399,"context_line":"  $notification_driver                  \u003d $::os_service_default,"},{"line_number":400,"context_line":"  $notification_topics                  \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7aa08908_1cb7e8f5","line":397,"range":{"start_line":383,"start_character":0,"end_line":397,"end_character":64},"updated":"2016-06-08 11:35:29.000000000","message":"fyi: i\u0027ve uploaded patch for ZeroMQ suppot in oslo\n\nhttps://review.openstack.org/327025","commit_id":"b11921f61debec999c5bd6ec3e67a972db3cdb30"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"8b3a16370114a4466ffd477967e8a057b9029373","unresolved":false,"context_lines":[{"line_number":380,"context_line":"  $sentinel_group_name                  \u003d $::os_service_default,"},{"line_number":381,"context_line":"  $wait_timeout                         \u003d $::os_service_default,"},{"line_number":382,"context_line":"  $check_timeout                        \u003d $::os_service_default,"},{"line_number":383,"context_line":"  $zmq_target_expire                    \u003d $::os_service_default,"},{"line_number":384,"context_line":"  $socket_timeout                       \u003d $::os_service_default,"},{"line_number":385,"context_line":"  $use_pub_sub                          \u003d $::os_service_default,"},{"line_number":386,"context_line":"  $rpc_cast_timeout                     \u003d $::os_service_default,"},{"line_number":387,"context_line":"  $rpc_poll_timeout                     \u003d $::os_service_default,"},{"line_number":388,"context_line":"  $rpc_zmq_min_port                     \u003d $::os_service_default,"},{"line_number":389,"context_line":"  $rpc_zmq_max_port                     \u003d $::os_service_default,"},{"line_number":390,"context_line":"  $rpc_zmq_bind_port_retries            \u003d $::os_service_default,"},{"line_number":391,"context_line":"  $rpc_zmq_bind_address                 \u003d $::os_service_default,"},{"line_number":392,"context_line":"  $rpc_zmq_matchmaker                   \u003d $::os_service_default,"},{"line_number":393,"context_line":"  $rpc_zmq_concurrency                  \u003d $::os_service_default,"},{"line_number":394,"context_line":"  $rpc_zmq_contexts                     \u003d $::os_service_default,"},{"line_number":395,"context_line":"  $rpc_zmq_topic_backlog                \u003d $::os_service_default,"},{"line_number":396,"context_line":"  $rpc_zmq_ipc_dir                      \u003d $::os_service_default,"},{"line_number":397,"context_line":"  $rpc_zmq_host                         \u003d $::os_service_default,"},{"line_number":398,"context_line":"  $notification_transport_url           \u003d $::os_service_default,"},{"line_number":399,"context_line":"  $notification_driver                  \u003d $::os_service_default,"},{"line_number":400,"context_line":"  $notification_topics                  \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7aa08908_bf9e8304","line":397,"range":{"start_line":383,"start_character":0,"end_line":397,"end_character":64},"in_reply_to":"7aa08908_1cb7e8f5","updated":"2016-06-08 12:33:03.000000000","message":"Ok, thanks. In next commit I will change it.","commit_id":"b11921f61debec999c5bd6ec3e67a972db3cdb30"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"00b0af7b0949ec02ec199b3e8c8a0482dd98dda7","unresolved":false,"context_lines":[{"line_number":82,"context_line":"#   (Optional) Maximum number of RabbitMQ connection retries. (integer value)"},{"line_number":83,"context_line":"#   Defaults to $::os_service_default"},{"line_number":84,"context_line":"#"},{"line_number":85,"context_line":"# [*rabbit_use_ssl*]"},{"line_number":86,"context_line":"#   (optional) Connect over SSL for RabbitMQ."},{"line_number":87,"context_line":"#"},{"line_number":88,"context_line":"# [*rabbit_heartbeat_rate*]"},{"line_number":89,"context_line":"#   (optional) ow often times during the heartbeat_timeout_threshold we"},{"line_number":90,"context_line":"#   check the heartbeat."},{"line_number":91,"context_line":"#"},{"line_number":92,"context_line":"# [*rabbit_ha_queues*]"},{"line_number":93,"context_line":"#   (optional) Use HA queues in RabbitMQ (x-ha-policy: all). If you change this"},{"line_number":94,"context_line":"#   option, you must wipe the RabbitMQ database."},{"line_number":95,"context_line":"#"},{"line_number":96,"context_line":"# [*rabbit_transient_queues_ttl*]"},{"line_number":97,"context_line":"#   (Optional) Positive integer representing duration in seconds for"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7aa08908_56626fae","line":94,"range":{"start_line":85,"start_character":0,"end_line":94,"end_character":48},"updated":"2016-06-10 08:03:18.000000000","message":"please add default values for these parameters","commit_id":"05ccaa106c5de21dae848ea52086d41f3491c325"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"00b0af7b0949ec02ec199b3e8c8a0482dd98dda7","unresolved":false,"context_lines":[{"line_number":107,"context_line":"#   (0 disable the heartbeat). EXPERIMENTAL. (integer value)"},{"line_number":108,"context_line":"#   Defaults to $::os_service_default"},{"line_number":109,"context_line":"#"},{"line_number":110,"context_line":"# [*kombu_ssl_ca_certs*]"},{"line_number":111,"context_line":"#   (optional) SSL certification authority file (valid only if SSL enabled)."},{"line_number":112,"context_line":"#"},{"line_number":113,"context_line":"# [*kombu_ssl_certfile*]"},{"line_number":114,"context_line":"#   (optional) SSL cert file (valid only if SSL enabled)."},{"line_number":115,"context_line":"#"},{"line_number":116,"context_line":"# [*kombu_ssl_keyfile*]"},{"line_number":117,"context_line":"#   (optional) SSL key file (valid only if SSL enabled)."},{"line_number":118,"context_line":"#"},{"line_number":119,"context_line":"# [*kombu_ssl_version*]"},{"line_number":120,"context_line":"#   (optional) SSL version to use (valid only if SSL enabled). Valid values are"},{"line_number":121,"context_line":"#   TLSv1 and SSLv23. SSLv2, SSLv3, TLSv1_1, and TLSv1_2 may be"},{"line_number":122,"context_line":"#   available on some distributions."},{"line_number":123,"context_line":"#"},{"line_number":124,"context_line":"# [*kombu_reconnect_delay*]"},{"line_number":125,"context_line":"#   (optional) How long to wait before reconnecting in response to an AMQP"},{"line_number":126,"context_line":"#   consumer cancel notification."},{"line_number":127,"context_line":"#"},{"line_number":128,"context_line":"# [*kombu_missing_consumer_retry_timeout*]"},{"line_number":129,"context_line":"#  (optional)How long to wait a missing client beforce abandoning to send it"},{"line_number":130,"context_line":"#   its replies. This value should not be longer than rpc_response_timeout."},{"line_number":131,"context_line":"#"},{"line_number":132,"context_line":"# [*kombu_failover_strategy*]"},{"line_number":133,"context_line":"#   (Optional) Determines how the next RabbitMQ node is chosen in case the one"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7aa08908_1652a7dd","line":130,"range":{"start_line":110,"start_character":3,"end_line":130,"end_character":75},"updated":"2016-06-10 08:03:18.000000000","message":"please add default values for these parameters","commit_id":"05ccaa106c5de21dae848ea52086d41f3491c325"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"00b0af7b0949ec02ec199b3e8c8a0482dd98dda7","unresolved":false,"context_lines":[{"line_number":141,"context_line":"#   (string value)"},{"line_number":142,"context_line":"#   Defaults to $::os_service_default"},{"line_number":143,"context_line":"#"},{"line_number":144,"context_line":"# [*amqp_durable_queues*]"},{"line_number":145,"context_line":"#   (optional) Use durable queues in AMQP."},{"line_number":146,"context_line":"#"},{"line_number":147,"context_line":"# [*watcher_planner*]"},{"line_number":148,"context_line":"#   (optional) The selected planner used to schedule the actions."},{"line_number":149,"context_line":"#"},{"line_number":150,"context_line":"# [*default_transport_url*]"},{"line_number":151,"context_line":"#   (Optional) A URL representing the messaging driver to use and its full"},{"line_number":152,"context_line":"#   configuration. If not set, we fall back to the rpc_backend option"},{"line_number":153,"context_line":"#   and driver specific configuration."},{"line_number":154,"context_line":"#"},{"line_number":155,"context_line":"# [*rpc_response_timeout*]"},{"line_number":156,"context_line":"#  (Optional) Seconds to wait for a response from a call."},{"line_number":157,"context_line":"#"},{"line_number":158,"context_line":"# [*log_dir*]"},{"line_number":159,"context_line":"#  (optional) Directory where logs should be stored."}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7aa08908_1600e7a9","line":156,"range":{"start_line":144,"start_character":0,"end_line":156,"end_character":57},"updated":"2016-06-10 08:03:18.000000000","message":"the same as above","commit_id":"05ccaa106c5de21dae848ea52086d41f3491c325"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"00b0af7b0949ec02ec199b3e8c8a0482dd98dda7","unresolved":false,"context_lines":[{"line_number":170,"context_line":"# [*amqp_password*]"},{"line_number":171,"context_line":"#   (Optional) Password for message broker authentication."},{"line_number":172,"context_line":"#"},{"line_number":173,"context_line":"# [*amqp_username*]"},{"line_number":174,"context_line":"#   (Optional) User name for message broker authentication."},{"line_number":175,"context_line":"#"},{"line_number":176,"context_line":"# [*amqp_ssl_ca_file*]"},{"line_number":177,"context_line":"#   (Optional) CA certificate PEM file to verify server certificate."},{"line_number":178,"context_line":"#"},{"line_number":179,"context_line":"# [*amqp_ssl_key_file*]"},{"line_number":180,"context_line":"#   (Optional) Private key PEM file used to sign cert_file certificate."},{"line_number":181,"context_line":"#"},{"line_number":182,"context_line":"# [*amqp_container_name*]"},{"line_number":183,"context_line":"#   (Optional) Name for the AMQP container."},{"line_number":184,"context_line":"#"},{"line_number":185,"context_line":"# [*amqp_sasl_mechanisms*]"},{"line_number":186,"context_line":"#   (Optional) Space separated list of acceptable SASL mechanisms."},{"line_number":187,"context_line":"#"},{"line_number":188,"context_line":"# [*amqp_server_request_prefix*]"},{"line_number":189,"context_line":"#   (Optional) Address prefix used when sending to a specific server."},{"line_number":190,"context_line":"#"},{"line_number":191,"context_line":"# [*amqp_ssl_key_password*]"},{"line_number":192,"context_line":"#   (Optional) Password for decrypting ssl_key_file (if encrypted)."},{"line_number":193,"context_line":"#"},{"line_number":194,"context_line":"# [*amqp_idle_timeout*]"},{"line_number":195,"context_line":"#   (Optional) Timeout for inactive connections (in seconds)."},{"line_number":196,"context_line":"#"},{"line_number":197,"context_line":"# [*amqp_ssl_cert_file*]"},{"line_number":198,"context_line":"#   (Optional) Identifying certificate PEM file to present to clients."},{"line_number":199,"context_line":"#"},{"line_number":200,"context_line":"# [*amqp_broadcast_prefix*]"},{"line_number":201,"context_line":"#   (Optional) Address prefix used when broadcasting to all servers."},{"line_number":202,"context_line":"#"},{"line_number":203,"context_line":"# [*amqp_trace*]"},{"line_number":204,"context_line":"#   (Optional) Debug: dump AMQP frames to stdout."},{"line_number":205,"context_line":"#"},{"line_number":206,"context_line":"# [*amqp_allow_insecure_clients*]"},{"line_number":207,"context_line":"#   (Optional) Accept clients using either SSL or plain TCP."},{"line_number":208,"context_line":"#"},{"line_number":209,"context_line":"# [*amqp_sasl_config_name*]"},{"line_number":210,"context_line":"#   (Optional) Name of configuration file (without .conf suffix)."},{"line_number":211,"context_line":"#"},{"line_number":212,"context_line":"# [*amqp_sasl_config_dir*]"},{"line_number":213,"context_line":"#   (Optional) Path to directory that contains the SASL configuration."},{"line_number":214,"context_line":"#"},{"line_number":215,"context_line":"# [*amqp_group_request_prefix*]"},{"line_number":216,"context_line":"#   (Optional) Address prefix when sending to any server in group."},{"line_number":217,"context_line":"#"},{"line_number":218,"context_line":"# [*control_exchange*]"},{"line_number":219,"context_line":"#   (Optional) The default exchange under which topics are scoped. May be"},{"line_number":220,"context_line":"#   overridden by an exchange name specified in the transport_url"},{"line_number":221,"context_line":"#   option."},{"line_number":222,"context_line":"#"},{"line_number":223,"context_line":"# [*rpc_cast_timeout*]"},{"line_number":224,"context_line":"#  (optional) Seconds to wait before a cast expires (TTL)."}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7aa08908_361a4318","line":221,"range":{"start_line":173,"start_character":0,"end_line":221,"end_character":11},"updated":"2016-06-10 08:03:18.000000000","message":"the same","commit_id":"05ccaa106c5de21dae848ea52086d41f3491c325"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"00b0af7b0949ec02ec199b3e8c8a0482dd98dda7","unresolved":false,"context_lines":[{"line_number":304,"context_line":"#  (optional) AMQP topic used for OpenStack notifications"},{"line_number":305,"context_line":"#  Defaults to $::os_service_default"},{"line_number":306,"context_line":"#"},{"line_number":307,"context_line":"# [*redis_host*]"},{"line_number":308,"context_line":"#   (Optional) Host to locate redis."},{"line_number":309,"context_line":"#"},{"line_number":310,"context_line":"# [*redis_port*]"},{"line_number":311,"context_line":"#   (Optional) Use this port to connect to redis host."},{"line_number":312,"context_line":"#"},{"line_number":313,"context_line":"# [*redis_password*]"},{"line_number":314,"context_line":"#  (optional) Password for Redis authentication, eventually needed by the"},{"line_number":315,"context_line":"#  specific monitoring we do from HAProxy for Redis"},{"line_number":316,"context_line":"#"},{"line_number":317,"context_line":"# [*sentinel_hosts*]"},{"line_number":318,"context_line":"#   (Optional) List of Redis Sentinel hosts"},{"line_number":319,"context_line":"#"},{"line_number":320,"context_line":"# [*sentinel_group_name*]"},{"line_number":321,"context_line":"#   (Optional) Redis replica set name."},{"line_number":322,"context_line":"#"},{"line_number":323,"context_line":"# [*wait_timeout*]"},{"line_number":324,"context_line":"#   (Optional) Time in ms to wait between connection attempts."},{"line_number":325,"context_line":"#"},{"line_number":326,"context_line":"# [*check_timeout*]"},{"line_number":327,"context_line":"#   (Optional) Time in ms to wait before the transaction is killed."},{"line_number":328,"context_line":"#"},{"line_number":329,"context_line":"# [*socket_timeout*]"},{"line_number":330,"context_line":"#   (Optional) Timeout in ms on blocking socket operations."},{"line_number":331,"context_line":"#"},{"line_number":332,"context_line":"# \u003d\u003d\u003d Authors"},{"line_number":333,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7aa08908_b6b3d309","line":330,"range":{"start_line":307,"start_character":0,"end_line":330,"end_character":59},"updated":"2016-06-10 08:03:18.000000000","message":"the same","commit_id":"05ccaa106c5de21dae848ea52086d41f3491c325"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"888e267625d25ed03f582a8b57391fe7d747a531","unresolved":false,"context_lines":[{"line_number":367,"context_line":"class watcher ("},{"line_number":368,"context_line":"  $use_ssl                              \u003d false,"},{"line_number":369,"context_line":"  $package_ensure                       \u003d \u0027present\u0027,"},{"line_number":370,"context_line":"  $ceilometer_client_api_version        \u003d \u00272\u0027,"},{"line_number":371,"context_line":"  $cinder_client_api_version            \u003d \u00272\u0027,"},{"line_number":372,"context_line":"  $glance_client_api_version            \u003d \u00272\u0027,"},{"line_number":373,"context_line":"  $neutron_client_api_version           \u003d \u00272\u0027,"},{"line_number":374,"context_line":"  $nova_client_api_version              \u003d \u00272\u0027,"},{"line_number":375,"context_line":"  $rpc_backend                          \u003d \u0027rabbit\u0027,"},{"line_number":376,"context_line":"  $ensure_package                       \u003d \u0027present\u0027,"},{"line_number":377,"context_line":"  $rabbit_host                          \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"7aa08908_a16fb2fa","line":374,"range":{"start_line":370,"start_character":2,"end_line":374,"end_character":46},"updated":"2016-06-13 12:13:28.000000000","message":"which service require them? All?","commit_id":"b07d589265aa35e44093166de0e677c15283bd31"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"cc051dc1de7fde568f9b1f6a8365aea07781bf67","unresolved":false,"context_lines":[{"line_number":367,"context_line":"class watcher ("},{"line_number":368,"context_line":"  $use_ssl                              \u003d false,"},{"line_number":369,"context_line":"  $package_ensure                       \u003d \u0027present\u0027,"},{"line_number":370,"context_line":"  $ceilometer_client_api_version        \u003d \u00272\u0027,"},{"line_number":371,"context_line":"  $cinder_client_api_version            \u003d \u00272\u0027,"},{"line_number":372,"context_line":"  $glance_client_api_version            \u003d \u00272\u0027,"},{"line_number":373,"context_line":"  $neutron_client_api_version           \u003d \u00272\u0027,"},{"line_number":374,"context_line":"  $nova_client_api_version              \u003d \u00272\u0027,"},{"line_number":375,"context_line":"  $rpc_backend                          \u003d \u0027rabbit\u0027,"},{"line_number":376,"context_line":"  $ensure_package                       \u003d \u0027present\u0027,"},{"line_number":377,"context_line":"  $rabbit_host                          \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"7aa08908_4cc3a257","line":374,"range":{"start_line":370,"start_character":2,"end_line":374,"end_character":46},"in_reply_to":"7aa08908_293c48c7","updated":"2016-06-13 13:10:33.000000000","message":"So I guess this options will be required and in generated config file these options exists, so I will leave it.\nGenerated config file: \nhttps://factory.b-com.com/www/watcher/doc/watcher/deploy/conf-files.html","commit_id":"b07d589265aa35e44093166de0e677c15283bd31"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"23d5590d0bb7d29362655d09e9585fa8fd84c108","unresolved":false,"context_lines":[{"line_number":367,"context_line":"class watcher ("},{"line_number":368,"context_line":"  $use_ssl                              \u003d false,"},{"line_number":369,"context_line":"  $package_ensure                       \u003d \u0027present\u0027,"},{"line_number":370,"context_line":"  $ceilometer_client_api_version        \u003d \u00272\u0027,"},{"line_number":371,"context_line":"  $cinder_client_api_version            \u003d \u00272\u0027,"},{"line_number":372,"context_line":"  $glance_client_api_version            \u003d \u00272\u0027,"},{"line_number":373,"context_line":"  $neutron_client_api_version           \u003d \u00272\u0027,"},{"line_number":374,"context_line":"  $nova_client_api_version              \u003d \u00272\u0027,"},{"line_number":375,"context_line":"  $rpc_backend                          \u003d \u0027rabbit\u0027,"},{"line_number":376,"context_line":"  $ensure_package                       \u003d \u0027present\u0027,"},{"line_number":377,"context_line":"  $rabbit_host                          \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"7aa08908_628e657a","line":374,"range":{"start_line":370,"start_character":2,"end_line":374,"end_character":46},"in_reply_to":"7aa08908_4cc3a257","updated":"2016-06-13 13:46:11.000000000","message":"ack, leave it here.","commit_id":"b07d589265aa35e44093166de0e677c15283bd31"},{"author":{"_account_id":16495,"name":"Jean-Emile DARTOIS","email":"jean-emile.dartois@b-com.com","username":"JeD"},"change_message_id":"604107385c354b08620b3bac4ea9636e40e31dfe","unresolved":false,"context_lines":[{"line_number":367,"context_line":"class watcher ("},{"line_number":368,"context_line":"  $use_ssl                              \u003d false,"},{"line_number":369,"context_line":"  $package_ensure                       \u003d \u0027present\u0027,"},{"line_number":370,"context_line":"  $ceilometer_client_api_version        \u003d \u00272\u0027,"},{"line_number":371,"context_line":"  $cinder_client_api_version            \u003d \u00272\u0027,"},{"line_number":372,"context_line":"  $glance_client_api_version            \u003d \u00272\u0027,"},{"line_number":373,"context_line":"  $neutron_client_api_version           \u003d \u00272\u0027,"},{"line_number":374,"context_line":"  $nova_client_api_version              \u003d \u00272\u0027,"},{"line_number":375,"context_line":"  $rpc_backend                          \u003d \u0027rabbit\u0027,"},{"line_number":376,"context_line":"  $ensure_package                       \u003d \u0027present\u0027,"},{"line_number":377,"context_line":"  $rabbit_host                          \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"7aa08908_293c48c7","line":374,"range":{"start_line":370,"start_character":2,"end_line":374,"end_character":46},"in_reply_to":"7aa08908_a16fb2fa","updated":"2016-06-13 12:34:26.000000000","message":"The service which will require all of them is the Watcher Applier and the Watcher Decision Engine.\nHowever, in the current version of watcher we are only using ceilometer and nova.","commit_id":"b07d589265aa35e44093166de0e677c15283bd31"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"b610b2a4795ebf214fc7cd5460c92c91949e0b21","unresolved":false,"context_lines":[{"line_number":374,"context_line":"  $nova_client_api_version              \u003d \u00272\u0027,"},{"line_number":375,"context_line":"  $rpc_backend                          \u003d \u0027rabbit\u0027,"},{"line_number":376,"context_line":"  $ensure_package                       \u003d \u0027present\u0027,"},{"line_number":377,"context_line":"  $rabbit_host                          \u003d $::os_service_default,"},{"line_number":378,"context_line":"  $rabbit_hosts                         \u003d $::os_service_default,"},{"line_number":379,"context_line":"  $rabbit_password                      \u003d $::os_service_default,"},{"line_number":380,"context_line":"  $rabbit_login_method                  \u003d $::os_service_default,"},{"line_number":381,"context_line":"  $rabbit_port                          \u003d $::os_service_default,"},{"line_number":382,"context_line":"  $rabbit_userid                        \u003d $::os_service_default,"},{"line_number":383,"context_line":"  $rabbit_virtual_host                  \u003d $::os_service_default,"},{"line_number":384,"context_line":"  $rabbit_retry_interval                \u003d $::os_service_default,"},{"line_number":385,"context_line":"  $rabbit_retry_backoff                 \u003d $::os_service_default,"},{"line_number":386,"context_line":"  $rabbit_interval_max                  \u003d $::os_service_default,"},{"line_number":387,"context_line":"  $rabbit_max_retries                   \u003d $::os_service_default,"},{"line_number":388,"context_line":"  $rabbit_use_ssl                       \u003d $::os_service_default,"},{"line_number":389,"context_line":"  $rabbit_heartbeat_rate                \u003d $::os_service_default,"},{"line_number":390,"context_line":"  $rabbit_ha_queues                     \u003d $::os_service_default,"},{"line_number":391,"context_line":"  $rabbit_transient_queues_ttl          \u003d $::os_service_default,"},{"line_number":392,"context_line":"  $rabbit_heartbeat_timeout_threshold   \u003d $::os_service_default,"},{"line_number":393,"context_line":"  $kombu_ssl_ca_certs                   \u003d $::os_service_default,"},{"line_number":394,"context_line":"  $kombu_ssl_certfile                   \u003d $::os_service_default,"},{"line_number":395,"context_line":"  $kombu_ssl_keyfile                    \u003d $::os_service_default,"},{"line_number":396,"context_line":"  $kombu_ssl_version                    \u003d $::os_service_default,"},{"line_number":397,"context_line":"  $kombu_reconnect_delay                \u003d $::os_service_default,"},{"line_number":398,"context_line":"  $kombu_missing_consumer_retry_timeout \u003d $::os_service_default,"},{"line_number":399,"context_line":"  $kombu_failover_strategy              \u003d $::os_service_default,"},{"line_number":400,"context_line":"  $kombu_compression                    \u003d $::os_service_default,"},{"line_number":401,"context_line":"  $amqp_durable_queues                  \u003d $::os_service_default,"},{"line_number":402,"context_line":"  $watcher_planner                      \u003d undef,"},{"line_number":403,"context_line":"  $default_transport_url                \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"7aa08908_553c1ebf","line":400,"range":{"start_line":377,"start_character":0,"end_line":400,"end_character":64},"updated":"2016-06-10 10:28:07.000000000","message":"we have some discussion with Emilien, such parameters can be moved into separate file. Because we already have overloaded main class. But as we don\u0027t have some certain solution for this, i guess we can go with it for now. Emilien, thoughts?","commit_id":"b07d589265aa35e44093166de0e677c15283bd31"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"888e267625d25ed03f582a8b57391fe7d747a531","unresolved":false,"context_lines":[{"line_number":374,"context_line":"  $nova_client_api_version              \u003d \u00272\u0027,"},{"line_number":375,"context_line":"  $rpc_backend                          \u003d \u0027rabbit\u0027,"},{"line_number":376,"context_line":"  $ensure_package                       \u003d \u0027present\u0027,"},{"line_number":377,"context_line":"  $rabbit_host                          \u003d $::os_service_default,"},{"line_number":378,"context_line":"  $rabbit_hosts                         \u003d $::os_service_default,"},{"line_number":379,"context_line":"  $rabbit_password                      \u003d $::os_service_default,"},{"line_number":380,"context_line":"  $rabbit_login_method                  \u003d $::os_service_default,"},{"line_number":381,"context_line":"  $rabbit_port                          \u003d $::os_service_default,"},{"line_number":382,"context_line":"  $rabbit_userid                        \u003d $::os_service_default,"},{"line_number":383,"context_line":"  $rabbit_virtual_host                  \u003d $::os_service_default,"},{"line_number":384,"context_line":"  $rabbit_retry_interval                \u003d $::os_service_default,"},{"line_number":385,"context_line":"  $rabbit_retry_backoff                 \u003d $::os_service_default,"},{"line_number":386,"context_line":"  $rabbit_interval_max                  \u003d $::os_service_default,"},{"line_number":387,"context_line":"  $rabbit_max_retries                   \u003d $::os_service_default,"},{"line_number":388,"context_line":"  $rabbit_use_ssl                       \u003d $::os_service_default,"},{"line_number":389,"context_line":"  $rabbit_heartbeat_rate                \u003d $::os_service_default,"},{"line_number":390,"context_line":"  $rabbit_ha_queues                     \u003d $::os_service_default,"},{"line_number":391,"context_line":"  $rabbit_transient_queues_ttl          \u003d $::os_service_default,"},{"line_number":392,"context_line":"  $rabbit_heartbeat_timeout_threshold   \u003d $::os_service_default,"},{"line_number":393,"context_line":"  $kombu_ssl_ca_certs                   \u003d $::os_service_default,"},{"line_number":394,"context_line":"  $kombu_ssl_certfile                   \u003d $::os_service_default,"},{"line_number":395,"context_line":"  $kombu_ssl_keyfile                    \u003d $::os_service_default,"},{"line_number":396,"context_line":"  $kombu_ssl_version                    \u003d $::os_service_default,"},{"line_number":397,"context_line":"  $kombu_reconnect_delay                \u003d $::os_service_default,"},{"line_number":398,"context_line":"  $kombu_missing_consumer_retry_timeout \u003d $::os_service_default,"},{"line_number":399,"context_line":"  $kombu_failover_strategy              \u003d $::os_service_default,"},{"line_number":400,"context_line":"  $kombu_compression                    \u003d $::os_service_default,"},{"line_number":401,"context_line":"  $amqp_durable_queues                  \u003d $::os_service_default,"},{"line_number":402,"context_line":"  $watcher_planner                      \u003d undef,"},{"line_number":403,"context_line":"  $default_transport_url                \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"7aa08908_61f4aa5a","line":400,"range":{"start_line":377,"start_character":0,"end_line":400,"end_character":64},"in_reply_to":"7aa08908_553c1ebf","updated":"2016-06-13 12:13:28.000000000","message":"yes, let\u0027s keep them here now, I\u0027m more concerned about other options","commit_id":"b07d589265aa35e44093166de0e677c15283bd31"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"888e267625d25ed03f582a8b57391fe7d747a531","unresolved":false,"context_lines":[{"line_number":399,"context_line":"  $kombu_failover_strategy              \u003d $::os_service_default,"},{"line_number":400,"context_line":"  $kombu_compression                    \u003d $::os_service_default,"},{"line_number":401,"context_line":"  $amqp_durable_queues                  \u003d $::os_service_default,"},{"line_number":402,"context_line":"  $watcher_planner                      \u003d undef,"},{"line_number":403,"context_line":"  $default_transport_url                \u003d $::os_service_default,"},{"line_number":404,"context_line":"  $rpc_response_timeout                 \u003d $::os_service_default,"},{"line_number":405,"context_line":"  # amqp"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"7aa08908_4156ce2a","line":402,"range":{"start_line":402,"start_character":1,"end_line":402,"end_character":48},"updated":"2016-06-13 12:13:28.000000000","message":"do we need it for all services?","commit_id":"b07d589265aa35e44093166de0e677c15283bd31"},{"author":{"_account_id":16495,"name":"Jean-Emile DARTOIS","email":"jean-emile.dartois@b-com.com","username":"JeD"},"change_message_id":"db00aa1d4ae6db4d736587f9630ac524c4eafc2e","unresolved":false,"context_lines":[{"line_number":399,"context_line":"  $kombu_failover_strategy              \u003d $::os_service_default,"},{"line_number":400,"context_line":"  $kombu_compression                    \u003d $::os_service_default,"},{"line_number":401,"context_line":"  $amqp_durable_queues                  \u003d $::os_service_default,"},{"line_number":402,"context_line":"  $watcher_planner                      \u003d undef,"},{"line_number":403,"context_line":"  $default_transport_url                \u003d $::os_service_default,"},{"line_number":404,"context_line":"  $rpc_response_timeout                 \u003d $::os_service_default,"},{"line_number":405,"context_line":"  # amqp"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"7aa08908_69bc9006","line":402,"range":{"start_line":402,"start_character":1,"end_line":402,"end_character":48},"in_reply_to":"7aa08908_4156ce2a","updated":"2016-06-13 12:39:00.000000000","message":"only for the decision engine","commit_id":"b07d589265aa35e44093166de0e677c15283bd31"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"23d5590d0bb7d29362655d09e9585fa8fd84c108","unresolved":false,"context_lines":[{"line_number":399,"context_line":"  $kombu_failover_strategy              \u003d $::os_service_default,"},{"line_number":400,"context_line":"  $kombu_compression                    \u003d $::os_service_default,"},{"line_number":401,"context_line":"  $amqp_durable_queues                  \u003d $::os_service_default,"},{"line_number":402,"context_line":"  $watcher_planner                      \u003d undef,"},{"line_number":403,"context_line":"  $default_transport_url                \u003d $::os_service_default,"},{"line_number":404,"context_line":"  $rpc_response_timeout                 \u003d $::os_service_default,"},{"line_number":405,"context_line":"  # amqp"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"7aa08908_e2f095ff","line":402,"range":{"start_line":402,"start_character":1,"end_line":402,"end_character":48},"in_reply_to":"7aa08908_69bc9006","updated":"2016-06-13 13:46:11.000000000","message":"ok so drop it from here.","commit_id":"b07d589265aa35e44093166de0e677c15283bd31"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"888e267625d25ed03f582a8b57391fe7d747a531","unresolved":false,"context_lines":[{"line_number":440,"context_line":"  $notification_driver                  \u003d $::os_service_default,"},{"line_number":441,"context_line":"  $notification_topics                  \u003d $::os_service_default,"},{"line_number":442,"context_line":"  # others"},{"line_number":443,"context_line":"  $redis_host                           \u003d $::os_service_default,"},{"line_number":444,"context_line":"  $redis_port                           \u003d $::os_service_default,"},{"line_number":445,"context_line":"  $redis_password                       \u003d $::os_service_default,"},{"line_number":446,"context_line":"  $sentinel_hosts                       \u003d $::os_service_default,"},{"line_number":447,"context_line":"  $sentinel_group_name                  \u003d $::os_service_default,"},{"line_number":448,"context_line":"  $wait_timeout                         \u003d $::os_service_default,"},{"line_number":449,"context_line":"  $check_timeout                        \u003d $::os_service_default,"},{"line_number":450,"context_line":"  $socket_timeout                       \u003d $::os_service_default,"},{"line_number":451,"context_line":") {"},{"line_number":452,"context_line":""},{"line_number":453,"context_line":"  include ::openstacklib::openstackclient"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"7aa08908_a114d24c","line":450,"range":{"start_line":443,"start_character":2,"end_line":450,"end_character":21},"updated":"2016-06-13 12:13:28.000000000","message":"which services need that? all?","commit_id":"b07d589265aa35e44093166de0e677c15283bd31"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"4804521bd8bbcc548fda6aeef7559567b9a92351","unresolved":false,"context_lines":[{"line_number":440,"context_line":"  $notification_driver                  \u003d $::os_service_default,"},{"line_number":441,"context_line":"  $notification_topics                  \u003d $::os_service_default,"},{"line_number":442,"context_line":"  # others"},{"line_number":443,"context_line":"  $redis_host                           \u003d $::os_service_default,"},{"line_number":444,"context_line":"  $redis_port                           \u003d $::os_service_default,"},{"line_number":445,"context_line":"  $redis_password                       \u003d $::os_service_default,"},{"line_number":446,"context_line":"  $sentinel_hosts                       \u003d $::os_service_default,"},{"line_number":447,"context_line":"  $sentinel_group_name                  \u003d $::os_service_default,"},{"line_number":448,"context_line":"  $wait_timeout                         \u003d $::os_service_default,"},{"line_number":449,"context_line":"  $check_timeout                        \u003d $::os_service_default,"},{"line_number":450,"context_line":"  $socket_timeout                       \u003d $::os_service_default,"},{"line_number":451,"context_line":") {"},{"line_number":452,"context_line":""},{"line_number":453,"context_line":"  include ::openstacklib::openstackclient"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"7aa08908_620145af","line":450,"range":{"start_line":443,"start_character":2,"end_line":450,"end_character":21},"in_reply_to":"7aa08908_a114d24c","updated":"2016-06-13 13:50:12.000000000","message":"These options are not neccessary for now. They will be added later.","commit_id":"b07d589265aa35e44093166de0e677c15283bd31"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"ca915566fa2147c7aff6ee21f3bce5ad2991e936","unresolved":false,"context_lines":[{"line_number":558,"context_line":"    topics        \u003d\u003e $notification_topics,"},{"line_number":559,"context_line":"  }"},{"line_number":560,"context_line":""},{"line_number":561,"context_line":"  watcher_config {"},{"line_number":562,"context_line":"    \u0027DEFAULT/host\u0027:                 value \u003d\u003e $redis_host;"},{"line_number":563,"context_line":"    \u0027DEFAULT/port\u0027:                 value \u003d\u003e $redis_port;"},{"line_number":564,"context_line":"    \u0027DEFAULT/password\u0027:             value \u003d\u003e $redis_password, secret \u003d\u003e true;"},{"line_number":565,"context_line":"    \u0027DEFAULT/sentinel_hosts\u0027:       value \u003d\u003e $sentinel_hosts;"},{"line_number":566,"context_line":"    \u0027DEFAULT/sentinel_group_name\u0027:  value \u003d\u003e $sentinel_group_name;"},{"line_number":567,"context_line":"    \u0027DEFAULT/wait_timeout\u0027:         value \u003d\u003e $wait_timeout;"},{"line_number":568,"context_line":"    \u0027DEFAULT/check_timeout\u0027:        value \u003d\u003e $check_timeout;"},{"line_number":569,"context_line":"    \u0027DEFAULT/socket_timeout\u0027:       value \u003d\u003e $socket_timeout;"},{"line_number":570,"context_line":"  }"},{"line_number":571,"context_line":"}"},{"line_number":572,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":4,"id":"7aa08908_e9236056","line":570,"range":{"start_line":561,"start_character":0,"end_line":570,"end_character":3},"updated":"2016-06-13 12:44:01.000000000","message":"section has been changed. I will fixed it in next commit.","commit_id":"b07d589265aa35e44093166de0e677c15283bd31"}]}