)]}'
{"manifests/api.pp":[{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"9903b3a6a8312578ac7615f5075d3e9f8aef70f6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7aa08908_6bec16f4","updated":"2016-06-15 10:34:05.000000000","message":"Can you add the license in the top of the file?","commit_id":"a4b97920bbde34fb91bf3e6a22f73cf99ac54934"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"36ce471185f862a30daffca49d733d2fc1db6ce4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7aa08908_e9c48e0f","in_reply_to":"7aa08908_6bec16f4","updated":"2016-06-15 14:15:29.000000000","message":"LICENSE file is in main directory. Adding it to every manifest file is a good idea.","commit_id":"a4b97920bbde34fb91bf3e6a22f73cf99ac54934"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"9903b3a6a8312578ac7615f5075d3e9f8aef70f6","unresolved":false,"context_lines":[{"line_number":151,"context_line":"# [*watcher_client_username*]"},{"line_number":152,"context_line":"#  (optional) Keystone username for watcher client. Decision engine works on"},{"line_number":153,"context_line":"#  this variable."},{"line_number":154,"context_line":"#  Defaults to $::os_service_default"},{"line_number":155,"context_line":"#"},{"line_number":156,"context_line":"# [*watcher_client_password*]"},{"line_number":157,"context_line":"#  (optional) Keystone password for watcher client."}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7aa08908_2b904e4e","line":154,"range":{"start_line":154,"start_character":15,"end_line":154,"end_character":36},"updated":"2016-06-15 10:34:05.000000000","message":"this doesn\u0027t seem to be the case here.","commit_id":"a4b97920bbde34fb91bf3e6a22f73cf99ac54934"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"36ce471185f862a30daffca49d733d2fc1db6ce4","unresolved":false,"context_lines":[{"line_number":151,"context_line":"# [*watcher_client_username*]"},{"line_number":152,"context_line":"#  (optional) Keystone username for watcher client. Decision engine works on"},{"line_number":153,"context_line":"#  this variable."},{"line_number":154,"context_line":"#  Defaults to $::os_service_default"},{"line_number":155,"context_line":"#"},{"line_number":156,"context_line":"# [*watcher_client_password*]"},{"line_number":157,"context_line":"#  (optional) Keystone password for watcher client."}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7aa08908_02028c72","line":154,"range":{"start_line":154,"start_character":15,"end_line":154,"end_character":36},"in_reply_to":"7aa08908_2b904e4e","updated":"2016-06-15 14:15:29.000000000","message":"I\u0027m miss it ;) Thx","commit_id":"a4b97920bbde34fb91bf3e6a22f73cf99ac54934"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"402fd9cea726764a28823236c37f3faf23df45da","unresolved":false,"context_lines":[{"line_number":272,"context_line":"        \u0027command\u0027  \u003d\u003e \"watcher --os-auth-url ${auth_uri} --os-tenant-name ${keystone_tenant} --os-username ${keystone_username} --os-password ${keystone_password} goal list\","},{"line_number":273,"context_line":"      }"},{"line_number":274,"context_line":"    }"},{"line_number":275,"context_line":"    $validation_options_hash \u003d merge($defaults, $validation_options)"},{"line_number":276,"context_line":"    create_resources(\u0027openstacklib::service_validation\u0027, $validation_options_hash, {\u0027subscribe\u0027 \u003d\u003e \u0027Service[watcher-api]\u0027})"},{"line_number":277,"context_line":"  }"},{"line_number":278,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7aa08908_7867ceb7","line":275,"range":{"start_line":275,"start_character":49,"end_line":275,"end_character":67},"updated":"2016-06-15 10:15:25.000000000","message":"no such variable in current context","commit_id":"a4b97920bbde34fb91bf3e6a22f73cf99ac54934"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"9903b3a6a8312578ac7615f5075d3e9f8aef70f6","unresolved":false,"context_lines":[{"line_number":272,"context_line":"        \u0027command\u0027  \u003d\u003e \"watcher --os-auth-url ${auth_uri} --os-tenant-name ${keystone_tenant} --os-username ${keystone_username} --os-password ${keystone_password} goal list\","},{"line_number":273,"context_line":"      }"},{"line_number":274,"context_line":"    }"},{"line_number":275,"context_line":"    $validation_options_hash \u003d merge($defaults, $validation_options)"},{"line_number":276,"context_line":"    create_resources(\u0027openstacklib::service_validation\u0027, $validation_options_hash, {\u0027subscribe\u0027 \u003d\u003e \u0027Service[watcher-api]\u0027})"},{"line_number":277,"context_line":"  }"},{"line_number":278,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7aa08908_abd55e1c","line":275,"range":{"start_line":275,"start_character":49,"end_line":275,"end_character":67},"in_reply_to":"7aa08908_7867ceb7","updated":"2016-06-15 10:34:05.000000000","message":"where is validation_options supposed to be coming from?","commit_id":"a4b97920bbde34fb91bf3e6a22f73cf99ac54934"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"744685365a47d4945760870eae9bf63700fd8006","unresolved":false,"context_lines":[{"line_number":251,"context_line":"  # in keystone::resource::authtoken"},{"line_number":252,"context_line":"  watcher_config {"},{"line_number":253,"context_line":"    \u0027keystone_authtoken/auth_uri\u0027:     value \u003d\u003e $auth_uri;"},{"line_number":254,"context_line":"    \u0027keystone_authtoken/auth_version\u0027: value \u003d\u003e $keystone_auth_version;"},{"line_number":255,"context_line":"    \u0027keystone_authtoken/auth_type\u0027:    value \u003d\u003e $keystone_auth_type;"},{"line_number":256,"context_line":"    \u0027keystone_authtoken/signing_dir\u0027:  value \u003d\u003e $keystone_signing_dir;"},{"line_number":257,"context_line":"    \u0027keystone_authtoken/region_name\u0027:  value \u003d\u003e $keystone_region_name;"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7aa08908_e1380cd7","line":254,"updated":"2016-06-15 18:19:59.000000000","message":"this one is old and not useful anymore AFIK.","commit_id":"dd40e53375536b1756dfe695f3541441ee1bc0ba"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"25308dc3d9e38b072f788d687cb900e8ead4002e","unresolved":false,"context_lines":[{"line_number":251,"context_line":"  # in keystone::resource::authtoken"},{"line_number":252,"context_line":"  watcher_config {"},{"line_number":253,"context_line":"    \u0027keystone_authtoken/auth_uri\u0027:     value \u003d\u003e $auth_uri;"},{"line_number":254,"context_line":"    \u0027keystone_authtoken/auth_version\u0027: value \u003d\u003e $keystone_auth_version;"},{"line_number":255,"context_line":"    \u0027keystone_authtoken/auth_type\u0027:    value \u003d\u003e $keystone_auth_type;"},{"line_number":256,"context_line":"    \u0027keystone_authtoken/signing_dir\u0027:  value \u003d\u003e $keystone_signing_dir;"},{"line_number":257,"context_line":"    \u0027keystone_authtoken/region_name\u0027:  value \u003d\u003e $keystone_region_name;"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7aa08908_f61efb0b","line":254,"in_reply_to":"7aa08908_e1380cd7","updated":"2016-06-16 08:26:45.000000000","message":"auth_version parameter is available in documentation:\nhttp://docs.openstack.org/developer/keystonemiddleware/middlewarearchitecture.html","commit_id":"dd40e53375536b1756dfe695f3541441ee1bc0ba"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"744685365a47d4945760870eae9bf63700fd8006","unresolved":false,"context_lines":[{"line_number":252,"context_line":"  watcher_config {"},{"line_number":253,"context_line":"    \u0027keystone_authtoken/auth_uri\u0027:     value \u003d\u003e $auth_uri;"},{"line_number":254,"context_line":"    \u0027keystone_authtoken/auth_version\u0027: value \u003d\u003e $keystone_auth_version;"},{"line_number":255,"context_line":"    \u0027keystone_authtoken/auth_type\u0027:    value \u003d\u003e $keystone_auth_type;"},{"line_number":256,"context_line":"    \u0027keystone_authtoken/signing_dir\u0027:  value \u003d\u003e $keystone_signing_dir;"},{"line_number":257,"context_line":"    \u0027keystone_authtoken/region_name\u0027:  value \u003d\u003e $keystone_region_name;"},{"line_number":258,"context_line":"    \u0027keystone_authtoken/cafile\u0027:       value \u003d\u003e $keystone_cafile;"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7aa08908_213334f8","line":255,"updated":"2016-06-15 18:19:59.000000000","message":"s","commit_id":"dd40e53375536b1756dfe695f3541441ee1bc0ba"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"25308dc3d9e38b072f788d687cb900e8ead4002e","unresolved":false,"context_lines":[{"line_number":252,"context_line":"  watcher_config {"},{"line_number":253,"context_line":"    \u0027keystone_authtoken/auth_uri\u0027:     value \u003d\u003e $auth_uri;"},{"line_number":254,"context_line":"    \u0027keystone_authtoken/auth_version\u0027: value \u003d\u003e $keystone_auth_version;"},{"line_number":255,"context_line":"    \u0027keystone_authtoken/auth_type\u0027:    value \u003d\u003e $keystone_auth_type;"},{"line_number":256,"context_line":"    \u0027keystone_authtoken/signing_dir\u0027:  value \u003d\u003e $keystone_signing_dir;"},{"line_number":257,"context_line":"    \u0027keystone_authtoken/region_name\u0027:  value \u003d\u003e $keystone_region_name;"},{"line_number":258,"context_line":"    \u0027keystone_authtoken/cafile\u0027:       value \u003d\u003e $keystone_cafile;"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7aa08908_16ff47ab","line":255,"in_reply_to":"7aa08908_213334f8","updated":"2016-06-16 08:26:45.000000000","message":"Auth_type parameter is available in documentation. \nAuth_plugin is deprecated.","commit_id":"dd40e53375536b1756dfe695f3541441ee1bc0ba"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"cd9facd041654405bac5159b07d6ced765aeab45","unresolved":false,"context_lines":[{"line_number":217,"context_line":"  $watcher_client_auth_type_real \u003d pick($watcher_client_auth_type, $keystone_auth_type)"},{"line_number":218,"context_line":"  $watcher_client_cafile_real \u003d pick($watcher_client_cafile, $keystone_cafile)"},{"line_number":219,"context_line":"  $watcher_client_certfile_real \u003d pick($watcher_client_certfile, $keystone_certfile)"},{"line_number":220,"context_line":"  $watcher_client_keyfile_real \u003d pick($watcher_client_keyfile, $keystone_keyfile)"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"  validate_string($keystone_password)"},{"line_number":223,"context_line":"  validate_string($watcher_client_password_real)"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7aa08908_d6cba3a2","line":220,"updated":"2016-06-17 17:00:13.000000000","message":"why not using the same values, why would they be different?","commit_id":"1dc80b3f2c1ee20e387132a0b79a3a73282f6417"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"fcbbd60e18f97017f65797cbd2415c71ac3b2580","unresolved":false,"context_lines":[{"line_number":217,"context_line":"  $watcher_client_auth_type_real \u003d pick($watcher_client_auth_type, $keystone_auth_type)"},{"line_number":218,"context_line":"  $watcher_client_cafile_real \u003d pick($watcher_client_cafile, $keystone_cafile)"},{"line_number":219,"context_line":"  $watcher_client_certfile_real \u003d pick($watcher_client_certfile, $keystone_certfile)"},{"line_number":220,"context_line":"  $watcher_client_keyfile_real \u003d pick($watcher_client_keyfile, $keystone_keyfile)"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"  validate_string($keystone_password)"},{"line_number":223,"context_line":"  validate_string($watcher_client_password_real)"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7aa08908_fc49558f","line":220,"in_reply_to":"7aa08908_d6cba3a2","updated":"2016-06-17 23:03:35.000000000","message":"hmm, I assumed that all section variables should be parametrized (user should be able to configure each parameter in each sections).","commit_id":"1dc80b3f2c1ee20e387132a0b79a3a73282f6417"},{"author":{"_account_id":16771,"name":"mpolenchuk","email":"mpolenchuk@mirantis.com","username":"mpolenchuk"},"change_message_id":"057bfd6926c5593968294b45f65f1948632e2084","unresolved":false,"context_lines":[{"line_number":260,"context_line":"    \u0027keystone_authtoken/keyfile\u0027:      value \u003d\u003e $keystone_keyfile;"},{"line_number":261,"context_line":"  }"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"  watcher_config {"},{"line_number":264,"context_line":"    \u0027watcher_clients_auth/username\u0027:            value \u003d\u003e $watcher_client_username_real;"},{"line_number":265,"context_line":"    \u0027watcher_clients_auth/password\u0027:            value \u003d\u003e $watcher_client_password_real, secret \u003d\u003e true;"},{"line_number":266,"context_line":"    \u0027watcher_clients_auth/auth_url\u0027:            value \u003d\u003e $auth_url;"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"5a9d85d2_a2c53f8f","line":263,"range":{"start_line":263,"start_character":2,"end_line":263,"end_character":17},"updated":"2016-06-21 08:16:50.000000000","message":"would be good to use class watcher::config instead.\nthe same for above.","commit_id":"1dc80b3f2c1ee20e387132a0b79a3a73282f6417"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"302364d9c44b6374909713783ee726ce09e83928","unresolved":false,"context_lines":[{"line_number":274,"context_line":"    \u0027watcher_clients_auth/keyfile\u0027:             value \u003d\u003e $watcher_client_keyfile_real;"},{"line_number":275,"context_line":"  }"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"  if $validate {"},{"line_number":278,"context_line":"    $defaults \u003d {"},{"line_number":279,"context_line":"      \u0027watcher-api\u0027 \u003d\u003e {"},{"line_number":280,"context_line":"        \u0027command\u0027  \u003d\u003e \"watcher --os-auth-url ${auth_uri} --os-tenant-name ${keystone_tenant} --os-username ${keystone_username} --os-password ${keystone_password} goal list\","},{"line_number":281,"context_line":"      }"},{"line_number":282,"context_line":"    }"},{"line_number":283,"context_line":"    $validation_options_hash \u003d merge($defaults, $validation_options)"},{"line_number":284,"context_line":"    create_resources(\u0027openstacklib::service_validation\u0027, $validation_options_hash, {\u0027subscribe\u0027 \u003d\u003e \u0027Service[watcher-api]\u0027})"},{"line_number":285,"context_line":"  }"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3aaa91ec_284d70c4","line":285,"range":{"start_line":277,"start_character":0,"end_line":285,"end_character":3},"updated":"2016-06-23 18:25:44.000000000","message":"please remove it, we don\u0027t need it.","commit_id":"1dc80b3f2c1ee20e387132a0b79a3a73282f6417"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"a5d71bf35f0d80b89e0facdf5f07c30f9dc35d0b","unresolved":false,"context_lines":[{"line_number":274,"context_line":"    \u0027watcher_clients_auth/keyfile\u0027:             value \u003d\u003e $watcher_client_keyfile_real;"},{"line_number":275,"context_line":"  }"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"  if $validate {"},{"line_number":278,"context_line":"    $defaults \u003d {"},{"line_number":279,"context_line":"      \u0027watcher-api\u0027 \u003d\u003e {"},{"line_number":280,"context_line":"        \u0027command\u0027  \u003d\u003e \"watcher --os-auth-url ${auth_uri} --os-tenant-name ${keystone_tenant} --os-username ${keystone_username} --os-password ${keystone_password} goal list\","},{"line_number":281,"context_line":"      }"},{"line_number":282,"context_line":"    }"},{"line_number":283,"context_line":"    $validation_options_hash \u003d merge($defaults, $validation_options)"},{"line_number":284,"context_line":"    create_resources(\u0027openstacklib::service_validation\u0027, $validation_options_hash, {\u0027subscribe\u0027 \u003d\u003e \u0027Service[watcher-api]\u0027})"},{"line_number":285,"context_line":"  }"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3aaa91ec_97a3dcb1","line":285,"range":{"start_line":277,"start_character":0,"end_line":285,"end_character":3},"in_reply_to":"3aaa91ec_284d70c4","updated":"2016-06-23 19:46:14.000000000","message":"Validation can be added now or later.\nI don\u0027t see any problem if validation will be added in this commit because puppet doesn\u0027t ensure if package is installed (I don\u0027t know the name of watcher service in RedHat distro) in system so user should install yourself watcher and validation should pass ;) By default validation is disabled, so there should be no problem.\n\nSummary: I can remove it for now and add it in next commit when package ensurance will be added or leave it.","commit_id":"1dc80b3f2c1ee20e387132a0b79a3a73282f6417"}],"spec/classes/watcher_api_spec.rb":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"402fd9cea726764a28823236c37f3faf23df45da","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  shared_examples \u0027watcher-api\u0027 do"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    context \u0027with default parameters\u0027 do"},{"line_number":8,"context_line":"      let :params do"},{"line_number":9,"context_line":"        {"},{"line_number":10,"context_line":"          :keystone_password     \u003d\u003e \u0027password\u0027,"},{"line_number":11,"context_line":"        }"},{"line_number":12,"context_line":"      end"},{"line_number":13,"context_line":"      it \u0027configures keystone authtoken\u0027 do"},{"line_number":14,"context_line":"        is_expected.to contain_watcher_config(\u0027keystone_authtoken/username\u0027).with_value(\u0027watcher\u0027)"},{"line_number":15,"context_line":"        is_expected.to contain_watcher_config(\u0027keystone_authtoken/password\u0027).with_value(\u0027password\u0027)"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"7aa08908_18a96a91","line":12,"range":{"start_line":8,"start_character":0,"end_line":12,"end_character":9},"updated":"2016-06-15 10:15:25.000000000","message":"can be set as globals params out of any context or examples","commit_id":"a4b97920bbde34fb91bf3e6a22f73cf99ac54934"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"402fd9cea726764a28823236c37f3faf23df45da","unresolved":false,"context_lines":[{"line_number":55,"context_line":"      end"},{"line_number":56,"context_line":"    end"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    context \u0027with default parameters\u0027 do"},{"line_number":59,"context_line":"      let :params do"},{"line_number":60,"context_line":"        {"},{"line_number":61,"context_line":"          :keystone_password       \u003d\u003e \u0027password\u0027,"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"7aa08908_d88c0231","line":58,"range":{"start_line":58,"start_character":13,"end_line":58,"end_character":36},"updated":"2016-06-15 10:15:25.000000000","message":"please do not use few contexts with one name","commit_id":"a4b97920bbde34fb91bf3e6a22f73cf99ac54934"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"36ce471185f862a30daffca49d733d2fc1db6ce4","unresolved":false,"context_lines":[{"line_number":55,"context_line":"      end"},{"line_number":56,"context_line":"    end"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    context \u0027with default parameters\u0027 do"},{"line_number":59,"context_line":"      let :params do"},{"line_number":60,"context_line":"        {"},{"line_number":61,"context_line":"          :keystone_password       \u003d\u003e \u0027password\u0027,"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"7aa08908_847ccfb6","line":58,"range":{"start_line":58,"start_character":13,"end_line":58,"end_character":36},"in_reply_to":"7aa08908_d88c0231","updated":"2016-06-15 14:15:29.000000000","message":"ok","commit_id":"a4b97920bbde34fb91bf3e6a22f73cf99ac54934"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"402fd9cea726764a28823236c37f3faf23df45da","unresolved":false,"context_lines":[{"line_number":78,"context_line":"      end"},{"line_number":79,"context_line":"    end"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    context \u0027with overridden parameters\u0027 do"},{"line_number":82,"context_line":"      let :params do"},{"line_number":83,"context_line":"        {"},{"line_number":84,"context_line":"          :keystone_password           \u003d\u003e \u0027password\u0027,"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"7aa08908_d8b362eb","line":81,"updated":"2016-06-15 10:15:25.000000000","message":"before do\n  params.merge! ( {\n  \u003cyour params\u003e\n})\n\nsame below","commit_id":"a4b97920bbde34fb91bf3e6a22f73cf99ac54934"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"36ce471185f862a30daffca49d733d2fc1db6ce4","unresolved":false,"context_lines":[{"line_number":78,"context_line":"      end"},{"line_number":79,"context_line":"    end"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    context \u0027with overridden parameters\u0027 do"},{"line_number":82,"context_line":"      let :params do"},{"line_number":83,"context_line":"        {"},{"line_number":84,"context_line":"          :keystone_password           \u003d\u003e \u0027password\u0027,"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"7aa08908_c2ab6474","line":81,"in_reply_to":"7aa08908_d8b362eb","updated":"2016-06-15 14:15:29.000000000","message":"ok","commit_id":"a4b97920bbde34fb91bf3e6a22f73cf99ac54934"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"6dff4312236f26b41c424e0407c9a8eae3882ac2","unresolved":false,"context_lines":[{"line_number":163,"context_line":"  }).each do |os,facts|"},{"line_number":164,"context_line":"    context \"on #{os}\" do"},{"line_number":165,"context_line":"      let (:facts) do"},{"line_number":166,"context_line":"        facts.merge!(OSDefaults.get_facts())"},{"line_number":167,"context_line":"      end"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"      it_behaves_like \u0027watcher-api\u0027"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"7aa08908_f80bbe22","line":166,"updated":"2016-06-15 10:05:17.000000000","message":"try to pass here:\n\nos_service_default \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027","commit_id":"a4b97920bbde34fb91bf3e6a22f73cf99ac54934"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"35d2f03cf29b05044d5b8c491051ce162c9dc539","unresolved":false,"context_lines":[{"line_number":163,"context_line":"  }).each do |os,facts|"},{"line_number":164,"context_line":"    context \"on #{os}\" do"},{"line_number":165,"context_line":"      let (:facts) do"},{"line_number":166,"context_line":"        facts.merge!(OSDefaults.get_facts())"},{"line_number":167,"context_line":"      end"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"      it_behaves_like \u0027watcher-api\u0027"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"7aa08908_1855eaf9","line":166,"in_reply_to":"7aa08908_f80bbe22","updated":"2016-06-15 10:06:34.000000000","message":"nevermind, invalid","commit_id":"a4b97920bbde34fb91bf3e6a22f73cf99ac54934"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"210e01f6751ed2ad2234c410195df526c1b43360","unresolved":false,"context_lines":[{"line_number":41,"context_line":"          :keystone_password     \u003d\u003e \u0027password1234\u0027,"},{"line_number":42,"context_line":"        })"},{"line_number":43,"context_line":"      end"},{"line_number":44,"context_line":"      it \u0027configures keystone authtoken\u0027 do"},{"line_number":45,"context_line":"        is_expected.to contain_watcher_config(\u0027keystone_authtoken/username\u0027).with_value(\u0027watcher_admin\u0027)"},{"line_number":46,"context_line":"        is_expected.to contain_watcher_config(\u0027keystone_authtoken/password\u0027).with_value(\u0027password1234\u0027)"},{"line_number":47,"context_line":"        is_expected.to contain_watcher_config(\u0027keystone_authtoken/auth_url\u0027).with_value(\u0027http://localhost:35357/\u0027)"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"7aa08908_d7495d62","line":44,"range":{"start_line":44,"start_character":6,"end_line":44,"end_character":43},"updated":"2016-06-15 15:31:16.000000000","message":"since you\u0027re adding params and you want to test the values of these parameters you could use  params[:keystone_*]","commit_id":"dd40e53375536b1756dfe695f3541441ee1bc0ba"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"0826dae1249fd4710a772c986a3dfeb5a530b01d","unresolved":false,"context_lines":[{"line_number":41,"context_line":"          :keystone_password     \u003d\u003e \u0027password1234\u0027,"},{"line_number":42,"context_line":"        })"},{"line_number":43,"context_line":"      end"},{"line_number":44,"context_line":"      it \u0027configures keystone authtoken\u0027 do"},{"line_number":45,"context_line":"        is_expected.to contain_watcher_config(\u0027keystone_authtoken/username\u0027).with_value(\u0027watcher_admin\u0027)"},{"line_number":46,"context_line":"        is_expected.to contain_watcher_config(\u0027keystone_authtoken/password\u0027).with_value(\u0027password1234\u0027)"},{"line_number":47,"context_line":"        is_expected.to contain_watcher_config(\u0027keystone_authtoken/auth_url\u0027).with_value(\u0027http://localhost:35357/\u0027)"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"7aa08908_57ae0d82","line":44,"range":{"start_line":44,"start_character":6,"end_line":44,"end_character":43},"in_reply_to":"7aa08908_d7495d62","updated":"2016-06-15 15:36:30.000000000","message":"that\u0027s not important, we are expecting same values.","commit_id":"dd40e53375536b1756dfe695f3541441ee1bc0ba"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"210e01f6751ed2ad2234c410195df526c1b43360","unresolved":false,"context_lines":[{"line_number":83,"context_line":"          :watcher_client_insecure     \u003d\u003e \u0027true\u0027,"},{"line_number":84,"context_line":"        })"},{"line_number":85,"context_line":"      end"},{"line_number":86,"context_line":"      it \u0027configures watcher clients auth\u0027 do"},{"line_number":87,"context_line":"        is_expected.to contain_watcher_config(\u0027watcher_clients_auth/username\u0027).with_value(\u0027watcher_user\u0027)"},{"line_number":88,"context_line":"        is_expected.to contain_watcher_config(\u0027watcher_clients_auth/password\u0027).with_value(\u0027PassWoRD\u0027)"},{"line_number":89,"context_line":"        is_expected.to contain_watcher_config(\u0027watcher_clients_auth/auth_url\u0027).with_value(\u0027http://localhost:35357/\u0027)"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"7aa08908_d7603dd2","line":86,"range":{"start_line":86,"start_character":9,"end_line":86,"end_character":42},"updated":"2016-06-15 15:31:16.000000000","message":"same from above","commit_id":"dd40e53375536b1756dfe695f3541441ee1bc0ba"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"0826dae1249fd4710a772c986a3dfeb5a530b01d","unresolved":false,"context_lines":[{"line_number":83,"context_line":"          :watcher_client_insecure     \u003d\u003e \u0027true\u0027,"},{"line_number":84,"context_line":"        })"},{"line_number":85,"context_line":"      end"},{"line_number":86,"context_line":"      it \u0027configures watcher clients auth\u0027 do"},{"line_number":87,"context_line":"        is_expected.to contain_watcher_config(\u0027watcher_clients_auth/username\u0027).with_value(\u0027watcher_user\u0027)"},{"line_number":88,"context_line":"        is_expected.to contain_watcher_config(\u0027watcher_clients_auth/password\u0027).with_value(\u0027PassWoRD\u0027)"},{"line_number":89,"context_line":"        is_expected.to contain_watcher_config(\u0027watcher_clients_auth/auth_url\u0027).with_value(\u0027http://localhost:35357/\u0027)"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"7aa08908_37b381eb","line":86,"range":{"start_line":86,"start_character":9,"end_line":86,"end_character":42},"in_reply_to":"7aa08908_d7603dd2","updated":"2016-06-15 15:36:30.000000000","message":"same","commit_id":"dd40e53375536b1756dfe695f3541441ee1bc0ba"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"210e01f6751ed2ad2234c410195df526c1b43360","unresolved":false,"context_lines":[{"line_number":127,"context_line":"      end"},{"line_number":128,"context_line":"      let :params do"},{"line_number":129,"context_line":"        {"},{"line_number":130,"context_line":"          :keystone_username       \u003d\u003e \u0027watcher_admin\u0027,"},{"line_number":131,"context_line":"          :keystone_insecure       \u003d\u003e \u0027true\u0027,"},{"line_number":132,"context_line":"          :keystone_region_name    \u003d\u003e \u0027RegionOne\u0027,"},{"line_number":133,"context_line":"          :watcher_client_username \u003d\u003e \u0027watcher_user\u0027,"},{"line_number":134,"context_line":"          :watcher_client_password \u003d\u003e \u0027watcher_password\u0027,"},{"line_number":135,"context_line":"          :watcher_client_insecure \u003d\u003e \u0027false\u0027,"},{"line_number":136,"context_line":"        }"},{"line_number":137,"context_line":"      end"},{"line_number":138,"context_line":"      it \u0027configures keystone authtoken\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"7aa08908_377f0168","line":135,"range":{"start_line":130,"start_character":0,"end_line":135,"end_character":46},"updated":"2016-06-15 15:31:16.000000000","message":"i think you should move all to params.merge! in before","commit_id":"dd40e53375536b1756dfe695f3541441ee1bc0ba"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"0826dae1249fd4710a772c986a3dfeb5a530b01d","unresolved":false,"context_lines":[{"line_number":127,"context_line":"      end"},{"line_number":128,"context_line":"      let :params do"},{"line_number":129,"context_line":"        {"},{"line_number":130,"context_line":"          :keystone_username       \u003d\u003e \u0027watcher_admin\u0027,"},{"line_number":131,"context_line":"          :keystone_insecure       \u003d\u003e \u0027true\u0027,"},{"line_number":132,"context_line":"          :keystone_region_name    \u003d\u003e \u0027RegionOne\u0027,"},{"line_number":133,"context_line":"          :watcher_client_username \u003d\u003e \u0027watcher_user\u0027,"},{"line_number":134,"context_line":"          :watcher_client_password \u003d\u003e \u0027watcher_password\u0027,"},{"line_number":135,"context_line":"          :watcher_client_insecure \u003d\u003e \u0027false\u0027,"},{"line_number":136,"context_line":"        }"},{"line_number":137,"context_line":"      end"},{"line_number":138,"context_line":"      it \u0027configures keystone authtoken\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"7aa08908_b7bf71a9","line":135,"range":{"start_line":130,"start_character":0,"end_line":135,"end_character":46},"in_reply_to":"7aa08908_377f0168","updated":"2016-06-15 15:36:30.000000000","message":"make sense","commit_id":"dd40e53375536b1756dfe695f3541441ee1bc0ba"}]}