)]}'
{"manifests/api.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"9cf8406b4d0971f4a0b1aa862e677ccc8fe6e7e9","unresolved":false,"context_lines":[{"line_number":231,"context_line":"  Class[\u0027watcher::policy\u0027] ~\u003e Service[\u0027watcher-api\u0027]"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"  Package[\u0027watcher-api\u0027] -\u003e Service[\u0027watcher-api\u0027]"},{"line_number":234,"context_line":"  Package[\u0027watcher-api\u0027] -\u003e Class[\u0027watcher::policy\u0027]"},{"line_number":235,"context_line":"  package { \u0027watcher-api\u0027:"},{"line_number":236,"context_line":"    ensure \u003d\u003e $package_ensure,"},{"line_number":237,"context_line":"    name   \u003d\u003e $::watcher::params::api_package_name,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3aaa91ec_247c91ea","line":234,"updated":"2016-06-29 10:13:07.000000000","message":"should not it be for watcher-common project? policy conf file should be placed exactly in common package, at least we have such approach for openstack packages.","commit_id":"640435fea1aaba82d99a341c549e05dbf2c6a26c"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"90bebe85d6b712a785b53509924c28b7fa746838","unresolved":false,"context_lines":[{"line_number":231,"context_line":"  Class[\u0027watcher::policy\u0027] ~\u003e Service[\u0027watcher-api\u0027]"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"  Package[\u0027watcher-api\u0027] -\u003e Service[\u0027watcher-api\u0027]"},{"line_number":234,"context_line":"  Package[\u0027watcher-api\u0027] -\u003e Class[\u0027watcher::policy\u0027]"},{"line_number":235,"context_line":"  package { \u0027watcher-api\u0027:"},{"line_number":236,"context_line":"    ensure \u003d\u003e $package_ensure,"},{"line_number":237,"context_line":"    name   \u003d\u003e $::watcher::params::api_package_name,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3aaa91ec_b020b74a","line":234,"in_reply_to":"3aaa91ec_157c1dea","updated":"2016-06-29 11:19:30.000000000","message":"AFAIU, you are using this spec for rpm:\n\nhttps://github.com/dduuch/openstack-watcher-rpm/blob/master/openstack-watcher.spec#L219\n\nIn this spec - policy.conf is in main package. Thoughts?","commit_id":"640435fea1aaba82d99a341c549e05dbf2c6a26c"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"5d0a90f994ae823e6ce3d10e5a4e5321a8f37a7e","unresolved":false,"context_lines":[{"line_number":231,"context_line":"  Class[\u0027watcher::policy\u0027] ~\u003e Service[\u0027watcher-api\u0027]"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"  Package[\u0027watcher-api\u0027] -\u003e Service[\u0027watcher-api\u0027]"},{"line_number":234,"context_line":"  Package[\u0027watcher-api\u0027] -\u003e Class[\u0027watcher::policy\u0027]"},{"line_number":235,"context_line":"  package { \u0027watcher-api\u0027:"},{"line_number":236,"context_line":"    ensure \u003d\u003e $package_ensure,"},{"line_number":237,"context_line":"    name   \u003d\u003e $::watcher::params::api_package_name,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3aaa91ec_157c1dea","line":234,"in_reply_to":"3aaa91ec_247c91ea","updated":"2016-06-29 11:08:13.000000000","message":"Just as I thought, but in many projects such as: puppet-octavia, puppet-mistral and puppet-gnocchi policy is in api package...","commit_id":"640435fea1aaba82d99a341c549e05dbf2c6a26c"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"b9c7e28b4e8bc850e28ca5f6f47d7f5aabe668ad","unresolved":false,"context_lines":[{"line_number":231,"context_line":"  Class[\u0027watcher::policy\u0027] ~\u003e Service[\u0027watcher-api\u0027]"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"  Package[\u0027watcher-api\u0027] -\u003e Service[\u0027watcher-api\u0027]"},{"line_number":234,"context_line":"  Package[\u0027watcher-api\u0027] -\u003e Class[\u0027watcher::policy\u0027]"},{"line_number":235,"context_line":"  package { \u0027watcher-api\u0027:"},{"line_number":236,"context_line":"    ensure \u003d\u003e $package_ensure,"},{"line_number":237,"context_line":"    name   \u003d\u003e $::watcher::params::api_package_name,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3aaa91ec_8b90f04f","line":234,"in_reply_to":"3aaa91ec_b020b74a","updated":"2016-06-29 11:41:56.000000000","message":"I agree. \nURL to final release: https://github.com/rdo-packages/watcher-distgit/blob/rpm-master/openstack-watcher.spec\nAs I see now, in debian watcher package, policy file is in common package, so probably I must fix rpm spec file and move policy from main package to common. \n\ntl;dr: I will move it to init.pp\n\nThx Denis Egorenko. I will change it in next patch set.","commit_id":"640435fea1aaba82d99a341c549e05dbf2c6a26c"}],"manifests/init.pp":[{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"3cb7e0e46155fb20f3c0273a93ec7c6a3e7f76a4","unresolved":false,"context_lines":[{"line_number":412,"context_line":"  include ::watcher::logging"},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"  package { \u0027watcher\u0027:"},{"line_number":415,"context_line":"    ensure \u003d\u003e $ensure_package,"},{"line_number":416,"context_line":"    name   \u003d\u003e $::watcher::params::common_package_name,"},{"line_number":417,"context_line":"    tag    \u003d\u003e [\u0027openstack\u0027, \u0027watcher-package\u0027],"},{"line_number":418,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3aaa91ec_bfa55848","line":415,"updated":"2016-06-28 14:45:41.000000000","message":"ensure_package parameter is duplicated.","commit_id":"e54f4363e255be648e6b8ace1f2f5c4f7d95ce73"}],"manifests/params.pp":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"1539e02115f0db507df6b200bc3e4832d2ff98ea","unresolved":false,"context_lines":[{"line_number":6,"context_line":"  case $::osfamily {"},{"line_number":7,"context_line":"    \u0027RedHat\u0027: {"},{"line_number":8,"context_line":"      $api_package_name    \u003d \u0027openstack-watcher-api\u0027"},{"line_number":9,"context_line":"      $common_package_name \u003d \u0027openstack-watcher-common\u0027"},{"line_number":10,"context_line":"    }"},{"line_number":11,"context_line":"    \u0027Debian\u0027: {"},{"line_number":12,"context_line":"      $api_package_name    \u003d \u0027watcher-api\u0027"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3aaa91ec_1e0ebc8b","line":9,"range":{"start_line":9,"start_character":29,"end_line":9,"end_character":55},"updated":"2016-06-30 12:50:52.000000000","message":"seems that this package is not upstream yet maybe after the bump the RDO repo this will show up","commit_id":"e5c0b9523e70526c7ae7bb0be8c06455b4aa0046"}]}