)]}'
{"manifests/api.pp":[{"author":{"_account_id":20259,"name":"Clenimar Filemon","email":"clenimar@lsd.ufcg.edu.br","username":"clenimar"},"change_message_id":"7a48d01d21bb9ff4aa157ef69dc1f9674bbcef9b","unresolved":false,"context_lines":[{"line_number":280,"context_line":"    certfile            \u003d\u003e $keystone_certfile,"},{"line_number":281,"context_line":"    keyfile             \u003d\u003e $keystone_keyfile,"},{"line_number":282,"context_line":"    project_name        \u003d\u003e $keystone_project_name,"},{"line_number":283,"context_line":"    project_domain_name \u003d\u003e $keystone_project_domain_name,"},{"line_number":284,"context_line":"    insecure            \u003d\u003e $keystone_insecure,"},{"line_number":285,"context_line":"    region_name         \u003d\u003e $keystone_region_name,"},{"line_number":286,"context_line":"    signing_dir         \u003d\u003e $keystone_signing_dir,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1aa78d24_2eaea7e7","line":283,"range":{"start_line":283,"start_character":4,"end_line":283,"end_character":23},"updated":"2016-07-07 21:13:04.000000000","message":"if you want to authenticate to keystone v3 api, you\u0027re going to need user domain info too.","commit_id":"9882e4ed8c3146232a2646fa505006c7c560f465"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"2691c1f2fe07ae18afda38050aa4e0b7f6f0c455","unresolved":false,"context_lines":[{"line_number":280,"context_line":"    certfile            \u003d\u003e $keystone_certfile,"},{"line_number":281,"context_line":"    keyfile             \u003d\u003e $keystone_keyfile,"},{"line_number":282,"context_line":"    project_name        \u003d\u003e $keystone_project_name,"},{"line_number":283,"context_line":"    project_domain_name \u003d\u003e $keystone_project_domain_name,"},{"line_number":284,"context_line":"    insecure            \u003d\u003e $keystone_insecure,"},{"line_number":285,"context_line":"    region_name         \u003d\u003e $keystone_region_name,"},{"line_number":286,"context_line":"    signing_dir         \u003d\u003e $keystone_signing_dir,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1aa78d24_31c3a88c","line":283,"range":{"start_line":283,"start_character":4,"end_line":283,"end_character":23},"in_reply_to":"1aa78d24_2eaea7e7","updated":"2016-07-07 21:24:15.000000000","message":"I was just fixing the duplication errors, seems like there\u0027s further configuration items that need to be added as I don\u0027t see the user domain name for this class","commit_id":"9882e4ed8c3146232a2646fa505006c7c560f465"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"e7c40c10a06ab7d3af3c6798cfef25714e9f21b1","unresolved":false,"context_lines":[{"line_number":280,"context_line":"    certfile            \u003d\u003e $keystone_certfile,"},{"line_number":281,"context_line":"    keyfile             \u003d\u003e $keystone_keyfile,"},{"line_number":282,"context_line":"    project_name        \u003d\u003e $keystone_project_name,"},{"line_number":283,"context_line":"    project_domain_name \u003d\u003e $keystone_project_domain_name,"},{"line_number":284,"context_line":"    insecure            \u003d\u003e $keystone_insecure,"},{"line_number":285,"context_line":"    region_name         \u003d\u003e $keystone_region_name,"},{"line_number":286,"context_line":"    signing_dir         \u003d\u003e $keystone_signing_dir,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1aa78d24_5102b40c","line":283,"range":{"start_line":283,"start_character":4,"end_line":283,"end_character":23},"in_reply_to":"1aa78d24_31c3a88c","updated":"2016-07-07 21:40:36.000000000","message":"Nope, according to documentation (https://factory.b-com.com/www/watcher/doc/watcher/deploy/conf-files.html) domain_name is only in watcher_clients_auth section.","commit_id":"9882e4ed8c3146232a2646fa505006c7c560f465"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"648908c2b6287bb6c1fc9fc87027cd61b0cb81c8","unresolved":false,"context_lines":[{"line_number":316,"context_line":"  }"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"  # NOTE(danpawlik): Added almost all parameters from keystone_authtoken."},{"line_number":319,"context_line":"  # Memcache parameters will be added later."},{"line_number":320,"context_line":"  keystone::resource::authtoken { \u0027watcher_config\u0027:"},{"line_number":321,"context_line":"    username                     \u003d\u003e $keystone_username,"},{"line_number":322,"context_line":"    password                     \u003d\u003e $keystone_password,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1aa78d24_ef459db3","line":319,"range":{"start_line":319,"start_character":2,"end_line":319,"end_character":44},"updated":"2016-07-08 12:19:10.000000000","message":"Why not add all parameters from https://github.com/openstack/puppet-keystone/blob/master/manifests/resource/authtoken.pp ? This can be done in this commit i think, I have done for puppet-nova (POC) https://review.openstack.org/#/c/337389/","commit_id":"5ed20e426f9cee8cb3cb9e4f10e2cd45633d86e0"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"c90ddac7a9f340b94e51e15c0243bd463b73a447","unresolved":false,"context_lines":[{"line_number":7,"context_line":"# [*keystone_password*]"},{"line_number":8,"context_line":"#   (required) Password to create for the service user"},{"line_number":9,"context_line":"#"},{"line_number":10,"context_line":"# [*keystone_tenant*]"},{"line_number":11,"context_line":"#  (Optional) The tenant of the auth user"},{"line_number":12,"context_line":"#  Defaults to services"},{"line_number":13,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1aa78d24_d7bc94dd","line":10,"range":{"start_line":10,"start_character":3,"end_line":10,"end_character":21},"updated":"2016-07-09 02:55:30.000000000","message":"why have this if you have project_name??","commit_id":"4f7c2d9a6dbdf133a7139f40e8a265107694c272"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"b541c37340905d40eeb2132a7235316565e2162a","unresolved":false,"context_lines":[{"line_number":7,"context_line":"# [*keystone_password*]"},{"line_number":8,"context_line":"#   (required) Password to create for the service user"},{"line_number":9,"context_line":"#"},{"line_number":10,"context_line":"# [*keystone_tenant*]"},{"line_number":11,"context_line":"#  (Optional) The tenant of the auth user"},{"line_number":12,"context_line":"#  Defaults to services"},{"line_number":13,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1aa78d24_4c41360b","line":10,"range":{"start_line":10,"start_character":3,"end_line":10,"end_character":21},"in_reply_to":"1aa78d24_d7bc94dd","updated":"2016-07-09 06:16:18.000000000","message":"Watcher client has both options, so changing it to keystone_project is a small detail.\nCinder have also the same problem ;P","commit_id":"4f7c2d9a6dbdf133a7139f40e8a265107694c272"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"c90ddac7a9f340b94e51e15c0243bd463b73a447","unresolved":false,"context_lines":[{"line_number":59,"context_line":"#"},{"line_number":60,"context_line":"# [*keystone_auth_version*]"},{"line_number":61,"context_line":"#  (Optional) API version of the admin Identity API endpoint."},{"line_number":62,"context_line":"#  Defaults to \u00273\u0027."},{"line_number":63,"context_line":"#"},{"line_number":64,"context_line":"# [*keystone_auth_type*]"},{"line_number":65,"context_line":"#  (Optional) Authentication type to load."}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1aa78d24_17cd7cb7","line":62,"range":{"start_line":62,"start_character":16,"end_line":62,"end_character":17},"updated":"2016-07-09 02:55:30.000000000","message":"v3? my bad in puppet-keystone i have update. \u003d)","commit_id":"4f7c2d9a6dbdf133a7139f40e8a265107694c272"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"b541c37340905d40eeb2132a7235316565e2162a","unresolved":false,"context_lines":[{"line_number":59,"context_line":"#"},{"line_number":60,"context_line":"# [*keystone_auth_version*]"},{"line_number":61,"context_line":"#  (Optional) API version of the admin Identity API endpoint."},{"line_number":62,"context_line":"#  Defaults to \u00273\u0027."},{"line_number":63,"context_line":"#"},{"line_number":64,"context_line":"# [*keystone_auth_type*]"},{"line_number":65,"context_line":"#  (Optional) Authentication type to load."}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1aa78d24_ecebc210","line":62,"range":{"start_line":62,"start_character":16,"end_line":62,"end_character":17},"in_reply_to":"1aa78d24_17cd7cb7","updated":"2016-07-09 06:16:18.000000000","message":"it\u0027s nobody\u0027s fault. They have updated document when we are creating patch.","commit_id":"4f7c2d9a6dbdf133a7139f40e8a265107694c272"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"c90ddac7a9f340b94e51e15c0243bd463b73a447","unresolved":false,"context_lines":[{"line_number":63,"context_line":"#"},{"line_number":64,"context_line":"# [*keystone_auth_type*]"},{"line_number":65,"context_line":"#  (Optional) Authentication type to load."},{"line_number":66,"context_line":"#  Defaults to \u0027password\u0027."},{"line_number":67,"context_line":"#"},{"line_number":68,"context_line":"# [*keystone_auth_section*]"},{"line_number":69,"context_line":"#  (Optional) Config Section from which to load plugin specific options."}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1aa78d24_9715ece6","line":66,"range":{"start_line":66,"start_character":15,"end_line":66,"end_character":25},"updated":"2016-07-09 02:55:30.000000000","message":"this is a default for watcher?","commit_id":"4f7c2d9a6dbdf133a7139f40e8a265107694c272"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"b541c37340905d40eeb2132a7235316565e2162a","unresolved":false,"context_lines":[{"line_number":63,"context_line":"#"},{"line_number":64,"context_line":"# [*keystone_auth_type*]"},{"line_number":65,"context_line":"#  (Optional) Authentication type to load."},{"line_number":66,"context_line":"#  Defaults to \u0027password\u0027."},{"line_number":67,"context_line":"#"},{"line_number":68,"context_line":"# [*keystone_auth_section*]"},{"line_number":69,"context_line":"#  (Optional) Config Section from which to load plugin specific options."}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1aa78d24_0c5e0ee9","line":66,"range":{"start_line":66,"start_character":15,"end_line":66,"end_character":25},"in_reply_to":"1aa78d24_9715ece6","updated":"2016-07-09 06:16:18.000000000","message":"In documentation is none, but if you don\u0027t  set it to password watcher will have problems. So better if I set as default password. It will help many users","commit_id":"4f7c2d9a6dbdf133a7139f40e8a265107694c272"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"c90ddac7a9f340b94e51e15c0243bd463b73a447","unresolved":false,"context_lines":[{"line_number":277,"context_line":"  $watcher_api_max_limit                   \u003d $::os_service_default,"},{"line_number":278,"context_line":"  $watcher_api_bind_host                   \u003d \u00270.0.0.0\u0027,"},{"line_number":279,"context_line":"  $keystone_project_name                   \u003d \u0027service\u0027,"},{"line_number":280,"context_line":"  $keystone_auth_version                   \u003d \u00273\u0027,"},{"line_number":281,"context_line":"  $keystone_auth_type                      \u003d \u0027password\u0027,"},{"line_number":282,"context_line":"  $keystone_auth_section                   \u003d $::os_service_default,"},{"line_number":283,"context_line":"  $keystone_user_domain_name               \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1aa78d24_b7c8e875","line":280,"range":{"start_line":280,"start_character":45,"end_line":280,"end_character":48},"updated":"2016-07-09 02:55:30.000000000","message":"$::os_service_default not? the user should set a value i think","commit_id":"4f7c2d9a6dbdf133a7139f40e8a265107694c272"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"c90ddac7a9f340b94e51e15c0243bd463b73a447","unresolved":false,"context_lines":[{"line_number":281,"context_line":"  $keystone_auth_type                      \u003d \u0027password\u0027,"},{"line_number":282,"context_line":"  $keystone_auth_section                   \u003d $::os_service_default,"},{"line_number":283,"context_line":"  $keystone_user_domain_name               \u003d $::os_service_default,"},{"line_number":284,"context_line":"  $keystone_project_domain_name            \u003d \u0027Default\u0027,"},{"line_number":285,"context_line":"  $keystone_insecure                       \u003d $::os_service_default,"},{"line_number":286,"context_line":"  $keystone_cache                          \u003d $::os_service_default,"},{"line_number":287,"context_line":"  $keystone_cafile                         \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1aa78d24_97c32c57","line":284,"range":{"start_line":284,"start_character":45,"end_line":284,"end_character":53},"updated":"2016-07-09 02:55:30.000000000","message":"$::os_service_default","commit_id":"4f7c2d9a6dbdf133a7139f40e8a265107694c272"}],"spec/classes/watcher_api_spec.rb":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"6711e1b37083cd9f83cf8204b34f0adbb1048dd9","unresolved":false,"context_lines":[{"line_number":113,"context_line":"          :keystone_memcache_use_advanced_pool     \u003d\u003e true,"},{"line_number":114,"context_line":"          :keystone_memcache_pool_unused_timeout   \u003d\u003e \u00276\u0027,"},{"line_number":115,"context_line":"          :keystone_memcached_servers              \u003d\u003e [\u0027memcached01:11211\u0027, \u0027memcached02:11211\u0027],"},{"line_number":116,"context_line":"        })"},{"line_number":117,"context_line":"      end"},{"line_number":118,"context_line":"      it \u0027configures keystone authtoken\u0027 do"},{"line_number":119,"context_line":"        is_expected.to contain_watcher_config(\u0027keystone_authtoken/username\u0027).with_value( params[:keystone_username] )"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"1aa78d24_315d3fed","line":116,"updated":"2016-07-08 15:05:08.000000000","message":"You missed to test some parameters:\nauth_type\ncache\ndelay_auth_decision\nhash_algorithms\nhttp_connect_timeout\nhttp_request_max_retries","commit_id":"56af25b80bac74c595aa6641fbd216310884feb3"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"c90ddac7a9f340b94e51e15c0243bd463b73a447","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        is_expected.to contain_watcher_config(\u0027keystone_authtoken/memcache_use_advanced_pool\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":60,"context_line":"        is_expected.to contain_watcher_config(\u0027keystone_authtoken/memcache_pool_unused_timeout\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":61,"context_line":"        is_expected.to contain_watcher_config(\u0027keystone_authtoken/memcached_servers\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":62,"context_line":"        is_expected.to contain_watcher_config(\u0027keystone_authtoken/auth_type\u0027).with_value(\u0027password\u0027)"},{"line_number":63,"context_line":"        is_expected.to contain_watcher_config(\u0027keystone_authtoken/cache\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":64,"context_line":"        is_expected.to contain_watcher_config(\u0027keystone_authtoken/delay_auth_decision\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":65,"context_line":"        is_expected.to contain_watcher_config(\u0027keystone_authtoken/hash_algorithms\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"1aa78d24_f236feb2","line":62,"range":{"start_line":62,"start_character":8,"end_line":62,"end_character":100},"updated":"2016-07-09 02:55:30.000000000","message":"duplicated (L40)","commit_id":"4f7c2d9a6dbdf133a7139f40e8a265107694c272"}]}