)]}'
{"manifests/decision_engine.pp":[{"author":{"_account_id":16771,"name":"mpolenchuk","email":"mpolenchuk@mirantis.com","username":"mpolenchuk"},"change_message_id":"2f4afebc2264d4b7e88025eaddbab9792e1137ae","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    \u0027watcher_planner/planner\u0027: value \u003d\u003e $planner;"},{"line_number":94,"context_line":"  }"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"  watcher_config {"},{"line_number":97,"context_line":"    \u0027watcher_planners.default/weights\u0027: value \u003d\u003e $weights;"},{"line_number":98,"context_line":"  }"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1aa78d24_90ccfb8b","line":96,"range":{"start_line":96,"start_character":2,"end_line":96,"end_character":16},"updated":"2016-07-14 07:41:54.000000000","message":"#minor: it might be good to coalesce into one block this config values.","commit_id":"a9226f9d4869434e61b7560dac9998277420bbd4"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"7362190693f04b6b63bad350f6ad9bdebfe053cb","unresolved":false,"context_lines":[{"line_number":94,"context_line":"  }"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"  watcher_config {"},{"line_number":97,"context_line":"    \u0027watcher_planners.default/weights\u0027: value \u003d\u003e $weights;"},{"line_number":98,"context_line":"  }"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1aa78d24_84b9587c","line":97,"range":{"start_line":97,"start_character":49,"end_line":97,"end_character":57},"updated":"2016-07-14 11:15:07.000000000","message":"as it dict value - how it should be present in config? In dict format or like it done for default log levels [1]?\n\n[1] https://github.com/openstack/puppet-oslo/blob/master/manifests/log.pp#L143\n\nAlso could you add simple example of dict to doc section for this parameter?","commit_id":"a9226f9d4869434e61b7560dac9998277420bbd4"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"b2cfdd3cce70900d0162fc1718d865c1819f6341","unresolved":false,"context_lines":[{"line_number":94,"context_line":"  }"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"  watcher_config {"},{"line_number":97,"context_line":"    \u0027watcher_planners.default/weights\u0027: value \u003d\u003e $weights;"},{"line_number":98,"context_line":"  }"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1aa78d24_e8ff1864","line":97,"range":{"start_line":97,"start_character":49,"end_line":97,"end_character":57},"in_reply_to":"1aa78d24_2125c35b","updated":"2016-07-15 09:51:10.000000000","message":"thanks, it works !","commit_id":"a9226f9d4869434e61b7560dac9998277420bbd4"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"33175c858dba80af3ed5ffb7919e60b5794fef33","unresolved":false,"context_lines":[{"line_number":94,"context_line":"  }"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"  watcher_config {"},{"line_number":97,"context_line":"    \u0027watcher_planners.default/weights\u0027: value \u003d\u003e $weights;"},{"line_number":98,"context_line":"  }"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1aa78d24_db15fae5","line":97,"range":{"start_line":97,"start_character":49,"end_line":97,"end_character":57},"in_reply_to":"1aa78d24_5ba8eadb","updated":"2016-07-14 11:41:46.000000000","message":"if so, then we need to convert current value and also update tests","commit_id":"a9226f9d4869434e61b7560dac9998277420bbd4"},{"author":{"_account_id":16771,"name":"mpolenchuk","email":"mpolenchuk@mirantis.com","username":"mpolenchuk"},"change_message_id":"3879163d1275cece84e65466019ec1eb051a8fb6","unresolved":false,"context_lines":[{"line_number":94,"context_line":"  }"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"  watcher_config {"},{"line_number":97,"context_line":"    \u0027watcher_planners.default/weights\u0027: value \u003d\u003e $weights;"},{"line_number":98,"context_line":"  }"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1aa78d24_5ba8eadb","line":97,"range":{"start_line":97,"start_character":49,"end_line":97,"end_character":57},"in_reply_to":"1aa78d24_84b9587c","updated":"2016-07-14 11:37:53.000000000","message":"should be foo \u003d k1:v1,k2:v2","commit_id":"a9226f9d4869434e61b7560dac9998277420bbd4"},{"author":{"_account_id":16771,"name":"mpolenchuk","email":"mpolenchuk@mirantis.com","username":"mpolenchuk"},"change_message_id":"9eee4841204f34757b69bc1aace8a2f5ac6fadc2","unresolved":false,"context_lines":[{"line_number":94,"context_line":"  }"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"  watcher_config {"},{"line_number":97,"context_line":"    \u0027watcher_planners.default/weights\u0027: value \u003d\u003e $weights;"},{"line_number":98,"context_line":"  }"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1aa78d24_2125c35b","line":97,"range":{"start_line":97,"start_character":49,"end_line":97,"end_character":57},"in_reply_to":"1aa78d24_c1eaff0d","updated":"2016-07-15 08:17:15.000000000","message":"so join(sort(join_keys_to_values($weights, \u0027:\u0027)), \u0027,\u0027)\nshould do a trick","commit_id":"a9226f9d4869434e61b7560dac9998277420bbd4"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"9123b3bcb590f9624633e60546cbb0d0b4eaa555","unresolved":false,"context_lines":[{"line_number":94,"context_line":"  }"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"  watcher_config {"},{"line_number":97,"context_line":"    \u0027watcher_planners.default/weights\u0027: value \u003d\u003e $weights;"},{"line_number":98,"context_line":"  }"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1aa78d24_c1eaff0d","line":97,"range":{"start_line":97,"start_character":49,"end_line":97,"end_character":57},"in_reply_to":"1aa78d24_db15fae5","updated":"2016-07-15 08:10:54.000000000","message":"It should be just as Michael Polenchuk said.","commit_id":"a9226f9d4869434e61b7560dac9998277420bbd4"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"b8a708cafc4b2494d0fc86375a0dfc5cc96f4308","unresolved":false,"context_lines":[{"line_number":57,"context_line":"  include ::watcher::deps"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"  if !is_service_default($weights) {"},{"line_number":60,"context_line":"    $weights_real \u003d join(sort(join_keys_to_values($weights, \u0027:\u0027)), \u0027,\u0027)"},{"line_number":61,"context_line":"  } else {"},{"line_number":62,"context_line":"    $weights_real \u003d $weights"},{"line_number":63,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"dada55a8_a2ac4bee","line":60,"updated":"2016-07-18 16:50:48.000000000","message":"I think we need to document this format with an example in the parameter comments. Also is there anyway to also support a string?  Normally with things like arrays we can still do join(any2array(\u0027...\u0027), \u0027,\u0027) because that still works.  Is there a reason to use a dict here rather than accepting a string or array of  values?","commit_id":"e50f356a1e2084b346ae104c70f670b5c9c4439b"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"4080914c34a67d57cd85a5f3dbae76d26fe18f33","unresolved":false,"context_lines":[{"line_number":57,"context_line":"  include ::watcher::deps"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"  if !is_service_default($weights) {"},{"line_number":60,"context_line":"    $weights_real \u003d join(sort(join_keys_to_values($weights, \u0027:\u0027)), \u0027,\u0027)"},{"line_number":61,"context_line":"  } else {"},{"line_number":62,"context_line":"    $weights_real \u003d $weights"},{"line_number":63,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"dada55a8_b834d249","line":60,"in_reply_to":"dada55a8_3e43b8b3","updated":"2016-07-21 13:34:18.000000000","message":"I\u0027m not saying we can\u0027t accept it, just making sure it\u0027s the right thing to do. My issue is more with the lack of format documentation than the usage of a dict.  I don\u0027t like necessarily blocking people into a specific format and for this since it gets converted to a csv anyway, I wasn\u0027t sure why we are putting such a hard requirement on parameter.","commit_id":"e50f356a1e2084b346ae104c70f670b5c9c4439b"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"403e9a0320f9d0bd3053e74fddd0bf03644b806d","unresolved":false,"context_lines":[{"line_number":57,"context_line":"  include ::watcher::deps"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"  if !is_service_default($weights) {"},{"line_number":60,"context_line":"    $weights_real \u003d join(sort(join_keys_to_values($weights, \u0027:\u0027)), \u0027,\u0027)"},{"line_number":61,"context_line":"  } else {"},{"line_number":62,"context_line":"    $weights_real \u003d $weights"},{"line_number":63,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"dada55a8_3e43b8b3","line":60,"in_reply_to":"dada55a8_a2ac4bee","updated":"2016-07-21 10:32:28.000000000","message":"well, we already have dict for log_level for example, for some other parameters, why we can\u0027t accept it here?\n\nBut agree with documentation, we can add it in doc section for this parameter, like simple example what should be in this parameter.","commit_id":"e50f356a1e2084b346ae104c70f670b5c9c4439b"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"8fda7be125b1470467110958706e28c2d5e5aadc","unresolved":false,"context_lines":[{"line_number":61,"context_line":"  include ::watcher::params"},{"line_number":62,"context_line":"  include ::watcher::deps"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"  if !is_service_default($weights) {"},{"line_number":65,"context_line":"    $weights_real \u003d join(sort(join_keys_to_values($weights, \u0027:\u0027)), \u0027,\u0027)"},{"line_number":66,"context_line":"  } else {"},{"line_number":67,"context_line":"    $weights_real \u003d $weights"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"dada55a8_7919ca21","line":64,"updated":"2016-07-27 09:42:48.000000000","message":"please add validate_hash($weights)","commit_id":"691cac937199bdc785d2ead78b4f9903fb2f242e"}]}