)]}'
{"manifests/api.pp":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"aef73f16c83f5411139bb79370efba3481bb3535","unresolved":false,"context_lines":[{"line_number":8,"context_line":"#   (required) User\u0027s password"},{"line_number":9,"context_line":"#"},{"line_number":10,"context_line":"# [*watcher_client_username*]"},{"line_number":11,"context_line":"#  (optional) The name of the auth user"},{"line_number":12,"context_line":"#  Defaults to watcher."},{"line_number":13,"context_line":"#"},{"line_number":14,"context_line":"# [*watcher_client_auth_uri*]"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3ac371cc_c5e738aa","line":11,"updated":"2016-08-17 22:40:05.000000000","message":"begin of identation problem ;) add should start after the \"*\"","commit_id":"fbfdb1895628189365612fb603378426f56a3201"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"aef73f16c83f5411139bb79370efba3481bb3535","unresolved":false,"context_lines":[{"line_number":99,"context_line":"# [*upgrade_db*]"},{"line_number":100,"context_line":"#  (optional) Run watcher-db-manage upgrade on api nodes after"},{"line_number":101,"context_line":"#  installing the package."},{"line_number":102,"context_line":"#  Defaults to false"},{"line_number":103,"context_line":"#"},{"line_number":104,"context_line":"class watcher::api ("},{"line_number":105,"context_line":"  $watcher_client_password,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3ac371cc_e587d4b2","line":102,"updated":"2016-08-17 22:40:05.000000000","message":"end of identation problem","commit_id":"fbfdb1895628189365612fb603378426f56a3201"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"aef73f16c83f5411139bb79370efba3481bb3535","unresolved":false,"context_lines":[{"line_number":113,"context_line":"  $watcher_api_port                        \u003d \u00279322\u0027,"},{"line_number":114,"context_line":"  $watcher_api_max_limit                   \u003d $::os_service_default,"},{"line_number":115,"context_line":"  $watcher_api_bind_host                   \u003d \u00270.0.0.0\u0027,"},{"line_number":116,"context_line":"  $watcher_client_default_domain_name      \u003d $::os_service_default,"},{"line_number":117,"context_line":"  $watcher_client_project_name             \u003d \u0027service\u0027,"},{"line_number":118,"context_line":"  $watcher_client_certfile                 \u003d $::os_service_default,"},{"line_number":119,"context_line":"  $watcher_client_cafile                   \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3ac371cc_103eacc0","line":116,"range":{"start_line":116,"start_character":38,"end_line":116,"end_character":43},"updated":"2016-08-17 22:40:05.000000000","message":"unused space, you can fix in all lines","commit_id":"fbfdb1895628189365612fb603378426f56a3201"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"b387377ea325ff7c00dce14428d7f54c1f100e22","unresolved":false,"context_lines":[{"line_number":113,"context_line":"  $watcher_api_port                        \u003d \u00279322\u0027,"},{"line_number":114,"context_line":"  $watcher_api_max_limit                   \u003d $::os_service_default,"},{"line_number":115,"context_line":"  $watcher_api_bind_host                   \u003d \u00270.0.0.0\u0027,"},{"line_number":116,"context_line":"  $watcher_client_default_domain_name      \u003d $::os_service_default,"},{"line_number":117,"context_line":"  $watcher_client_project_name             \u003d \u0027service\u0027,"},{"line_number":118,"context_line":"  $watcher_client_certfile                 \u003d $::os_service_default,"},{"line_number":119,"context_line":"  $watcher_client_cafile                   \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3ac371cc_bd05e146","line":116,"range":{"start_line":116,"start_character":38,"end_line":116,"end_character":43},"in_reply_to":"3ac371cc_103eacc0","updated":"2016-08-18 07:49:22.000000000","message":"ok","commit_id":"fbfdb1895628189365612fb603378426f56a3201"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"aef73f16c83f5411139bb79370efba3481bb3535","unresolved":false,"context_lines":[{"line_number":195,"context_line":"  if $validate {"},{"line_number":196,"context_line":"    $defaults \u003d {"},{"line_number":197,"context_line":"      \u0027watcher-api\u0027 \u003d\u003e {"},{"line_number":198,"context_line":"        \u0027command\u0027  \u003d\u003e \"watcher --os-auth-url ${watcher_client_auth_uri} --os-project-name ${watcher_client_project_name} --os-username ${watcher_client_username} --os-password ${watcher_client_password} goal list\","},{"line_number":199,"context_line":"      }"},{"line_number":200,"context_line":"    }"},{"line_number":201,"context_line":"    $validation_options_hash \u003d merge($defaults, $validation_options)"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3ac371cc_d0dc1448","line":198,"range":{"start_line":198,"start_character":67,"end_line":198,"end_character":70},"updated":"2016-08-17 22:40:05.000000000","message":"here should be auth_url for consistency no?","commit_id":"fbfdb1895628189365612fb603378426f56a3201"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"b387377ea325ff7c00dce14428d7f54c1f100e22","unresolved":false,"context_lines":[{"line_number":195,"context_line":"  if $validate {"},{"line_number":196,"context_line":"    $defaults \u003d {"},{"line_number":197,"context_line":"      \u0027watcher-api\u0027 \u003d\u003e {"},{"line_number":198,"context_line":"        \u0027command\u0027  \u003d\u003e \"watcher --os-auth-url ${watcher_client_auth_uri} --os-project-name ${watcher_client_project_name} --os-username ${watcher_client_username} --os-password ${watcher_client_password} goal list\","},{"line_number":199,"context_line":"      }"},{"line_number":200,"context_line":"    }"},{"line_number":201,"context_line":"    $validation_options_hash \u003d merge($defaults, $validation_options)"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3ac371cc_5d5cad7c","line":198,"range":{"start_line":198,"start_character":67,"end_line":198,"end_character":70},"in_reply_to":"3ac371cc_d0dc1448","updated":"2016-08-18 07:49:22.000000000","message":"Yeah.\nI was already too tired so I did not notice a single letter","commit_id":"fbfdb1895628189365612fb603378426f56a3201"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"8777034b43615d8e2d09404e969f73734ad8769b","unresolved":false,"context_lines":[{"line_number":190,"context_line":""},{"line_number":191,"context_line":"  watcher_config {"},{"line_number":192,"context_line":"    \u0027watcher_clients_auth/username\u0027:            value \u003d\u003e $watcher_client_username;"},{"line_number":193,"context_line":"    \u0027watcher_clients_auth/password\u0027:            value \u003d\u003e $watcher_client_password, secret \u003d\u003e true;"},{"line_number":194,"context_line":"    \u0027watcher_clients_auth/auth_url\u0027:            value \u003d\u003e $watcher_client_auth_url;"},{"line_number":195,"context_line":"    \u0027watcher_clients_auth/auth_uri\u0027:            value \u003d\u003e $watcher_client_auth_uri;"},{"line_number":196,"context_line":"    \u0027watcher_clients_auth/project_name\u0027:        value \u003d\u003e $watcher_client_project_name;"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3ac371cc_2666f629","line":193,"updated":"2016-08-18 10:55:09.000000000","message":"looks like these parameters are same for keystone_authtoken, is it correct ?","commit_id":"f3a15fe85f2fb832f74d8737c2c3aeb07ca585f2"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"28776ecba15d22149611ad84d9512760d3d924aa","unresolved":false,"context_lines":[{"line_number":396,"context_line":"    }"},{"line_number":397,"context_line":"  }"},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"  keystone::resource::authtoken { \u0027watcher_config\u0027:"},{"line_number":400,"context_line":"    username                       \u003d\u003e $keystone_username,"},{"line_number":401,"context_line":"    password                       \u003d\u003e $keystone_password,"},{"line_number":402,"context_line":"    project_name                   \u003d\u003e $keystone_project_name,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1ac06dbe_59e8e510","side":"PARENT","line":399,"updated":"2016-08-19 23:54:13.000000000","message":"So we\u0027ve been adding in a parameter to api classes called auth_strategy where if auth_strategy \u003d\u003d keystone then we\u0027re doing an include of \u003cclass\u003e::keystone::authtoken.  That might make sense here as well","commit_id":"4c4c2a4497b5f42beca7170e1909d95921fe80f0"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"61e0e3577a753fd208d82ffaf0426070a32cb16d","unresolved":false,"context_lines":[{"line_number":396,"context_line":"    }"},{"line_number":397,"context_line":"  }"},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"  keystone::resource::authtoken { \u0027watcher_config\u0027:"},{"line_number":400,"context_line":"    username                       \u003d\u003e $keystone_username,"},{"line_number":401,"context_line":"    password                       \u003d\u003e $keystone_password,"},{"line_number":402,"context_line":"    project_name                   \u003d\u003e $keystone_project_name,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1ac06dbe_338ee278","side":"PARENT","line":399,"in_reply_to":"1ac06dbe_59e8e510","updated":"2016-08-20 07:23:43.000000000","message":"Good to know. I will change it in next PS","commit_id":"4c4c2a4497b5f42beca7170e1909d95921fe80f0"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"28d0fbe3120a1b99b3e6a072ef8b225bffa2f53b","unresolved":false,"context_lines":[{"line_number":348,"context_line":"  if !is_service_default($keystone_memcached_servers) and !empty($keystone_memcached_servers){"},{"line_number":349,"context_line":"    validate_array($keystone_memcached_servers)"},{"line_number":350,"context_line":"    $keystone_memcached_servers_real \u003d join($keystone_memcached_servers,\u0027,\u0027)"},{"line_number":351,"context_line":"  }"},{"line_number":352,"context_line":""},{"line_number":353,"context_line":"  Watcher_config\u003c||\u003e ~\u003e Service[\u0027watcher-api\u0027]"},{"line_number":354,"context_line":"  Class[\u0027watcher::policy\u0027] ~\u003e Service[\u0027watcher-api\u0027]"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"fa7ab95a_2920319b","side":"PARENT","line":351,"updated":"2016-08-31 20:15:55.000000000","message":"So we have this here as it\u0027s the pattern we\u0027re going with for this. Without this inclusion it might be possible to configure the api without a valid keystone configuration. This will cause the authtoken class to throw an error about lacking configuration. It\u0027s not here for backwards compatibility so much as ensuring that people are aware that they need to configure this class. So we still need this include, but we don\u0027t necessarily need to configure the backwards compatibility support.","commit_id":"4c4c2a4497b5f42beca7170e1909d95921fe80f0"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"5071cb9840dd30d804c805053d19fefcf20ef687","unresolved":false,"context_lines":[{"line_number":145,"context_line":"  include ::watcher::policy"},{"line_number":146,"context_line":"  include ::watcher::deps"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"  if $auth_strategy \u003d\u003d \u0027keystone\u0027 {"},{"line_number":149,"context_line":"    include ::watcher::keystone::authtoken"},{"line_number":150,"context_line":"  }"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"  validate_string($watcher_client_password)"},{"line_number":153,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":7,"id":"fa7ab95a_d52d5ea9","line":150,"range":{"start_line":148,"start_character":0,"end_line":150,"end_character":3},"updated":"2016-08-29 10:34:39.000000000","message":"do we need this include here and why?\n\nfor watcher we don\u0027t have backward compatibility rule","commit_id":"1c1c244fae96002b7508c071dd0d79086998590d"}],"manifests/keystone/authtoken.pp":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"aef73f16c83f5411139bb79370efba3481bb3535","unresolved":false,"context_lines":[{"line_number":28,"context_line":"#   Defaults to $::os_service_default"},{"line_number":29,"context_line":"#"},{"line_number":30,"context_line":"# [*insecure*]"},{"line_number":31,"context_line":"#  (Optional) If true, explicitly allow TLS without checking server cert"},{"line_number":32,"context_line":"#  against any certificate authorities.  WARNING: not recommended.  Use with"},{"line_number":33,"context_line":"#  caution."},{"line_number":34,"context_line":"#  Defaults to $:os_service_default"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3ac371cc_f0e5d008","line":31,"updated":"2016-08-17 22:40:05.000000000","message":"identation","commit_id":"fbfdb1895628189365612fb603378426f56a3201"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"aef73f16c83f5411139bb79370efba3481bb3535","unresolved":false,"context_lines":[{"line_number":187,"context_line":"#  (Optional) In order to prevent excessive effort spent validating tokens,"},{"line_number":188,"context_line":"#  the middleware caches previously-seen tokens for a configurable duration"},{"line_number":189,"context_line":"#  (in seconds). Set to -1 to disable caching completely. Integer value"},{"line_number":190,"context_line":"#  Defaults to $::os_service_default."},{"line_number":191,"context_line":"#"},{"line_number":192,"context_line":"class watcher::keystone::authtoken ("},{"line_number":193,"context_line":"  $password,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3ac371cc_10d22c28","line":190,"updated":"2016-08-17 22:40:05.000000000","message":"end of identation problem","commit_id":"fbfdb1895628189365612fb603378426f56a3201"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"aef73f16c83f5411139bb79370efba3481bb3535","unresolved":false,"context_lines":[{"line_number":227,"context_line":"  $token_cache_time               \u003d $::os_service_default,"},{"line_number":228,"context_line":") {"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"  if !is_service_default($memcached_servers) and !empty($memcached_servers){"},{"line_number":231,"context_line":"    validate_array($memcached_servers)"},{"line_number":232,"context_line":"    $memcached_servers_real \u003d join($memcached_servers,\u0027,\u0027)"},{"line_number":233,"context_line":"  }"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"  keystone::resource::authtoken { \u0027watcher_config\u0027:"},{"line_number":236,"context_line":"    password                       \u003d\u003e $password,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3ac371cc_309ac86e","line":233,"range":{"start_line":230,"start_character":0,"end_line":233,"end_character":3},"updated":"2016-08-17 22:40:05.000000000","message":"why this? the resource will do this validation","commit_id":"fbfdb1895628189365612fb603378426f56a3201"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"b387377ea325ff7c00dce14428d7f54c1f100e22","unresolved":false,"context_lines":[{"line_number":227,"context_line":"  $token_cache_time               \u003d $::os_service_default,"},{"line_number":228,"context_line":") {"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"  if !is_service_default($memcached_servers) and !empty($memcached_servers){"},{"line_number":231,"context_line":"    validate_array($memcached_servers)"},{"line_number":232,"context_line":"    $memcached_servers_real \u003d join($memcached_servers,\u0027,\u0027)"},{"line_number":233,"context_line":"  }"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"  keystone::resource::authtoken { \u0027watcher_config\u0027:"},{"line_number":236,"context_line":"    password                       \u003d\u003e $password,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3ac371cc_6884490a","line":233,"range":{"start_line":230,"start_character":0,"end_line":233,"end_character":3},"in_reply_to":"3ac371cc_309ac86e","updated":"2016-08-18 07:49:22.000000000","message":"ok","commit_id":"fbfdb1895628189365612fb603378426f56a3201"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"f16195ed1524a0e7881d3d54a80621e3b311e53c","unresolved":false,"context_lines":[{"line_number":29,"context_line":"#"},{"line_number":30,"context_line":"# [*insecure*]"},{"line_number":31,"context_line":"#   (Optional) If true, explicitly allow TLS without checking server cert"},{"line_number":32,"context_line":"#   against any certificate authorities.  WARNING: not recommended.  Use with"},{"line_number":33,"context_line":"#   caution."},{"line_number":34,"context_line":"#   Defaults to $:os_service_default"},{"line_number":35,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1ac06dbe_fa1a6416","line":32,"range":{"start_line":32,"start_character":40,"end_line":32,"end_character":42},"updated":"2016-08-19 22:58:25.000000000","message":"nit: You have double spaces here","commit_id":"08afd1a8baa0d49589695e56e2782d94202cb027"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"5071cb9840dd30d804c805053d19fefcf20ef687","unresolved":false,"context_lines":[{"line_number":229,"context_line":"    fail(\u0027Please set password for watcher service user\u0027)"},{"line_number":230,"context_line":"  }"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"  $password_real \u003d pick($::watcher::api::watcher_client_password, $password)"},{"line_number":233,"context_line":"  $username_real \u003d pick($::watcher::api::watcher_client_username, $username)"},{"line_number":234,"context_line":"  $auth_uri_real \u003d pick($::watcher::api::watcher_client_auth_uri, $auth_uri)"},{"line_number":235,"context_line":"  $auth_url_real \u003d pick($::watcher::api::watcher_client_auth_url, $auth_url)"},{"line_number":236,"context_line":"  $project_name_real \u003d pick($::watcher::api::watcher_client_project_name, $project_name)"},{"line_number":237,"context_line":"  $certfile_real \u003d pick($::watcher::api::watcher_client_certfile, $certfile)"},{"line_number":238,"context_line":"  $cafile_real \u003d pick($::watcher::api::watcher_client_cafile, $cafile)"},{"line_number":239,"context_line":"  $project_domain_name_real \u003d pick($::watcher::api::watcher_client_project_domain_name, $project_domain_name)"},{"line_number":240,"context_line":"  $insecure_real \u003d pick($::watcher::api::watcher_client_insecure, $insecure)"},{"line_number":241,"context_line":"  $keyfile_real \u003d pick($::watcher::api::watcher_client_keyfile, $keyfile)"},{"line_number":242,"context_line":"  $auth_type_real \u003d pick($::watcher::api::watcher_client_auth_type, $auth_type)"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"  keystone::resource::authtoken { \u0027watcher_config\u0027:"},{"line_number":245,"context_line":"    password                       \u003d\u003e $password_real,"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"fa7ab95a_950e7639","line":242,"range":{"start_line":232,"start_character":0,"end_line":242,"end_character":79},"updated":"2016-08-29 10:34:39.000000000","message":"same","commit_id":"1c1c244fae96002b7508c071dd0d79086998590d"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"28d0fbe3120a1b99b3e6a072ef8b225bffa2f53b","unresolved":false,"context_lines":[{"line_number":239,"context_line":"  $project_domain_name_real \u003d pick($::watcher::api::watcher_client_project_domain_name, $project_domain_name)"},{"line_number":240,"context_line":"  $insecure_real \u003d pick($::watcher::api::watcher_client_insecure, $insecure)"},{"line_number":241,"context_line":"  $keyfile_real \u003d pick($::watcher::api::watcher_client_keyfile, $keyfile)"},{"line_number":242,"context_line":"  $auth_type_real \u003d pick($::watcher::api::watcher_client_auth_type, $auth_type)"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"  keystone::resource::authtoken { \u0027watcher_config\u0027:"},{"line_number":245,"context_line":"    password                       \u003d\u003e $password_real,"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"fa7ab95a_4923b5a7","line":242,"updated":"2016-08-31 20:15:55.000000000","message":"yea we can get away without the pick items here","commit_id":"1c1c244fae96002b7508c071dd0d79086998590d"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"d674ef8a35a9ce3eb7d591e0039ae2bc0e232a21","unresolved":false,"context_lines":[{"line_number":239,"context_line":"  $project_domain_name_real \u003d pick($::watcher::api::watcher_client_project_domain_name, $project_domain_name)"},{"line_number":240,"context_line":"  $insecure_real \u003d pick($::watcher::api::watcher_client_insecure, $insecure)"},{"line_number":241,"context_line":"  $keyfile_real \u003d pick($::watcher::api::watcher_client_keyfile, $keyfile)"},{"line_number":242,"context_line":"  $auth_type_real \u003d pick($::watcher::api::watcher_client_auth_type, $auth_type)"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"  keystone::resource::authtoken { \u0027watcher_config\u0027:"},{"line_number":245,"context_line":"    password                       \u003d\u003e $password_real,"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"fa7ab95a_d6370b4b","line":242,"in_reply_to":"fa7ab95a_4923b5a7","updated":"2016-09-02 07:03:23.000000000","message":"I don\u0027t agree.\nNormally watcher_cliet_* parameters are the same as keystone_authtoken. Pick is a good and I suggest to keep my solution.","commit_id":"1c1c244fae96002b7508c071dd0d79086998590d"}],"spec/acceptance/watcher_spec.rb":[{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"b5c2217660c522407b30718a7c18688642180eba","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        password \u003d\u003e \u0027a_big_secret\u0027,"},{"line_number":35,"context_line":"      }"},{"line_number":36,"context_line":"      class { \u0027::watcher::keystone::authtoken\u0027:"},{"line_number":37,"context_line":"        password \u003d\u003e \u0027a_big_secret\u0027,"},{"line_number":38,"context_line":"      }"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"      # Watcher service is not packaged on Ubuntu platform, but is available"}],"source_content_type":"text/x-ruby","patch_set":6,"id":"fa7ab95a_3c13515e","line":37,"range":{"start_line":37,"start_character":10,"end_line":37,"end_character":11},"updated":"2016-08-25 21:41:31.000000000","message":"password is not necessary. It will be removed in next PS.","commit_id":"adb96d5d944737b5f010d110f6f324167ff1575d"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"93cf1a1290975d362d1ace91b6913b913f90c22a","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        password \u003d\u003e \u0027a_big_secret\u0027,"},{"line_number":35,"context_line":"      }"},{"line_number":36,"context_line":"      class { \u0027::watcher::keystone::authtoken\u0027:"},{"line_number":37,"context_line":"        password \u003d\u003e \u0027a_big_secret\u0027,"},{"line_number":38,"context_line":"      }"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"      # Watcher service is not packaged on Ubuntu platform, but is available"}],"source_content_type":"text/x-ruby","patch_set":6,"id":"fa7ab95a_97ddc816","line":37,"range":{"start_line":37,"start_character":10,"end_line":37,"end_character":11},"in_reply_to":"fa7ab95a_3c13515e","updated":"2016-08-27 02:42:23.000000000","message":"I think the class should be under $::osfamily \u003d\u003d RedHat because you don\u0027t have watcher in ubuntu","commit_id":"adb96d5d944737b5f010d110f6f324167ff1575d"}],"spec/classes/watcher_api_spec.rb":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"f16195ed1524a0e7881d3d54a80621e3b311e53c","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        is_expected.to contain_watcher_config(\u0027watcher_clients_auth/username\u0027).with_value( params[:watcher_client_username] )"},{"line_number":106,"context_line":"        is_expected.to contain_watcher_config(\u0027watcher_clients_auth/password\u0027).with_value( params[:watcher_client_password] )"},{"line_number":107,"context_line":"        is_expected.to contain_watcher_config(\u0027watcher_clients_auth/auth_uri\u0027).with_value(\u0027http://localhost:5001/\u0027)"},{"line_number":108,"context_line":"        is_expected.to contain_watcher_config(\u0027watcher_clients_auth/auth_url\u0027).with_value(\u0027http://localhost:35358/\u0027)"},{"line_number":109,"context_line":"        is_expected.to contain_watcher_config(\u0027watcher_clients_auth/project_name\u0027).with_value( params[:watcher_client_project_name] )"},{"line_number":110,"context_line":"        is_expected.to contain_watcher_config(\u0027watcher_clients_auth/project_domain_name\u0027).with_value( params[:watcher_client_project_domain_name] )"},{"line_number":111,"context_line":"        is_expected.to contain_watcher_config(\u0027watcher_clients_auth/insecure\u0027).with_value( params[:watcher_client_insecure] )"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"1ac06dbe_1aa660c1","line":108,"updated":"2016-08-19 22:58:25.000000000","message":"why such ports and not 5000/35537?","commit_id":"08afd1a8baa0d49589695e56e2782d94202cb027"},{"author":{"_account_id":20676,"name":"daniel.pawlik","display_name":"Daniel Pawlik","email":"dpawlik@redhat.com","username":"daniel.pawlik"},"change_message_id":"61e0e3577a753fd208d82ffaf0426070a32cb16d","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        is_expected.to contain_watcher_config(\u0027watcher_clients_auth/username\u0027).with_value( params[:watcher_client_username] )"},{"line_number":106,"context_line":"        is_expected.to contain_watcher_config(\u0027watcher_clients_auth/password\u0027).with_value( params[:watcher_client_password] )"},{"line_number":107,"context_line":"        is_expected.to contain_watcher_config(\u0027watcher_clients_auth/auth_uri\u0027).with_value(\u0027http://localhost:5001/\u0027)"},{"line_number":108,"context_line":"        is_expected.to contain_watcher_config(\u0027watcher_clients_auth/auth_url\u0027).with_value(\u0027http://localhost:35358/\u0027)"},{"line_number":109,"context_line":"        is_expected.to contain_watcher_config(\u0027watcher_clients_auth/project_name\u0027).with_value( params[:watcher_client_project_name] )"},{"line_number":110,"context_line":"        is_expected.to contain_watcher_config(\u0027watcher_clients_auth/project_domain_name\u0027).with_value( params[:watcher_client_project_domain_name] )"},{"line_number":111,"context_line":"        is_expected.to contain_watcher_config(\u0027watcher_clients_auth/insecure\u0027).with_value( params[:watcher_client_insecure] )"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"1ac06dbe_f3ac4aef","line":108,"in_reply_to":"1ac06dbe_1aa660c1","updated":"2016-08-20 07:23:43.000000000","message":"Slawek: because context is: \u0027watcher clients auth section with overridden parameters\u0027 so I test if non default options are changed in watcher.conf :)\nIn line 76 you can check that default values are 5000 and 35357\n\nAlex: it\u0027s good.","commit_id":"08afd1a8baa0d49589695e56e2782d94202cb027"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"28776ecba15d22149611ad84d9512760d3d924aa","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        is_expected.to contain_watcher_config(\u0027watcher_clients_auth/username\u0027).with_value( params[:watcher_client_username] )"},{"line_number":106,"context_line":"        is_expected.to contain_watcher_config(\u0027watcher_clients_auth/password\u0027).with_value( params[:watcher_client_password] )"},{"line_number":107,"context_line":"        is_expected.to contain_watcher_config(\u0027watcher_clients_auth/auth_uri\u0027).with_value(\u0027http://localhost:5001/\u0027)"},{"line_number":108,"context_line":"        is_expected.to contain_watcher_config(\u0027watcher_clients_auth/auth_url\u0027).with_value(\u0027http://localhost:35358/\u0027)"},{"line_number":109,"context_line":"        is_expected.to contain_watcher_config(\u0027watcher_clients_auth/project_name\u0027).with_value( params[:watcher_client_project_name] )"},{"line_number":110,"context_line":"        is_expected.to contain_watcher_config(\u0027watcher_clients_auth/project_domain_name\u0027).with_value( params[:watcher_client_project_domain_name] )"},{"line_number":111,"context_line":"        is_expected.to contain_watcher_config(\u0027watcher_clients_auth/insecure\u0027).with_value( params[:watcher_client_insecure] )"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"1ac06dbe_5963c5dc","line":108,"in_reply_to":"1ac06dbe_1aa660c1","updated":"2016-08-19 23:54:13.000000000","message":"to check non-defaults","commit_id":"08afd1a8baa0d49589695e56e2782d94202cb027"}]}