)]}'
{"manifests/db/sync.pp":[{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"7bf43be5e109434098cf140b2881d5116afb70e3","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    refreshonly \u003d\u003e true,"},{"line_number":9,"context_line":"    try_sleep   \u003d\u003e 5,"},{"line_number":10,"context_line":"    tries       \u003d\u003e 10,"},{"line_number":11,"context_line":"    logoutput   \u003d\u003e \u0027on_failure\u0027,"},{"line_number":12,"context_line":"    subscribe   \u003d\u003e [Package[\u0027zaqar\u0027], Zaqar_config[\u0027database/connection\u0027]],"},{"line_number":13,"context_line":"  }"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3a98d1f4_b1565fd0","line":11,"updated":"2016-09-29 14:11:00.000000000","message":"I know a lot of the other puppet modules have the logoutput \u003d\u003e on_failure line, but I would avoid adding it to those that do not unless there is a compelling reason. IIUC, on_failure is the default anyways, so it is probably unnecessary in any case. I\u0027d remove it to keep the scope of your patches limited to the bug in question and consistent across the board.","commit_id":"f3d7811f59f114e8806c3b2b55cdfdd444ae2c8b"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"37dcb0468dbf56d91a1e65bdffb174a38937a8b6","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    refreshonly \u003d\u003e true,"},{"line_number":9,"context_line":"    try_sleep   \u003d\u003e 5,"},{"line_number":10,"context_line":"    tries       \u003d\u003e 10,"},{"line_number":11,"context_line":"    logoutput   \u003d\u003e \u0027on_failure\u0027,"},{"line_number":12,"context_line":"    subscribe   \u003d\u003e [Package[\u0027zaqar\u0027], Zaqar_config[\u0027database/connection\u0027]],"},{"line_number":13,"context_line":"  }"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3a98d1f4_91508360","line":11,"in_reply_to":"3a98d1f4_b1565fd0","updated":"2016-09-29 14:15:15.000000000","message":"Brent, we are adding it in cookiecutter module also: https://review.openstack.org/#/c/378724/1/puppet-%257B%257Bcookiecutter.project_name%257D%257D/manifests/db/sync.pp\n\nSo, it will be kinda of pattern. Are you still disagree?","commit_id":"f3d7811f59f114e8806c3b2b55cdfdd444ae2c8b"}]}