)]}'
{"pycadf/credential.py":[{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"0f1778b2a1c431e940aa99d3a461babb5f45863e","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    def __init__(self, token, identity_provider, protocol, user, groups):"},{"line_number":84,"context_line":"        super(FederatedCredential, self).__init__("},{"line_number":85,"context_line":"            token\u003dtoken,"},{"line_number":86,"context_line":"            type\u003d\u0027federated\u0027)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        # FederatedCredential.identity_provider"},{"line_number":89,"context_line":"        setattr(self, FED_CRED_KEYNAME_IDENTITY_PROVIDER, identity_provider)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1abeadc6_db2df9ff","line":86,"updated":"2014-08-20 20:39:47.000000000","message":"this is what i was trying to ask about in IRC, but never got a response. if a federated credential is just a credential with a magical \"type\" attribute, then i assume it should be defined by convention for all such credentials rather than by the lib consumer. i\u0027m further assuming that \"federated\" is a reasonable value in such a case, rather than setting the type to be equal to protocol (\"saml2\") as originally requested.","commit_id":"79a6c6b1ada8dd3b0bdfe0ad0319ae1ab72003e8"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"86a85c5f46dd9caccd68cd1e641a9a54deac654c","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        FED_CRED_KEYNAME_GROUPS,"},{"line_number":76,"context_line":"        lambda x: isinstance(x, list))"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def __init__(self, token, type, identity_provider, user, groups):"},{"line_number":79,"context_line":"        super(FederatedCredential, self).__init__("},{"line_number":80,"context_line":"            token\u003dtoken,"},{"line_number":81,"context_line":"            type\u003dtype)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_c160a7d1","line":78,"updated":"2014-08-21 00:23:12.000000000","message":"Don\u0027t you need to save the type?","commit_id":"c685f9bffff14722153d8fd8ccc9cf8a45397e43"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"80ff92a1fd6bc397a6cb64095570fa8a844f9a57","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    def __init__(self, token, type, identity_provider, user, groups):"},{"line_number":79,"context_line":"        super(FederatedCredential, self).__init__("},{"line_number":80,"context_line":"            token\u003dtoken,"},{"line_number":81,"context_line":"            type\u003dtype)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        # FederatedCredential.identity_provider"},{"line_number":84,"context_line":"        setattr(self, FED_CRED_KEYNAME_IDENTITY_PROVIDER, identity_provider)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_97242dc6","line":81,"updated":"2014-08-21 02:31:18.000000000","message":"Davanum: it\u0027s passed into the super class here, which assigns it as an instance attribute","commit_id":"c685f9bffff14722153d8fd8ccc9cf8a45397e43"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"5b855b20a9d24f85b5d0b75f43b30c557e9d8f5f","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        \"\"\"Validation to ensure Credential required attributes are set.\"\"\""},{"line_number":94,"context_line":"        return ("},{"line_number":95,"context_line":"            super(FederatedCredential, self).is_valid()"},{"line_number":96,"context_line":"            and self._isset(CRED_KEYNAME_TYPE)"},{"line_number":97,"context_line":"            and self._isset(FED_CRED_KEYNAME_IDENTITY_PROVIDER)"},{"line_number":98,"context_line":"            and self._isset(FED_CRED_KEYNAME_USER)"},{"line_number":99,"context_line":"            and self._isset(FED_CRED_KEYNAME_GROUPS))"}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_48a914de","line":96,"updated":"2014-08-21 04:36:38.000000000","message":"What about token, or is that optional?","commit_id":"52727bcea3a98e72331e748ce5f9e3a111a64cd1"}],"pycadf/tests/test_cadf_spec.py":[{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"86a85c5f46dd9caccd68cd1e641a9a54deac654c","unresolved":false,"context_lines":[{"line_number":69,"context_line":"                identifier.generate_uuid(),"},{"line_number":70,"context_line":"                identifier.generate_uuid(),"},{"line_number":71,"context_line":"                identifier.generate_uuid()])"},{"line_number":72,"context_line":"        self.assertEqual(cred.is_valid(), True)"},{"line_number":73,"context_line":"        dict_cred \u003d cred.as_dict()"},{"line_number":74,"context_line":"        for key in credential.FED_CRED_KEYNAMES:"},{"line_number":75,"context_line":"            self.assertIn(key, dict_cred)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_a1400b35","line":72,"updated":"2014-08-21 00:23:12.000000000","message":"self.assertTrue() would be better?","commit_id":"c685f9bffff14722153d8fd8ccc9cf8a45397e43"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"80ff92a1fd6bc397a6cb64095570fa8a844f9a57","unresolved":false,"context_lines":[{"line_number":69,"context_line":"                identifier.generate_uuid(),"},{"line_number":70,"context_line":"                identifier.generate_uuid(),"},{"line_number":71,"context_line":"                identifier.generate_uuid()])"},{"line_number":72,"context_line":"        self.assertEqual(cred.is_valid(), True)"},{"line_number":73,"context_line":"        dict_cred \u003d cred.as_dict()"},{"line_number":74,"context_line":"        for key in credential.FED_CRED_KEYNAMES:"},{"line_number":75,"context_line":"            self.assertIn(key, dict_cred)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_57161556","line":72,"in_reply_to":"1abeadc6_a1400b35","updated":"2014-08-21 02:31:18.000000000","message":"yes, but i\u0027m just following the established convention of other tests here :)\n\ni\u0027d like to refactor them all for such issues","commit_id":"c685f9bffff14722153d8fd8ccc9cf8a45397e43"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"5b855b20a9d24f85b5d0b75f43b30c557e9d8f5f","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def test_federated_credential(self):"},{"line_number":63,"context_line":"        cred \u003d credential.FederatedCredential("},{"line_number":64,"context_line":"            token\u003didentifier.generate_uuid(),"},{"line_number":65,"context_line":"            type\u003d\u0027http://docs.oasis-open.org/security/saml/v2.0\u0027,"},{"line_number":66,"context_line":"            identity_provider\u003didentifier.generate_uuid(),"},{"line_number":67,"context_line":"            user\u003didentifier.generate_uuid(),"}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_88aecce4","line":64,"updated":"2014-08-21 04:36:38.000000000","message":"Nit, This isn\u0027t necessary according to the validator","commit_id":"52727bcea3a98e72331e748ce5f9e3a111a64cd1"}]}