)]}'
{"pycadf/identifier.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"86fbab0ca3e7f06f26a0e832bfd67abb147c847e","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"def is_valid(value):"},{"line_number":53,"context_line":"    \"\"\"Validation to ensure Identifier is correct."},{"line_number":54,"context_line":"    \"\"\""},{"line_number":55,"context_line":"    if value in [\u0027target\u0027, \u0027initiator\u0027, \u0027observer\u0027]:"},{"line_number":56,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a8ffd7b_57fb577b","line":53,"updated":"2015-12-02 14:49:47.000000000","message":"The docstring should be updated to say what it does.","commit_id":"6f1de9ca0471e3a6e079f89ad03adf39e8ea97d0"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"a1b4199bb40bc5a131ecec49defa88c7f88079d2","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"def is_valid(value):"},{"line_number":53,"context_line":"    \"\"\"Validation to ensure Identifier is correct."},{"line_number":54,"context_line":"    \"\"\""},{"line_number":55,"context_line":"    if value in [\u0027target\u0027, \u0027initiator\u0027, \u0027observer\u0027]:"},{"line_number":56,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a8ffd7b_d1051211","line":53,"in_reply_to":"9a8ffd7b_57fb577b","updated":"2015-12-02 15:21:26.000000000","message":"Maybe something like:\n\n    \"\"\"Validation to ensure Identifier is of a specific type or value.\n\n       If the Identifier value is a string type and not a UUID type,\n       warn against interoperability issues and return True. This relaxes\n       the requirement of having strict UUID checking.\n\n    \"\"\"","commit_id":"6f1de9ca0471e3a6e079f89ad03adf39e8ea97d0"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"46502bb5353c13538435eec88ccbab7b9de3c2b1","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        if not isinstance(value, six.string_types) or not value:"},{"line_number":61,"context_line":"            return False"},{"line_number":62,"context_line":"        warnings.warn(\u0027Invalid uuid. To ensure interoperability, identifiers\u0027"},{"line_number":63,"context_line":"                      \u0027should be a valid uuid.\u0027)"},{"line_number":64,"context_line":"    return True"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a8ffd7b_7711bb03","line":63,"updated":"2015-12-02 14:48:29.000000000","message":"It would be nice to use a subclass of UserWarning that\u0027s used for pycadf warnings (e.g., PycadfUserWarning) for the category. This would make it easier for applications to enable/disable.","commit_id":"6f1de9ca0471e3a6e079f89ad03adf39e8ea97d0"}]}