)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"625466fa0d729fe1420222ff1ef21cbaaefbe9b5","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Gage Hugo \u003cgagehugo@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-02-02 20:28:04 -0600"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allow multiple joined uuids to be considered valid"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In keystone, multiple domain ids are handled by concatenating"},{"line_number":10,"context_line":"two IDs together. This causes issues with pycadf validation and"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a430d35_45d84ef0","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":50},"updated":"2017-02-03 02:40:23.000000000","message":"you\u0027re doing a bit more than this, maybe:\n\n\"make the is_valid() check more flexible\" instead?","commit_id":"ef858713dbd51adb23d0cf0d63491ec4692220c4"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"d470381564bb9220e0f1ac7a85829da77eeeb012","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Gage Hugo \u003cgagehugo@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-02-02 20:28:04 -0600"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allow multiple joined uuids to be considered valid"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In keystone, multiple domain ids are handled by concatenating"},{"line_number":10,"context_line":"two IDs together. This causes issues with pycadf validation and"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a430d35_4f63f1b1","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":50},"in_reply_to":"1a430d35_45d84ef0","updated":"2017-02-03 16:53:46.000000000","message":"will do!","commit_id":"ef858713dbd51adb23d0cf0d63491ec4692220c4"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"625466fa0d729fe1420222ff1ef21cbaaefbe9b5","unresolved":false,"context_lines":[{"line_number":25,"context_line":"- Allows 2 or more concatenated uuids to be considered valid without"},{"line_number":26,"context_line":"emitting a warning"},{"line_number":27,"context_line":"- Cleaned up the list of words that are exceptions for validation"},{"line_number":28,"context_line":"- Added \u0027default\u0027 to list of valid words in exception list"},{"line_number":29,"context_line":"- Added offending value to printed warning"},{"line_number":30,"context_line":"- Broke up test_identifiers for better clarity about which tests"},{"line_number":31,"context_line":"were valid. This also solves the issue of `warning_mock.called` always"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a430d35_854b16b0","line":28,"range":{"start_line":28,"start_character":2,"end_line":28,"end_character":21},"updated":"2017-02-03 02:40:23.000000000","message":"keystone test logs thank you","commit_id":"ef858713dbd51adb23d0cf0d63491ec4692220c4"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"625466fa0d729fe1420222ff1ef21cbaaefbe9b5","unresolved":false,"context_lines":[{"line_number":26,"context_line":"emitting a warning"},{"line_number":27,"context_line":"- Cleaned up the list of words that are exceptions for validation"},{"line_number":28,"context_line":"- Added \u0027default\u0027 to list of valid words in exception list"},{"line_number":29,"context_line":"- Added offending value to printed warning"},{"line_number":30,"context_line":"- Broke up test_identifiers for better clarity about which tests"},{"line_number":31,"context_line":"were valid. This also solves the issue of `warning_mock.called` always"},{"line_number":32,"context_line":"being `True` once an invalid uuid of type string was checked within"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a430d35_654e2ac3","line":29,"range":{"start_line":29,"start_character":2,"end_line":29,"end_character":42},"updated":"2017-02-03 02:40:23.000000000","message":"nice addition","commit_id":"ef858713dbd51adb23d0cf0d63491ec4692220c4"}],"pycadf/identifier.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"625466fa0d729fe1420222ff1ef21cbaaefbe9b5","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    if not value:"},{"line_number":57,"context_line":"        raise ValueError"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    chars_to_remove \u003d [\u0027urn:uuid:\u0027, \u0027{\u0027, \u0027}\u0027, \u0027-\u0027]"},{"line_number":60,"context_line":"    for chars in chars_to_remove:"},{"line_number":61,"context_line":"        value \u003d value.replace(chars, \u0027\u0027)"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a430d35_e5e77aaa","line":59,"range":{"start_line":59,"start_character":4,"end_line":59,"end_character":50},"updated":"2017-02-03 02:40:23.000000000","message":"i\u0027d like to see tests for these cases as well","commit_id":"ef858713dbd51adb23d0cf0d63491ec4692220c4"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"d470381564bb9220e0f1ac7a85829da77eeeb012","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    if not value:"},{"line_number":57,"context_line":"        raise ValueError"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    chars_to_remove \u003d [\u0027urn:uuid:\u0027, \u0027{\u0027, \u0027}\u0027, \u0027-\u0027]"},{"line_number":60,"context_line":"    for chars in chars_to_remove:"},{"line_number":61,"context_line":"        value \u003d value.replace(chars, \u0027\u0027)"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a430d35_2fff8502","line":59,"range":{"start_line":59,"start_character":4,"end_line":59,"end_character":50},"in_reply_to":"1a430d35_e5e77aaa","updated":"2017-02-03 16:53:46.000000000","message":"Done","commit_id":"ef858713dbd51adb23d0cf0d63491ec4692220c4"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"5f80c4791bdf84b09fc6a100818471c736ddc2e3","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    chars_to_remove \u003d [\u0027urn:uuid:\u0027, \u0027{\u0027, \u0027}\u0027, \u0027-\u0027]"},{"line_number":60,"context_line":"    for chars in chars_to_remove:"},{"line_number":61,"context_line":"        value \u003d value.replace(chars, \u0027\u0027)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    for val in [value[i:i + 32] for i in range(0, len(value), 32)]:"},{"line_number":64,"context_line":"        uid \u003d uuid.UUID(val)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a430d35_9042110f","line":61,"updated":"2017-02-06 16:38:14.000000000","message":"I think we could make this a one-liner (or two-liner if we can figure out how to make a regular expression that combines the two patterns in the sub functions):\n\n  import re\n  ...\n  value \u003d re.sub(\u0027[{}-]\u0027, \u0027\u0027 value)\n  value \u003d re.sub(\u0027[urn:uuid:\u0027\u0027, \u0027\u0027 value)\n\nWhich *should* be faster than iterating the list [0].\n\n[0] http://stackoverflow.com/questions/3939361/remove-specific-characters-from-a-string-in-python","commit_id":"7a94da19821ae82caf6c881da4000d5f16308ffc"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"679b5b67a0832186c27e793467f8454b3772a97c","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    chars_to_remove \u003d [\u0027urn:uuid:\u0027, \u0027{\u0027, \u0027}\u0027, \u0027-\u0027]"},{"line_number":60,"context_line":"    for chars in chars_to_remove:"},{"line_number":61,"context_line":"        value \u003d value.replace(chars, \u0027\u0027)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    for val in [value[i:i + 32] for i in range(0, len(value), 32)]:"},{"line_number":64,"context_line":"        uid \u003d uuid.UUID(val)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a430d35_f3ac3f37","line":61,"in_reply_to":"1a430d35_9042110f","updated":"2017-02-06 16:51:31.000000000","message":"Actually - this might do it:\n\n  import re\n  ...\n  value \u003d re.sub(\u0027[{}-]|urn:uuid:\u0027, \u0027\u0027, value)\n\nand my tests locally: \n\n  \u003e\u003e\u003e val1 \u003d \u0027urn:uuid:12345678-1234-5678-1234-567812345678\u0027\n  \u003e\u003e\u003e val2 \u003d \u0027{1234567890abcdef1234567890abcdef}\u0027\n  \u003e\u003e\u003e val3 \u003d \u0027{12345678-1234-5678-1234-567812345678}\u0027\n  \u003e\u003e\u003e re.sub(\u0027[{}-]|urn:uuid:\u0027, \u0027\u0027, val1)\n  \u002712345678123456781234567812345678\u0027\n  \u003e\u003e\u003e re.sub(\u0027[{}-]|urn:uuid:\u0027, \u0027\u0027, val2)\n  \u00271234567890abcdef1234567890abcdef\u0027\n  \u003e\u003e\u003e re.sub(\u0027[{}-]|urn:uuid:\u0027, \u0027\u0027, val3)\n  \u002712345678123456781234567812345678\u0027","commit_id":"7a94da19821ae82caf6c881da4000d5f16308ffc"}],"pycadf/tests/test_cadf_spec.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"5f80c4791bdf84b09fc6a100818471c736ddc2e3","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        # multiple uuids joined together"},{"line_number":61,"context_line":"        long_128_uuid \u003d (\u00273adce28e67e44544a5a9d5f1ab54f578a86d310aac3a465e9d\u0027"},{"line_number":62,"context_line":"                         \u0027d2693a78b45c0e42dce28e67e44544a5a9d5f1ab54f578a86d\u0027"},{"line_number":63,"context_line":"                         \u0027310aac3a465e9dd2693a78b45c0e\u0027)"},{"line_number":64,"context_line":"        self.assertTrue(identifier.is_valid(long_128_uuid))"},{"line_number":65,"context_line":"        self.assertFalse(warning_mock.called)"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a430d35_bca0c944","line":63,"updated":"2017-02-06 16:38:14.000000000","message":"nit: minor nit that we can address in another patch is making these one uuid per line, just as a purely cosmetic readability thing.\n\n  long_128_uuid \u003d (\u00273adce28e67e44544a5a9d5f1ab54f578\u0027\n      \u00276d310aac3a465e9dd2693a78b45c0e42\u0027\n       ...)","commit_id":"7a94da19821ae82caf6c881da4000d5f16308ffc"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"50d0645c163b9b8d736626e55b05a7239a57e754","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        # multiple uuids joined together"},{"line_number":61,"context_line":"        long_128_uuid \u003d (\u00273adce28e67e44544a5a9d5f1ab54f578a86d310aac3a465e9d\u0027"},{"line_number":62,"context_line":"                         \u0027d2693a78b45c0e42dce28e67e44544a5a9d5f1ab54f578a86d\u0027"},{"line_number":63,"context_line":"                         \u0027310aac3a465e9dd2693a78b45c0e\u0027)"},{"line_number":64,"context_line":"        self.assertTrue(identifier.is_valid(long_128_uuid))"},{"line_number":65,"context_line":"        self.assertFalse(warning_mock.called)"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1a430d35_dc73cbe5","line":63,"updated":"2017-02-06 20:51:15.000000000","message":"What if we had this same test but had it include a urn value, too? As well as uuids with dashes in them? Technically the regular expression substitutions should cleanse them all before breaking them up.","commit_id":"02155e1055ece69ca09f66fa54d4e9f7ffe34f02"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"77d0899580490a312df941a6a9bd916d31fa71de","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        # multiple uuids joined together"},{"line_number":61,"context_line":"        long_128_uuid \u003d (\u00273adce28e67e44544a5a9d5f1ab54f578a86d310aac3a465e9d\u0027"},{"line_number":62,"context_line":"                         \u0027d2693a78b45c0e42dce28e67e44544a5a9d5f1ab54f578a86d\u0027"},{"line_number":63,"context_line":"                         \u0027310aac3a465e9dd2693a78b45c0e\u0027)"},{"line_number":64,"context_line":"        self.assertTrue(identifier.is_valid(long_128_uuid))"},{"line_number":65,"context_line":"        self.assertFalse(warning_mock.called)"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1a430d35_22758597","line":63,"in_reply_to":"1a430d35_dc73cbe5","updated":"2017-02-06 23:01:09.000000000","message":"Done","commit_id":"02155e1055ece69ca09f66fa54d4e9f7ffe34f02"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"c6596e8bc754daded19102e28eb3c5e12631e6c0","unresolved":false,"context_lines":[{"line_number":71,"context_line":"             \u002712345678-1234-5678-1234-567812345678}\u0027),"},{"line_number":72,"context_line":"            (\u0027urn:uuid:3adce28e67e44544a5a9d5f1ab54f578a86d310aac3a465e9d\u0027"},{"line_number":73,"context_line":"             \u0027d2693a78b45c0e42dce28e67e44544a5a9d5f1ab54f578a86d\u0027"},{"line_number":74,"context_line":"             \u0027310aac3a465e9dd2693a78b45c0e\u0027)]"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        for value in long_128_uuids:"},{"line_number":77,"context_line":"            self.assertTrue(identifier.is_valid(value))"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a430d35_745ab02b","line":74,"updated":"2017-02-08 04:05:48.000000000","message":"nice!","commit_id":"a4a8f46248ab1d1a68d422276df21f75b24be84c"}]}
