)]}'
{"pyeclib/ec_iface.py":[{"author":{"_account_id":17363,"name":"Timur Alperovich","email":"timur@timuralp.com","username":"timuralp"},"change_message_id":"fd5f4125fefd2928c4c1f718c323938f96b9d5b5","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        return check_backend_available(int_type.value)"},{"line_number":43,"context_line":"    except ImportError:"},{"line_number":44,"context_line":"        # check_backend_available has been supported since"},{"line_number":45,"context_line":"        # liberasurecode\u003e\u003d1.2.0 so we need to define the func for older"},{"line_number":46,"context_line":"        # liberasurecode version"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        # select available k, m values"}],"source_content_type":"text/x-python","patch_set":5,"id":"7ac969e8_6649eed0","line":45,"updated":"2016-08-12 21:13:02.000000000","message":"I think it\u0027s reasonable to have a versioned dependency on liberasurecode. I would prefer pyeclib to throw an exception if an incompatible version is loaded and packaging can ensure that the situation does not arise. This particular bit of backwards compatibility is not a huge deal, but I don\u0027t think it\u0027s necessary. What are others opinions on this?","commit_id":"10802bac59b694c0935e2b72ef47972ded702e76"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"614596321f3ec3f6629db722880378e4e9df539f","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        return check_backend_available(int_type.value)"},{"line_number":43,"context_line":"    except ImportError:"},{"line_number":44,"context_line":"        # check_backend_available has been supported since"},{"line_number":45,"context_line":"        # liberasurecode\u003e\u003d1.2.0 so we need to define the func for older"},{"line_number":46,"context_line":"        # liberasurecode version"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        # select available k, m values"}],"source_content_type":"text/x-python","patch_set":5,"id":"7ac969e8_95036e0d","line":45,"in_reply_to":"7ac969e8_6649eed0","updated":"2016-08-12 23:33:24.000000000","message":"It may be good idea to raise Exception instead of backward compatibility *in the future* but I believe we need this right now.\n\nThe biggest reason I think so is that packaging repository is still using older version liberasurecode. i.e. bindep (liberasurecode-dev[dpkg], liberasurecode-devel[rpm])cannot install the newest liberasurecode supports check_backend_available.\n\nThis makes us hard to setup gate job unless we make the install script from source for liberasurecode. If we do so, probably this one also will be unnecessary.\n\nI think, this can be a tentative way until package repo updated so the procedure orders are:\n\n1. merge this as is (i.e. backward compatible)\n2. liberasurecode-dev, liberasurecode-devel updated in package repo\n3. change backward compatibility to raise Exception if older liberasurecode loaded\n\nThought?","commit_id":"10802bac59b694c0935e2b72ef47972ded702e76"},{"author":{"_account_id":17363,"name":"Timur Alperovich","email":"timur@timuralp.com","username":"timuralp"},"change_message_id":"f0b402da0d68b37ef890b63299456076c763c380","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        return check_backend_available(int_type.value)"},{"line_number":43,"context_line":"    except ImportError:"},{"line_number":44,"context_line":"        # check_backend_available has been supported since"},{"line_number":45,"context_line":"        # liberasurecode\u003e\u003d1.2.0 so we need to define the func for older"},{"line_number":46,"context_line":"        # liberasurecode version"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        # select available k, m values"}],"source_content_type":"text/x-python","patch_set":5,"id":"7ac969e8_60c54e5a","line":45,"in_reply_to":"7ac969e8_95036e0d","updated":"2016-08-13 00:05:57.000000000","message":"Makes sense. I did not know about the gate job situation. I think we should re move this code before the next iteration of pyeclib, but it\u0027s fine to get the gate job to pass.","commit_id":"10802bac59b694c0935e2b72ef47972ded702e76"},{"author":{"_account_id":17363,"name":"Timur Alperovich","email":"timur@timuralp.com","username":"timuralp"},"change_message_id":"fd5f4125fefd2928c4c1f718c323938f96b9d5b5","unresolved":false,"context_lines":[{"line_number":523,"context_line":"    version_str \u003d \u0027.\u0027.join([major, minor, rev])"},{"line_number":524,"context_line":"    return version_str"},{"line_number":525,"context_line":""},{"line_number":526,"context_line":"LIBERASURECODE_VERSION \u003d _liberasurecode_version()"}],"source_content_type":"text/x-python","patch_set":5,"id":"7ac969e8_6620cef8","line":526,"updated":"2016-08-12 21:13:02.000000000","message":"We should codify the minimum version and do a comparison check.","commit_id":"10802bac59b694c0935e2b72ef47972ded702e76"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"614596321f3ec3f6629db722880378e4e9df539f","unresolved":false,"context_lines":[{"line_number":523,"context_line":"    version_str \u003d \u0027.\u0027.join([major, minor, rev])"},{"line_number":524,"context_line":"    return version_str"},{"line_number":525,"context_line":""},{"line_number":526,"context_line":"LIBERASURECODE_VERSION \u003d _liberasurecode_version()"}],"source_content_type":"text/x-python","patch_set":5,"id":"7ac969e8_d5e16600","line":526,"in_reply_to":"7ac969e8_6620cef8","updated":"2016-08-12 23:33:24.000000000","message":"If we raise an exception when a module defined variable assigned, all time we import the module, we will get the error. i.e. we cannot use the module anymore with incompatible liberasurecode. That might be fair but it cannot make us to pass the gate job (i.e. unit test which import this module will get errors) forever until package repo is updated.","commit_id":"10802bac59b694c0935e2b72ef47972ded702e76"}]}
