)]}'
{"pyeclib/core.py":[{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"d38cc415b16849b7d69d644f1ad846ba784431fe","unresolved":false,"context_lines":[{"line_number":84,"context_line":"            raise ECInsufficientFragments("},{"line_number":85,"context_line":"                \"Not enough fragments given in ECPyECLibDriver.decode\")"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        return pyeclib_c.decode(self.handle, list(fragment_payloads),"},{"line_number":88,"context_line":"                                fragment_len, ranges, force_metadata_checks)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def reconstruct(self, fragment_payloads, indexes_to_reconstruct):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a77a97e_e36a9580","line":87,"range":{"start_line":87,"start_character":45,"end_line":87,"end_character":69},"updated":"2016-11-17 07:25:43.000000000","message":"On my first impression, why not call \u0027list\u0027 before checking \u0027len\u0027 at L83 but it seems safe if we expects fragment_payloads should be just tuple or list.","commit_id":"82d0b668c9d3ec5a869c7d59a7645a783251a76f"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"91a42bf7499f3f32818a1d8f68eb84ac298663fa","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        return pyeclib_c.encode(self.handle, data_bytes)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def _validate_and_return_fragment_size(self, fragments):"},{"line_number":67,"context_line":"        if len(fragments) \u003d\u003d 0 or len(fragments[0]) \u003d\u003d 0:"},{"line_number":68,"context_line":"            return -1"},{"line_number":69,"context_line":"        fragment_len \u003d len(fragments[0])"},{"line_number":70,"context_line":"        for fragment in fragments[1:]:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_185510f9","line":67,"updated":"2016-11-18 02:37:26.000000000","message":"Good catch! Unless do that, we see IndexError instead.","commit_id":"9cc72f7ce8cc1db9e4116be99bee513f3169ed91"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"91a42bf7499f3f32818a1d8f68eb84ac298663fa","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        _fragment_payloads \u003d list(fragment_payloads)"},{"line_number":78,"context_line":"        fragment_len \u003d self._validate_and_return_fragment_size("},{"line_number":79,"context_line":"            _fragment_payloads)"},{"line_number":80,"context_line":"        if fragment_len \u003c 0:"},{"line_number":81,"context_line":"            raise ECDriverError("},{"line_number":82,"context_line":"                \"Invalid fragment payload in ECPyECLibDriver.decode\")"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        if len(_fragment_payloads) \u003c self.k:"},{"line_number":85,"context_line":"            raise ECInsufficientFragments("},{"line_number":86,"context_line":"                \"Not enough fragments given in ECPyECLibDriver.decode\")"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        return pyeclib_c.decode(self.handle, _fragment_payloads,"},{"line_number":89,"context_line":"                                fragment_len, ranges, force_metadata_checks)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_f8a134f9","line":86,"range":{"start_line":80,"start_character":0,"end_line":86,"end_character":71},"updated":"2016-11-18 02:37:26.000000000","message":"I\u0027m realizing to want to swap those if conditions because if an empty fragment_payloads list incoming, latter ECInsufficientFragments seems suitable for the situation but it\u0027s ok to pend it to in follow-up.","commit_id":"9cc72f7ce8cc1db9e4116be99bee513f3169ed91"}],"test/test_pyeclib_api.py":[{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"d38cc415b16849b7d69d644f1ad846ba784431fe","unresolved":false,"context_lines":[{"line_number":533,"context_line":""},{"line_number":534,"context_line":"            for holes in combinations(frags, tolerable_failures):"},{"line_number":535,"context_line":"                indexes, check_frags \u003d zip(*(pair for pair in frags"},{"line_number":536,"context_line":"                                             if pair not in holes))"},{"line_number":537,"context_line":"                decoded \u003d pyeclib_driver.decode(check_frags)"},{"line_number":538,"context_line":"                self.assertEqual("},{"line_number":539,"context_line":"                    orig_data, decoded,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a77a97e_4338a9ef","line":536,"updated":"2016-11-17 07:25:43.000000000","message":"Ok, you are doing opposite approach from mine that collect all holes frags combination and check with the available rest. That seems to work well and seems less code...\n\nBut it looks a bit tricky from the purpose and if you want to just avoid the translation of dict for py3, \n\nhttps://gist.github.com/bloodeagle40234/1939f4fd6e9020ec916c3bc7c62ba11a\n\ncan be an intermediate solution for that.\n\nI think it\u0027s ok to go with current code but to make the reader easy to understand, I like to add more inline comments how the greedy test is running here.","commit_id":"82d0b668c9d3ec5a869c7d59a7645a783251a76f"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"91a42bf7499f3f32818a1d8f68eb84ac298663fa","unresolved":false,"context_lines":[{"line_number":244,"context_line":""},{"line_number":245,"context_line":"                idxs_to_remove \u003d random.sample(range("},{"line_number":246,"context_line":"                    pyeclib_driver.k + pyeclib_driver.m), 2)"},{"line_number":247,"context_line":"                available_fragments \u003d encoded_fragments[:]"},{"line_number":248,"context_line":"                for i in sorted(idxs_to_remove, reverse\u003dTrue):"},{"line_number":249,"context_line":"                    available_fragments.pop(i)"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"                frag_iter \u003d iter(available_fragments)"},{"line_number":252,"context_line":"                decoded_str \u003d pyeclib_driver.decode(frag_iter)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_53b12946","line":249,"range":{"start_line":247,"start_character":16,"end_line":249,"end_character":46},"updated":"2016-11-18 02:37:26.000000000","message":"nits) Just,\n\n available_fragments \u003d [frag for i, frag in enumurate(encoded_fragments) if i not in idx_to_remove]\n\n???","commit_id":"9cc72f7ce8cc1db9e4116be99bee513f3169ed91"}]}
