)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16896,"name":"Ondřej Nový","email":"novy@ondrej.org","username":"onovy"},"change_message_id":"0fc1c5ec664daed25e4aff96572d2aaab406184b","unresolved":false,"context_lines":[{"line_number":16,"context_line":"makes a warning log line to syslog which suggest \"you\u0027re using older"},{"line_number":17,"context_line":"liberasurecode which will be deprecated, please upgrade it\"."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"NOTE:"},{"line_number":20,"context_line":"- This dependency managemnet depends on erasurecode_version.h header"},{"line_number":21,"context_line":"  file in liberasurecode. i.e. it cannot care of overwritten .so library"},{"line_number":22,"context_line":"  after PyECLib built once."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5a74a57a_61565d2b","line":19,"updated":"2016-11-28 08:56:23.000000000","message":"this is a bit critical for downstream/distros. Because this is just warning, i think it\u0027s fine for now. But please change this is (near? :) future.\n\nthanks.","commit_id":"30dfcdfbae8b70676ab3c0319817410663b01f46"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"89a18d7d5ed065eb38ed286520ffb57c86f86c26","unresolved":false,"context_lines":[{"line_number":16,"context_line":"makes a warning log line to syslog which suggest \"you\u0027re using older"},{"line_number":17,"context_line":"liberasurecode which will be deprecated, please upgrade it\"."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"NOTE:"},{"line_number":20,"context_line":"- This dependency managemnet depends on erasurecode_version.h header"},{"line_number":21,"context_line":"  file in liberasurecode. i.e. it cannot care of overwritten .so library"},{"line_number":22,"context_line":"  after PyECLib built once."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5a74a57a_b14df4c5","line":19,"in_reply_to":"5a74a57a_61565d2b","updated":"2016-11-29 04:23:08.000000000","message":"Exactly, I\u0027m keeping the task to do that, thanks.","commit_id":"30dfcdfbae8b70676ab3c0319817410663b01f46"}],"pyeclib/ec_iface.py":[{"author":{"_account_id":12261,"name":"Mahati","email":"mahati.chamarthy@gmail.com","username":"Mahati"},"change_message_id":"7a762aff563cb31dc738a24ccb21084cda3c7712","unresolved":false,"context_lines":[{"line_number":541,"context_line":"    if version_int \u003c required_version:"},{"line_number":542,"context_line":"        logger.warning("},{"line_number":543,"context_line":"            \u0027DEPRECATED WARNING: your liberasurecode \u0027"},{"line_number":544,"context_line":"            \u0027%s will be deprecated in the future since the issue \u0027"},{"line_number":545,"context_line":"            \u0027https://bugs.launchpad.net/swift/+bug/1639691; \u0027"},{"line_number":546,"context_line":"            \u0027Please upgrade to \u003e\u003d1.3.1\u0027 % version_str)"},{"line_number":547,"context_line":"    return version_str"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a74a57a_91012f6d","line":544,"updated":"2016-11-25 17:13:31.000000000","message":"nit: s/since/because of\n\nAlso, maybe a note indicating that we need to reinstall pyeclib after upgrading liberasurecode?","commit_id":"7325304b25da9f08bcb51e1ffa07ee8d8262d17c"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"f86d36ec2d38306fddb62cb1f04536a7413c9453","unresolved":false,"context_lines":[{"line_number":541,"context_line":"    if version_int \u003c required_version:"},{"line_number":542,"context_line":"        logger.warning("},{"line_number":543,"context_line":"            \u0027DEPRECATED WARNING: your liberasurecode \u0027"},{"line_number":544,"context_line":"            \u0027%s will be deprecated in the future since the issue \u0027"},{"line_number":545,"context_line":"            \u0027https://bugs.launchpad.net/swift/+bug/1639691; \u0027"},{"line_number":546,"context_line":"            \u0027Please upgrade to \u003e\u003d1.3.1\u0027 % version_str)"},{"line_number":547,"context_line":"    return version_str"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a74a57a_38602101","line":544,"in_reply_to":"5a74a57a_91012f6d","updated":"2016-11-28 02:20:03.000000000","message":"I like that idea, will do soon, thanks.","commit_id":"7325304b25da9f08bcb51e1ffa07ee8d8262d17c"},{"author":{"_account_id":7485,"name":"Tushar Gohad","email":"tushar.gohad@intel.com","username":"tsg"},"change_message_id":"21714dbd285708f803fbdf230dcd723e1fbaaea0","unresolved":false,"context_lines":[{"line_number":541,"context_line":"    if version_int \u003c required_version:"},{"line_number":542,"context_line":"        logger.warning("},{"line_number":543,"context_line":"            \u0027DEPRECATED WARNING: your liberasurecode \u0027"},{"line_number":544,"context_line":"            \u0027%s will be deprecated in the future because of the issue \u0027"},{"line_number":545,"context_line":"            \u0027https://bugs.launchpad.net/swift/+bug/1639691; \u0027"},{"line_number":546,"context_line":"            \u0027Please upgrade to \u003e\u003d1.3.1 and rebuild pyeclib to suppress \u0027"},{"line_number":547,"context_line":"            \u0027this message\u0027 % version_str)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a74a57a_d1fd10b2","line":544,"range":{"start_line":544,"start_character":42,"end_line":544,"end_character":48},"updated":"2016-11-29 04:05:43.000000000","message":"s/future/near future","commit_id":"30dfcdfbae8b70676ab3c0319817410663b01f46"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"89a18d7d5ed065eb38ed286520ffb57c86f86c26","unresolved":false,"context_lines":[{"line_number":541,"context_line":"    if version_int \u003c required_version:"},{"line_number":542,"context_line":"        logger.warning("},{"line_number":543,"context_line":"            \u0027DEPRECATED WARNING: your liberasurecode \u0027"},{"line_number":544,"context_line":"            \u0027%s will be deprecated in the future because of the issue \u0027"},{"line_number":545,"context_line":"            \u0027https://bugs.launchpad.net/swift/+bug/1639691; \u0027"},{"line_number":546,"context_line":"            \u0027Please upgrade to \u003e\u003d1.3.1 and rebuild pyeclib to suppress \u0027"},{"line_number":547,"context_line":"            \u0027this message\u0027 % version_str)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a74a57a_d148b0b5","line":544,"range":{"start_line":544,"start_character":42,"end_line":544,"end_character":48},"in_reply_to":"5a74a57a_d1fd10b2","updated":"2016-11-29 04:23:08.000000000","message":"Done","commit_id":"30dfcdfbae8b70676ab3c0319817410663b01f46"},{"author":{"_account_id":7485,"name":"Tushar Gohad","email":"tushar.gohad@intel.com","username":"tsg"},"change_message_id":"21714dbd285708f803fbdf230dcd723e1fbaaea0","unresolved":false,"context_lines":[{"line_number":543,"context_line":"            \u0027DEPRECATED WARNING: your liberasurecode \u0027"},{"line_number":544,"context_line":"            \u0027%s will be deprecated in the future because of the issue \u0027"},{"line_number":545,"context_line":"            \u0027https://bugs.launchpad.net/swift/+bug/1639691; \u0027"},{"line_number":546,"context_line":"            \u0027Please upgrade to \u003e\u003d1.3.1 and rebuild pyeclib to suppress \u0027"},{"line_number":547,"context_line":"            \u0027this message\u0027 % version_str)"},{"line_number":548,"context_line":"    return version_str"},{"line_number":549,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a74a57a_f1d5ac1b","line":546,"range":{"start_line":546,"start_character":43,"end_line":546,"end_character":50},"updated":"2016-11-29 04:05:43.000000000","message":"We don\u0027t really need to rebuild/reinstall pyeclib, or do we?","commit_id":"30dfcdfbae8b70676ab3c0319817410663b01f46"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"89a18d7d5ed065eb38ed286520ffb57c86f86c26","unresolved":false,"context_lines":[{"line_number":543,"context_line":"            \u0027DEPRECATED WARNING: your liberasurecode \u0027"},{"line_number":544,"context_line":"            \u0027%s will be deprecated in the future because of the issue \u0027"},{"line_number":545,"context_line":"            \u0027https://bugs.launchpad.net/swift/+bug/1639691; \u0027"},{"line_number":546,"context_line":"            \u0027Please upgrade to \u003e\u003d1.3.1 and rebuild pyeclib to suppress \u0027"},{"line_number":547,"context_line":"            \u0027this message\u0027 % version_str)"},{"line_number":548,"context_line":"    return version_str"},{"line_number":549,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a74a57a_d171900d","line":546,"range":{"start_line":546,"start_character":43,"end_line":546,"end_character":50},"in_reply_to":"5a74a57a_f1d5ac1b","updated":"2016-11-29 04:23:08.000000000","message":"we don\u0027t want to rebuild actually but it is needed for now. That is because get_liberasurecode_version at L529 refers erasurecode_version.h so that it was defined when pyeclib_c was built.\n\nFor now, we have a couple of choices to detect *actual* .so file version as follows:\n\n1. adding sort of liberasurecode_get_version as a liberasurecode function and then change get_liberasurecode_version function to use it instead of referring header file.\n\n2. doing small file encode and call get_libec_version with an encoded fragment. For now, it\u0027s only way to find the .so lib version actually but I think this is not good idea because the fragment encoding is obviously overhead and wasted.\n\nAnyway, I think, this is a quick fix to notice users what happens in your erasure code so the message can be accepted.","commit_id":"30dfcdfbae8b70676ab3c0319817410663b01f46"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"df75a2f7c89b741f62c9e879b0e6ef15525fb8db","unresolved":false,"context_lines":[{"line_number":543,"context_line":"            \u0027DEPRECATED WARNING: your liberasurecode \u0027"},{"line_number":544,"context_line":"            \u0027%s will be deprecated in the near future because of the issue \u0027"},{"line_number":545,"context_line":"            \u0027https://bugs.launchpad.net/swift/+bug/1639691; \u0027"},{"line_number":546,"context_line":"            \u0027Please upgrade to \u003e\u003d1.3.1 and rebuild pyeclib to suppress \u0027"},{"line_number":547,"context_line":"            \u0027this message\u0027 % version_str)"},{"line_number":548,"context_line":"    return version_str"},{"line_number":549,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5a74a57a_34a2899b","line":546,"updated":"2016-11-29 18:59:25.000000000","message":"rebuild.... liberasurecode?","commit_id":"d163972bb04faf192d0ba65451dcc388b5bb19f0"}]}
