)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"2f106b8007bdd3cce3e081ed9411d58efcefdc5c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3ecca96b_773ba460","updated":"2022-04-07 23:37:49.000000000","message":"Actually, we probably want the tox job to run *both* black and flake8 -- otherwise we lose some of the hacking checks, for example.","commit_id":"0a1707a3c8396586a0a26381b34e81b0682f6229"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"aebbacf71b073f7e3a3549aea495575ff98491c0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"87fde4f3_0df4c69d","updated":"2022-04-06 13:46:39.000000000","message":"Sorry, I think I owe Pete a beer for having reviewed this ;-)","commit_id":"0a1707a3c8396586a0a26381b34e81b0682f6229"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"77ba634db231abd3870412341eb8d2677d80678b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"87ba3a92_fa25e637","updated":"2022-04-05 23:23:44.000000000","message":"This looks like more make work and I read through all of it. Poor Tim.","commit_id":"0a1707a3c8396586a0a26381b34e81b0682f6229"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"04553a209c2769e24e23c9222d397cd097ec7a99","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8cf9c783_5b1036e4","updated":"2022-04-06 16:25:52.000000000","message":"recheck","commit_id":"0a1707a3c8396586a0a26381b34e81b0682f6229"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"aebbacf71b073f7e3a3549aea495575ff98491c0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ba41b3a4_a1c4e3ee","in_reply_to":"87ba3a92_fa25e637","updated":"2022-04-06 13:46:39.000000000","message":"No, that was the great thing! All I had to do was run\n\n black --target-version py27 pyeclib/ tools/ test/ setup.py doc/\n\n(i.e., the tox job but without the --check)","commit_id":"0a1707a3c8396586a0a26381b34e81b0682f6229"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"891d3840386d397c0561da19fbe6adc057cbf360","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"59fd0bdd_7b8db7a9","updated":"2022-04-14 17:40:49.000000000","message":"Still probably requires some discussion about whether we actually want this.","commit_id":"46f35aa64a9482b32e6e1f85c5f05021784221c0"},{"author":{"_account_id":34930,"name":"Jianjian Huo","email":"jhuo@nvidia.com","username":"jhuo"},"change_message_id":"0b95c151c0b48159f56e257e069145459e8815c2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"35dfb64f_506b61b5","updated":"2025-09-24 21:49:46.000000000","message":"I like black\u0027s modern style!","commit_id":"4d9324a013188ec97545f0a4e1b30a02c790f1ae"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"1012a4a832ea9ba7ec54aeb6d5ac204d2d368e2d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"a54e0526_92ac3206","updated":"2026-03-10 15:53:51.000000000","message":"recheck","commit_id":"b41b3f18093efb8fa1286a3128cc3a7b1be309f5"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"87474ba6f2b422e7f7eda13f310e70c64f8e7230","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"d1349492_fc41cb94","updated":"2026-04-21 16:14:44.000000000","message":"Useful validation:\n```\ngit checkout @~ -- .\ngit checkout @ -- tox.ini\nblack --target-version py310 --line-length 79 pyeclib/ tools/ test/ setup.py doc/ pack_wheel.py\ngit diff --name-only | xargs git add\ngit status\n```\n(I.e. back out all of the `*.py` changes, then run `black` exactly like the updated CI will, minus the `--check --diff` flags, then compare.)\n\nThis revealed one small delta:\n```\ndiff --git a/test/test_pyeclib_api.py b/test/test_pyeclib_api.py\nindex 1c0243b..8aea57d 100644\n--- a/test/test_pyeclib_api.py\n+++ b/test/test_pyeclib_api.py\n@@ -202,10 +202,7 @@ class TestPyECLibDriver(unittest.TestCase):\n                 \"local_parity\": 2,\n             }\n             threads \u003d [\n-                threading.Thread(\n-                    target\u003dcreate_backend,\n-                    args\u003d(ec_params, q),\n-                )\n+                threading.Thread(target\u003dcreate_backend, args\u003d(ec_params, q))\n                 for _ in range(5)\n             ]\n             for t in threads:\n```\nbut I like it just fine and black seems OK with it being written either way.","commit_id":"d42982f2dea2bd8574a4bd2c1057dc04f8ccb9d2"}],"test/test_pyeclib_c.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"891d3840386d397c0561da19fbe6adc057cbf360","unresolved":true,"context_lines":[{"line_number":230,"context_line":""},{"line_number":231,"context_line":"            range_offset \u003d 0"},{"line_number":232,"context_line":"            for r in ranges:"},{"line_number":233,"context_line":"                start, end \u003d r[0], r[1] + 1"},{"line_number":234,"context_line":"                if whole_file_bytes[start:end] !\u003d decoded_file_ranges[range_offset]:"},{"line_number":235,"context_line":"                    success \u003d False"},{"line_number":236,"context_line":"                range_offset +\u003d 1"}],"source_content_type":"text/x-python","patch_set":3,"id":"5c9e9407_fd129eab","line":233,"updated":"2022-04-14 17:40:49.000000000","message":"This was me -- otherwise, black wants to format like\n\n r[0] : r[1] + 1\n\nwhile flake8 wants something more like\n\n r[0]:r[1] + 1\n\nor something.","commit_id":"46f35aa64a9482b32e6e1f85c5f05021784221c0"}],"tox.ini":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"891d3840386d397c0561da19fbe6adc057cbf360","unresolved":true,"context_lines":[{"line_number":37,"context_line":"# H101: Use TODO(NAME)"},{"line_number":38,"context_line":"# H404: multi line docstring should start without a leading new line"},{"line_number":39,"context_line":"# H405: multi line docstring summary not separated with an empty line"},{"line_number":40,"context_line":"# W503: line break before binary operator"},{"line_number":41,"context_line":"ignore \u003d H101,H404,H405,W503"},{"line_number":42,"context_line":"max-line-length \u003d 88"}],"source_content_type":"text/x-properties","patch_set":3,"id":"652fe869_52270111","line":40,"updated":"2022-04-14 17:40:49.000000000","message":"black likes it the other way ;-)","commit_id":"46f35aa64a9482b32e6e1f85c5f05021784221c0"},{"author":{"_account_id":34930,"name":"Jianjian Huo","email":"jhuo@nvidia.com","username":"jhuo"},"change_message_id":"0b95c151c0b48159f56e257e069145459e8815c2","unresolved":true,"context_lines":[{"line_number":37,"context_line":"# H101: Use TODO(NAME)"},{"line_number":38,"context_line":"# H404: multi line docstring should start without a leading new line"},{"line_number":39,"context_line":"# H405: multi line docstring summary not separated with an empty line"},{"line_number":40,"context_line":"# W503: line break before binary operator"},{"line_number":41,"context_line":"ignore \u003d H101,H404,H405,W503"},{"line_number":42,"context_line":"max-line-length \u003d 88"}],"source_content_type":"text/x-properties","patch_set":3,"id":"60ddd021_11e7b9f1","line":40,"in_reply_to":"652fe869_52270111","updated":"2025-09-24 21:49:46.000000000","message":"ack.\n\nblack also recommends to ignore E701, but probably pyeclib doesn\u0027t use that style yet, see: https://black.readthedocs.io/en/stable/guides/using_black_with_other_tools.html#e701-e704","commit_id":"46f35aa64a9482b32e6e1f85c5f05021784221c0"}]}