)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"3863a9d7168152e4e3ee6327b2af794a9495ec52","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8cb79ba0_7fca3664","updated":"2024-02-08 22:54:09.000000000","message":"At the very least, I should make this configurable in the Dockerfile.\n\nIt\u0027s a bit of a questionable idea, anyway, though -- we\u0027ve already deprecated support, and we might be on shaky ground to distribute such a wheel. Still, I like the idea of having as many supported backends baked in as possible.","commit_id":"d2bdbb348676575015fdd0b0d556b24231d55de3"}],"Dockerfile":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"8583a8d099cac26a16595fcc1793bd4e50e21fec","unresolved":true,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"RUN mkdir /opt/src /output"},{"line_number":18,"context_line":"RUN yum install -y zlib-devel"},{"line_number":19,"context_line":"# Update auditwheel so it can improve our tag to manylinux1 automatically"},{"line_number":20,"context_line":"# Not *too far*, though, since we\u0027ve got the old base image"},{"line_number":21,"context_line":"RUN /opt/_internal/tools/bin/pip install -U \u0027auditwheel\u003c5.2\u0027"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-dockerfile","patch_set":5,"id":"5fb2103c_0f7a19f6","line":19,"range":{"start_line":19,"start_character":49,"end_line":19,"end_character":59},"updated":"2024-08-29 19:05:05.000000000","message":"Hmm... but we\u0027re building `pyeclib-1.6.1-cp35-abi3-manylinux_2_12_x86_64.manylinux2010_x86_64.whl` now...\n\nI should figure out *why*.","commit_id":"f607095c5ba063d5108458ab9088b97393f5c560"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"e7ed40ef6b9a694983cadb9ba450c5c9b306c61f","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"RUN mkdir /opt/src /output"},{"line_number":18,"context_line":"RUN yum install -y zlib-devel"},{"line_number":19,"context_line":"# Update auditwheel so it can improve our tag to manylinux1 automatically"},{"line_number":20,"context_line":"# Not *too far*, though, since we\u0027ve got the old base image"},{"line_number":21,"context_line":"RUN /opt/_internal/tools/bin/pip install -U \u0027auditwheel\u003c5.2\u0027"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-dockerfile","patch_set":5,"id":"60805ffd_5e704656","line":19,"range":{"start_line":19,"start_character":49,"end_line":19,"end_character":59},"in_reply_to":"5fb2103c_0f7a19f6","updated":"2024-08-29 22:42:54.000000000","message":"```\n$ auditwheel show pyeclib-1.6.1-cp35-abi3-manylinux_2_12_x86_64.manylinux2010_x86_64.whl\n\npyeclib-1.6.1-cp35-abi3-manylinux_2_12_x86_64.manylinux2010_x86_64.whl\nis consistent with the following platform tag:\n\"manylinux_2_12_x86_64\".\n\nThe wheel references external versioned symbols in these\nsystem-provided shared libraries: libpthread.so.0 with versions\n{\u0027GLIBC_2.2.5\u0027}, libc.so.6 with versions {\u0027GLIBC_2.3.4\u0027,\n\u0027GLIBC_2.2.5\u0027, \u0027GLIBC_2.4\u0027, \u0027GLIBC_2.7\u0027}\n\nThis constrains the platform tag to \"manylinux_2_12_x86_64\". In order\nto achieve a more compatible tag, you would need to recompile a new\nwheel from source on a system with earlier versions of these\nlibraries, such as a recent manylinux image.\n\n$ objdump -T .../pyeclib.libs/libgf_complete-pyeclib.so.1 | grep GLIBC_2.7\n0000000000000000      DF *UND*\t0000000000000000 (GLIBC_2.7)  __isoc99_sscanf\n```\nAnd sure enough, [gf-complete is littered with some `sscanf` calls](https://github.com/search?q\u003drepo%3Aceph%2Fgf-complete sscanf\u0026type\u003dcode). I suppose we could try to excise them or something, but IDK that it matters enough, especially given that I\u0027m not sure we actually *want* to go this far out the chain...","commit_id":"f607095c5ba063d5108458ab9088b97393f5c560"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"cd1a840a94e035f8f8acdb184ae9f0da7c4fa8a4","unresolved":true,"context_lines":[{"line_number":60,"context_line":"    sed -i \u0027/gf_general_s_to_val/,/^}$/d\u0027 src/gf_general.c \u0026\u0026 \\"},{"line_number":61,"context_line":"    truncate -s 0 src/gf_method.c \u0026\u0026 \\"},{"line_number":62,"context_line":"    ./autogen.sh \u0026\u0026 \\"},{"line_number":63,"context_line":"    ./configure --prefix\u003d/usr \u0026\u0026 \\"},{"line_number":64,"context_line":"    make \u0026\u0026 \\"},{"line_number":65,"context_line":"    make install"},{"line_number":66,"context_line":"ADD https://github.com/ceph/jerasure/archive/de1739cc.tar.gz /opt/src/jerasure.tar.gz"}],"source_content_type":"text/x-dockerfile","patch_set":10,"id":"e6715bf1_b1cd7818","line":63,"updated":"2024-10-25 16:33:53.000000000","message":"If we do this, we probably need to be careful about what optimizations the compiler is allowed -- we were seeing `Illegal instruction` errors on CI nodes with old processors prior to https://review.opendev.org/c/openstack/pyeclib/+/933338 and I suspect jerasure/gf-complete are closer to liberasurecode than isa-l with regard to build-once-run-anywhere readiness.","commit_id":"e43ee4bfe7fb4568ca4500c4ad17bbf531c06823"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"cd1a840a94e035f8f8acdb184ae9f0da7c4fa8a4","unresolved":true,"context_lines":[{"line_number":69,"context_line":"    sed -i \u0027s/src Examples/src/\u0027 Makefile.am \u0026\u0026 \\"},{"line_number":70,"context_line":"    sed -i \u0027s!Examples/Makefile!!\u0027 configure.ac \u0026\u0026 \\"},{"line_number":71,"context_line":"    autoreconf --force --install \u0026\u0026 \\"},{"line_number":72,"context_line":"    ./configure --prefix\u003d/usr \u0026\u0026 \\"},{"line_number":73,"context_line":"    make \u0026\u0026 \\"},{"line_number":74,"context_line":"    make install"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-dockerfile","patch_set":10,"id":"1746dad8_1564ca15","line":72,"updated":"2024-10-25 16:33:53.000000000","message":"Both projects.","commit_id":"e43ee4bfe7fb4568ca4500c4ad17bbf531c06823"}]}