)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"aa86227f501c8d3f3c095f711db51d2858eb2577","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f188f9e2_f52f170a","updated":"2024-09-13 21:40:00.000000000","message":"The built wheels at https://zuul.opendev.org/t/openstack/build/88a3872f55634ee4b00cefa125042ab2/artifacts and https://zuul.opendev.org/t/openstack/build/58c3eb84f655436ca3f27bdfe4f6b79b/artifacts still have the `abi3` tag 👍\n\nAnd tests pass on https://review.opendev.org/c/openstack/pyeclib/+/927605! \\o/ Previously it\u0027d bomb out like\n```\n/usr/local/include/python3.13t/Python.h:51:4: error:\n#error \"The limited API is not currently supported in the free-threaded build\"\n```\nThough we get a warning:\n```\nRuntimeWarning: The global interpreter lock (GIL) has been enabled to load\nmodule \u0027pyeclib_c\u0027, which has not declared that it can run safely without\nthe GIL. To override this behavior and keep the GIL disabled (at your own\nrisk), run with PYTHON_GIL\u003d0 or -Xgil\u003d0.\n```\nThat\u0027s fine enough, though -- we can sort out on that review whether \"Test under py313\" ought to include \"get pyeclib working on free-threaded python\" or not.","commit_id":"1343d39053f2616545fb2a478b3c4e6200b1086a"}],"src/c/pyeclib_c/pyeclib_c.c":[{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"f70c4f137451fd4a8df72ea738b8d60735f723d9","unresolved":true,"context_lines":[{"line_number":28,"context_line":"#include \u003cstdio.h\u003e"},{"line_number":29,"context_line":"#include \u003cpaths.h\u003e"},{"line_number":30,"context_line":"#define PY_SSIZE_T_CLEAN"},{"line_number":31,"context_line":"#define Py_LIMITED_API 0x03050000"},{"line_number":32,"context_line":"#include \u003cPython.h\u003e"},{"line_number":33,"context_line":"#include \u003cmath.h\u003e"},{"line_number":34,"context_line":"#include \u003cbytesobject.h\u003e"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"72d13b14_3bf99260","side":"PARENT","line":31,"updated":"2024-09-23 07:47:34.000000000","message":"OK, for those reviewing at home. This definition can be used to define the minimum supported python.\n\nBasically Tim is getting the build tooling to add it for us. which does feel better as we can also controller the build tooling, so less hardcoded code seems like a win to me! \nWe can alway add it back if we ever need to limit it again.","commit_id":"883f504e6b6edb766d17b3a38bb3d55c47585549"}]}
