)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"ae3dfcfb48ada3cbcb706aac4580540f8cdf433c","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As discussed in mailing list, we agreed to drop \"alarm search\" command and"},{"line_number":10,"context_line":"add a --query parameter to \"alarm list\" to perform what \"alarm search\""},{"line_number":11,"context_line":"does. and also this change will drop mandatory --type in \"alarm list\", the"},{"line_number":12,"context_line":"--filter parameter will be added(in another patch)."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I68c5463fe37e3051b0e52d59f30a0eb36dd62424"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5aef4532_3778a82b","line":11,"range":{"start_line":11,"start_character":6,"end_line":11,"end_character":37},"updated":"2016-03-11 08:56:04.000000000","message":"And this patch will also drop","commit_id":"975217c75aa2a9e2a403c6e980be98e1b8804fd2"}],"aodhclient/v2/alarm_cli.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"89d96bf2e1af97127c11b1660e96ead433f8f1cd","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def get_parser(self, prog_name):"},{"line_number":35,"context_line":"        parser \u003d super(CliAlarmList, self).get_parser(prog_name)"},{"line_number":36,"context_line":"        parser.add_argument(\u0027-t\u0027, \u0027--type\u0027, required\u003dTrue,"},{"line_number":37,"context_line":"                            choices\u003dALARM_TYPES, help\u003d\u0027Type of alarm\u0027)"},{"line_number":38,"context_line":"        return parser"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_1fa6d952","side":"PARENT","line":36,"updated":"2016-03-03 04:34:37.000000000","message":"if you drop the argument, then you can\u0027t specify it. you should just drop the requirement.","commit_id":"3024acd5c62c8c2224deff2f0716f98132149ab6"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"3664be6d939b74ec98043cce0c0db822e2a17035","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def get_parser(self, prog_name):"},{"line_number":35,"context_line":"        parser \u003d super(CliAlarmList, self).get_parser(prog_name)"},{"line_number":36,"context_line":"        parser.add_argument(\u0027-t\u0027, \u0027--type\u0027, required\u003dTrue,"},{"line_number":37,"context_line":"                            choices\u003dALARM_TYPES, help\u003d\u0027Type of alarm\u0027)"},{"line_number":38,"context_line":"        return parser"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_421fe4b6","side":"PARENT","line":36,"in_reply_to":"7af24918_1fa6d952","updated":"2016-03-03 05:05:20.000000000","message":"so you prefer to support query filters which can include type\u003dxxx and can support more filter conditions[1] or just keep this argument without \"required\u003dTrue\" ?\n\n[1] https://review.openstack.org/#/c/283959/","commit_id":"3024acd5c62c8c2224deff2f0716f98132149ab6"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"4a81a874b52ed869fda7609e95a956dc60ccc441","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        return parser"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def take_action(self, parsed_args):"},{"line_number":50,"context_line":"        type_query \u003d \u0027{\"\u003d\": {\"type\": \"%s\"}}\u0027 % parsed_args.type"},{"line_number":51,"context_line":"        if parsed_args.query:"},{"line_number":52,"context_line":"            query \u003d \u0027{\"and\": [%s, %s]}\u0027 % (type_query, parsed_args.query)"},{"line_number":53,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5aef4532_265a3c51","line":50,"updated":"2016-03-11 07:15:26.000000000","message":"This inherit from CliAlarmList, so parsed_args.type doesn\u0027t exists anymore.","commit_id":"aebef3e4fc9cfb706e77c0f05ba9aa53662fb9ef"}]}