)]}'
{"id":"openstack%2Fpython-aodhclient~309765","triplet_id":"openstack%2Fpython-aodhclient~master~I936fbe66d2711db49c48d6a73638103fe8e5603e","project":"openstack/python-aodhclient","branch":"master","topic":"clever-name","hashtags":[],"change_id":"I936fbe66d2711db49c48d6a73638103fe8e5603e","subject":"treat alarm id as name if it is not uuid like","status":"ABANDONED","created":"2016-04-24 13:23:29.000000000","updated":"2016-04-30 00:06:01.000000000","total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"5c24f8208f3c1b886153a178b70463446481c9e7","_number":309765,"virtual_id_number":309765,"owner":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},{"value":1,"date":"2016-04-26 13:32:49.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2016-04-27 02:17:54.000000000","_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},{"date":"2016-04-26 23:32:37.000000000","_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"rejected":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},{"value":-2,"date":"2016-04-29 19:17:30.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-04-25 03:51:02.000000000","updated_by":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"reviewer":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"state":"REVIEWER"},{"updated":"2016-04-26 13:32:49.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2016-04-26 23:32:37.000000000","updated_by":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"reviewer":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"state":"REVIEWER"}],"messages":[{"id":"c822249c350740f9c187acf68ecd197c1cf56a52","author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"date":"2016-04-24 13:23:29.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"851a2e17989310ccf0f8cdb2a4c4e8ddc2260b88","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-04-24 13:35:08.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-aodhclient-docs http://docs-draft.openstack.org/65/309765/1/check/gate-python-aodhclient-docs/74d685d//doc/build/html/ : SUCCESS in 8m 39s\n- gate-python-aodhclient-pep8 http://logs.openstack.org/65/309765/1/check/gate-python-aodhclient-pep8/493bd06/ : SUCCESS in 8m 49s\n- gate-python-aodhclient-python27 http://logs.openstack.org/65/309765/1/check/gate-python-aodhclient-python27/7968498/ : SUCCESS in 9m 54s\n- gate-python-aodhclient-python34 http://logs.openstack.org/65/309765/1/check/gate-python-aodhclient-python34/760431c/ : SUCCESS in 11m 33s\n- gate-python-aodhclient-pypy http://logs.openstack.org/65/309765/1/check/gate-python-aodhclient-pypy/1562779/ : FAILURE in 3m 18s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"c569251443713c098890313baffca81290d848b2","author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"date":"2016-04-25 03:37:20.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"cf98a9188aa99a37737b0f13b157a48bd15532fb","author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"date":"2016-04-25 03:51:02.000000000","message":"Patch Set 1: Code-Review-1\n\nYes, we already discussed this when we put up this new feature, and it has been decided to be the current way.","accounts_in_message":[],"_revision_number":1},{"id":"49077103ba3a85260533925e0750631a739d8e11","author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"date":"2016-04-25 04:25:00.000000000","message":"Patch Set 1:\n\n@jd__\n\n$ aodh alarm show aa0541eb-6384-4579-b128-6e598533913b\n+---------------------------+--------------------------------------+\n| Field                     | Value                                |\n+---------------------------+--------------------------------------+\n| alarm_actions             | []                                   |\n| alarm_id                  | aa0541eb-6384-4579-b128-6e598533913b |\n| description               | Alarm when * event occurred.         |\n| enabled                   | True                                 |\n| event_type                | *                                    |\n| insufficient_data_actions | []                                   |\n| name                      | test-event-alarm-01                  |\n| ok_actions                | []                                   |\n| project_id                | 74a0f0d8734d46a18773139c0c331e5e     |\n| query                     | []                                   |\n| repeat_actions            | False                                |\n| severity                  | low                                  |\n| state                     | insufficient data                    |\n| state_timestamp           | 2016-04-23T05:45:45.724697           |\n| time_constraints          | []                                   |\n| timestamp                 | 2016-04-23T05:45:45.724697           |\n| type                      | event                                |\n| user_id                   | c417eb1ad2534df483e9065c03ab8da8     |\n+---------------------------+--------------------------------------+\n\naodh alarm show --alarm-name aa0541eb-6384-4579-b128-6e598533913b ?? why should do such thing, alarm-name is a specific option, user should read the help string","accounts_in_message":[],"_revision_number":1},{"id":"e14299a69aba757c4786476bf2e009fa8bbe4536","author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"date":"2016-04-25 04:28:00.000000000","message":"Patch Set 1:\n\n@jd__\n\nI understand what you say,\n\nzqfan@BJWS:/opt/stack/python-aodhclient$ aodh alarm show --alarm-name aa0541eb-6384-4579-b128-6e598533913a\n+---------------------------+--------------------------------------+\n| Field                     | Value                                |\n+---------------------------+--------------------------------------+\n| alarm_actions             | []                                   |\n| alarm_id                  | aa0541eb-6384-4579-b128-6e598533913b |\n| description               | Alarm when * event occurred.         |\n| enabled                   | True                                 |\n| event_type                | *                                    |\n| insufficient_data_actions | []                                   |\n| name                      | aa0541eb-6384-4579-b128-6e598533913a |\n| ok_actions                | []                                   |\n| project_id                | 74a0f0d8734d46a18773139c0c331e5e     |\n| query                     | []                                   |\n| repeat_actions            | False                                |\n| severity                  | low                                  |\n| state                     | insufficient data                    |\n| state_timestamp           | 2016-04-23T05:45:45.724697           |\n| time_constraints          | []                                   |\n| timestamp                 | 2016-04-25T12:26:50.391207           |\n| type                      | event                                |\n| user_id                   | c417eb1ad2534df483e9065c03ab8da8     |\n+---------------------------+--------------------------------------+\n(pep8) zqfan@BJWS:/opt/stack/python-aodhclient$ aodh alarm show aa0541eb-6384-4579-b128-6e598533913a\nAlarm aa0541eb-6384-4579-b128-6e598533913a not found (HTTP 404) (Request-ID: req-c2dcf637-20fc-4854-94ae-ee51d25bdc5f)\n\n\nHowever, I think we should provide convenient way for cli users, if an end user just want such hacking funny thing, let them play with themselves and let normal user have a happy life","accounts_in_message":[],"_revision_number":1},{"id":"cc9f0c7e195d689d5a8adb01f2186b58ffdfc701","author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"date":"2016-04-25 04:32:20.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"f94a9e2260fb39f7f8e077ace3446bfa3070d583","author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"date":"2016-04-25 15:47:05.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"7375bfd2018772301a7d1a113d5696ebe856ee58","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-04-25 15:56:33.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-aodhclient-docs http://logs.openstack.org/65/309765/2/check/gate-python-aodhclient-docs/1f203d3/ : FAILURE in 2m 16s\n- gate-python-aodhclient-pep8 http://logs.openstack.org/65/309765/2/check/gate-python-aodhclient-pep8/32366ad/ : SUCCESS in 9m 22s\n- gate-python-aodhclient-python27 http://logs.openstack.org/65/309765/2/check/gate-python-aodhclient-python27/aa436f2/ : SUCCESS in 8m 55s\n- gate-python-aodhclient-python34 http://logs.openstack.org/65/309765/2/check/gate-python-aodhclient-python34/d8f57d9/ : SUCCESS in 8m 26s\n- gate-python-aodhclient-pypy http://logs.openstack.org/65/309765/2/check/gate-python-aodhclient-pypy/c2d1960/ : FAILURE in 2m 57s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"8e1c43bae8062e78855e4718636f869a93317e52","author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"date":"2016-04-25 16:03:29.000000000","message":"Patch Set 2:\n\nrecheck","accounts_in_message":[],"_revision_number":2},{"id":"fdbf888ae1e7b562d47ab7337951893aca97f763","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-04-25 16:17:40.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-aodhclient-docs http://docs-draft.openstack.org/65/309765/2/check/gate-python-aodhclient-docs/7d1a542//doc/build/html/ : SUCCESS in 9m 26s\n- gate-python-aodhclient-pep8 http://logs.openstack.org/65/309765/2/check/gate-python-aodhclient-pep8/b74f988/ : SUCCESS in 9m 05s\n- gate-python-aodhclient-python27 http://logs.openstack.org/65/309765/2/check/gate-python-aodhclient-python27/44d9402/ : SUCCESS in 9m 42s\n- gate-python-aodhclient-python34 http://logs.openstack.org/65/309765/2/check/gate-python-aodhclient-python34/e35f50a/ : SUCCESS in 13m 11s\n- gate-python-aodhclient-pypy http://logs.openstack.org/65/309765/2/check/gate-python-aodhclient-pypy/cc1e123/ : FAILURE in 2m 45s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"4e9116bb5a28bb223ebcbb096af14d6b4b46a1f4","author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"date":"2016-04-25 16:49:47.000000000","message":"Patch Set 2: Code-Review-1\n\n\"However, I think we should provide convenient way for cli users, if an end user just want such hacking funny thing, let them play with themselves and let normal user have a happy life\"\n\nI agree, but you can\u0027t return a 404 to a completely valid command line just because you are trying to be smarter than the user. This is just awful.\n\nWhat could be acceptable for the CLI and only the CLI is to do a second request if it turns out the value given is a name and not a UUID. But that will end up doing 2 requests for most cases where the alarm name is not found, so I\u0027m not sure it\u0027s a good call either.","accounts_in_message":[],"_revision_number":2},{"id":"bd0b241f42a2847f3625de3682178c29b8a8cc6c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-04-26 02:03:10.000000000","message":"Patch Set 2: Verified-1\n\nMerge Failed.\n\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.","accounts_in_message":[],"_revision_number":2},{"id":"5f217dc9fb4ed6d419b4c8cac374cdb25cf28601","author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"date":"2016-04-26 02:57:33.000000000","message":"Patch Set 2:\n\nIt is ok to do a second request, nova does it and people has nothing complaint for this feature\n\nAs a heavy user of telemetry service, I will try everything I can do to save my time and do things convenient and efficient\n\nwe can add an environment variable, to control ambiguous id is allowed  or not, if yes, then we do twice, if not, we treat it as id then let it fail. by default, it is no, just as currently behavior. I cannot image an user would manually open it and complain the extra request which will only occur if name is uuid like\n\nCheers","accounts_in_message":[],"_revision_number":2},{"id":"782589f960b315b417b0c6337af6ae7b1e459dcf","author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"date":"2016-04-26 07:36:48.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"38331f257d8b868802350c54c574bb3c974a5c73","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-04-26 07:47:15.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-aodhclient-docs http://docs-draft.openstack.org/65/309765/3/check/gate-python-aodhclient-docs/0993a90//doc/build/html/ : SUCCESS in 9m 13s\n- gate-python-aodhclient-pep8 http://logs.openstack.org/65/309765/3/check/gate-python-aodhclient-pep8/96ef320/ : SUCCESS in 8m 45s\n- gate-python-aodhclient-python27 http://logs.openstack.org/65/309765/3/check/gate-python-aodhclient-python27/cd3ac41/ : FAILURE in 9m 24s\n- gate-python-aodhclient-python34 http://logs.openstack.org/65/309765/3/check/gate-python-aodhclient-python34/5a9384c/ : FAILURE in 8m 29s\n- gate-python-aodhclient-pypy http://logs.openstack.org/65/309765/3/check/gate-python-aodhclient-pypy/33daf2f/ : FAILURE in 1m 51s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"2cfc901f172c5eb8679cde00e32ba62c2990c529","author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"date":"2016-04-26 09:04:41.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"0478f0e3e03b13e7d2ec87f198263e6472f0d4fe","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-04-26 09:18:43.000000000","message":"Patch Set 4: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-aodhclient-docs http://docs-draft.openstack.org/65/309765/4/check/gate-python-aodhclient-docs/57df08e//doc/build/html/ : SUCCESS in 8m 38s\n- gate-python-aodhclient-pep8 http://logs.openstack.org/65/309765/4/check/gate-python-aodhclient-pep8/9f9a937/ : SUCCESS in 9m 46s\n- gate-python-aodhclient-python27 http://logs.openstack.org/65/309765/4/check/gate-python-aodhclient-python27/c99b04c/ : FAILURE in 10m 56s\n- gate-python-aodhclient-python34 http://logs.openstack.org/65/309765/4/check/gate-python-aodhclient-python34/146badf/ : FAILURE in 13m 29s\n- gate-python-aodhclient-pypy http://logs.openstack.org/65/309765/4/check/gate-python-aodhclient-pypy/037ac2f/ : FAILURE in 2m 40s (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"f4ec1a9d424c676f45614664f133272f2264364a","author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"date":"2016-04-26 11:13:57.000000000","message":"Patch Set 4:\n\nrecheck","accounts_in_message":[],"_revision_number":4},{"id":"d65d8a79219615cae36f3c19d5f3471e88be56b4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-04-26 11:26:59.000000000","message":"Patch Set 4:\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-aodhclient-docs http://docs-draft.openstack.org/65/309765/4/check/gate-python-aodhclient-docs/8b02942//doc/build/html/ : SUCCESS in 9m 07s\n- gate-python-aodhclient-pep8 http://logs.openstack.org/65/309765/4/check/gate-python-aodhclient-pep8/7ccd1dd/ : SUCCESS in 8m 43s\n- gate-python-aodhclient-python27 http://logs.openstack.org/65/309765/4/check/gate-python-aodhclient-python27/fd2a361/ : FAILURE in 9m 32s\n- gate-python-aodhclient-python34 http://logs.openstack.org/65/309765/4/check/gate-python-aodhclient-python34/a04c195/ : FAILURE in 12m 55s\n- gate-python-aodhclient-pypy http://logs.openstack.org/65/309765/4/check/gate-python-aodhclient-pypy/aff3497/ : FAILURE in 2m 58s (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"8547263f6a2a3c060b3815bd03aa872c1ee45a82","author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"date":"2016-04-26 13:05:59.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"b15b7e73cb71d4edb9cf9536670d9effac72dd88","author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"date":"2016-04-26 13:18:15.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"d2bd1cbbcd6829375ad14493ddd087b4c333376b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-04-26 13:32:49.000000000","message":"Patch Set 6: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-aodhclient-docs http://docs-draft.openstack.org/65/309765/6/check/gate-python-aodhclient-docs/200d3a7//doc/build/html/ : SUCCESS in 8m 45s\n- gate-python-aodhclient-pep8 http://logs.openstack.org/65/309765/6/check/gate-python-aodhclient-pep8/339cdec/ : SUCCESS in 10m 34s\n- gate-python-aodhclient-python27 http://logs.openstack.org/65/309765/6/check/gate-python-aodhclient-python27/71771dc/ : SUCCESS in 9m 57s\n- gate-python-aodhclient-python34 http://logs.openstack.org/65/309765/6/check/gate-python-aodhclient-python34/f283127/ : SUCCESS in 13m 59s\n- gate-python-aodhclient-pypy http://logs.openstack.org/65/309765/6/check/gate-python-aodhclient-pypy/89615b5/ : FAILURE in 2m 59s (non-voting)","accounts_in_message":[],"_revision_number":6},{"id":"ac99958ef461e896e869a6ad46f4a9fdb0aef534","author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"date":"2016-04-26 23:32:37.000000000","message":"Patch Set 6:\n\n(1 comment)\n\nI like the idea of that UX improvement ZhiQiang Fan, but I think it\u0027s terribly done here :) I\u0027ve proposed another approach https://review.openstack.org/310331","accounts_in_message":[],"_revision_number":6},{"id":"fbe53e04462e92fb3cabc278fdffc7cd2880e92d","author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"date":"2016-04-27 02:17:54.000000000","message":"Patch Set 6:\n\nI\u0027m really sorry for my unprofessional programming skills and ridiculous thoughts, I spent a whole day just to produce such piece of shit, hope I can do it better in future","accounts_in_message":[],"_revision_number":6},{"id":"1edd0e8b106b1859e2515fa62b5bc23a7dfc37f9","author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"date":"2016-04-27 05:25:38.000000000","message":"Patch Set 6:\n\nI remembered that I add this --aodh-ambiguous-id option is because tempest doesn\u0027t have a way to expose the environment variable, so I have to put it as optional argument to let it testable in gate\n\npersonally, I think use it internally is OK for user","accounts_in_message":[],"_revision_number":6},{"id":"f110101fdd6f48910586099f71772416f1d3fba7","author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"date":"2016-04-27 12:52:15.000000000","message":"Patch Set 6:\n\nBah programming skills and UX are really orthogonal skills, ZhiQiang Fan :)\n\nDon\u0027t take it the wrong way, I\"m glad you worked on that, I was just kidding you because I think we can do better than that. At least I hope! :)","accounts_in_message":[],"_revision_number":6},{"id":"af518327084d9785ae5f05fd0b11d796e8c78e3c","author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"date":"2016-04-27 13:00:39.000000000","message":"Patch Set 6:\n\n@jd\n\nThank you. I know you\u0027re just kidding, but I feel bad because I cannot make a perfect one","accounts_in_message":[],"_revision_number":6},{"id":"9db4f7bb87f9760941250fea0a0835a3c237e741","author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"date":"2016-04-29 19:17:30.000000000","message":"Patch Set 6: Code-Review-2\n\nsee https://review.openstack.org/#/c/310331","accounts_in_message":[],"_revision_number":6},{"id":"b4468972055a8ea4564c2ba51df6cfecc43d636b","author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"date":"2016-04-30 00:06:01.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":6}],"current_revision_number":6,"current_revision":"eda5c40556cd2c9ab030fbabed1da06fbadb2529","revisions":{"701a1a59cd7f631a08b109a386ae8267a89f9a04":{"kind":"REWORK","_number":1,"created":"2016-04-24 13:23:29.000000000","uploader":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"ref":"refs/changes/65/309765/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-aodhclient","ref":"refs/changes/65/309765/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-aodhclient refs/changes/65/309765/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-aodhclient refs/changes/65/309765/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-aodhclient refs/changes/65/309765/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-aodhclient refs/changes/65/309765/1"}}},"commit":{"parents":[{"commit":"9036e3ada9b7274f5878a2b80a2a66013b487005","subject":"Switch from deprecated tempest-lib to tempest","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-aodhclient/commit/9036e3ada9b7274f5878a2b80a2a66013b487005"}]}],"author":{"name":"ZhiQiang Fan","email":"aji.zqfan@gmail.com","date":"2016-04-24 20:54:34.000000000","tz":480},"committer":{"name":"ZhiQiang Fan","email":"aji.zqfan@gmail.com","date":"2016-04-24 21:23:59.000000000","tz":480},"subject":"treat alarm id as name if it is not uuid like","message":"treat alarm id as name if it is not uuid like\n\nWe can specify alarm name to do alarm {show, update, delete}, but\nneed to explicitly use --alarm-name, which seems not so convenient.\n\nThis patch adds a check for postional argument, if it is uuid like,\nwe treat it as alarm id, if not, we treat it as name.\n\nIf name is a uuid like string, this will not work, and return a\n404 code, in case of such scenario, adds a detailed help message\nfor this ambiguous field.\n\nChange-Id: I936fbe66d2711db49c48d6a73638103fe8e5603e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-aodhclient/commit/701a1a59cd7f631a08b109a386ae8267a89f9a04"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-aodhclient/commit/701a1a59cd7f631a08b109a386ae8267a89f9a04"}]},"branch":"refs/heads/master"},"e214a469c74cf8f4a8a9ca6d3d30bef4c3bd0606":{"kind":"REWORK","_number":2,"created":"2016-04-25 15:47:05.000000000","uploader":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"ref":"refs/changes/65/309765/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-aodhclient","ref":"refs/changes/65/309765/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-aodhclient refs/changes/65/309765/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-aodhclient refs/changes/65/309765/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-aodhclient refs/changes/65/309765/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-aodhclient refs/changes/65/309765/2"}}},"commit":{"parents":[{"commit":"db1a34ce935107a7f53728ec17d9f658090a9349","subject":"refactor code of adding alarm id and name arguments","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-aodhclient/commit/db1a34ce935107a7f53728ec17d9f658090a9349"}]}],"author":{"name":"ZhiQiang Fan","email":"aji.zqfan@gmail.com","date":"2016-04-24 20:54:34.000000000","tz":480},"committer":{"name":"ZhiQiang Fan","email":"aji.zqfan@gmail.com","date":"2016-04-25 23:47:22.000000000","tz":480},"subject":"treat alarm id as name if it is not uuid like","message":"treat alarm id as name if it is not uuid like\n\nWe can specify alarm name to do alarm {show, update, delete}, but\nneed to explicitly use --alarm-name, which seems not so convenient.\n\nThis patch adds a check for postional argument, if it is uuid like,\nwe treat it as alarm id, if not, we treat it as name.\n\nIf name is a uuid like string, this will not work, and return a\n404 code, in case of such scenario, adds a detailed help message\nfor this ambiguous field.\n\nChange-Id: I936fbe66d2711db49c48d6a73638103fe8e5603e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-aodhclient/commit/e214a469c74cf8f4a8a9ca6d3d30bef4c3bd0606"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-aodhclient/commit/e214a469c74cf8f4a8a9ca6d3d30bef4c3bd0606"}]},"branch":"refs/heads/master"},"e2c3fe4bf56d15722a7f40178a23abb8232a33c3":{"kind":"REWORK","_number":3,"created":"2016-04-26 07:36:48.000000000","uploader":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"ref":"refs/changes/65/309765/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-aodhclient","ref":"refs/changes/65/309765/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-aodhclient refs/changes/65/309765/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-aodhclient refs/changes/65/309765/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-aodhclient refs/changes/65/309765/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-aodhclient refs/changes/65/309765/3"}}},"commit":{"parents":[{"commit":"e719965c0c099d477c568b99c3af328b2be0e57d","subject":"refactor code of adding alarm id and name arguments","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-aodhclient/commit/e719965c0c099d477c568b99c3af328b2be0e57d"}]}],"author":{"name":"ZhiQiang Fan","email":"aji.zqfan@gmail.com","date":"2016-04-24 20:54:34.000000000","tz":480},"committer":{"name":"ZhiQiang Fan","email":"aji.zqfan@gmail.com","date":"2016-04-26 15:37:19.000000000","tz":480},"subject":"treat alarm id as name if it is not uuid like","message":"treat alarm id as name if it is not uuid like\n\nWe can specify alarm name to do alarm {show, update, delete}, but\nneed to explicitly use --alarm-name, which seems not so convenient.\n\nThis patch adds a check for postional argument, if it is UUID like,\nwe treat it as alarm id, if not, we treat it as name.\n\nHowever, there is a rare case that a name can be UUID like as well,\ncommand will fail with 404 and people will treat it as a bug. We\ncan do an extra request for 404 error to try to use the value as\nname, but it will sacrifice normal 404 case for unnecessary time\ncost.\n\nSo an environment variable named AODH_AMBIGUOUS_ID will be checked,\nonly if its value is literally true, then we will allow\nput name as positional argument, and if the name is UUID like,\nno 404 raised for the first request, we will do an extra request\nto check if the UUID liked name exist.\n\nChange-Id: I936fbe66d2711db49c48d6a73638103fe8e5603e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-aodhclient/commit/e2c3fe4bf56d15722a7f40178a23abb8232a33c3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-aodhclient/commit/e2c3fe4bf56d15722a7f40178a23abb8232a33c3"}]},"branch":"refs/heads/master"},"5c22eb19c73fc68b37df65d4e76ab833b73aa7d3":{"kind":"REWORK","_number":4,"created":"2016-04-26 09:04:41.000000000","uploader":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"ref":"refs/changes/65/309765/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-aodhclient","ref":"refs/changes/65/309765/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-aodhclient refs/changes/65/309765/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-aodhclient refs/changes/65/309765/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-aodhclient refs/changes/65/309765/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-aodhclient refs/changes/65/309765/4"}}},"commit":{"parents":[{"commit":"0ae81f9c5aea454116c31065127ce7fbabb9930b","subject":"add mock to test requirement list","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-aodhclient/commit/0ae81f9c5aea454116c31065127ce7fbabb9930b"}]}],"author":{"name":"ZhiQiang Fan","email":"aji.zqfan@gmail.com","date":"2016-04-24 20:54:34.000000000","tz":480},"committer":{"name":"ZhiQiang Fan","email":"aji.zqfan@gmail.com","date":"2016-04-26 17:04:33.000000000","tz":480},"subject":"treat alarm id as name if it is not uuid like","message":"treat alarm id as name if it is not uuid like\n\nWe can specify alarm name to do alarm {show, update, delete}, but\nneed to explicitly use --alarm-name, which seems not so convenient.\n\nThis patch adds a check for postional argument, if it is UUID like,\nwe treat it as alarm id, if not, we treat it as name.\n\nHowever, there is a rare case that a name can be UUID like as well,\ncommand will fail with 404 and people will treat it as a bug. We\ncan do an extra request for 404 error to try to use the value as\nname, but it will sacrifice normal 404 case for unnecessary time\ncost.\n\nSo an environment variable named AODH_AMBIGUOUS_ID will be checked,\nonly if its value is literally true, then we will allow\nput name as positional argument, and if the name is UUID like,\nno 404 raised for the first request, we will do an extra request\nto check if the UUID liked name exist.\n\nChange-Id: I936fbe66d2711db49c48d6a73638103fe8e5603e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-aodhclient/commit/5c22eb19c73fc68b37df65d4e76ab833b73aa7d3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-aodhclient/commit/5c22eb19c73fc68b37df65d4e76ab833b73aa7d3"}]},"branch":"refs/heads/master"},"0c1fdca888a84e7b02c85369d7bd61b319911799":{"kind":"REWORK","_number":5,"created":"2016-04-26 13:05:59.000000000","uploader":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"ref":"refs/changes/65/309765/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-aodhclient","ref":"refs/changes/65/309765/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-aodhclient refs/changes/65/309765/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-aodhclient refs/changes/65/309765/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-aodhclient refs/changes/65/309765/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-aodhclient refs/changes/65/309765/5"}}},"commit":{"parents":[{"commit":"0ae81f9c5aea454116c31065127ce7fbabb9930b","subject":"add mock to test requirement list","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-aodhclient/commit/0ae81f9c5aea454116c31065127ce7fbabb9930b"}]}],"author":{"name":"ZhiQiang Fan","email":"aji.zqfan@gmail.com","date":"2016-04-24 20:54:34.000000000","tz":480},"committer":{"name":"ZhiQiang Fan","email":"aji.zqfan@gmail.com","date":"2016-04-26 21:06:28.000000000","tz":480},"subject":"treat alarm id as name if it is not uuid like","message":"treat alarm id as name if it is not uuid like\n\nWe can specify alarm name to do alarm {show, update, delete}, but\nneed to explicitly use --alarm-name, which seems not so convenient.\n\nThis patch adds a check for postional argument, if it is UUID like,\nwe treat it as alarm id, if not, we treat it as name.\n\nHowever, there is a rare case that a name can be UUID like as well,\ncommand will fail with 404 and people will treat it as a bug. We\ncan do an extra request for 404 error to try to use the value as\nname, but it will sacrifice normal 404 case for unnecessary time\ncost.\n\nSo an environment variable named AODH_AMBIGUOUS_ID will be checked,\nonly if its value is literally true, then we will allow\nput name as positional argument, and if the name is UUID like,\nno 404 raised for the first request, we will do an extra request\nto check if the UUID liked name exist.\n\nChange-Id: I936fbe66d2711db49c48d6a73638103fe8e5603e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-aodhclient/commit/0c1fdca888a84e7b02c85369d7bd61b319911799"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-aodhclient/commit/0c1fdca888a84e7b02c85369d7bd61b319911799"}]},"branch":"refs/heads/master"},"eda5c40556cd2c9ab030fbabed1da06fbadb2529":{"kind":"REWORK","_number":6,"created":"2016-04-26 13:18:15.000000000","uploader":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"ref":"refs/changes/65/309765/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-aodhclient","ref":"refs/changes/65/309765/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-aodhclient refs/changes/65/309765/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-aodhclient refs/changes/65/309765/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-aodhclient refs/changes/65/309765/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-aodhclient refs/changes/65/309765/6"}}},"commit":{"parents":[{"commit":"0ae81f9c5aea454116c31065127ce7fbabb9930b","subject":"add mock to test requirement list","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-aodhclient/commit/0ae81f9c5aea454116c31065127ce7fbabb9930b"}]}],"author":{"name":"ZhiQiang Fan","email":"aji.zqfan@gmail.com","date":"2016-04-24 20:54:34.000000000","tz":480},"committer":{"name":"ZhiQiang Fan","email":"aji.zqfan@gmail.com","date":"2016-04-26 21:14:38.000000000","tz":480},"subject":"treat alarm id as name if it is not uuid like","message":"treat alarm id as name if it is not uuid like\n\nWe can specify alarm name to do alarm {show, update, delete}, but\nneed to explicitly use --alarm-name, which seems not so convenient.\n\nThis patch adds a check for postional argument, if it is UUID like,\nwe treat it as alarm id, if not, we treat it as name.\n\nHowever, there is a rare case that a name can be UUID like as well,\ncommand will fail with 404 and people will treat it as a bug. We\ncan do an extra request for 404 error to try to use the value as\nname, but it will sacrifice normal 404 case for unnecessary time\ncost.\n\nSo an environment variable named AODH_AMBIGUOUS_ID will be checked,\nonly if its value is literally true, then we will allow\nput name as positional argument, and if the name is UUID like,\nno 404 raised for the first request, we will do an extra request\nto check if the UUID liked name exist.\n\nChange-Id: I936fbe66d2711db49c48d6a73638103fe8e5603e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-aodhclient/commit/eda5c40556cd2c9ab030fbabed1da06fbadb2529"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-aodhclient/commit/eda5c40556cd2c9ab030fbabed1da06fbadb2529"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}