)]}'
{"id":"openstack%2Fpython-aodhclient~314026","triplet_id":"openstack%2Fpython-aodhclient~master~I6234414a66b25892c4615b19a694572b93e64caa","project":"openstack/python-aodhclient","branch":"master","topic":"bug/1579663","hashtags":[],"change_id":"I6234414a66b25892c4615b19a694572b93e64caa","subject":"add valid choice for alarm type help text","status":"MERGED","created":"2016-05-09 09:42:08.000000000","updated":"2016-05-10 08:05:03.000000000","submitted":"2016-05-10 08:05:03.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"dce9c9132a9dd47a884cca257552dd3b49e427c7","_number":314026,"virtual_id_number":314026,"owner":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2016-05-10 08:05:03.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},{"value":0,"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-05-09 10:15:47.000000000","_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},{"value":2,"date":"2016-05-10 07:50:24.000000000","_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},{"value":1,"date":"2016-05-10 07:50:24.000000000","_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-05-09 10:15:47.000000000","updated_by":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"reviewer":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"state":"REVIEWER"},{"updated":"2016-05-10 07:50:24.000000000","updated_by":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"reviewer":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"state":"REVIEWER"},{"updated":"2016-05-10 08:05:03.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"fc365bf467e173c2fbaebc5d5e025bc9006d277e","author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"date":"2016-05-09 09:42:08.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"41a4b6717c5512c0518586a456a778276692c349","author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"date":"2016-05-09 09:47:30.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"f9a27d0b977d6d843be7d1f28f8c8daff2d6fbc3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-05-09 10:01:30.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-aodhclient-docs http://docs-draft.openstack.org/26/314026/2/check/gate-python-aodhclient-docs/486bbe7//doc/build/html/ : SUCCESS in 8m 48s\n- gate-python-aodhclient-pep8 http://logs.openstack.org/26/314026/2/check/gate-python-aodhclient-pep8/c25c5d0/ : SUCCESS in 8m 53s\n- gate-python-aodhclient-python27 http://logs.openstack.org/26/314026/2/check/gate-python-aodhclient-python27/096b177/ : SUCCESS in 9m 08s\n- gate-python-aodhclient-python34 http://logs.openstack.org/26/314026/2/check/gate-python-aodhclient-python34/ba1eba1/ : SUCCESS in 11m 55s\n- gate-python-aodhclient-pypy http://logs.openstack.org/26/314026/2/check/gate-python-aodhclient-pypy/01abf9d/ : FAILURE in 2m 37s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"a8d82fe762362fe860c080a746e160a7c249529d","author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"date":"2016-05-09 10:15:47.000000000","message":"Patch Set 2: Code-Review+2\n\nLooks like a bug in argparse, but yeah :)","accounts_in_message":[],"_revision_number":2},{"id":"bc2fd096077c1085ed0ae149cddb8d79f67a294d","author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"date":"2016-05-09 10:59:50.000000000","message":"Patch Set 2:\n\n@jd:\n\nargparse can print choice if you don\u0027t set the metavar, but it will look like:\n\n-t {threshold,event,composite,gnocchi_resources_threshold,gnocchi_aggregation_by_metrics_threshold,gnocchi_aggregation_by_resources_threshold}, --type {threshold,event,composite,gnocchi_resources_threshold,gnocchi_aggregation_by_metrics_threshold,gnocchi_aggregation_by_resources_threshold}\n\nwhich is terrible to me, so I choose this simple way","accounts_in_message":[],"_revision_number":2},{"id":"9be56c2415af891c661a229949f41a7dee988a1d","author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"date":"2016-05-09 11:37:00.000000000","message":"Patch Set 2:\n\nI don\u0027t think it\u0027s terrible. I\u0027d say it\u0027s better to use the same everywhere and *maybe* build a subclass of argparse that override that everywhere.\n\nBecause it\u0027s likely we\u0027re not going to have same format everywhere with that approach.\n\nThough I think it\u0027s good enough for now.","accounts_in_message":[],"_revision_number":2},{"id":"a027de3d12cdea4800f58d4944e476cbed52d933","author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"date":"2016-05-10 07:50:24.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"029d67b277004e052f2480365abf67f829ba13e5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-05-10 07:50:29.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"df559155b192469a510e68600460ee4b30c442d1","date":"2016-05-10 08:05:03.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":2},{"id":"81956528dfabdca743be03e7559651b6b4207b5b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-05-10 08:05:03.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-aodhclient-docs http://docs-draft.openstack.org/26/314026/2/gate/gate-python-aodhclient-docs/ef9fa0d//doc/build/html/ : SUCCESS in 10m 26s\n- gate-python-aodhclient-pep8 http://logs.openstack.org/26/314026/2/gate/gate-python-aodhclient-pep8/323803c/ : SUCCESS in 6m 07s\n- gate-python-aodhclient-python27 http://logs.openstack.org/26/314026/2/gate/gate-python-aodhclient-python27/fe38e8b/ : SUCCESS in 6m 34s\n- gate-python-aodhclient-python34 http://logs.openstack.org/26/314026/2/gate/gate-python-aodhclient-python34/dd8d7b9/ : SUCCESS in 13m 40s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"9d435c9e146fb7fc958aaac08d0bb4289e37468c","revisions":{"5971f8ed13046bbe481b161eedeefc5bc72be905":{"kind":"REWORK","_number":1,"created":"2016-05-09 09:42:08.000000000","uploader":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"ref":"refs/changes/26/314026/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-aodhclient","ref":"refs/changes/26/314026/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-aodhclient refs/changes/26/314026/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-aodhclient refs/changes/26/314026/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-aodhclient refs/changes/26/314026/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-aodhclient refs/changes/26/314026/1"}}},"commit":{"parents":[{"commit":"0f48f582049fbf318bdd9a5cbbd1f39a89074dc2","subject":"shell: fix meter help string","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-aodhclient/commit/0f48f582049fbf318bdd9a5cbbd1f39a89074dc2"}]}],"author":{"name":"ZhiQiang Fan","email":"aji.zqfan@gmail.com","date":"2016-05-09 17:41:43.000000000","tz":480},"committer":{"name":"ZhiQiang Fan","email":"aji.zqfan@gmail.com","date":"2016-05-09 17:41:43.000000000","tz":480},"subject":"add valid choice for alarm type","message":"add valid choice for alarm type\n\nThe valid choice for alarm type is not provided in help text, which\nmay confuse end users.\n\nChange-Id: I6234414a66b25892c4615b19a694572b93e64caa\nCloses-Bug: #1579663\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-aodhclient/commit/5971f8ed13046bbe481b161eedeefc5bc72be905"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-aodhclient/commit/5971f8ed13046bbe481b161eedeefc5bc72be905"}]},"branch":"refs/heads/master"},"9d435c9e146fb7fc958aaac08d0bb4289e37468c":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2016-05-09 09:47:30.000000000","uploader":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"ref":"refs/changes/26/314026/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-aodhclient","ref":"refs/changes/26/314026/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-aodhclient refs/changes/26/314026/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-aodhclient refs/changes/26/314026/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-aodhclient refs/changes/26/314026/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-aodhclient refs/changes/26/314026/2"}}},"commit":{"parents":[{"commit":"0f48f582049fbf318bdd9a5cbbd1f39a89074dc2","subject":"shell: fix meter help string","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-aodhclient/commit/0f48f582049fbf318bdd9a5cbbd1f39a89074dc2"}]}],"author":{"name":"ZhiQiang Fan","email":"aji.zqfan@gmail.com","date":"2016-05-09 17:41:43.000000000","tz":480},"committer":{"name":"ZhiQiang Fan","email":"aji.zqfan@gmail.com","date":"2016-05-09 17:47:52.000000000","tz":480},"subject":"add valid choice for alarm type help text","message":"add valid choice for alarm type help text\n\nThe valid choice for alarm type is not provided in help text, which\nmay confuse end users.\n\nChange-Id: I6234414a66b25892c4615b19a694572b93e64caa\nCloses-Bug: #1579663\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-aodhclient/commit/9d435c9e146fb7fc958aaac08d0bb4289e37468c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-aodhclient/commit/9d435c9e146fb7fc958aaac08d0bb4289e37468c"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}