)]}'
{"aodhclient/exceptions.py":[{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"f6369b345d74ef81d046152f0a005279e48dfedc","unresolved":false,"context_lines":[{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    exception \u003d cls(**kwargs)"},{"line_number":189,"context_line":"    if isinstance(exception, ClientException) and response.status_code:"},{"line_number":190,"context_line":"        exception.http_status \u003d response.status_code"},{"line_number":191,"context_line":"    return exception"}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_64c29d54","line":190,"range":{"start_line":190,"start_character":8,"end_line":190,"end_character":52},"updated":"2016-06-02 04:46:34.000000000","message":"This attaching an attribute looks a bit strange, why don\u0027t put http_status to the __init__ of ClientException ?","commit_id":"d75a8e83bb4a17286b34daadb1322d881c07f274"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"82c2f2fd34a9bc0feed590ad9f35075ed4679419","unresolved":false,"context_lines":[{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    exception \u003d cls(**kwargs)"},{"line_number":189,"context_line":"    if isinstance(exception, ClientException) and response.status_code:"},{"line_number":190,"context_line":"        exception.http_status \u003d response.status_code"},{"line_number":191,"context_line":"    return exception"}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_a49ac511","line":190,"range":{"start_line":190,"start_character":8,"end_line":190,"end_character":52},"in_reply_to":"9abb7d3a_64c29d54","updated":"2016-06-02 04:57:37.000000000","message":"it is not attaching, I have added this property to the class, see Line 18, it is just simply assignment, if we know the http status code while we not define an exception for it\n\nthe reason why it is not in init parameters because core team agree to use implicit way for error code, see https://review.openstack.org/#/c/317915/","commit_id":"d75a8e83bb4a17286b34daadb1322d881c07f274"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"750392fdb93df3f2ffdf9ef6a24e6a76329869f4","unresolved":false,"context_lines":[{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    exception \u003d cls(**kwargs)"},{"line_number":189,"context_line":"    if isinstance(exception, ClientException) and response.status_code:"},{"line_number":190,"context_line":"        exception.http_status \u003d response.status_code"},{"line_number":191,"context_line":"    return exception"}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_af7299ae","line":190,"range":{"start_line":190,"start_character":8,"end_line":190,"end_character":52},"in_reply_to":"9abb7d3a_a49ac511","updated":"2016-06-02 07:37:55.000000000","message":"got it, thanks for explanation","commit_id":"d75a8e83bb4a17286b34daadb1322d881c07f274"}]}
