)]}'
{"id":"openstack%2Fpython-aodhclient~322768","triplet_id":"openstack%2Fpython-aodhclient~master~Ib9920a1f21885917fe7bc4562f1b54602112a473","project":"openstack/python-aodhclient","branch":"master","topic":"bug/1586994","hashtags":[],"change_id":"Ib9920a1f21885917fe7bc4562f1b54602112a473","subject":"add default value for http_status in ClientException","status":"MERGED","created":"2016-05-30 11:11:43.000000000","updated":"2016-08-29 13:54:42.000000000","submitted":"2016-08-29 13:54:42.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"c0f6777cee2cb3ef124b6c5dbe84bdc2b1741625","_number":322768,"virtual_id_number":322768,"owner":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},{"value":2,"date":"2016-08-29 13:54:42.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"all":[{"value":2,"date":"2016-06-02 07:37:55.000000000","_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-08-29 13:47:37.000000000","_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"all":[{"value":0,"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-08-29 13:47:37.000000000","_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-06-02 07:37:55.000000000","updated_by":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"reviewer":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"state":"REVIEWER"},{"updated":"2016-08-29 13:47:37.000000000","updated_by":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"reviewer":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"state":"REVIEWER"},{"updated":"2016-08-29 13:54:42.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"b622cd62f2e8b5ec3144e6612bf47fbed00a724c","author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"date":"2016-05-30 11:11:43.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"bcfed24b611d3c35a8b0b2242561d9bf523d9d70","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-05-30 11:25:36.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-aodhclient-docs http://docs-draft.openstack.org/68/322768/1/check/gate-python-aodhclient-docs/fa93c62//doc/build/html/ : SUCCESS in 7m 49s\n- gate-python-aodhclient-pep8 http://logs.openstack.org/68/322768/1/check/gate-python-aodhclient-pep8/961437e/ : SUCCESS in 6m 07s\n- gate-python-aodhclient-python27 http://logs.openstack.org/68/322768/1/check/gate-python-aodhclient-python27/6c27e08/ : SUCCESS in 11m 27s\n- gate-python-aodhclient-python34 http://logs.openstack.org/68/322768/1/check/gate-python-aodhclient-python34/da09fe7/ : SUCCESS in 12m 14s\n- gate-python-aodhclient-pypy http://logs.openstack.org/68/322768/1/check/gate-python-aodhclient-pypy/dfd9f48/ : FAILURE in 2m 32s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"f6369b345d74ef81d046152f0a005279e48dfedc","author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"date":"2016-06-02 04:46:34.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"82c2f2fd34a9bc0feed590ad9f35075ed4679419","author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"date":"2016-06-02 04:57:37.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"750392fdb93df3f2ffdf9ef6a24e6a76329869f4","author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"date":"2016-06-02 07:37:55.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"6bf2927367d18f80b17effdf19717e0695172193","author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"date":"2016-08-29 13:47:37.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"5dc97f49cbef6b0c55f3cb37bdeec0c0c58f28a5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-08-29 13:47:49.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"d19c69cf3a92941a1d58a8cc397661c2f3cfd9c3","date":"2016-08-29 13:54:42.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1},{"id":"46d28adc908a3566c94f15ae04b5af9a74312494","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-08-29 13:54:42.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-aodhclient-docs-ubuntu-xenial http://docs-draft.openstack.org/68/322768/1/gate/gate-python-aodhclient-docs-ubuntu-xenial/b2bcc6c//doc/build/html/ : SUCCESS in 4m 13s\n- gate-python-aodhclient-pep8-ubuntu-xenial http://logs.openstack.org/68/322768/1/gate/gate-python-aodhclient-pep8-ubuntu-xenial/e8e5f6a/ : SUCCESS in 2m 54s\n- gate-python-aodhclient-python27-ubuntu-xenial http://logs.openstack.org/68/322768/1/gate/gate-python-aodhclient-python27-ubuntu-xenial/9db79fa/ : SUCCESS in 4m 50s\n- gate-python-aodhclient-python34 http://logs.openstack.org/68/322768/1/gate/gate-python-aodhclient-python34/8b248cd/ : SUCCESS in 6m 47s\n- gate-python-aodhclient-python35 http://logs.openstack.org/68/322768/1/gate/gate-python-aodhclient-python35/688d6e9/ : SUCCESS in 4m 37s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"d75a8e83bb4a17286b34daadb1322d881c07f274","revisions":{"d75a8e83bb4a17286b34daadb1322d881c07f274":{"kind":"REWORK","_number":1,"created":"2016-05-30 11:11:43.000000000","uploader":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"ref":"refs/changes/68/322768/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-aodhclient","ref":"refs/changes/68/322768/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-aodhclient refs/changes/68/322768/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-aodhclient refs/changes/68/322768/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-aodhclient refs/changes/68/322768/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-aodhclient refs/changes/68/322768/1"}}},"commit":{"parents":[{"commit":"e745247fab23b9ee455f5a9202df623442c18e08","subject":"Merge \"improve threshold \u0026 event alarm query formatting\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-aodhclient/commit/e745247fab23b9ee455f5a9202df623442c18e08"}]}],"author":{"name":"ZhiQiang Fan","email":"aji.zqfan@gmail.com","date":"2016-05-30 19:08:17.000000000","tz":480},"committer":{"name":"ZhiQiang Fan","email":"aji.zqfan@gmail.com","date":"2016-05-30 19:08:17.000000000","tz":480},"subject":"add default value for http_status in ClientException","message":"add default value for http_status in ClientException\n\nClientException is not a virtual base class, hence it can be\ninitialized and string formatted, but the required property\n\u0027http_status\u0027 is not set by defaut, which will cause AttributeError\nif we cannot convert a dedicate exception from response.\n\nThis patch fixes it by adding default value \u0027N/A\u0027 for http_status,\nand set it with response.status_code when it is a ClientException\ninstance.\n\nChange-Id: Ib9920a1f21885917fe7bc4562f1b54602112a473\nCloses-Bug: #1586994\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-aodhclient/commit/d75a8e83bb4a17286b34daadb1322d881c07f274"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-aodhclient/commit/d75a8e83bb4a17286b34daadb1322d881c07f274"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}