)]}'
{"aodhclient/v2/alarm_cli.py":[{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"1001e6718d31aa3692c5e03a8e9164191a269750","unresolved":false,"context_lines":[{"line_number":363,"context_line":"    def _validate_args(self, parsed_args):"},{"line_number":364,"context_line":"        if (parsed_args.type \u003d\u003d \u0027threshold\u0027 and"},{"line_number":365,"context_line":"            not (parsed_args.meter_name and"},{"line_number":366,"context_line":"                 (parsed_args.threshold or"},{"line_number":367,"context_line":"                                parsed_args.threshold \u003d\u003d 0))):"},{"line_number":368,"context_line":"            self.parser.error(\u0027Threshold alarm requires -m/--meter-name and \u0027"},{"line_number":369,"context_line":"                              \u0027--threshold parameters. Meter name can be \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f93b717_c4e6b4e9","line":366,"updated":"2018-01-25 12:53:42.000000000","message":"That looks wrong, it should be:\n\n  (parsed_args.meter_name and parsed_args.threshold is not None)","commit_id":"622a7feaf57ae9bf8a1936c757c422b3f0d5e2e6"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"1001e6718d31aa3692c5e03a8e9164191a269750","unresolved":false,"context_lines":[{"line_number":372,"context_line":"              not (parsed_args.metric and"},{"line_number":373,"context_line":"                   parsed_args.resource_id and parsed_args.resource_type"},{"line_number":374,"context_line":"                   and parsed_args.aggregation_method)"},{"line_number":375,"context_line":"              and (parsed_args.threshold or parsed_args.threshold \u003d\u003d 0)):"},{"line_number":376,"context_line":"            self.parser.error(\u0027gnocchi_resources_threshold requires --metric, \u0027"},{"line_number":377,"context_line":"                              \u0027--threshold, --resource-id, --resource-type \u0027"},{"line_number":378,"context_line":"                              \u0027and --aggregation-method\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f93b717_e4ebb0ad","line":375,"updated":"2018-01-25 12:53:42.000000000","message":"Same here.","commit_id":"622a7feaf57ae9bf8a1936c757c422b3f0d5e2e6"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"462d26883e87e1cf2064eb956e420147858cd195","unresolved":false,"context_lines":[{"line_number":351,"context_line":"                              \u0027--threshold, --resource-id, --resource-type \u0027"},{"line_number":352,"context_line":"                              \u0027and --aggregation-method\u0027)"},{"line_number":353,"context_line":"        elif (parsed_args.type \u003d\u003d \u0027gnocchi_aggregation_by_metrics_threshold\u0027"},{"line_number":354,"context_line":"              and not (parsed_args.metrics and parsed_args.threshold and"},{"line_number":355,"context_line":"                       parsed_args.aggregation_method)):"},{"line_number":356,"context_line":"            self.parser.error(\u0027gnocchi_aggregation_by_metrics_threshold \u0027"},{"line_number":357,"context_line":"                              \u0027requires --metrics, --threshold and \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f93b717_99cf0528","line":354,"updated":"2018-02-01 13:55:25.000000000","message":"doesnt this apply to the other threshold values as well?","commit_id":"ab477f1e140d25883fff8be190563e49b208ad57"}]}