)]}'
{"aodhclient/utils.py":[{"author":{"_account_id":27068,"name":"Trinh Nguyen","email":"dangtrinhnt@gmail.com","username":"dangtrinhnt"},"change_message_id":"580318a3aa41efe3deab080c538e46ec2551f6ad","unresolved":false,"context_lines":[{"line_number":130,"context_line":"                value \u003d None"},{"line_number":131,"context_line":"        else:"},{"line_number":132,"context_line":"            value \u003d getattr(parsed_args, attr)"},{"line_number":133,"context_line":"        if value is not None:"},{"line_number":134,"context_line":"            d[attr] \u003d value"},{"line_number":135,"context_line":"        if value \u003d\u003d [\"\"]:"},{"line_number":136,"context_line":"            d[attr] \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffb9cba7_d8d90b57","line":133,"range":{"start_line":133,"start_character":11,"end_line":133,"end_character":28},"updated":"2019-05-01 07:39:08.000000000","message":"If value is an empty string, this is still true.","commit_id":"dc10b228e5105113bec4c5eb745cf4d9929ff2e8"},{"author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"change_message_id":"9261998367ee9b6331c2c222f0eebc9c6e458ec6","unresolved":false,"context_lines":[{"line_number":130,"context_line":"                value \u003d None"},{"line_number":131,"context_line":"        else:"},{"line_number":132,"context_line":"            value \u003d getattr(parsed_args, attr)"},{"line_number":133,"context_line":"        if value is not None:"},{"line_number":134,"context_line":"            d[attr] \u003d value"},{"line_number":135,"context_line":"        if value \u003d\u003d [\"\"]:"},{"line_number":136,"context_line":"            d[attr] \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfbec78f_2d287a32","line":133,"range":{"start_line":133,"start_character":11,"end_line":133,"end_character":28},"in_reply_to":"dfbec78f_9618df81","updated":"2019-05-09 03:48:06.000000000","message":"this will fail if value is False.\n\nI can nest this and make a note.","commit_id":"dc10b228e5105113bec4c5eb745cf4d9929ff2e8"},{"author":{"_account_id":27068,"name":"Trinh Nguyen","email":"dangtrinhnt@gmail.com","username":"dangtrinhnt"},"change_message_id":"2472930d6b639047beae182a8a4f5a06181e3a0b","unresolved":false,"context_lines":[{"line_number":130,"context_line":"                value \u003d None"},{"line_number":131,"context_line":"        else:"},{"line_number":132,"context_line":"            value \u003d getattr(parsed_args, attr)"},{"line_number":133,"context_line":"        if value is not None:"},{"line_number":134,"context_line":"            d[attr] \u003d value"},{"line_number":135,"context_line":"        if value \u003d\u003d [\"\"]:"},{"line_number":136,"context_line":"            d[attr] \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfbec78f_9618df81","line":133,"range":{"start_line":133,"start_character":11,"end_line":133,"end_character":28},"in_reply_to":"ffb9cba7_b34eb86c","updated":"2019-05-08 02:58:46.000000000","message":"I don\u0027t like the fact that the value will be assigned twice (overwritten). If you want to catch the empty case, why not change this to:\n\n`if value:`\n\nand then you can catch the empty case below.","commit_id":"dc10b228e5105113bec4c5eb745cf4d9929ff2e8"},{"author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"change_message_id":"a13580f36498661ced6e64e60e90a53db1adae68","unresolved":false,"context_lines":[{"line_number":130,"context_line":"                value \u003d None"},{"line_number":131,"context_line":"        else:"},{"line_number":132,"context_line":"            value \u003d getattr(parsed_args, attr)"},{"line_number":133,"context_line":"        if value is not None:"},{"line_number":134,"context_line":"            d[attr] \u003d value"},{"line_number":135,"context_line":"        if value \u003d\u003d [\"\"]:"},{"line_number":136,"context_line":"            d[attr] \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffb9cba7_b34eb86c","line":133,"range":{"start_line":133,"start_character":11,"end_line":133,"end_character":28},"in_reply_to":"ffb9cba7_d8d90b57","updated":"2019-05-01 10:29:28.000000000","message":"yes but it\u0027ll be overwritten by the code below","commit_id":"dc10b228e5105113bec4c5eb745cf4d9929ff2e8"},{"author":{"_account_id":27068,"name":"Trinh Nguyen","email":"dangtrinhnt@gmail.com","username":"dangtrinhnt"},"change_message_id":"580318a3aa41efe3deab080c538e46ec2551f6ad","unresolved":false,"context_lines":[{"line_number":132,"context_line":"            value \u003d getattr(parsed_args, attr)"},{"line_number":133,"context_line":"        if value is not None:"},{"line_number":134,"context_line":"            d[attr] \u003d value"},{"line_number":135,"context_line":"        if value \u003d\u003d [\"\"]:"},{"line_number":136,"context_line":"            d[attr] \u003d None"},{"line_number":137,"context_line":"    return d"},{"line_number":138,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ffb9cba7_78da5f4b","line":135,"range":{"start_line":135,"start_character":20,"end_line":135,"end_character":24},"updated":"2019-05-01 07:39:08.000000000","message":"Is \"value\" an array?","commit_id":"dc10b228e5105113bec4c5eb745cf4d9929ff2e8"},{"author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"change_message_id":"a13580f36498661ced6e64e60e90a53db1adae68","unresolved":false,"context_lines":[{"line_number":132,"context_line":"            value \u003d getattr(parsed_args, attr)"},{"line_number":133,"context_line":"        if value is not None:"},{"line_number":134,"context_line":"            d[attr] \u003d value"},{"line_number":135,"context_line":"        if value \u003d\u003d [\"\"]:"},{"line_number":136,"context_line":"            d[attr] \u003d None"},{"line_number":137,"context_line":"    return d"},{"line_number":138,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ffb9cba7_f347504b","line":135,"range":{"start_line":135,"start_character":20,"end_line":135,"end_character":24},"in_reply_to":"ffb9cba7_78da5f4b","updated":"2019-05-01 10:29:28.000000000","message":"value is an array for options --alarm-actions, --ok-actions etc, because they have action\u003d\u0027append\u0027 in\n\nhttps://opendev.org/openstack/python-aodhclient/src/branch/stable/stein/aodhclient/v2/alarm_cli.py#L231","commit_id":"dc10b228e5105113bec4c5eb745cf4d9929ff2e8"},{"author":{"_account_id":27068,"name":"Trinh Nguyen","email":"dangtrinhnt@gmail.com","username":"dangtrinhnt"},"change_message_id":"2472930d6b639047beae182a8a4f5a06181e3a0b","unresolved":false,"context_lines":[{"line_number":132,"context_line":"            value \u003d getattr(parsed_args, attr)"},{"line_number":133,"context_line":"        if value is not None:"},{"line_number":134,"context_line":"            d[attr] \u003d value"},{"line_number":135,"context_line":"        if value \u003d\u003d [\"\"]:"},{"line_number":136,"context_line":"            d[attr] \u003d None"},{"line_number":137,"context_line":"    return d"},{"line_number":138,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dfbec78f_490e143c","line":135,"range":{"start_line":135,"start_character":20,"end_line":135,"end_character":24},"in_reply_to":"ffb9cba7_f347504b","updated":"2019-05-08 02:58:46.000000000","message":"ok","commit_id":"dc10b228e5105113bec4c5eb745cf4d9929ff2e8"}]}