)]}'
{"id":"openstack%2Fpython-aodhclient~747722","triplet_id":"openstack%2Fpython-aodhclient~master~Ia46259e960493c92a6701a165518ef87b03c5c2d","project":"openstack/python-aodhclient","branch":"master","hashtags":[],"change_id":"Ia46259e960493c92a6701a165518ef87b03c5c2d","subject":"Don\u0027t use */* in accept header","status":"MERGED","created":"2020-08-24 13:03:24.000000000","updated":"2020-08-30 04:19:56.000000000","submitted":"2020-08-29 08:11:48.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"747722-1598688708618-f63fd487","meta_rev_id":"bb32a5030d25540d710481bd1f2261fb91582d16","_number":747722,"virtual_id_number":747722,"owner":{"_account_id":5792,"name":"Dan Radez","email":"dradez@redhat.com","username":"dradez"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-08-29 08:11:48.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":14107,"name":"zhurong","email":"aaronzhu1121@gmail.com","username":"zhurong"},{"value":0,"date":"2020-08-26 15:02:38.000000000","_account_id":5792,"name":"Dan Radez","email":"dradez@redhat.com","username":"dradez"},{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"date":"2020-08-24 13:34:24.000000000","_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"all":[{"value":2,"date":"2020-08-26 20:59:29.000000000","_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2020-08-29 07:59:14.000000000","_account_id":14107,"name":"zhurong","email":"aaronzhu1121@gmail.com","username":"zhurong"},{"value":0,"_account_id":5792,"name":"Dan Radez","email":"dradez@redhat.com","username":"dradez"},{"value":1,"date":"2020-08-26 20:39:48.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":14107,"name":"zhurong","email":"aaronzhu1121@gmail.com","username":"zhurong"},"all":[{"value":0,"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2020-08-29 07:59:14.000000000","_account_id":14107,"name":"zhurong","email":"aaronzhu1121@gmail.com","username":"zhurong"},{"value":0,"_account_id":5792,"name":"Dan Radez","email":"dradez@redhat.com","username":"dradez"},{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":5792,"name":"Dan Radez","email":"dradez@redhat.com","username":"dradez"},{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":14107,"name":"zhurong","email":"aaronzhu1121@gmail.com","username":"zhurong"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-08-24 13:34:24.000000000","updated_by":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"reviewer":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"state":"REVIEWER"},{"updated":"2020-08-26 20:39:48.000000000","updated_by":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"reviewer":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"state":"REVIEWER"},{"updated":"2020-08-26 20:59:29.000000000","updated_by":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"reviewer":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"state":"REVIEWER"},{"updated":"2020-08-29 07:59:14.000000000","updated_by":{"_account_id":14107,"name":"zhurong","email":"aaronzhu1121@gmail.com","username":"zhurong"},"reviewer":{"_account_id":14107,"name":"zhurong","email":"aaronzhu1121@gmail.com","username":"zhurong"},"state":"REVIEWER"},{"updated":"2020-08-29 08:11:48.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"d50e05927e09decfeef086b56558f083096f7510","author":{"_account_id":5792,"name":"Dan Radez","email":"dradez@redhat.com","username":"dradez"},"date":"2020-08-24 13:03:24.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"837fe3f6abee152f8843dbe28337395db963dc95","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-24 13:22:24.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/862de44636874f32af02913e0ac3b718 : SUCCESS in 5m 08s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/5883c197f746479ea0fed9fcff059466 : SUCCESS in 9m 08s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/da54d513d8d34787adc6e29ee98045d2 : SUCCESS in 8m 58s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/1634c0f0eefa429d94a8c0c2a7b10682 : SUCCESS in 8m 43s\n- openstackclient-check-plugins https://zuul.opendev.org/t/openstack/build/5ae3018ee04240a4a09cc897e1358c4f : SUCCESS in 7m 10s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"da9d2b40f53b65b40c9ee2cdc986e3da1c77ed8f","author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"date":"2020-08-24 13:34:24.000000000","message":"Patch Set 1:\n\nDid you check for DELETE REST API calls. It probably won\u0027t work like gnocchiclient.","accounts_in_message":[],"_revision_number":1},{"id":"998d6c25cb0e4ae75741cdf89a22009389a28723","author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"date":"2020-08-25 08:43:20.000000000","message":"Patch Set 1:\n\nHi Dan, could you please explain more about what potential issues may be caused by\u0027*/*\u0027?","accounts_in_message":[],"_revision_number":1},{"id":"6b77812dfdd99499295f78ac7b12bd94ad67f777","author":{"_account_id":5792,"name":"Dan Radez","email":"dradez@redhat.com","username":"dradez"},"date":"2020-08-26 15:02:38.000000000","message":"Patch Set 1:\n\nThere\u0027s an update to pecan we\u0027re trying to put into Openstack for neutron that is stricter on how accept headers are handled.","accounts_in_message":[],"_revision_number":1},{"id":"d507c14e7c66aee56428a437ba02d44cb8f3c42d","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2020-08-26 20:39:48.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"58afd28a475483e248746e9f23f2679bffe4c6f0","author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"date":"2020-08-26 20:59:29.000000000","message":"Patch Set 1: Code-Review+2\n\n\u003e There\u0027s an update to pecan we\u0027re trying to put into Openstack for\n \u003e neutron that is stricter on how accept headers are handled.\n\nThanks for the info.","accounts_in_message":[],"_revision_number":1},{"id":"32ddd1bc6a42b65a257563ca8d572076ca8183a7","author":{"_account_id":14107,"name":"zhurong","email":"aaronzhu1121@gmail.com","username":"zhurong"},"date":"2020-08-29 07:59:14.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nthanks","accounts_in_message":[],"_revision_number":1},{"id":"e1de08428cd8791587884aee5d540cc4ad02c6de","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-29 07:59:25.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"7888cb4592322bd5b5c9aa21fda542b8c871ff18","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-29 08:11:48.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"b2cbd0b6bb23f67e4d06ec73cf25ae473c8cfac4","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-29 08:11:48.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/1bfa8f504b3847a9a0d85c23845c0311 : SUCCESS in 3m 08s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/33a6ed847a9f4546aa5ee215e1adadc2 : SUCCESS in 7m 28s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/94ec6c22f5e44030ad9ba200b5aca487 : SUCCESS in 7m 01s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/86ca35b7a1d940319d0965eaff78cc21 : SUCCESS in 3m 16s","accounts_in_message":[],"_revision_number":1},{"id":"8d65537aa743dffa832d53aaa2931dec0265f6ec","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-29 08:12:53.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/1e507828634a449789aaabe8cb3de5f9 : SUCCESS in 46s","accounts_in_message":[],"_revision_number":1},{"id":"bb32a5030d25540d710481bd1f2261fb91582d16","author":{"_account_id":19134,"name":"Eyal","email":"eyalb1@gmail.com","username":"eyalb"},"date":"2020-08-30 04:19:56.000000000","message":"Patch Set 1:\n\nplease don\u0027t release a new aodh client until the delete rest calls  are fixed. it will break vitrage gate jobs","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"dff4f153d442e442276eea0d82f87a5d4cb692fe","revisions":{"dff4f153d442e442276eea0d82f87a5d4cb692fe":{"kind":"REWORK","_number":1,"created":"2020-08-24 13:03:24.000000000","uploader":{"_account_id":5792,"name":"Dan Radez","email":"dradez@redhat.com","username":"dradez"},"ref":"refs/changes/22/747722/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-aodhclient","ref":"refs/changes/22/747722/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-aodhclient refs/changes/22/747722/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-aodhclient refs/changes/22/747722/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-aodhclient refs/changes/22/747722/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-aodhclient refs/changes/22/747722/1"}}},"commit":{"parents":[{"commit":"7153763b9e331fca1b38b51719fabd065785f78b","subject":"Remove translation sections from setup.cfg","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-aodhclient/commit/7153763b9e331fca1b38b51719fabd065785f78b"}]}],"author":{"name":"Dan Radez","email":"dradez@redhat.com","date":"2020-08-24 13:01:41.000000000","tz":-240},"committer":{"name":"Dan Radez","email":"dradez@redhat.com","date":"2020-08-24 13:03:24.000000000","tz":-240},"subject":"Don\u0027t use */* in accept header","message":"Don\u0027t use */* in accept header\n\nThe response is returned as text/plain in case of exception.\nPecan 1.4 uses accept header to decide the response content type.\n\nThis also affected gnocciclient and has been fixed there.\nhttps://github.com/gnocchixyz/python-gnocchiclient/pull/110\n\nChange-Id: Ia46259e960493c92a6701a165518ef87b03c5c2d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-aodhclient/commit/dff4f153d442e442276eea0d82f87a5d4cb692fe"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-aodhclient/commit/dff4f153d442e442276eea0d82f87a5d4cb692fe"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}