)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34975,"name":"Jaromír Wysoglad","email":"jwysogla@redhat.com","username":"jwysogla"},"change_message_id":"437810b81a193be92baa73cc8aa14b9f544ed766","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d9c195ce_31e2872b","updated":"2026-08-03 10:44:07.000000000","message":"I think this should be expanded to deprecating the whole threshold alarm type. Looking at the linked commit, it removed the whole threshold alarm type as stated in the commit message. So even without the `--period`, creating a threshold alarm still won\u0027t work.\n```\n$ openstack alarm create -t threshold --name testing --meter-name abc --threshold 123\nUnknown attribute for argument data: threshold_rule (HTTP 400) (Request-ID: req-8ae698b0-4889-4e0b-a13e-4d0b78c275f6)\n```\n\nWhat I think should be done is deprecating the whole threshold alarm type, which seems to be a leftover after the linked removal. So deprecate the `--statistics` and `--meter-name` options as well. I think we could add a deprecation notice when `-t threshold` is used as well, maybe we could use the _validate_args for that? https://opendev.org/openstack/python-aodhclient/src/branch/master/aodhclient/v2/alarm_cli.py#L395","commit_id":"f8bb8e028c1a35458c1306cc5ae3e43db068deee"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"4c5f634eecde0f5883e0aaa9d834fa0a968e85fe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"bf7f4afe_35446741","in_reply_to":"295d4c06_e1e419fd","updated":"2026-08-12 14:02:11.000000000","message":"Done","commit_id":"f8bb8e028c1a35458c1306cc5ae3e43db068deee"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d8f11bf52308802338b1d8e01c71f290f632de10","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"295d4c06_e1e419fd","in_reply_to":"d9c195ce_31e2872b","updated":"2026-08-03 11:00:48.000000000","message":"\u003e What I think should be done is deprecating the whole threshold alarm type\n\noh yes. That\u0027s a good point. I\u0027ll address that soon.\n\n\n\u003e I think we could add a deprecation notice when -t threshold is used as well\n\nI initially thought that but decided to avoid adding a message because potentially breaking tools which read command output. I\u0027ll check if there could be a better method","commit_id":"f8bb8e028c1a35458c1306cc5ae3e43db068deee"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"c6319892691cb7054f5e5a33ce01af081bf5102f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"f56b3d63_8c6c1b20","updated":"2026-08-13 03:54:26.000000000","message":"recheck","commit_id":"071f12ea8df03c62b7b4b262d152d08728a6a4ab"}],"aodhclient/v2/alarm_cli.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"66d73ff3862e3be442820425e696c62c164fcf42","unresolved":false,"context_lines":[{"line_number":311,"context_line":"            \u0027--statistic\u0027, metavar\u003d\u0027\u003cSTATISTIC\u003e\u0027, dest\u003d\u0027statistic\u0027,"},{"line_number":312,"context_line":"            choices\u003dSTATISTICS,"},{"line_number":313,"context_line":"            help\u003d\u0027(DEPRECATED) Statistic to evaluate, one of: %s\u0027 %"},{"line_number":314,"context_line":"                  str(STATISTICS))"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"        # For common Gnocchi threshold type alarm"},{"line_number":317,"context_line":"        gnocchi_common_group \u003d parser.add_argument_group("}],"source_content_type":"text/x-python","patch_set":5,"id":"1e973554_985679a6","line":314,"updated":"2026-08-12 16:48:33.000000000","message":"pep8: E131 continuation line unaligned for hanging indent","commit_id":"41e7c8122987cb310d1d4a550c85475a66912da5"}]}
