)]}'
{"barbicanclient/barbican.py":[{"author":{"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"},"change_message_id":"457343d76eedb45086cc580c1139607b91b7e780","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    def __init__(self, **kwargs):"},{"line_number":36,"context_line":"        super(Barbican, self).__init__("},{"line_number":37,"context_line":"            description\u003d__doc__.strip(),"},{"line_number":38,"context_line":"            version\u003d\u00270.1\u0027,"},{"line_number":39,"context_line":"            command_manager\u003dcliff.commandmanager.CommandManager("},{"line_number":40,"context_line":"                \u0027barbican.client\u0027),"},{"line_number":41,"context_line":"            **kwargs"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_6839b6a2","line":38,"updated":"2014-07-17 13:55:57.000000000","message":"Eventually we probably should get this from pbr, but ok for now.","commit_id":"97d786e1f4f734866569c17e959cf535b33f1a28"},{"author":{"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"},"change_message_id":"457343d76eedb45086cc580c1139607b91b7e780","unresolved":false,"context_lines":[{"line_number":203,"context_line":"    supported_entity_handlers \u003d {"},{"line_number":204,"context_line":"        \"order\": entity_handlers.OrderHandler,"},{"line_number":205,"context_line":"        \"secret\": entity_handlers.SecretHandler,"},{"line_number":206,"context_line":"        \"verification\": entity_handlers.VerificationsHandler,"},{"line_number":207,"context_line":"    }"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    def get_parser(self, prog_name):"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_08759a31","line":206,"updated":"2014-07-17 13:55:57.000000000","message":"Ugh, sorry Juan. That verification resource should be removed, but ok to do in another CR of course.","commit_id":"97d786e1f4f734866569c17e959cf535b33f1a28"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"91e3789d98dbc425ab6c0e2e02f8f0b780847910","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from barbicanclient.common import auth"},{"line_number":25,"context_line":"from barbicanclient import client"},{"line_number":26,"context_line":"from barbicanclient import version"},{"line_number":27,"context_line":"import cliff.app"},{"line_number":28,"context_line":"import cliff.command"},{"line_number":29,"context_line":"import cliff.commandmanager"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_1ac8a720","line":27,"updated":"2014-08-06 12:34:37.000000000","message":"cliff libraries should go before barbican and after stdlib.","commit_id":"5a06f0e13f59175c9158136a3b5a11fa03b24495"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"91e3789d98dbc425ab6c0e2e02f8f0b780847910","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from barbicanclient import client"},{"line_number":26,"context_line":"from barbicanclient import version"},{"line_number":27,"context_line":"import cliff.app"},{"line_number":28,"context_line":"import cliff.command"},{"line_number":29,"context_line":"import cliff.commandmanager"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_daf46f57","line":28,"updated":"2014-08-06 12:34:37.000000000","message":"if you did from cliff import command, you could just reference command instead of cliff.command at line 160 (and others)","commit_id":"5a06f0e13f59175c9158136a3b5a11fa03b24495"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"91e3789d98dbc425ab6c0e2e02f8f0b780847910","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        entity, len(obj_list), offset))"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"class CreateOrder(cliff.command.Command):"},{"line_number":161,"context_line":"    \"\"\"Create a new order.\"\"\""},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    def get_parser(self, prog_name):"}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_1a7a67f0","line":160,"updated":"2014-08-06 12:34:37.000000000","message":"I think you want to use cliff.show here:\nhttps://github.com/openstack/cliff/blob/master/cliff/show.py","commit_id":"5a06f0e13f59175c9158136a3b5a11fa03b24495"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"91e3789d98dbc425ab6c0e2e02f8f0b780847910","unresolved":false,"context_lines":[{"line_number":194,"context_line":"        self.app.stdout.write(str(entity) + \u0027\\n\u0027)"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"class DeleteOrder(cliff.command.Command):"},{"line_number":198,"context_line":"    \"\"\"Delete an order by providing its href.\"\"\""},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"    def get_parser(self, prog_name):"}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_1a198787","line":197,"updated":"2014-08-06 12:34:37.000000000","message":"I would probably put all the Order related content in it\u0027s own module, same with Secret, but I guess that\u0027s refactoring you may do later.","commit_id":"5a06f0e13f59175c9158136a3b5a11fa03b24495"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"91e3789d98dbc425ab6c0e2e02f8f0b780847910","unresolved":false,"context_lines":[{"line_number":206,"context_line":"        self.app.client.orders.delete(args.URI)"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"class GetOrder(cliff.command.Command):"},{"line_number":210,"context_line":"    \"\"\"Retrieve a order by providing its URI.\"\"\""},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"    def get_parser(self, prog_name):"}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_ba2a5b8f","line":209,"updated":"2014-08-06 12:34:37.000000000","message":"I think you want to use cliff.show here:\nhttps://github.com/openstack/cliff/blob/master/cliff/show.py","commit_id":"5a06f0e13f59175c9158136a3b5a11fa03b24495"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"91e3789d98dbc425ab6c0e2e02f8f0b780847910","unresolved":false,"context_lines":[{"line_number":219,"context_line":"        self.app.stdout.write(str(entity) + \u0027\\n\u0027)"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"class ListOrder(cliff.command.Command):"},{"line_number":223,"context_line":"    \"\"\"List orders.\"\"\""},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"    def get_parser(self, prog_name):"}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_7a07e31e","line":222,"updated":"2014-08-06 12:34:37.000000000","message":"You might be able to take advantage of lister\nhttps://github.com/openstack/cliff/blob/master/cliff/lister.py","commit_id":"5a06f0e13f59175c9158136a3b5a11fa03b24495"},{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"8b3480968d1a0e4c121da18d5e7a511b784d000d","unresolved":false,"context_lines":[{"line_number":38,"context_line":"            version\u003dversion.__version__,"},{"line_number":39,"context_line":"            command_manager\u003dcommandmanager.CommandManager("},{"line_number":40,"context_line":"                namespace\u003d\u0027barbican.client\u0027,"},{"line_number":41,"context_line":"                convert_underscores\u003dTrue),"},{"line_number":42,"context_line":"            **kwargs"},{"line_number":43,"context_line":"        )"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_fa7b97f1","line":41,"updated":"2014-08-08 17:23:53.000000000","message":"Could just say ommandmanager.CommandManager(\u0027barbican.client\u0027) here","commit_id":"b0db1c281ff03d736ce3d6791bafac0bffd1ef5a"},{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"8b3480968d1a0e4c121da18d5e7a511b784d000d","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                            help\u003d\u0027Defaults to env[OS_TENANT_NAME].\u0027)"},{"line_number":81,"context_line":"        parser.add_argument(\u0027--os-tenant-id\u0027, \u0027-I\u0027,"},{"line_number":82,"context_line":"                            metavar\u003d\u0027\u003ctenant-id\u003e\u0027,"},{"line_number":83,"context_line":"                            default\u003dclient.env(\u0027OS_TENANT_ID\u0027),"},{"line_number":84,"context_line":"                            help\u003d\u0027Defaults to env[OS_TENANT_ID].\u0027)"},{"line_number":85,"context_line":"        parser.add_argument(\u0027--os-project-id\u0027,"},{"line_number":86,"context_line":"                            metavar\u003d\u0027\u003cauth-project-id\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_da2ed3aa","line":83,"updated":"2014-08-08 17:23:53.000000000","message":"Unrelated, but might want this for tenant stuff:\n\n    help\u003dargparse.SUPPRESS,","commit_id":"b0db1c281ff03d736ce3d6791bafac0bffd1ef5a"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"147fbde8f1622ae28bc1f1c4993de4343e386b64","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                            help\u003d\u0027Defaults to env[OS_TENANT_NAME].\u0027)"},{"line_number":81,"context_line":"        parser.add_argument(\u0027--os-tenant-id\u0027, \u0027-I\u0027,"},{"line_number":82,"context_line":"                            metavar\u003d\u0027\u003ctenant-id\u003e\u0027,"},{"line_number":83,"context_line":"                            default\u003dclient.env(\u0027OS_TENANT_ID\u0027),"},{"line_number":84,"context_line":"                            help\u003d\u0027Defaults to env[OS_TENANT_ID].\u0027)"},{"line_number":85,"context_line":"        parser.add_argument(\u0027--os-project-id\u0027,"},{"line_number":86,"context_line":"                            metavar\u003d\u0027\u003cauth-project-id\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_1362e2a6","line":83,"in_reply_to":"baada198_da2ed3aa","updated":"2014-08-09 11:54:50.000000000","message":"We can leave this for a subsequent commit.","commit_id":"b0db1c281ff03d736ce3d6791bafac0bffd1ef5a"},{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"8b3480968d1a0e4c121da18d5e7a511b784d000d","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        return parser"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    def _assert_no_auth_and_auth_url_mutually_exclusive(self, no_auth,"},{"line_number":122,"context_line":"                                                        auth_url):"},{"line_number":123,"context_line":"        if no_auth and auth_url:"},{"line_number":124,"context_line":"            raise Exception(\"ERROR: argument --os-auth-url/-A: not allowed \""},{"line_number":125,"context_line":"                            \"with argument --no-auth/-N\")"}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_9d445549","line":122,"updated":"2014-08-08 17:23:53.000000000","message":"I\u0027m not sure how this would work with --os-auth-url since it has an argument, but you could make these two args a group:\n\n    auth_group \u003d parser.add_mutually_exclusive_group()\n    auth_group.add_argument(...","commit_id":"b0db1c281ff03d736ce3d6791bafac0bffd1ef5a"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"147fbde8f1622ae28bc1f1c4993de4343e386b64","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        return parser"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    def _assert_no_auth_and_auth_url_mutually_exclusive(self, no_auth,"},{"line_number":122,"context_line":"                                                        auth_url):"},{"line_number":123,"context_line":"        if no_auth and auth_url:"},{"line_number":124,"context_line":"            raise Exception(\"ERROR: argument --os-auth-url/-A: not allowed \""},{"line_number":125,"context_line":"                            \"with argument --no-auth/-N\")"}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_5307fac8","line":122,"in_reply_to":"baada198_9d445549","updated":"2014-08-09 11:54:50.000000000","message":"I indeed tried this but as much as I tried, I couldn\u0027t get mutually exclusive groups to get the error message into the same stderr output as does cliff, it seems it takes another one... so I couldn\u0027t properly write tests, thus I ended up doing it like this.","commit_id":"b0db1c281ff03d736ce3d6791bafac0bffd1ef5a"}],"barbicanclient/barbican_cli/orders.py":[{"author":{"_account_id":7262,"name":"John Vrbanac","email":"john.vrbanac@linux.com","username":"john.vrbanac"},"change_message_id":"6e6a11e58385997f79a39b2063f9629f338ef0ec","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def get_parser(self, prog_name):"},{"line_number":82,"context_line":"        parser \u003d super(DeleteOrder, self).get_parser(prog_name)"},{"line_number":83,"context_line":"        parser.add_argument(\u0027URI\u0027, help\u003d\u0027The URI reference for the order\u0027)"},{"line_number":84,"context_line":"        return parser"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def take_action(self, args):"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_fc9be8c5","line":83,"updated":"2014-08-06 16:04:26.000000000","message":"I know the naming is a direct port from the old client, so this isn\u0027t a blocking issue, but I think we should probably rename this to order_ref, href, or something more inline with the API.","commit_id":"101f2c2f6991adf9fc740103121a5a52685d5ef0"},{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"8b3480968d1a0e4c121da18d5e7a511b784d000d","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        parser \u003d super(CreateOrder, self).get_parser(prog_name)"},{"line_number":46,"context_line":"        parser.add_argument(\u0027--name\u0027, \u0027-n\u0027,"},{"line_number":47,"context_line":"                            help\u003d\u0027a human-friendly name.\u0027)"},{"line_number":48,"context_line":"        parser.add_argument(\u0027--algorithm\u0027, \u0027-a\u0027, default\u003d\u0027aes\u0027,"},{"line_number":49,"context_line":"                            help\u003d\u0027the algorithm to be used with the \u0027"},{"line_number":50,"context_line":"                                 \u0027requested key (default: \u0027"},{"line_number":51,"context_line":"                                 \u0027%(default)s).\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_2eb3110a","line":48,"updated":"2014-08-08 17:23:53.000000000","message":"If this is a well known set maybe use choices\u003d[\u0027aes\u0027, ...],","commit_id":"b0db1c281ff03d736ce3d6791bafac0bffd1ef5a"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"147fbde8f1622ae28bc1f1c4993de4343e386b64","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        parser \u003d super(CreateOrder, self).get_parser(prog_name)"},{"line_number":46,"context_line":"        parser.add_argument(\u0027--name\u0027, \u0027-n\u0027,"},{"line_number":47,"context_line":"                            help\u003d\u0027a human-friendly name.\u0027)"},{"line_number":48,"context_line":"        parser.add_argument(\u0027--algorithm\u0027, \u0027-a\u0027, default\u003d\u0027aes\u0027,"},{"line_number":49,"context_line":"                            help\u003d\u0027the algorithm to be used with the \u0027"},{"line_number":50,"context_line":"                                 \u0027requested key (default: \u0027"},{"line_number":51,"context_line":"                                 \u0027%(default)s).\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_73087ed8","line":48,"in_reply_to":"baada198_2eb3110a","updated":"2014-08-09 11:54:50.000000000","message":"Well, the point was to have the functionality as it was before, I think that should go to a subsequent commit.","commit_id":"b0db1c281ff03d736ce3d6791bafac0bffd1ef5a"},{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"8b3480968d1a0e4c121da18d5e7a511b784d000d","unresolved":false,"context_lines":[{"line_number":49,"context_line":"                            help\u003d\u0027the algorithm to be used with the \u0027"},{"line_number":50,"context_line":"                                 \u0027requested key (default: \u0027"},{"line_number":51,"context_line":"                                 \u0027%(default)s).\u0027)"},{"line_number":52,"context_line":"        parser.add_argument(\u0027--bit-length\u0027, \u0027-b\u0027, default\u003d256,"},{"line_number":53,"context_line":"                            help\u003d\u0027the bit length of the requested\u0027"},{"line_number":54,"context_line":"                                 \u0027 secret key (default: %(default)s).\u0027,"},{"line_number":55,"context_line":"                            type\u003dint)"}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_aebe41cc","line":52,"updated":"2014-08-08 17:23:53.000000000","message":"Perhaps \"type\u003dint,\" for this","commit_id":"b0db1c281ff03d736ce3d6791bafac0bffd1ef5a"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"147fbde8f1622ae28bc1f1c4993de4343e386b64","unresolved":false,"context_lines":[{"line_number":49,"context_line":"                            help\u003d\u0027the algorithm to be used with the \u0027"},{"line_number":50,"context_line":"                                 \u0027requested key (default: \u0027"},{"line_number":51,"context_line":"                                 \u0027%(default)s).\u0027)"},{"line_number":52,"context_line":"        parser.add_argument(\u0027--bit-length\u0027, \u0027-b\u0027, default\u003d256,"},{"line_number":53,"context_line":"                            help\u003d\u0027the bit length of the requested\u0027"},{"line_number":54,"context_line":"                                 \u0027 secret key (default: %(default)s).\u0027,"},{"line_number":55,"context_line":"                            type\u003dint)"}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_930d12ea","line":52,"in_reply_to":"baada198_aebe41cc","updated":"2014-08-09 11:54:50.000000000","message":"there is already type\u003dint, see three lines below :)","commit_id":"b0db1c281ff03d736ce3d6791bafac0bffd1ef5a"},{"author":{"_account_id":9234,"name":"Steve Heyman","email":"steve@heyman.com","username":"hockeynut"},"change_message_id":"28d4141a496f507b0b5c95fba490c5a8aa6c2267","unresolved":false,"context_lines":[{"line_number":61,"context_line":"                            help\u003d\u0027the type/format of the secret to be\u0027"},{"line_number":62,"context_line":"                                 \u0027 generated (default: %(default)s).\u0027)"},{"line_number":63,"context_line":"        parser.add_argument(\u0027--expiration\u0027, \u0027-x\u0027,"},{"line_number":64,"context_line":"                            help\u003d\u0027the expiration \u0027"},{"line_number":65,"context_line":"                                 \u0027time for the secret in ISO 8601 format.\u0027)"},{"line_number":66,"context_line":"        return parser"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_74479da4","line":64,"updated":"2014-08-08 15:29:59.000000000","message":"default?  if none then we should say so in the help","commit_id":"b0db1c281ff03d736ce3d6791bafac0bffd1ef5a"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"b19b03a70ee5e79bd9be5aba4cdab04f88c44f27","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"class DeleteOrder(command.Command):"},{"line_number":79,"context_line":"    \"\"\"Delete an order by providing its href.\"\"\""},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def get_parser(self, prog_name):"},{"line_number":82,"context_line":"        parser \u003d super(DeleteOrder, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_ebbf79c8","line":79,"updated":"2014-08-07 15:49:21.000000000","message":"you mention href here, but use URI. i think you are swapping between the two terms, i suggest sticking to one of them","commit_id":"b0db1c281ff03d736ce3d6791bafac0bffd1ef5a"},{"author":{"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"},"change_message_id":"080ef2d093142a8e4418655dd9e684cc33eb7c3d","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"class DeleteOrder(command.Command):"},{"line_number":79,"context_line":"    \"\"\"Delete an order by providing its href.\"\"\""},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def get_parser(self, prog_name):"},{"line_number":82,"context_line":"        parser \u003d super(DeleteOrder, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_3a826fc7","line":79,"in_reply_to":"baada198_ebbf79c8","updated":"2014-08-08 16:41:53.000000000","message":"I think we\u0027ve \u0027standardized\u0027 (a bit loosely unfortunately) on using hrefs instead of just URIs.","commit_id":"b0db1c281ff03d736ce3d6791bafac0bffd1ef5a"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"b19b03a70ee5e79bd9be5aba4cdab04f88c44f27","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"class GetOrder(show.ShowOne, OrderFormatter):"},{"line_number":91,"context_line":"    \"\"\"Retrieve a order by providing its URI.\"\"\""},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def get_parser(self, prog_name):"},{"line_number":94,"context_line":"        parser \u003d super(GetOrder, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_0bb74df9","line":91,"updated":"2014-08-07 15:49:21.000000000","message":"an*","commit_id":"b0db1c281ff03d736ce3d6791bafac0bffd1ef5a"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"147fbde8f1622ae28bc1f1c4993de4343e386b64","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"class GetOrder(show.ShowOne, OrderFormatter):"},{"line_number":91,"context_line":"    \"\"\"Retrieve a order by providing its URI.\"\"\""},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def get_parser(self, prog_name):"},{"line_number":94,"context_line":"        parser \u003d super(GetOrder, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_b3f5b6cd","line":91,"in_reply_to":"baada198_0bb74df9","updated":"2014-08-09 11:54:50.000000000","message":"Done","commit_id":"b0db1c281ff03d736ce3d6791bafac0bffd1ef5a"},{"author":{"_account_id":9234,"name":"Steve Heyman","email":"steve@heyman.com","username":"hockeynut"},"change_message_id":"28d4141a496f507b0b5c95fba490c5a8aa6c2267","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        return self._get_formatted_entity(entity)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"class ListOrder(lister.Lister, OrderFormatter):"},{"line_number":104,"context_line":"    \"\"\"List orders.\"\"\""},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    def get_parser(self, prog_name):"}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_b42855ef","line":103,"updated":"2014-08-08 15:29:59.000000000","message":"should we make this plural?  ListOrder seems to imply only 1","commit_id":"b0db1c281ff03d736ce3d6791bafac0bffd1ef5a"},{"author":{"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"},"change_message_id":"080ef2d093142a8e4418655dd9e684cc33eb7c3d","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        return self._get_formatted_entity(entity)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"class ListOrder(lister.Lister, OrderFormatter):"},{"line_number":104,"context_line":"    \"\"\"List orders.\"\"\""},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    def get_parser(self, prog_name):"}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_dac41310","line":103,"in_reply_to":"baada198_b42855ef","updated":"2014-08-08 16:41:53.000000000","message":"I think ListOrders would be more accurate.","commit_id":"b0db1c281ff03d736ce3d6791bafac0bffd1ef5a"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"147fbde8f1622ae28bc1f1c4993de4343e386b64","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        return self._get_formatted_entity(entity)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"class ListOrder(lister.Lister, OrderFormatter):"},{"line_number":104,"context_line":"    \"\"\"List orders.\"\"\""},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    def get_parser(self, prog_name):"}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_d3f22ae2","line":103,"in_reply_to":"baada198_dac41310","updated":"2014-08-09 11:54:50.000000000","message":"I thought the same thing, but I got the naming as python-openstack client does.","commit_id":"b0db1c281ff03d736ce3d6791bafac0bffd1ef5a"},{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"8b3480968d1a0e4c121da18d5e7a511b784d000d","unresolved":false,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    def get_parser(self, prog_name):"},{"line_number":107,"context_line":"        parser \u003d super(ListOrder, self).get_parser(prog_name)"},{"line_number":108,"context_line":"        parser.add_argument(\u0027--limit\u0027, \u0027-l\u0027, default\u003d10,"},{"line_number":109,"context_line":"                            help\u003d\u0027specify the limit to the number of items \u0027"},{"line_number":110,"context_line":"                                 \u0027to list per page (default: %(default)s; \u0027"},{"line_number":111,"context_line":"                                 \u0027maximum: 100)\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_ce85350b","line":108,"updated":"2014-08-08 17:23:53.000000000","message":"Somehting like:\n\n    type\u003dint, choices\u003drange(5, 100))","commit_id":"b0db1c281ff03d736ce3d6791bafac0bffd1ef5a"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"147fbde8f1622ae28bc1f1c4993de4343e386b64","unresolved":false,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    def get_parser(self, prog_name):"},{"line_number":107,"context_line":"        parser \u003d super(ListOrder, self).get_parser(prog_name)"},{"line_number":108,"context_line":"        parser.add_argument(\u0027--limit\u0027, \u0027-l\u0027, default\u003d10,"},{"line_number":109,"context_line":"                            help\u003d\u0027specify the limit to the number of items \u0027"},{"line_number":110,"context_line":"                                 \u0027to list per page (default: %(default)s; \u0027"},{"line_number":111,"context_line":"                                 \u0027maximum: 100)\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_f3fbaebc","line":108,"in_reply_to":"baada198_ce85350b","updated":"2014-08-09 11:54:50.000000000","message":"there is already type int, but the choice range would be really good, unfortunately, it looks pretty bad when you try to get the help off it. Any suggestions on fixing that?","commit_id":"b0db1c281ff03d736ce3d6791bafac0bffd1ef5a"},{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"8b3480968d1a0e4c121da18d5e7a511b784d000d","unresolved":false,"context_lines":[{"line_number":110,"context_line":"                                 \u0027to list per page (default: %(default)s; \u0027"},{"line_number":111,"context_line":"                                 \u0027maximum: 100)\u0027,"},{"line_number":112,"context_line":"                            type\u003dint)"},{"line_number":113,"context_line":"        parser.add_argument(\u0027--offset\u0027, \u0027-o\u0027, default\u003d0,"},{"line_number":114,"context_line":"                            help\u003d\u0027specify the page offset \u0027"},{"line_number":115,"context_line":"                                 \u0027(default: %(default)s)\u0027,"},{"line_number":116,"context_line":"                            type\u003dint)"}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_2e8151fa","line":113,"updated":"2014-08-08 17:23:53.000000000","message":"type\u003dint,","commit_id":"b0db1c281ff03d736ce3d6791bafac0bffd1ef5a"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"147fbde8f1622ae28bc1f1c4993de4343e386b64","unresolved":false,"context_lines":[{"line_number":110,"context_line":"                                 \u0027to list per page (default: %(default)s; \u0027"},{"line_number":111,"context_line":"                                 \u0027maximum: 100)\u0027,"},{"line_number":112,"context_line":"                            type\u003dint)"},{"line_number":113,"context_line":"        parser.add_argument(\u0027--offset\u0027, \u0027-o\u0027, default\u003d0,"},{"line_number":114,"context_line":"                            help\u003d\u0027specify the page offset \u0027"},{"line_number":115,"context_line":"                                 \u0027(default: %(default)s)\u0027,"},{"line_number":116,"context_line":"                            type\u003dint)"}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_3329a63a","line":113,"in_reply_to":"baada198_2e8151fa","updated":"2014-08-09 11:54:50.000000000","message":"it\u0027s 3 lines below this.","commit_id":"b0db1c281ff03d736ce3d6791bafac0bffd1ef5a"}],"barbicanclient/barbican_cli/secrets.py":[{"author":{"_account_id":9234,"name":"Steve Heyman","email":"steve@heyman.com","username":"hockeynut"},"change_message_id":"28d4141a496f507b0b5c95fba490c5a8aa6c2267","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"class DeleteSecret(command.Command):"},{"line_number":52,"context_line":"    \"\"\"Delete an secret by providing its href.\"\"\""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def get_parser(self, prog_name):"},{"line_number":55,"context_line":"        parser \u003d super(DeleteSecret, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_b4da151b","line":52,"updated":"2014-08-08 15:29:59.000000000","message":"as \"other Steve\" commented it would be good for us to be consistent with uri or href.  That applies beyond just this CR but we can set a good example here :-)","commit_id":"b0db1c281ff03d736ce3d6791bafac0bffd1ef5a"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"147fbde8f1622ae28bc1f1c4993de4343e386b64","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"class DeleteSecret(command.Command):"},{"line_number":52,"context_line":"    \"\"\"Delete an secret by providing its href.\"\"\""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def get_parser(self, prog_name):"},{"line_number":55,"context_line":"        parser \u003d super(DeleteSecret, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_532e1a43","line":52,"in_reply_to":"baada198_b4da151b","updated":"2014-08-09 11:54:50.000000000","message":"I would really prefer we do this in a separate CR.","commit_id":"b0db1c281ff03d736ce3d6791bafac0bffd1ef5a"},{"author":{"_account_id":9234,"name":"Steve Heyman","email":"steve@heyman.com","username":"hockeynut"},"change_message_id":"28d4141a496f507b0b5c95fba490c5a8aa6c2267","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        parser \u003d super(GetSecret, self).get_parser(prog_name)"},{"line_number":68,"context_line":"        parser.add_argument(\u0027URI\u0027, help\u003d\u0027The URI reference for the secret.\u0027)"},{"line_number":69,"context_line":"        parser.add_argument(\u0027--decrypt\u0027, \u0027-d\u0027,"},{"line_number":70,"context_line":"                            help\u003d\u0027if specified, keep will retrieve the \u0027"},{"line_number":71,"context_line":"                                 \u0027unencrypted secret data; \u0027"},{"line_number":72,"context_line":"                                 \u0027the data type can be specified with \u0027"},{"line_number":73,"context_line":"                                 \u0027--payload-content-type.\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_74d4fde9","line":70,"updated":"2014-08-08 15:29:59.000000000","message":"are we using keep. or should we say Barbican?","commit_id":"b0db1c281ff03d736ce3d6791bafac0bffd1ef5a"},{"author":{"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"},"change_message_id":"080ef2d093142a8e4418655dd9e684cc33eb7c3d","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        parser \u003d super(GetSecret, self).get_parser(prog_name)"},{"line_number":68,"context_line":"        parser.add_argument(\u0027URI\u0027, help\u003d\u0027The URI reference for the secret.\u0027)"},{"line_number":69,"context_line":"        parser.add_argument(\u0027--decrypt\u0027, \u0027-d\u0027,"},{"line_number":70,"context_line":"                            help\u003d\u0027if specified, keep will retrieve the \u0027"},{"line_number":71,"context_line":"                                 \u0027unencrypted secret data; \u0027"},{"line_number":72,"context_line":"                                 \u0027the data type can be specified with \u0027"},{"line_number":73,"context_line":"                                 \u0027--payload-content-type.\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_badbdfe8","line":70,"in_reply_to":"baada198_74d4fde9","updated":"2014-08-08 16:41:53.000000000","message":"How about just: \"If specified, retrieve the unencrypted secret data; ...\"","commit_id":"b0db1c281ff03d736ce3d6791bafac0bffd1ef5a"},{"author":{"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"},"change_message_id":"080ef2d093142a8e4418655dd9e684cc33eb7c3d","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        parser.add_argument(\u0027--decrypt\u0027, \u0027-d\u0027,"},{"line_number":70,"context_line":"                            help\u003d\u0027if specified, keep will retrieve the \u0027"},{"line_number":71,"context_line":"                                 \u0027unencrypted secret data; \u0027"},{"line_number":72,"context_line":"                                 \u0027the data type can be specified with \u0027"},{"line_number":73,"context_line":"                                 \u0027--payload-content-type.\u0027,"},{"line_number":74,"context_line":"                            action\u003d\u0027store_true\u0027)"},{"line_number":75,"context_line":"        parser.add_argument(\u0027--payload_content_type\u0027, \u0027-t\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_3a6c2f07","line":72,"updated":"2014-08-08 16:41:53.000000000","message":"Hmmm....just noting that we aren\u0027t using I18n conventions (i.e. that _ prefix) for help strings. Not part of this CR, but something we should address in a future CR for sure.","commit_id":"b0db1c281ff03d736ce3d6791bafac0bffd1ef5a"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"147fbde8f1622ae28bc1f1c4993de4343e386b64","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        parser.add_argument(\u0027--decrypt\u0027, \u0027-d\u0027,"},{"line_number":70,"context_line":"                            help\u003d\u0027if specified, keep will retrieve the \u0027"},{"line_number":71,"context_line":"                                 \u0027unencrypted secret data; \u0027"},{"line_number":72,"context_line":"                                 \u0027the data type can be specified with \u0027"},{"line_number":73,"context_line":"                                 \u0027--payload-content-type.\u0027,"},{"line_number":74,"context_line":"                            action\u003d\u0027store_true\u0027)"},{"line_number":75,"context_line":"        parser.add_argument(\u0027--payload_content_type\u0027, \u0027-t\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_731f9e0b","line":72,"in_reply_to":"baada198_3a6c2f07","updated":"2014-08-09 11:54:50.000000000","message":"sure :)","commit_id":"b0db1c281ff03d736ce3d6791bafac0bffd1ef5a"},{"author":{"_account_id":9234,"name":"Steve Heyman","email":"steve@heyman.com","username":"hockeynut"},"change_message_id":"28d4141a496f507b0b5c95fba490c5a8aa6c2267","unresolved":false,"context_lines":[{"line_number":89,"context_line":"            return self._get_formatted_entity(entity)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"class ListSecret(lister.Lister, SecretFormatter):"},{"line_number":93,"context_line":"    \"\"\"List secrets.\"\"\""},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def get_parser(self, prog_name):"}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_d42dc9fe","line":92,"updated":"2014-08-08 15:29:59.000000000","message":"plural perhaps?","commit_id":"b0db1c281ff03d736ce3d6791bafac0bffd1ef5a"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"147fbde8f1622ae28bc1f1c4993de4343e386b64","unresolved":false,"context_lines":[{"line_number":89,"context_line":"            return self._get_formatted_entity(entity)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"class ListSecret(lister.Lister, SecretFormatter):"},{"line_number":93,"context_line":"    \"\"\"List secrets.\"\"\""},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def get_parser(self, prog_name):"}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_93243260","line":92,"in_reply_to":"baada198_ba775fd0","updated":"2014-08-09 11:54:50.000000000","message":"Even though I also dislike the lack of plural form in this, I got this naming convention from the python-openstack client. if you look at List\u003cEntity\u003e classes they are in singular, perhaps we could ask the devs there why? meanwhile, I really think that shouldn\u0027t be addressed here. The point of this CR is to have a working implementation that\u0027s compliant with their standards so we can integrate this later with ease.","commit_id":"b0db1c281ff03d736ce3d6791bafac0bffd1ef5a"},{"author":{"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"},"change_message_id":"080ef2d093142a8e4418655dd9e684cc33eb7c3d","unresolved":false,"context_lines":[{"line_number":89,"context_line":"            return self._get_formatted_entity(entity)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"class ListSecret(lister.Lister, SecretFormatter):"},{"line_number":93,"context_line":"    \"\"\"List secrets.\"\"\""},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def get_parser(self, prog_name):"}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_ba775fd0","line":92,"in_reply_to":"baada198_d42dc9fe","updated":"2014-08-08 16:41:53.000000000","message":"Yes, ListSecrets please.","commit_id":"b0db1c281ff03d736ce3d6791bafac0bffd1ef5a"},{"author":{"_account_id":9234,"name":"Steve Heyman","email":"steve@heyman.com","username":"hockeynut"},"change_message_id":"28d4141a496f507b0b5c95fba490c5a8aa6c2267","unresolved":false,"context_lines":[{"line_number":114,"context_line":"                                 \u0027 (default: %(default)s).\u0027,"},{"line_number":115,"context_line":"                            type\u003dint)"},{"line_number":116,"context_line":"        parser.add_argument(\u0027--mode\u0027, \u0027-m\u0027, default\u003dNone,"},{"line_number":117,"context_line":"                            help\u003d\u0027the algorithm mode filter for the\u0027"},{"line_number":118,"context_line":"                                 \u0027 list (default: %(default)s).\u0027)"},{"line_number":119,"context_line":"        return parser"},{"line_number":120,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_9416f19f","line":117,"updated":"2014-08-08 15:29:59.000000000","message":"can we remove \"algorithm\" here?  I don\u0027t think we use the term \"algorithm mode\" anywhere else.","commit_id":"b0db1c281ff03d736ce3d6791bafac0bffd1ef5a"},{"author":{"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"},"change_message_id":"080ef2d093142a8e4418655dd9e684cc33eb7c3d","unresolved":false,"context_lines":[{"line_number":114,"context_line":"                                 \u0027 (default: %(default)s).\u0027,"},{"line_number":115,"context_line":"                            type\u003dint)"},{"line_number":116,"context_line":"        parser.add_argument(\u0027--mode\u0027, \u0027-m\u0027, default\u003dNone,"},{"line_number":117,"context_line":"                            help\u003d\u0027the algorithm mode filter for the\u0027"},{"line_number":118,"context_line":"                                 \u0027 list (default: %(default)s).\u0027)"},{"line_number":119,"context_line":"        return parser"},{"line_number":120,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_ba259fc0","line":117,"in_reply_to":"baada198_9416f19f","updated":"2014-08-08 16:41:53.000000000","message":"Well, the mode really is a modifier on an algorithm, so I think this is accurate to say. I\u0027ll see if I can get Paul to weigh in here too...","commit_id":"b0db1c281ff03d736ce3d6791bafac0bffd1ef5a"},{"author":{"_account_id":8004,"name":"Paul Kehrer","email":"paul.l.kehrer@gmail.com","username":"reaperhulk"},"change_message_id":"e8d779b6f2903a12e3bc6b97dc2f503553ab700f","unresolved":false,"context_lines":[{"line_number":114,"context_line":"                                 \u0027 (default: %(default)s).\u0027,"},{"line_number":115,"context_line":"                            type\u003dint)"},{"line_number":116,"context_line":"        parser.add_argument(\u0027--mode\u0027, \u0027-m\u0027, default\u003dNone,"},{"line_number":117,"context_line":"                            help\u003d\u0027the algorithm mode filter for the\u0027"},{"line_number":118,"context_line":"                                 \u0027 list (default: %(default)s).\u0027)"},{"line_number":119,"context_line":"        return parser"},{"line_number":120,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_e38cd230","line":117,"in_reply_to":"baada198_ba259fc0","updated":"2014-08-08 16:54:20.000000000","message":"It would be okay to remove it IMO, but maybe just rewording it like \"the mode associated with the algorithm\" would be good?","commit_id":"b0db1c281ff03d736ce3d6791bafac0bffd1ef5a"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"147fbde8f1622ae28bc1f1c4993de4343e386b64","unresolved":false,"context_lines":[{"line_number":114,"context_line":"                                 \u0027 (default: %(default)s).\u0027,"},{"line_number":115,"context_line":"                            type\u003dint)"},{"line_number":116,"context_line":"        parser.add_argument(\u0027--mode\u0027, \u0027-m\u0027, default\u003dNone,"},{"line_number":117,"context_line":"                            help\u003d\u0027the algorithm mode filter for the\u0027"},{"line_number":118,"context_line":"                                 \u0027 list (default: %(default)s).\u0027)"},{"line_number":119,"context_line":"        return parser"},{"line_number":120,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_b31cd615","line":117,"in_reply_to":"baada198_e38cd230","updated":"2014-08-09 11:54:50.000000000","message":"I think that\u0027s work for another CR. I can do it without problems, but would still prefer that.","commit_id":"b0db1c281ff03d736ce3d6791bafac0bffd1ef5a"},{"author":{"_account_id":9234,"name":"Steve Heyman","email":"steve@heyman.com","username":"hockeynut"},"change_message_id":"28d4141a496f507b0b5c95fba490c5a8aa6c2267","unresolved":false,"context_lines":[{"line_number":153,"context_line":"                                 \u0027(default: %(default)s).\u0027,"},{"line_number":154,"context_line":"                            type\u003dint)"},{"line_number":155,"context_line":"        parser.add_argument(\u0027--mode\u0027, \u0027-m\u0027, default\u003d\u0027cbc\u0027,"},{"line_number":156,"context_line":"                            help\u003d\u0027the algorithm mode; used only for \u0027"},{"line_number":157,"context_line":"                                 \u0027reference (default: %(default)s)\u0027)"},{"line_number":158,"context_line":"        parser.add_argument(\u0027--expiration\u0027, \u0027-x\u0027,"},{"line_number":159,"context_line":"                            help\u003d\u0027the expiration time for the secret in \u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_946d1132","line":156,"updated":"2014-08-08 15:29:59.000000000","message":"same as above","commit_id":"b0db1c281ff03d736ce3d6791bafac0bffd1ef5a"},{"author":{"_account_id":9234,"name":"Steve Heyman","email":"steve@heyman.com","username":"hockeynut"},"change_message_id":"28d4141a496f507b0b5c95fba490c5a8aa6c2267","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        parser.add_argument(\u0027--mode\u0027, \u0027-m\u0027, default\u003d\u0027cbc\u0027,"},{"line_number":156,"context_line":"                            help\u003d\u0027the algorithm mode; used only for \u0027"},{"line_number":157,"context_line":"                                 \u0027reference (default: %(default)s)\u0027)"},{"line_number":158,"context_line":"        parser.add_argument(\u0027--expiration\u0027, \u0027-x\u0027,"},{"line_number":159,"context_line":"                            help\u003d\u0027the expiration time for the secret in \u0027"},{"line_number":160,"context_line":"                                 \u0027ISO 8601 format.\u0027)"},{"line_number":161,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_f453ad6b","line":158,"updated":"2014-08-08 15:29:59.000000000","message":"default?  if none then we should say so in the help","commit_id":"b0db1c281ff03d736ce3d6791bafac0bffd1ef5a"}],"barbicanclient/test/test_barbican.py":[{"author":{"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"},"change_message_id":"457343d76eedb45086cc580c1139607b91b7e780","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            os.environ \u003d _old_env"},{"line_number":51,"context_line":"        return exit_code, out"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def teatDown(self):"},{"line_number":54,"context_line":"        self.global_file.close()"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def test_should_show_usage_error_with_no_args(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_68be1666","line":53,"updated":"2014-07-17 13:55:57.000000000","message":"teat --\u003e tear I think :)","commit_id":"97d786e1f4f734866569c17e959cf535b33f1a28"},{"author":{"_account_id":7874,"name":"Venkat Sundaram","email":"tsv@hp.com","username":"tsv"},"change_message_id":"b728d8370668d4f445d6c9b872fbde04a7b1fd1f","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        self.assertEqual(0, exit_code)"},{"line_number":63,"context_line":"        self.assertIn(\u0027usage: \u0027, out)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def _test_should_error_if_noauth_and_authurl_both_specified(self):"},{"line_number":66,"context_line":"        args \u003d \"--no-auth --os-auth-url http://localhost:5000/v3\""},{"line_number":67,"context_line":"        exit_code, out \u003d self.barbican(args)"},{"line_number":68,"context_line":"        self.assertEqual(1, exit_code)"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_7d142850","line":65,"updated":"2014-08-06 22:59:55.000000000","message":"Any reason why this test is disabled ?","commit_id":"101f2c2f6991adf9fc740103121a5a52685d5ef0"},{"author":{"_account_id":7874,"name":"Venkat Sundaram","email":"tsv@hp.com","username":"tsv"},"change_message_id":"b728d8370668d4f445d6c9b872fbde04a7b1fd1f","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    def _test_should_error_if_noauth_and_authurl_both_specified(self):"},{"line_number":66,"context_line":"        args \u003d \"--no-auth --os-auth-url http://localhost:5000/v3\""},{"line_number":67,"context_line":"        exit_code, out \u003d self.barbican(args)"},{"line_number":68,"context_line":"        self.assertEqual(1, exit_code)"},{"line_number":69,"context_line":"        self.assertIn("},{"line_number":70,"context_line":"            \u0027error: argument --os-auth-url/-A: not allowed with \u0027"},{"line_number":71,"context_line":"            \u0027argument --no-auth/-N\u0027, out)"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_5dfda408","line":68,"updated":"2014-08-06 22:59:55.000000000","message":"why 1 ?","commit_id":"101f2c2f6991adf9fc740103121a5a52685d5ef0"},{"author":{"_account_id":7874,"name":"Venkat Sundaram","email":"tsv@hp.com","username":"tsv"},"change_message_id":"b728d8370668d4f445d6c9b872fbde04a7b1fd1f","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        self.assertIn(expected_err_msg, out)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def test_should_error_if_noauth_and_missing_endpoint_tenantid_args(self):"},{"line_number":81,"context_line":"        self._expect_error_with_invalid_noauth_args(\"--no-auth list secret\")"},{"line_number":82,"context_line":"        self._expect_error_with_invalid_noauth_args("},{"line_number":83,"context_line":"            \"--no-auth --endpoint http://xyz list secret\")"},{"line_number":84,"context_line":"        self._expect_error_with_invalid_noauth_args("}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_fd2118fe","line":81,"updated":"2014-08-06 22:59:55.000000000","message":"Any reason why you flipped the \"secret list\" part here and in the next few lines ? This test is only for the endpoint/tenant-id args","commit_id":"101f2c2f6991adf9fc740103121a5a52685d5ef0"}],"setup.cfg":[{"author":{"_account_id":9234,"name":"Steve Heyman","email":"steve@heyman.com","username":"hockeynut"},"change_message_id":"28d4141a496f507b0b5c95fba490c5a8aa6c2267","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    order_create \u003d barbicanclient.barbican_cli.orders:CreateOrder"},{"line_number":32,"context_line":"    order_delete \u003d barbicanclient.barbican_cli.orders:DeleteOrder"},{"line_number":33,"context_line":"    order_get \u003d barbicanclient.barbican_cli.orders:GetOrder"},{"line_number":34,"context_line":"    order_list \u003d barbicanclient.barbican_cli.orders:ListOrder"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    secret_delete \u003d barbicanclient.barbican_cli.secrets:DeleteSecret"},{"line_number":37,"context_line":"    secret_get \u003d barbicanclient.barbican_cli.secrets:GetSecret"}],"source_content_type":"text/x-ttcn-cfg","patch_set":10,"id":"baada198_b4ebf579","line":34,"updated":"2014-08-08 15:29:59.000000000","message":"if we make plural then need to change it here too","commit_id":"b0db1c281ff03d736ce3d6791bafac0bffd1ef5a"},{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"8b3480968d1a0e4c121da18d5e7a511b784d000d","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    order_create \u003d barbicanclient.barbican_cli.orders:CreateOrder"},{"line_number":32,"context_line":"    order_delete \u003d barbicanclient.barbican_cli.orders:DeleteOrder"},{"line_number":33,"context_line":"    order_get \u003d barbicanclient.barbican_cli.orders:GetOrder"},{"line_number":34,"context_line":"    order_list \u003d barbicanclient.barbican_cli.orders:ListOrder"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    secret_delete \u003d barbicanclient.barbican_cli.secrets:DeleteSecret"},{"line_number":37,"context_line":"    secret_get \u003d barbicanclient.barbican_cli.secrets:GetSecret"}],"source_content_type":"text/x-ttcn-cfg","patch_set":10,"id":"baada198_ceda951c","line":34,"in_reply_to":"baada198_b4ebf579","updated":"2014-08-08 17:23:53.000000000","message":"I kind of like the singular better.","commit_id":"b0db1c281ff03d736ce3d6791bafac0bffd1ef5a"},{"author":{"_account_id":9234,"name":"Steve Heyman","email":"steve@heyman.com","username":"hockeynut"},"change_message_id":"28d4141a496f507b0b5c95fba490c5a8aa6c2267","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    secret_delete \u003d barbicanclient.barbican_cli.secrets:DeleteSecret"},{"line_number":37,"context_line":"    secret_get \u003d barbicanclient.barbican_cli.secrets:GetSecret"},{"line_number":38,"context_line":"    secret_list \u003d barbicanclient.barbican_cli.secrets:ListSecret"},{"line_number":39,"context_line":"    secret_store \u003d barbicanclient.barbican_cli.secrets:StoreSecret"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"[build_sphinx]"}],"source_content_type":"text/x-ttcn-cfg","patch_set":10,"id":"baada198_54fc593f","line":38,"updated":"2014-08-08 15:29:59.000000000","message":"same as above","commit_id":"b0db1c281ff03d736ce3d6791bafac0bffd1ef5a"}]}