)]}'
{"barbicanclient/barbican_cli/containers.py":[{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"67e280897813beb655a916d1b20c15c4955eca68","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        return parser"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def take_action(self, args):"},{"line_number":96,"context_line":"        container_type \u003d self.app.client.containers._container_map.get("},{"line_number":97,"context_line":"            args.type)"},{"line_number":98,"context_line":"        if not container_type:"},{"line_number":99,"context_line":"            raise ValueError(\u0027Invalid container type specified.\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_9127ddb5","line":96,"updated":"2014-10-03 10:12:35.000000000","message":"well, if you are using a member variable that has an underscore prefix, then the member variable is not meant to be \"protected\" or \"private\", so why is you adding the prefix underscore?","commit_id":"a30df056bf7ccf34d4346052a08df8c8534154b5"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"d72a90067c32327d7a69daf2b38f926098cc3830","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        return parser"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def take_action(self, args):"},{"line_number":96,"context_line":"        container_type \u003d self.app.client.containers._container_map.get("},{"line_number":97,"context_line":"            args.type)"},{"line_number":98,"context_line":"        if not container_type:"},{"line_number":99,"context_line":"            raise ValueError(\u0027Invalid container type specified.\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_40b2f394","line":96,"in_reply_to":"baa201ad_9127ddb5","updated":"2014-10-03 20:27:05.000000000","message":"Doug and I talked about this one, and the idea is that we don\u0027t want to form a contract for that attribute being available, in case we change how this works in the future... So we kept it private, but since this code is \"in the same package\" we\u0027re going ahead and using it here. If this were java, I would have made container_map a package-private attribute. It\u0027s not really intended to be used by end-users.","commit_id":"a30df056bf7ccf34d4346052a08df8c8534154b5"}],"barbicanclient/base.py":[{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"67e280897813beb655a916d1b20c15c4955eca68","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        \"\"\""},{"line_number":50,"context_line":"        Returns the total number of entities stored in Barbican."},{"line_number":51,"context_line":"        \"\"\""},{"line_number":52,"context_line":"        href \u003d \u0027{0}/{1}\u0027.format(self._self._base_url, self._entity)"},{"line_number":53,"context_line":"        params \u003d {\u0027limit\u0027: 0, \u0027offset\u0027: 0}"},{"line_number":54,"context_line":"        resp \u003d self._api._get(href, params)"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_0c21164d","line":52,"updated":"2014-10-03 10:12:35.000000000","message":"self._self? OK, this is getting confusing for me :(","commit_id":"a30df056bf7ccf34d4346052a08df8c8534154b5"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"d72a90067c32327d7a69daf2b38f926098cc3830","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        \"\"\""},{"line_number":50,"context_line":"        Returns the total number of entities stored in Barbican."},{"line_number":51,"context_line":"        \"\"\""},{"line_number":52,"context_line":"        href \u003d \u0027{0}/{1}\u0027.format(self._self._base_url, self._entity)"},{"line_number":53,"context_line":"        params \u003d {\u0027limit\u0027: 0, \u0027offset\u0027: 0}"},{"line_number":54,"context_line":"        resp \u003d self._api._get(href, params)"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_407913c7","line":52,"in_reply_to":"baa201ad_0c21164d","updated":"2014-10-03 20:27:05.000000000","message":"Uhh, oh hey, that is a bug... \u003e_\u003e\n\nMaking a patch now. Good catch.","commit_id":"a30df056bf7ccf34d4346052a08df8c8534154b5"}],"barbicanclient/client.py":[{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"67e280897813beb655a916d1b20c15c4955eca68","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        if isinstance(headers, dict) and not self._session.auth:"},{"line_number":162,"context_line":"            headers[\u0027X-Project-Id\u0027] \u003d self._tenant_id"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    def _get(self, href, params\u003dNone):"},{"line_number":165,"context_line":"        headers \u003d {\u0027Accept\u0027: \u0027application/json\u0027}"},{"line_number":166,"context_line":"        self._prepare_auth(headers)"},{"line_number":167,"context_line":"        resp \u003d self._session.get(href, params\u003dparams, headers\u003dheaders)"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_0ce836e1","line":164,"updated":"2014-10-03 10:12:35.000000000","message":"why?","commit_id":"a30df056bf7ccf34d4346052a08df8c8534154b5"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"d72a90067c32327d7a69daf2b38f926098cc3830","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        if isinstance(headers, dict) and not self._session.auth:"},{"line_number":162,"context_line":"            headers[\u0027X-Project-Id\u0027] \u003d self._tenant_id"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    def _get(self, href, params\u003dNone):"},{"line_number":165,"context_line":"        headers \u003d {\u0027Accept\u0027: \u0027application/json\u0027}"},{"line_number":166,"context_line":"        self._prepare_auth(headers)"},{"line_number":167,"context_line":"        resp \u003d self._session.get(href, params\u003dparams, headers\u003dheaders)"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_e03847f1","line":164,"in_reply_to":"baa201ad_0ce836e1","updated":"2014-10-03 20:27:05.000000000","message":"Cleaning up the namespace for developers using the client.","commit_id":"a30df056bf7ccf34d4346052a08df8c8534154b5"}],"barbicanclient/orders.py":[{"author":{"_account_id":9234,"name":"Steve Heyman","email":"steve@heyman.com","username":"hockeynut"},"change_message_id":"e7971da1dea6415f1f3703fc8799eb72830c9760","unresolved":false,"context_lines":[{"line_number":241,"context_line":"    def create(self, name\u003dNone, payload_content_type\u003dNone,"},{"line_number":242,"context_line":"               algorithm\u003dNone, bit_length\u003dNone, mode\u003dNone, expiration\u003dNone):"},{"line_number":243,"context_line":"        \"\"\""},{"line_number":244,"context_line":"        Order creation method"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"        :param name: A friendly name for the secret"},{"line_number":247,"context_line":"        :param payload_content_type: The format/type of the secret data"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa201ad_6a8bf41e","line":244,"updated":"2014-10-08 18:57:19.000000000","message":"nit - \"Create an Order\" would match how we did it on line 231","commit_id":"5ee63bb7813b83f40143d678b3108b191de48824"},{"author":{"_account_id":9234,"name":"Steve Heyman","email":"steve@heyman.com","username":"hockeynut"},"change_message_id":"e7971da1dea6415f1f3703fc8799eb72830c9760","unresolved":false,"context_lines":[{"line_number":249,"context_line":"        :param bit_length: The bit length of this secret key"},{"line_number":250,"context_line":"        :param mode: The algorithm mode used with this secret key"},{"line_number":251,"context_line":"        :param expiration: The expiration time of the secret in ISO 8601 format"},{"line_number":252,"context_line":"        :returns: Secret object"},{"line_number":253,"context_line":"        \"\"\""},{"line_number":254,"context_line":"        return Order(api\u003dself._api, name\u003dname,"},{"line_number":255,"context_line":"                     payload_content_type\u003dpayload_content_type,"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa201ad_ea7e0418","line":252,"updated":"2014-10-08 18:57:19.000000000","message":"returns an Order object, not a Secret - and I know it was like that before :-)","commit_id":"5ee63bb7813b83f40143d678b3108b191de48824"}],"barbicanclient/secrets.py":[{"author":{"_account_id":9234,"name":"Steve Heyman","email":"steve@heyman.com","username":"hockeynut"},"change_message_id":"e7971da1dea6415f1f3703fc8799eb72830c9760","unresolved":false,"context_lines":[{"line_number":251,"context_line":"    def get(self, secret_ref, payload_content_type\u003dNone):"},{"line_number":252,"context_line":"        \"\"\"Get a Secret"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"        :param secret_ref: Full HATEOAS reference to a Secret"},{"line_number":255,"context_line":"        :returns: Secret"},{"line_number":256,"context_line":"        \"\"\""},{"line_number":257,"context_line":"        LOG.debug(\"Getting secret - Secret href: {0}\".format(secret_ref))"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa201ad_eaa524a2","line":254,"updated":"2014-10-08 18:57:19.000000000","message":"should add :param for payload_content_type","commit_id":"5ee63bb7813b83f40143d678b3108b191de48824"},{"author":{"_account_id":9234,"name":"Steve Heyman","email":"steve@heyman.com","username":"hockeynut"},"change_message_id":"e7971da1dea6415f1f3703fc8799eb72830c9760","unresolved":false,"context_lines":[{"line_number":267,"context_line":"               payload_content_type\u003dNone, payload_content_encoding\u003dNone,"},{"line_number":268,"context_line":"               algorithm\u003dNone, bit_length\u003dNone, mode\u003dNone, expiration\u003dNone):"},{"line_number":269,"context_line":"        \"\"\""},{"line_number":270,"context_line":"        Secret creation method"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"        :param name: A friendly name for the Secret"},{"line_number":273,"context_line":"        :param payload: The unencrypted secret data"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa201ad_aa987c6a","line":270,"updated":"2014-10-08 18:57:19.000000000","message":"nit - should say \"Create a secret\" like we did on line 252","commit_id":"5ee63bb7813b83f40143d678b3108b191de48824"}]}