)]}'
{"barbicanclient/secrets.py":[{"author":{"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"},"change_message_id":"7169dbcc28fb7c0bd5d2f4b3d7581dfc1d432a6f","unresolved":false,"context_lines":[{"line_number":164,"context_line":"    @property"},{"line_number":165,"context_line":"    def payload(self):"},{"line_number":166,"context_line":"        if not self._payload:"},{"line_number":167,"context_line":"            self._fetch_payload()"},{"line_number":168,"context_line":"        return self._payload"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    @name.setter"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_ec79d093","line":167,"updated":"2014-11-25 16:21:55.000000000","message":"Just curious...if I make a secret from href here (with payload_content_type\u003dNone), and then get this payload property, I\u0027ll get a ValueError because the payload_content_type hasn\u0027t been loaded, correct?  It might be better to get the metadata first in those cases, and then get the payload?","commit_id":"c7ea7bdf60a42f576ddaeee578fe063aa9c41eb1"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"977044bfc5f407975690c90c4c1b6b027200229d","unresolved":false,"context_lines":[{"line_number":164,"context_line":"    @property"},{"line_number":165,"context_line":"    def payload(self):"},{"line_number":166,"context_line":"        if not self._payload:"},{"line_number":167,"context_line":"            self._fetch_payload()"},{"line_number":168,"context_line":"        return self._payload"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    @name.setter"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_b4f673d5","line":167,"in_reply_to":"5a890539_0171ff0b","updated":"2014-12-02 23:36:19.000000000","message":"This does work as expected, because of the order of operations in _fetch_payload, it will fetch the metadata to get a content_type, but only if payload_content_type wasn\u0027t specified.","commit_id":"c7ea7bdf60a42f576ddaeee578fe063aa9c41eb1"},{"author":{"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"},"change_message_id":"e2b481e9372c2b9f6545d88c28a16b79496b50c3","unresolved":false,"context_lines":[{"line_number":164,"context_line":"    @property"},{"line_number":165,"context_line":"    def payload(self):"},{"line_number":166,"context_line":"        if not self._payload:"},{"line_number":167,"context_line":"            self._fetch_payload()"},{"line_number":168,"context_line":"        return self._payload"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    @name.setter"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_fe535b69","line":167,"in_reply_to":"5a890539_b4f673d5","updated":"2014-12-03 15:40:50.000000000","message":"Yeah, the lazy load side effects are tricky to step through, but not sure how else to clarify things to the casual code reader. :)","commit_id":"c7ea7bdf60a42f576ddaeee578fe063aa9c41eb1"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"630f3e96f54d6ee38bb83399b9c2a6f3ba3ccec8","unresolved":false,"context_lines":[{"line_number":164,"context_line":"    @property"},{"line_number":165,"context_line":"    def payload(self):"},{"line_number":166,"context_line":"        if not self._payload:"},{"line_number":167,"context_line":"            self._fetch_payload()"},{"line_number":168,"context_line":"        return self._payload"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    @name.setter"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_0171ff0b","line":167,"in_reply_to":"5a890539_ec79d093","updated":"2014-12-01 17:11:20.000000000","message":"curious about this too ..","commit_id":"c7ea7bdf60a42f576ddaeee578fe063aa9c41eb1"},{"author":{"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"},"change_message_id":"e2b481e9372c2b9f6545d88c28a16b79496b50c3","unresolved":false,"context_lines":[{"line_number":198,"context_line":"        self._payload \u003d value"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"    @payload_content_type.setter"},{"line_number":201,"context_line":"    @immutable_after_save"},{"line_number":202,"context_line":"    def payload_content_type(self, value):"},{"line_number":203,"context_line":"        self._payload_content_type \u003d value"},{"line_number":204,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_be08f380","line":201,"updated":"2014-12-03 15:40:50.000000000","message":"Could you move this property setter to just below its getter above (so at #163)?","commit_id":"c7ea7bdf60a42f576ddaeee578fe063aa9c41eb1"},{"author":{"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"},"change_message_id":"de2cfd7d446ac56cec73ae3d9918b54c9b139787","unresolved":false,"context_lines":[{"line_number":198,"context_line":"        self._payload \u003d value"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"    @payload_content_type.setter"},{"line_number":201,"context_line":"    @immutable_after_save"},{"line_number":202,"context_line":"    def payload_content_type(self, value):"},{"line_number":203,"context_line":"        self._payload_content_type \u003d value"},{"line_number":204,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_8763e3af","line":201,"in_reply_to":"5a890539_7b2698bb","updated":"2014-12-03 17:45:27.000000000","message":"Normally not a big deal, but in the case of all these side effects, I\u0027d favor putting all operations for a given property next to each other. Not a big enough nit to put up another patch for though...","commit_id":"c7ea7bdf60a42f576ddaeee578fe063aa9c41eb1"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"e80d2154a70aa10f93ea48f6022babacbb908588","unresolved":false,"context_lines":[{"line_number":198,"context_line":"        self._payload \u003d value"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"    @payload_content_type.setter"},{"line_number":201,"context_line":"    @immutable_after_save"},{"line_number":202,"context_line":"    def payload_content_type(self, value):"},{"line_number":203,"context_line":"        self._payload_content_type \u003d value"},{"line_number":204,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_7b2698bb","line":201,"in_reply_to":"5a890539_be08f380","updated":"2014-12-03 16:32:38.000000000","message":"I had chosen to group getters together and setters together, I think... It\u0027s kind of arbitrary, but I guess I could move it if you think it\u0027s really relevant?","commit_id":"c7ea7bdf60a42f576ddaeee578fe063aa9c41eb1"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"e80d2154a70aa10f93ea48f6022babacbb908588","unresolved":false,"context_lines":[{"line_number":208,"context_line":"        self._payload_content_encoding \u003d value"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"    def _fetch_payload(self):"},{"line_number":211,"context_line":"        if not self.payload_content_type and not self.content_types:"},{"line_number":212,"context_line":"            raise ValueError(\u0027Secret has no encrypted data to decrypt.\u0027)"},{"line_number":213,"context_line":"        elif not self.payload_content_type:"},{"line_number":214,"context_line":"            raise ValueError(\"Must specify decrypt content-type as \""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_bb6ac0b2","line":211,"updated":"2014-12-03 16:32:38.000000000","message":"This `if` statement is the line than causes the content_types lazy-load to happen if payload_content_type is not set. If payload_content_type is set, it short-circuits and uses that, but if it\u0027s not, it calls the property for content_types, triggering the lazy-load, which fills payload_content_type.","commit_id":"c7ea7bdf60a42f576ddaeee578fe063aa9c41eb1"},{"author":{"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"},"change_message_id":"de2cfd7d446ac56cec73ae3d9918b54c9b139787","unresolved":false,"context_lines":[{"line_number":208,"context_line":"        self._payload_content_encoding \u003d value"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"    def _fetch_payload(self):"},{"line_number":211,"context_line":"        if not self.payload_content_type and not self.content_types:"},{"line_number":212,"context_line":"            raise ValueError(\u0027Secret has no encrypted data to decrypt.\u0027)"},{"line_number":213,"context_line":"        elif not self.payload_content_type:"},{"line_number":214,"context_line":"            raise ValueError(\"Must specify decrypt content-type as \""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_07da9377","line":211,"in_reply_to":"5a890539_bb6ac0b2","updated":"2014-12-03 17:45:27.000000000","message":"Yep, I eventually got that...not very obvious of course but that is the nature of lazy loading.","commit_id":"c7ea7bdf60a42f576ddaeee578fe063aa9c41eb1"}]}
