)]}'
{"id":"openstack%2Fpython-barbicanclient~148448","triplet_id":"openstack%2Fpython-barbicanclient~master~Ib8a495d6bb7a45e3492aea2e326a7714c79bba8c","project":"openstack/python-barbicanclient","branch":"master","topic":"requests-mock","hashtags":[],"change_id":"Ib8a495d6bb7a45e3492aea2e326a7714c79bba8c","subject":"Remove cyclical dependency","status":"MERGED","created":"2015-01-20 06:31:35.000000000","updated":"2015-03-03 23:26:53.000000000","submitted":"2015-03-03 23:26:52.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"dc9c49963fcf30fcf17c00bb209663a238a36b36","_number":148448,"virtual_id_number":148448,"owner":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":7136,"name":"Chad Lung","email":"chad.lung@gmail.com","username":"chadlung"},{"value":2,"date":"2015-03-03 23:26:52.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},{"value":0,"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":7136,"name":"Chad Lung","email":"chad.lung@gmail.com","username":"chadlung"},"all":[{"value":2,"date":"2015-02-25 16:11:10.000000000","_account_id":7136,"name":"Chad Lung","email":"chad.lung@gmail.com","username":"chadlung"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2015-02-25 09:24:55.000000000","_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},{"value":2,"date":"2015-02-25 14:44:11.000000000","_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7136,"name":"Chad Lung","email":"chad.lung@gmail.com","username":"chadlung"},"all":[{"value":1,"date":"2015-02-25 16:11:10.000000000","_account_id":7136,"name":"Chad Lung","email":"chad.lung@gmail.com","username":"chadlung"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},{"value":0,"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":7136,"name":"Chad Lung","email":"chad.lung@gmail.com","username":"chadlung"},{"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"},{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-02-25 09:24:55.000000000","updated_by":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"reviewer":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"state":"REVIEWER"},{"updated":"2015-02-25 14:44:11.000000000","updated_by":{"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"},"reviewer":{"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"},"state":"REVIEWER"},{"updated":"2015-02-25 16:11:10.000000000","updated_by":{"_account_id":7136,"name":"Chad Lung","email":"chad.lung@gmail.com","username":"chadlung"},"reviewer":{"_account_id":7136,"name":"Chad Lung","email":"chad.lung@gmail.com","username":"chadlung"},"state":"REVIEWER"},{"updated":"2015-03-03 23:26:52.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"0cb0681d3f3abe97bb8c1d556adedc817fff2868","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2015-01-20 06:31:35.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"18bf6c4bef0a814d68160d813f1f24332913508b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-01-20 07:03:34.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-barbicanclient-python26 http://logs.openstack.org/48/148448/1/check/gate-python-barbicanclient-python26/f5cf3d5/ : SUCCESS in 50s\n- gate-python-barbicanclient-python33 http://logs.openstack.org/48/148448/1/check/gate-python-barbicanclient-python33/296cb5e/ : FAILURE in 1m 53s\n- gate-python-barbicanclient-pypy http://logs.openstack.org/48/148448/1/check/gate-python-barbicanclient-pypy/d969d97/ : SUCCESS in 1m 55s\n- gate-tempest-dsvm-neutron-src-python-barbicanclient http://logs.openstack.org/48/148448/1/check/gate-tempest-dsvm-neutron-src-python-barbicanclient/cbc8b45/ : FAILURE in 31m 46s\n- gate-python-barbicanclient-pep8 http://logs.openstack.org/48/148448/1/check/gate-python-barbicanclient-pep8/152a277/ : SUCCESS in 38s\n- gate-python-barbicanclient-python27 http://logs.openstack.org/48/148448/1/check/gate-python-barbicanclient-python27/64bae3c/ : SUCCESS in 35s\n- python-barbicanclient-docs http://logs.openstack.org/48/148448/1/check/python-barbicanclient-docs/81adcdf/ : SUCCESS in 27s","accounts_in_message":[],"_revision_number":1},{"id":"81413bee997b39314af63425e6880e4545340e93","author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"date":"2015-01-20 08:42:41.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"a406bbb238e413eb13d27a8334d3b4db7fe7c752","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2015-02-25 04:28:14.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"e25dcf14c074b296d33d7b8c1c53865e13ac5eb4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-02-25 05:38:35.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-barbicanclient-python26 http://logs.openstack.org/48/148448/2/check/gate-python-barbicanclient-python26/bab560f/ : SUCCESS in 53s\n- gate-python-barbicanclient-pep8 http://logs.openstack.org/48/148448/2/check/gate-python-barbicanclient-pep8/e6a5728/ : SUCCESS in 33s\n- gate-python-barbicanclient-docs http://docs-draft.openstack.org/48/148448/2/check/gate-python-barbicanclient-docs/ee79be9//doc/build/html/ : SUCCESS in 1m 19s\n- gate-python-barbicanclient-python27 http://logs.openstack.org/48/148448/2/check/gate-python-barbicanclient-python27/8fba5ad/ : SUCCESS in 37s\n- gate-python-barbicanclient-python34 http://logs.openstack.org/48/148448/2/check/gate-python-barbicanclient-python34/c7d09d6/ : SUCCESS in 2m 37s\n- gate-python-barbicanclient-pypy http://logs.openstack.org/48/148448/2/check/gate-python-barbicanclient-pypy/59ca5b1/ : SUCCESS in 1m 21s\n- gate-tempest-dsvm-neutron-src-python-barbicanclient http://logs.openstack.org/48/148448/2/check/gate-tempest-dsvm-neutron-src-python-barbicanclient/c9af815/ : SUCCESS in 1h 07m 30s\n- gate-tempest-dsvm-neutron-src-python-barbicanclient-juno http://logs.openstack.org/48/148448/2/check/gate-tempest-dsvm-neutron-src-python-barbicanclient-juno/197d04b/ : SUCCESS in 1h 01m 51s","accounts_in_message":[],"_revision_number":2},{"id":"59bd88da2a7ba3c27f6ccce2960c29ae2f700895","author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"date":"2015-02-25 09:24:55.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"b31ae13b560d4c149cb3914129c5edae5c0f22b1","author":{"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"},"date":"2015-02-25 14:44:11.000000000","message":"Patch Set 2: Code-Review+2\n\nI","accounts_in_message":[],"_revision_number":2},{"id":"f9dcdf2c188091b656a027ffe311a79a8c05ab5c","author":{"_account_id":7136,"name":"Chad Lung","email":"chad.lung@gmail.com","username":"chadlung"},"date":"2015-02-25 16:11:10.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"c314205e3996df43ea2be43a953b798ceb23f5a6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-03-03 22:30:42.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"66a59791ec9a5889835a1ab7ff2a1ba168dfe66c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-03-03 23:26:52.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-barbicanclient-python26 http://logs.openstack.org/48/148448/2/gate/gate-python-barbicanclient-python26/81d73f7/ : SUCCESS in 48s\n- gate-python-barbicanclient-docs http://docs-draft.openstack.org/48/148448/2/gate/gate-python-barbicanclient-docs/9d179a3//doc/build/html/ : SUCCESS in 49s\n- gate-python-barbicanclient-pep8 http://logs.openstack.org/48/148448/2/gate/gate-python-barbicanclient-pep8/2a51f1b/ : SUCCESS in 52s\n- gate-python-barbicanclient-python27 http://logs.openstack.org/48/148448/2/gate/gate-python-barbicanclient-python27/3503acc/ : SUCCESS in 43s\n- gate-python-barbicanclient-python34 http://logs.openstack.org/48/148448/2/gate/gate-python-barbicanclient-python34/d7e2022/ : SUCCESS in 2m 00s\n- gate-python-barbicanclient-pypy http://logs.openstack.org/48/148448/2/gate/gate-python-barbicanclient-pypy/ea482f8/ : SUCCESS in 1m 22s\n- gate-tempest-dsvm-neutron-src-python-barbicanclient http://logs.openstack.org/48/148448/2/gate/gate-tempest-dsvm-neutron-src-python-barbicanclient/d752228/ : SUCCESS in 55m 29s","accounts_in_message":[],"_revision_number":2},{"id":"5fb60401ff6081d0c0a37faa1153f0618860c19a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-03-03 23:26:53.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"0f3265f0e130c94a39ebbfea321837d7c6def267","revisions":{"79f85f896dbee60faf1147cb620b0355ea21d3a1":{"kind":"REWORK","_number":1,"created":"2015-01-20 06:31:35.000000000","uploader":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"ref":"refs/changes/48/148448/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-barbicanclient","ref":"refs/changes/48/148448/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-barbicanclient refs/changes/48/148448/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-barbicanclient refs/changes/48/148448/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-barbicanclient refs/changes/48/148448/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-barbicanclient refs/changes/48/148448/1"}}},"commit":{"parents":[{"commit":"aac81d532d55b0374e1dff86c01a69239a82eb0a","subject":"Convert CRUD tests to requests-mock","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-barbicanclient/commit/aac81d532d55b0374e1dff86c01a69239a82eb0a"}]}],"author":{"name":"Jamie Lennox","email":"jamielennox@redhat.com","date":"2015-01-19 05:52:53.000000000","tz":600},"committer":{"name":"Jamie Lennox","email":"jamielennox@redhat.com","date":"2015-01-20 06:28:40.000000000","tz":600},"subject":"Remove cyclical dependency","message":"Remove cyclical dependency\n\nPart of the reason that we typically separate the request manager from\nthe client object itself as otherwise we end up with a circular\ndependency between the client and the managers. This has caused problems\nin the past (in other projects) where session objects that maintain a\nconnection pool were not being freed (and the connections remaining\nopen) because the circular reference meant that it didn\u0027t free the\nobject.\n\nCreate a HTTPClient object that handles the actual requests from\nmanagers.\n\nChange-Id: Ib8a495d6bb7a45e3492aea2e326a7714c79bba8c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-barbicanclient/commit/79f85f896dbee60faf1147cb620b0355ea21d3a1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-barbicanclient/commit/79f85f896dbee60faf1147cb620b0355ea21d3a1"}]},"branch":"refs/heads/master"},"0f3265f0e130c94a39ebbfea321837d7c6def267":{"kind":"REWORK","_number":2,"created":"2015-02-25 04:28:14.000000000","uploader":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"ref":"refs/changes/48/148448/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-barbicanclient","ref":"refs/changes/48/148448/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-barbicanclient refs/changes/48/148448/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-barbicanclient refs/changes/48/148448/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-barbicanclient refs/changes/48/148448/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-barbicanclient refs/changes/48/148448/2"}}},"commit":{"parents":[{"commit":"928e561282dcf6d63a045863b381aac4e223ec7f","subject":"Convert CRUD tests to requests-mock","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-barbicanclient/commit/928e561282dcf6d63a045863b381aac4e223ec7f"}]}],"author":{"name":"Jamie Lennox","email":"jamielennox@redhat.com","date":"2015-01-19 05:52:53.000000000","tz":600},"committer":{"name":"Jamie Lennox","email":"jamielennox@redhat.com","date":"2015-02-25 04:22:49.000000000","tz":660},"subject":"Remove cyclical dependency","message":"Remove cyclical dependency\n\nPart of the reason that we typically separate the request manager from\nthe client object itself as otherwise we end up with a circular\ndependency between the client and the managers. This has caused problems\nin the past (in other projects) where session objects that maintain a\nconnection pool were not being freed (and the connections remaining\nopen) because the circular reference meant that it didn\u0027t free the\nobject.\n\nCreate a HTTPClient object that handles the actual requests from\nmanagers.\n\nChange-Id: Ib8a495d6bb7a45e3492aea2e326a7714c79bba8c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-barbicanclient/commit/0f3265f0e130c94a39ebbfea321837d7c6def267"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-barbicanclient/commit/0f3265f0e130c94a39ebbfea321837d7c6def267"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}