)]}'
{"functionaltests/client/v1/behaviors/container_behaviors.py":[{"author":{"_account_id":7262,"name":"John Vrbanac","email":"john.vrbanac@linux.com","username":"john.vrbanac"},"change_message_id":"0143c5c5e0cbf698f2c9c66c3fd999c0c7d04cfb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\"\"\""},{"line_number":2,"context_line":"Copyright 2014 Rackspace"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"you may not use this file except in compliance with the License."}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_4389f173","line":2,"updated":"2015-02-04 21:11:26.000000000","message":"2015","commit_id":"7bc25b4403cf27b3adb17b4f5c11f0f47f718d49"},{"author":{"_account_id":7262,"name":"John Vrbanac","email":"john.vrbanac@linux.com","username":"john.vrbanac"},"change_message_id":"0143c5c5e0cbf698f2c9c66c3fd999c0c7d04cfb","unresolved":false,"context_lines":[{"line_number":34,"context_line":"            self.created_entities.append(container_ref)"},{"line_number":35,"context_line":"        return resp"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def create_rsa_container(self, container):"},{"line_number":38,"context_line":"        \"\"\"Create an RSA container from data in a client container object"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        :param container: The metadata used to create the container"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_a8e8cae2","line":37,"updated":"2015-02-04 21:11:26.000000000","message":"How is this different than create_container() ?","commit_id":"7bc25b4403cf27b3adb17b4f5c11f0f47f718d49"},{"author":{"_account_id":7262,"name":"John Vrbanac","email":"john.vrbanac@linux.com","username":"john.vrbanac"},"change_message_id":"0143c5c5e0cbf698f2c9c66c3fd999c0c7d04cfb","unresolved":false,"context_lines":[{"line_number":49,"context_line":"            self.created_entities.append(container_ref)"},{"line_number":50,"context_line":"        return resp"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def get_container(self, client, container_ref):"},{"line_number":53,"context_line":"        \"\"\"Handles getting a single container"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        :param client: Barbican client object"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_e3b6653d","line":52,"updated":"2015-02-04 21:11:26.000000000","message":"Why are you passing in the client every time? It should only be passed in when you create a behavior.","commit_id":"7bc25b4403cf27b3adb17b4f5c11f0f47f718d49"},{"author":{"_account_id":7262,"name":"John Vrbanac","email":"john.vrbanac@linux.com","username":"john.vrbanac"},"change_message_id":"0143c5c5e0cbf698f2c9c66c3fd999c0c7d04cfb","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        \"\"\""},{"line_number":72,"context_line":"        return client.containers.list(limit\u003dlimit, offset\u003doffset)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def delete_container(self, client, container_ref, extra_headers\u003dNone,"},{"line_number":75,"context_line":"                         expected_fail\u003dFalse):"},{"line_number":76,"context_line":"        \"\"\"Handles deleting a containers."},{"line_number":77,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_68e5f2da","line":74,"updated":"2015-02-04 21:11:26.000000000","message":"What are extra_headers for? They don\u0027t appear to be used.","commit_id":"7bc25b4403cf27b3adb17b4f5c11f0f47f718d49"},{"author":{"_account_id":7262,"name":"John Vrbanac","email":"john.vrbanac@linux.com","username":"john.vrbanac"},"change_message_id":"0143c5c5e0cbf698f2c9c66c3fd999c0c7d04cfb","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        \"\"\""},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        container \u003d client.containers.get(container_ref)"},{"line_number":87,"context_line":"        resp \u003d container.delete()"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        if not expected_fail:"},{"line_number":90,"context_line":"            self.created_entities.remove(container_ref)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_88b306e8","line":87,"updated":"2015-02-04 21:11:26.000000000","message":"If I recall correctly, you don\u0027t need to retrieve the container before you delete it. The container manager has a delete method which takes a ref.","commit_id":"7bc25b4403cf27b3adb17b4f5c11f0f47f718d49"},{"author":{"_account_id":9234,"name":"Steve Heyman","email":"steve@heyman.com","username":"hockeynut"},"change_message_id":"fc13e676ebe0859ec6fbaa3bb1810df5f2a082fd","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"class ContainerBehaviors(base_behaviors.BaseBehaviors):"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    def create_container(self, data):"},{"line_number":23,"context_line":"        \"\"\"Creates a generic container object"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"        :param data: Data used to create object"}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_c7b93fcd","line":22,"updated":"2015-02-05 20:58:56.000000000","message":"since we have create RSA container, lets call this one create_generic_container","commit_id":"50452da8b941262dacede1ee411b57f53edcf36d"},{"author":{"_account_id":13510,"name":"Thomas Dinkjian","email":"thomas.dinkjian@rackspace.com","username":"tdink"},"change_message_id":"df6c0fdd0026e38aa826c6205cc4c95b6f718c13","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"class ContainerBehaviors(base_behaviors.BaseBehaviors):"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    def create_container(self, data):"},{"line_number":23,"context_line":"        \"\"\"Creates a generic container object"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"        :param data: Data used to create object"}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_625c014c","line":22,"in_reply_to":"da86d52c_c7b93fcd","updated":"2015-02-05 21:32:56.000000000","message":"Done","commit_id":"50452da8b941262dacede1ee411b57f53edcf36d"},{"author":{"_account_id":9234,"name":"Steve Heyman","email":"steve@heyman.com","username":"hockeynut"},"change_message_id":"fc13e676ebe0859ec6fbaa3bb1810df5f2a082fd","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"        :param data: Data used to create object"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"        :return: A container object"},{"line_number":28,"context_line":"        \"\"\""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"        return self.client.containers.create(**data)"}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_67a17393","line":27,"updated":"2015-02-05 20:58:56.000000000","message":"a generic container object","commit_id":"50452da8b941262dacede1ee411b57f53edcf36d"},{"author":{"_account_id":13510,"name":"Thomas Dinkjian","email":"thomas.dinkjian@rackspace.com","username":"tdink"},"change_message_id":"df6c0fdd0026e38aa826c6205cc4c95b6f718c13","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"        :param data: Data used to create object"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"        :return: A container object"},{"line_number":28,"context_line":"        \"\"\""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"        return self.client.containers.create(**data)"}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_a2527932","line":27,"in_reply_to":"da86d52c_67a17393","updated":"2015-02-05 21:32:56.000000000","message":"Done","commit_id":"50452da8b941262dacede1ee411b57f53edcf36d"},{"author":{"_account_id":9234,"name":"Steve Heyman","email":"steve@heyman.com","username":"hockeynut"},"change_message_id":"fc13e676ebe0859ec6fbaa3bb1810df5f2a082fd","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        return self.client.containers.create(**data)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def create_rsa_container(self, data):"},{"line_number":33,"context_line":"        \"\"\"Creates a generic container object"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        :param data: Data used to create object"},{"line_number":36,"context_line":"        :return: A container object"}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_677a5325","line":33,"updated":"2015-02-05 20:58:56.000000000","message":"actually its an RSA container.  Revenge of copy/paste!","commit_id":"50452da8b941262dacede1ee411b57f53edcf36d"},{"author":{"_account_id":13510,"name":"Thomas Dinkjian","email":"thomas.dinkjian@rackspace.com","username":"tdink"},"change_message_id":"df6c0fdd0026e38aa826c6205cc4c95b6f718c13","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        return self.client.containers.create(**data)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def create_rsa_container(self, data):"},{"line_number":33,"context_line":"        \"\"\"Creates a generic container object"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        :param data: Data used to create object"},{"line_number":36,"context_line":"        :return: A container object"}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_4228dd99","line":33,"in_reply_to":"da86d52c_677a5325","updated":"2015-02-05 21:32:56.000000000","message":"Done","commit_id":"50452da8b941262dacede1ee411b57f53edcf36d"},{"author":{"_account_id":9234,"name":"Steve Heyman","email":"steve@heyman.com","username":"hockeynut"},"change_message_id":"fc13e676ebe0859ec6fbaa3bb1810df5f2a082fd","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        \"\"\"Creates a generic container object"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        :param data: Data used to create object"},{"line_number":36,"context_line":"        :return: A container object"},{"line_number":37,"context_line":"        \"\"\""},{"line_number":38,"context_line":"        return self.client.containers.create_rsa(**data)"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_0799976d","line":36,"updated":"2015-02-05 20:58:56.000000000","message":"an RSA container object - might as well be specific","commit_id":"50452da8b941262dacede1ee411b57f53edcf36d"},{"author":{"_account_id":13510,"name":"Thomas Dinkjian","email":"thomas.dinkjian@rackspace.com","username":"tdink"},"change_message_id":"df6c0fdd0026e38aa826c6205cc4c95b6f718c13","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        \"\"\"Creates a generic container object"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        :param data: Data used to create object"},{"line_number":36,"context_line":"        :return: A container object"},{"line_number":37,"context_line":"        \"\"\""},{"line_number":38,"context_line":"        return self.client.containers.create_rsa(**data)"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_622321bd","line":36,"in_reply_to":"da86d52c_0799976d","updated":"2015-02-05 21:32:56.000000000","message":"Done","commit_id":"50452da8b941262dacede1ee411b57f53edcf36d"},{"author":{"_account_id":9234,"name":"Steve Heyman","email":"steve@heyman.com","username":"hockeynut"},"change_message_id":"fc13e676ebe0859ec6fbaa3bb1810df5f2a082fd","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        return self.client.containers.create_rsa(**data)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def create_certificate_container(self, data):"},{"line_number":41,"context_line":"        \"\"\"Creates a generic container object"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        :param data: Data used to create object"},{"line_number":44,"context_line":"        :return: A container object"}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_87c3c736","line":41,"updated":"2015-02-05 20:58:56.000000000","message":"a certificate container, not generic.  Copy/Paste again!","commit_id":"50452da8b941262dacede1ee411b57f53edcf36d"},{"author":{"_account_id":13510,"name":"Thomas Dinkjian","email":"thomas.dinkjian@rackspace.com","username":"tdink"},"change_message_id":"df6c0fdd0026e38aa826c6205cc4c95b6f718c13","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        return self.client.containers.create_rsa(**data)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def create_certificate_container(self, data):"},{"line_number":41,"context_line":"        \"\"\"Creates a generic container object"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        :param data: Data used to create object"},{"line_number":44,"context_line":"        :return: A container object"}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_c21bed7e","line":41,"in_reply_to":"da86d52c_87c3c736","updated":"2015-02-05 21:32:56.000000000","message":"Done","commit_id":"50452da8b941262dacede1ee411b57f53edcf36d"},{"author":{"_account_id":9234,"name":"Steve Heyman","email":"steve@heyman.com","username":"hockeynut"},"change_message_id":"fc13e676ebe0859ec6fbaa3bb1810df5f2a082fd","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        \"\"\"Creates a generic container object"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        :param data: Data used to create object"},{"line_number":44,"context_line":"        :return: A container object"},{"line_number":45,"context_line":"        \"\"\""},{"line_number":46,"context_line":"        return self.client.containers.create_certificate(**data)"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_c7e05fcf","line":44,"updated":"2015-02-05 20:58:56.000000000","message":"a certificate container","commit_id":"50452da8b941262dacede1ee411b57f53edcf36d"},{"author":{"_account_id":13510,"name":"Thomas Dinkjian","email":"thomas.dinkjian@rackspace.com","username":"tdink"},"change_message_id":"df6c0fdd0026e38aa826c6205cc4c95b6f718c13","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        \"\"\"Creates a generic container object"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        :param data: Data used to create object"},{"line_number":44,"context_line":"        :return: A container object"},{"line_number":45,"context_line":"        \"\"\""},{"line_number":46,"context_line":"        return self.client.containers.create_certificate(**data)"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_e21e316f","line":44,"in_reply_to":"da86d52c_c7e05fcf","updated":"2015-02-05 21:32:56.000000000","message":"Done","commit_id":"50452da8b941262dacede1ee411b57f53edcf36d"},{"author":{"_account_id":9234,"name":"Steve Heyman","email":"steve@heyman.com","username":"hockeynut"},"change_message_id":"fc13e676ebe0859ec6fbaa3bb1810df5f2a082fd","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        return self.client.containers.create_certificate(**data)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def store_container(self, container):"},{"line_number":49,"context_line":"        \"\"\"Create generic container from the data in a client container object"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        :param container: The metadata used to create the container"},{"line_number":52,"context_line":"        :return: A container ref"}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_a7d52be6","line":49,"updated":"2015-02-05 20:58:56.000000000","message":"Stores, not create ... right?","commit_id":"50452da8b941262dacede1ee411b57f53edcf36d"},{"author":{"_account_id":13510,"name":"Thomas Dinkjian","email":"thomas.dinkjian@rackspace.com","username":"tdink"},"change_message_id":"df6c0fdd0026e38aa826c6205cc4c95b6f718c13","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        return self.client.containers.create_certificate(**data)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def store_container(self, container):"},{"line_number":49,"context_line":"        \"\"\"Create generic container from the data in a client container object"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        :param container: The metadata used to create the container"},{"line_number":52,"context_line":"        :return: A container ref"}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_420ffd36","line":49,"in_reply_to":"da86d52c_a7d52be6","updated":"2015-02-05 21:32:56.000000000","message":"Done","commit_id":"50452da8b941262dacede1ee411b57f53edcf36d"},{"author":{"_account_id":9234,"name":"Steve Heyman","email":"steve@heyman.com","username":"hockeynut"},"change_message_id":"fc13e676ebe0859ec6fbaa3bb1810df5f2a082fd","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    def store_container(self, container):"},{"line_number":49,"context_line":"        \"\"\"Create generic container from the data in a client container object"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        :param container: The metadata used to create the container"},{"line_number":52,"context_line":"        :return: A container ref"},{"line_number":53,"context_line":"        \"\"\""},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_e70ac388","line":51,"updated":"2015-02-05 20:58:56.000000000","message":"its a container object","commit_id":"50452da8b941262dacede1ee411b57f53edcf36d"},{"author":{"_account_id":13510,"name":"Thomas Dinkjian","email":"thomas.dinkjian@rackspace.com","username":"tdink"},"change_message_id":"df6c0fdd0026e38aa826c6205cc4c95b6f718c13","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    def store_container(self, container):"},{"line_number":49,"context_line":"        \"\"\"Create generic container from the data in a client container object"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        :param container: The metadata used to create the container"},{"line_number":52,"context_line":"        :return: A container ref"},{"line_number":53,"context_line":"        \"\"\""},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_3d16ac4c","line":51,"in_reply_to":"da86d52c_e70ac388","updated":"2015-02-05 21:32:56.000000000","message":"Done","commit_id":"50452da8b941262dacede1ee411b57f53edcf36d"},{"author":{"_account_id":9234,"name":"Steve Heyman","email":"steve@heyman.com","username":"hockeynut"},"change_message_id":"fc13e676ebe0859ec6fbaa3bb1810df5f2a082fd","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        :return: A container ref"},{"line_number":53,"context_line":"        \"\"\""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        resp \u003d container.store()"},{"line_number":56,"context_line":"        container_ref \u003d str(resp)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        if container_ref:"}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_c7985f1e","line":55,"updated":"2015-02-05 20:58:56.000000000","message":"the resp should already be a string.  Are you seeing something different?","commit_id":"50452da8b941262dacede1ee411b57f53edcf36d"},{"author":{"_account_id":13510,"name":"Thomas Dinkjian","email":"thomas.dinkjian@rackspace.com","username":"tdink"},"change_message_id":"df6c0fdd0026e38aa826c6205cc4c95b6f718c13","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        :return: A container ref"},{"line_number":53,"context_line":"        \"\"\""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        resp \u003d container.store()"},{"line_number":56,"context_line":"        container_ref \u003d str(resp)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        if container_ref:"}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_fd089429","line":55,"in_reply_to":"da86d52c_c7985f1e","updated":"2015-02-05 21:32:56.000000000","message":"its coming back as unicode","commit_id":"50452da8b941262dacede1ee411b57f53edcf36d"},{"author":{"_account_id":9234,"name":"Steve Heyman","email":"steve@heyman.com","username":"hockeynut"},"change_message_id":"fc13e676ebe0859ec6fbaa3bb1810df5f2a082fd","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        containers_to_delete \u003d [container for container"},{"line_number":100,"context_line":"                                in self.created_entities]"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        for container_ref in containers_to_delete:"},{"line_number":103,"context_line":"            self.delete_container(container_ref)"}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_07b6f789","line":102,"updated":"2015-02-05 20:58:56.000000000","message":"might be a good idea to add a comment that the contained secrets should be deleted by whomever created them - we won\u0027t do it here.  This may change when https://review.openstack.org/#/c/134578/ is done.","commit_id":"50452da8b941262dacede1ee411b57f53edcf36d"},{"author":{"_account_id":13510,"name":"Thomas Dinkjian","email":"thomas.dinkjian@rackspace.com","username":"tdink"},"change_message_id":"df6c0fdd0026e38aa826c6205cc4c95b6f718c13","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        containers_to_delete \u003d [container for container"},{"line_number":100,"context_line":"                                in self.created_entities]"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        for container_ref in containers_to_delete:"},{"line_number":103,"context_line":"            self.delete_container(container_ref)"}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_1d23a8a7","line":102,"in_reply_to":"da86d52c_07b6f789","updated":"2015-02-05 21:32:56.000000000","message":"In the tests we call delete all created secrets to handle this cleanup.","commit_id":"50452da8b941262dacede1ee411b57f53edcf36d"}],"functionaltests/client/v1/behaviors/secret_behaviors.py":[{"author":{"_account_id":9234,"name":"Steve Heyman","email":"steve@heyman.com","username":"hockeynut"},"change_message_id":"fc13e676ebe0859ec6fbaa3bb1810df5f2a082fd","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        return resp"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def get_secret(self, secret_ref, payload_content_type\u003dNone):"},{"line_number":47,"context_line":"        \"\"\"Retrieves a secret and its payload."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"            :param secret_ref: A secret reference"}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_879e6761","line":46,"updated":"2015-02-05 20:58:56.000000000","message":"You really have a thing with these blank lines...","commit_id":"50452da8b941262dacede1ee411b57f53edcf36d"},{"author":{"_account_id":13510,"name":"Thomas Dinkjian","email":"thomas.dinkjian@rackspace.com","username":"tdink"},"change_message_id":"df6c0fdd0026e38aa826c6205cc4c95b6f718c13","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        return resp"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def get_secret(self, secret_ref, payload_content_type\u003dNone):"},{"line_number":47,"context_line":"        \"\"\"Retrieves a secret and its payload."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"            :param secret_ref: A secret reference"}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_dd7af086","line":46,"in_reply_to":"da86d52c_879e6761","updated":"2015-02-05 21:32:56.000000000","message":"this was a missed pep8 violation in the secrets CR","commit_id":"50452da8b941262dacede1ee411b57f53edcf36d"},{"author":{"_account_id":9234,"name":"Steve Heyman","email":"steve@heyman.com","username":"hockeynut"},"change_message_id":"fc24459e8c9070a2ef14b53d9a80274ef1748d54","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        return resp"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def get_secret(self, secret_ref, payload_content_type\u003dNone):"},{"line_number":47,"context_line":"        \"\"\"Retrieves a secret and its payload."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"            :param secret_ref: A secret reference"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_29be4dd5","line":46,"updated":"2015-02-06 16:49:54.000000000","message":"blank line","commit_id":"3e5e2ef7448b3a3b6988f3abafd90586ebff60b1"}],"functionaltests/client/v1/smoke/test_containers.py":[{"author":{"_account_id":7262,"name":"John Vrbanac","email":"john.vrbanac@linux.com","username":"john.vrbanac"},"change_message_id":"0143c5c5e0cbf698f2c9c66c3fd999c0c7d04cfb","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"create_container_empty_data \u003d {"},{"line_number":43,"context_line":"    \"name\": None,"},{"line_number":44,"context_line":"    \"secrets\": []"},{"line_number":45,"context_line":"}"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_887066dd","line":44,"updated":"2015-02-04 21:11:26.000000000","message":"This was has a list and defaults_data has a dict. Which one?","commit_id":"7bc25b4403cf27b3adb17b4f5c11f0f47f718d49"},{"author":{"_account_id":7262,"name":"John Vrbanac","email":"john.vrbanac@linux.com","username":"john.vrbanac"},"change_message_id":"0143c5c5e0cbf698f2c9c66c3fd999c0c7d04cfb","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        create_container_rsa_data[\u0027private_key\u0027] \u003d secret_2"},{"line_number":74,"context_line":"        create_container_rsa_data[\u0027private_key_passphrase\u0027] \u003d secret_3"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        self.secret_id_1 \u003d secret_ref_1.split(\u0027/\u0027)[-1]"},{"line_number":77,"context_line":"        self.secret_id_2 \u003d secret_ref_2.split(\u0027/\u0027)[-1]"},{"line_number":78,"context_line":"        self.secret_id_3 \u003d secret_ref_3.split(\u0027/\u0027)[-1]"},{"line_number":79,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_880f8687","line":76,"updated":"2015-02-04 21:11:26.000000000","message":"These aren\u0027t used.","commit_id":"7bc25b4403cf27b3adb17b4f5c11f0f47f718d49"},{"author":{"_account_id":7262,"name":"John Vrbanac","email":"john.vrbanac@linux.com","username":"john.vrbanac"},"change_message_id":"0143c5c5e0cbf698f2c9c66c3fd999c0c7d04cfb","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        return secret_ref, secret"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def _get_a_secret(self, secret_id):"},{"line_number":91,"context_line":"        resp \u003d self.client.get(\u0027secrets/{0}\u0027.format(secret_id))"},{"line_number":92,"context_line":"        self.assertEqual(resp.status_code, 200)"},{"line_number":93,"context_line":"        return resp.json()"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_084476b5","line":90,"updated":"2015-02-04 21:11:26.000000000","message":"I don\u0027t think this is used.","commit_id":"7bc25b4403cf27b3adb17b4f5c11f0f47f718d49"},{"author":{"_account_id":7262,"name":"John Vrbanac","email":"john.vrbanac@linux.com","username":"john.vrbanac"},"change_message_id":"0143c5c5e0cbf698f2c9c66c3fd999c0c7d04cfb","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        self.assertIsNotNone(container_ref)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    @testcase.attr(\u0027positive\u0027)"},{"line_number":105,"context_line":"    def test_container_create_defaults(self):"},{"line_number":106,"context_line":"        \"\"\"Covers creating a container with three secret refs.\"\"\""},{"line_number":107,"context_line":"        test_model \u003d self.barbicanclient.containers.create("},{"line_number":108,"context_line":"            **create_container_defaults_data)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_08a55646","line":105,"updated":"2015-02-04 21:11:26.000000000","message":"Parameterize this test and create_empty.","commit_id":"7bc25b4403cf27b3adb17b4f5c11f0f47f718d49"},{"author":{"_account_id":7262,"name":"John Vrbanac","email":"john.vrbanac@linux.com","username":"john.vrbanac"},"change_message_id":"0143c5c5e0cbf698f2c9c66c3fd999c0c7d04cfb","unresolved":false,"context_lines":[{"line_number":188,"context_line":"        limit \u003d 10"},{"line_number":189,"context_line":"        offset \u003d 0"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"        for i in xrange(11):"},{"line_number":192,"context_line":"            test_model \u003d self.barbicanclient.containers.create("},{"line_number":193,"context_line":"                **create_container_defaults_data)"},{"line_number":194,"context_line":"            container_ref \u003d self.behaviors.create_container(test_model)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_837129aa","line":191,"updated":"2015-02-04 21:11:26.000000000","message":"How about (limit + 1). Also, xrange isn\u0027t Python 3 compatible","commit_id":"7bc25b4403cf27b3adb17b4f5c11f0f47f718d49"},{"author":{"_account_id":9234,"name":"Steve Heyman","email":"steve@heyman.com","username":"hockeynut"},"change_message_id":"fc13e676ebe0859ec6fbaa3bb1810df5f2a082fd","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        create_container_rsa_data[\u0027private_key_passphrase\u0027] \u003d secret_3"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def tearDown(self):"},{"line_number":77,"context_line":"        self.secret_behaviors.delete_all_created_secrets()"},{"line_number":78,"context_line":"        self.behaviors.delete_all_created_containers()"},{"line_number":79,"context_line":"        super(ContainersTestCase, self).tearDown()"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_07127761","line":77,"updated":"2015-02-05 20:58:56.000000000","message":"lets put a comment here about deleting the secrets FIRST since they are referenced by the containers.","commit_id":"50452da8b941262dacede1ee411b57f53edcf36d"},{"author":{"_account_id":13510,"name":"Thomas Dinkjian","email":"thomas.dinkjian@rackspace.com","username":"tdink"},"change_message_id":"df6c0fdd0026e38aa826c6205cc4c95b6f718c13","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        create_container_rsa_data[\u0027private_key_passphrase\u0027] \u003d secret_3"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def tearDown(self):"},{"line_number":77,"context_line":"        self.secret_behaviors.delete_all_created_secrets()"},{"line_number":78,"context_line":"        self.behaviors.delete_all_created_containers()"},{"line_number":79,"context_line":"        super(ContainersTestCase, self).tearDown()"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_9d5cf81a","line":77,"in_reply_to":"da86d52c_07127761","updated":"2015-02-05 21:32:56.000000000","message":"Done","commit_id":"50452da8b941262dacede1ee411b57f53edcf36d"}]}