)]}'
{"functionaltests/client/base.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"aeaf09744259224d9543310c904faaaa97449995","unresolved":false,"context_lines":[{"line_number":33,"context_line":"class TestCase(oslotest.BaseTestCase):"},{"line_number":34,"context_line":"    max_payload_size \u003d CONF.keymanager.max_payload_size"},{"line_number":35,"context_line":"    max_sized_payload \u003d u\u0027a\u0027 * max_payload_size"},{"line_number":36,"context_line":"    oversized_payload \u003d \u0027a\u0027 * (max_payload_size + 1)"},{"line_number":37,"context_line":"    max_field_size \u003d 255"},{"line_number":38,"context_line":"    max_sized_field \u003d \u0027a\u0027 * max_field_size"},{"line_number":39,"context_line":"    oversized_field \u003d \u0027a\u0027 * (max_field_size + 1)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_7f02a50a","line":36,"updated":"2015-03-16 23:14:16.000000000","message":"Should you fix all of these to be unicode now to match, or is this one different from the rest somehow?","commit_id":"28e8c7f758d42ab10a7a29fdfd02f2b0a33797e8"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"f389d6d4a5b584a99e5e0c118d0a466778bdda13","unresolved":false,"context_lines":[{"line_number":33,"context_line":"class TestCase(oslotest.BaseTestCase):"},{"line_number":34,"context_line":"    max_payload_size \u003d CONF.keymanager.max_payload_size"},{"line_number":35,"context_line":"    max_sized_payload \u003d u\u0027a\u0027 * max_payload_size"},{"line_number":36,"context_line":"    oversized_payload \u003d \u0027a\u0027 * (max_payload_size + 1)"},{"line_number":37,"context_line":"    max_field_size \u003d 255"},{"line_number":38,"context_line":"    max_sized_field \u003d \u0027a\u0027 * max_field_size"},{"line_number":39,"context_line":"    oversized_field \u003d \u0027a\u0027 * (max_field_size + 1)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_36d83d7f","line":36,"in_reply_to":"9a80dd14_02f78dd5","updated":"2015-03-17 13:49:07.000000000","message":"uhm...what about using six.u ?","commit_id":"28e8c7f758d42ab10a7a29fdfd02f2b0a33797e8"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"f0f73ea7bb93ff530fda1fe5408ae59989c96ae8","unresolved":false,"context_lines":[{"line_number":33,"context_line":"class TestCase(oslotest.BaseTestCase):"},{"line_number":34,"context_line":"    max_payload_size \u003d CONF.keymanager.max_payload_size"},{"line_number":35,"context_line":"    max_sized_payload \u003d u\u0027a\u0027 * max_payload_size"},{"line_number":36,"context_line":"    oversized_payload \u003d \u0027a\u0027 * (max_payload_size + 1)"},{"line_number":37,"context_line":"    max_field_size \u003d 255"},{"line_number":38,"context_line":"    max_sized_field \u003d \u0027a\u0027 * max_field_size"},{"line_number":39,"context_line":"    oversized_field \u003d \u0027a\u0027 * (max_field_size + 1)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_6fc2d387","line":36,"in_reply_to":"9a80dd14_36d83d7f","updated":"2015-03-17 15:45:52.000000000","message":"I don\u0027t think there\u0027s a need for six.u.  OpenStack clients only support Python 2.6, 2.7 and 3.4, and unicode (u) literals work in all of these versions.  six.u is only necessary for support Python 3.x versions where the unicode literal is unacceptable, such as 3.2.","commit_id":"28e8c7f758d42ab10a7a29fdfd02f2b0a33797e8"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"d2ee068b8943b0f9624a5fc3972ca62c9bad2445","unresolved":false,"context_lines":[{"line_number":33,"context_line":"class TestCase(oslotest.BaseTestCase):"},{"line_number":34,"context_line":"    max_payload_size \u003d CONF.keymanager.max_payload_size"},{"line_number":35,"context_line":"    max_sized_payload \u003d u\u0027a\u0027 * max_payload_size"},{"line_number":36,"context_line":"    oversized_payload \u003d \u0027a\u0027 * (max_payload_size + 1)"},{"line_number":37,"context_line":"    max_field_size \u003d 255"},{"line_number":38,"context_line":"    max_sized_field \u003d \u0027a\u0027 * max_field_size"},{"line_number":39,"context_line":"    oversized_field \u003d \u0027a\u0027 * (max_field_size + 1)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_8fd627c2","line":36,"in_reply_to":"9a80dd14_6fc2d387","updated":"2015-03-17 15:55:03.000000000","message":"I just don\u0027t understand why these all wouldn\u0027t be fixed at the same time, to be consistent, while we\u0027re already here...","commit_id":"28e8c7f758d42ab10a7a29fdfd02f2b0a33797e8"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"11ffde898d1f6f1a33f5b64528917aeba67467d6","unresolved":false,"context_lines":[{"line_number":33,"context_line":"class TestCase(oslotest.BaseTestCase):"},{"line_number":34,"context_line":"    max_payload_size \u003d CONF.keymanager.max_payload_size"},{"line_number":35,"context_line":"    max_sized_payload \u003d u\u0027a\u0027 * max_payload_size"},{"line_number":36,"context_line":"    oversized_payload \u003d \u0027a\u0027 * (max_payload_size + 1)"},{"line_number":37,"context_line":"    max_field_size \u003d 255"},{"line_number":38,"context_line":"    max_sized_field \u003d \u0027a\u0027 * max_field_size"},{"line_number":39,"context_line":"    oversized_field \u003d \u0027a\u0027 * (max_field_size + 1)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_02f78dd5","line":36,"in_reply_to":"9a80dd14_7f02a50a","updated":"2015-03-17 03:24:30.000000000","message":"They\u0027ll probably end up being unicode as well.  This is the first patch in a series to get the functional tests to pass.","commit_id":"28e8c7f758d42ab10a7a29fdfd02f2b0a33797e8"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"715891e7554c6a6da8e2ab09e20315b9f33d2762","unresolved":false,"context_lines":[{"line_number":33,"context_line":"class TestCase(oslotest.BaseTestCase):"},{"line_number":34,"context_line":"    max_payload_size \u003d CONF.keymanager.max_payload_size"},{"line_number":35,"context_line":"    max_sized_payload \u003d u\u0027a\u0027 * max_payload_size"},{"line_number":36,"context_line":"    oversized_payload \u003d \u0027a\u0027 * (max_payload_size + 1)"},{"line_number":37,"context_line":"    max_field_size \u003d 255"},{"line_number":38,"context_line":"    max_sized_field \u003d \u0027a\u0027 * max_field_size"},{"line_number":39,"context_line":"    oversized_field \u003d \u0027a\u0027 * (max_field_size + 1)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_2a40c906","line":36,"in_reply_to":"9a80dd14_8fd627c2","updated":"2015-03-17 16:00:39.000000000","message":"Sure, we could change everything at once, but the idea is to make incremental changes across several CRs to minimize the line count change in each CR.  This encourages quick reviews.","commit_id":"28e8c7f758d42ab10a7a29fdfd02f2b0a33797e8"}],"functionaltests/client/v1/functional/test_secrets.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"aeaf09744259224d9543310c904faaaa97449995","unresolved":false,"context_lines":[{"line_number":268,"context_line":"        self.assertIsNotNone(secret_ref)"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"        get_resp \u003d self.behaviors.get_secret(secret_ref)"},{"line_number":271,"context_line":"        self.assertEqual(test_model.payload, get_resp.payload)"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"    @utils.parameterized_dataset({"},{"line_number":274,"context_line":"        \u0027array\u0027: [[\u0027boom\u0027]],"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_5f2401b2","line":271,"updated":"2015-03-16 23:14:16.000000000","message":"My brain is a little bit shot right now, but doesn\u0027t this imply that what is being returned is encoded differently than before? Why/when did the return change, or am I misunderstanding?","commit_id":"28e8c7f758d42ab10a7a29fdfd02f2b0a33797e8"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"11ffde898d1f6f1a33f5b64528917aeba67467d6","unresolved":false,"context_lines":[{"line_number":268,"context_line":"        self.assertIsNotNone(secret_ref)"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"        get_resp \u003d self.behaviors.get_secret(secret_ref)"},{"line_number":271,"context_line":"        self.assertEqual(test_model.payload, get_resp.payload)"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"    @utils.parameterized_dataset({"},{"line_number":274,"context_line":"        \u0027array\u0027: [[\u0027boom\u0027]],"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_62fe89b0","line":271,"in_reply_to":"9a80dd14_5f2401b2","updated":"2015-03-17 03:24:30.000000000","message":"As we discussed in person, there was a patch earlier that deprecated setting your own payload_content type, so base64 is handled by the client now.","commit_id":"28e8c7f758d42ab10a7a29fdfd02f2b0a33797e8"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"d2ee068b8943b0f9624a5fc3972ca62c9bad2445","unresolved":false,"context_lines":[{"line_number":268,"context_line":"        self.assertIsNotNone(secret_ref)"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"        get_resp \u003d self.behaviors.get_secret(secret_ref)"},{"line_number":271,"context_line":"        self.assertEqual(test_model.payload, get_resp.payload)"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"    @utils.parameterized_dataset({"},{"line_number":274,"context_line":"        \u0027array\u0027: [[\u0027boom\u0027]],"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_cff73f58","line":271,"in_reply_to":"9a80dd14_62fe89b0","updated":"2015-03-17 15:55:03.000000000","message":"Cool, makes sense, and it is much less awkward now when storing/retrieving. :P","commit_id":"28e8c7f758d42ab10a7a29fdfd02f2b0a33797e8"}]}