)]}'
{"barbicanclient/secrets.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"56bfeaead2d1217e33b8bb8e12636d36925461c4","unresolved":false,"context_lines":[{"line_number":263,"context_line":""},{"line_number":264,"context_line":"        if not self.payload:"},{"line_number":265,"context_line":"            raise exceptions.NoPayloadException"},{"line_number":266,"context_line":"        if isinstance(self.payload, (list, int)):"},{"line_number":267,"context_line":"            raise exceptions.InvalidPayloadException"},{"line_number":268,"context_line":"        if self.payload_content_type:"},{"line_number":269,"context_line":"            \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_c385725a","line":266,"updated":"2015-03-17 08:30:52.000000000","message":"I am beginning to wonder if the \"no integers\" thing is an artificial restriction. What if my secret is the answer to life, the universe, and everything? Is there a huge difference between putting in 42 as an integer and \"42\" as a string? Any Integer can be easily stringified in Python... What do other people think?","commit_id":"94e49a4c1618bf320a03e0dc4664b989001554b2"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"7805b6875015a70f8e3230e3115033a64d1e3514","unresolved":false,"context_lines":[{"line_number":263,"context_line":""},{"line_number":264,"context_line":"        if not self.payload:"},{"line_number":265,"context_line":"            raise exceptions.NoPayloadException"},{"line_number":266,"context_line":"        if isinstance(self.payload, (list, int)):"},{"line_number":267,"context_line":"            raise exceptions.InvalidPayloadException"},{"line_number":268,"context_line":"        if self.payload_content_type:"},{"line_number":269,"context_line":"            \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_1e0259b4","line":266,"in_reply_to":"9a80dd14_95b54c80","updated":"2015-03-17 20:11:29.000000000","message":"Here is the comprehensive list of supported types:\n\nhttps://github.com/openstack/python-barbicanclient/blob/master/doc/source/usage.rst#secret-content-types\n\nUnicode in Python 3 is supported via six.text_type.","commit_id":"94e49a4c1618bf320a03e0dc4664b989001554b2"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"2e5939a39ff29144dda0c27e7618ab41f75acb32","unresolved":false,"context_lines":[{"line_number":263,"context_line":""},{"line_number":264,"context_line":"        if not self.payload:"},{"line_number":265,"context_line":"            raise exceptions.NoPayloadException"},{"line_number":266,"context_line":"        if isinstance(self.payload, (list, int)):"},{"line_number":267,"context_line":"            raise exceptions.InvalidPayloadException"},{"line_number":268,"context_line":"        if self.payload_content_type:"},{"line_number":269,"context_line":"            \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_c972df10","line":266,"in_reply_to":"9a80dd14_a3b4fed4","updated":"2015-03-17 15:32:22.000000000","message":"Could this be an `else` on the content_type check below? If the type of self.payload doesn\u0027t match a known six type, then raise this InvalidPayloadException? Otherwise, obviously we know what type it is and we can deal with it...","commit_id":"94e49a4c1618bf320a03e0dc4664b989001554b2"},{"author":{"_account_id":11970,"name":"Chelsea Winfree","email":"chelsea.winfree@gmail.com","username":"chellygel"},"change_message_id":"8760e4c62fa766b8bfe45860f4a2cfaeca3646bb","unresolved":false,"context_lines":[{"line_number":263,"context_line":""},{"line_number":264,"context_line":"        if not self.payload:"},{"line_number":265,"context_line":"            raise exceptions.NoPayloadException"},{"line_number":266,"context_line":"        if isinstance(self.payload, (list, int)):"},{"line_number":267,"context_line":"            raise exceptions.InvalidPayloadException"},{"line_number":268,"context_line":"        if self.payload_content_type:"},{"line_number":269,"context_line":"            \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_a3b4fed4","line":266,"in_reply_to":"9a80dd14_c385725a","updated":"2015-03-17 08:44:24.000000000","message":"str-ing the int sounds right to me. \n\n I guess we could try making sure everything is a string instead? if not str: \n\nIm really not sure how to handle this case. would love suggestions though.","commit_id":"94e49a4c1618bf320a03e0dc4664b989001554b2"},{"author":{"_account_id":8004,"name":"Paul Kehrer","email":"paul.l.kehrer@gmail.com","username":"reaperhulk"},"change_message_id":"c10b6dc71e617432b14db76ba77b06f95c780e90","unresolved":false,"context_lines":[{"line_number":263,"context_line":""},{"line_number":264,"context_line":"        if not self.payload:"},{"line_number":265,"context_line":"            raise exceptions.NoPayloadException"},{"line_number":266,"context_line":"        if isinstance(self.payload, (list, int)):"},{"line_number":267,"context_line":"            raise exceptions.InvalidPayloadException"},{"line_number":268,"context_line":"        if self.payload_content_type:"},{"line_number":269,"context_line":"            \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_fe667228","line":266,"in_reply_to":"9a80dd14_c972df10","updated":"2015-03-17 16:23:34.000000000","message":"I am -1 on implicitly stringifying other data types. A check to confirm str/bytes/unicode makes sense.","commit_id":"94e49a4c1618bf320a03e0dc4664b989001554b2"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"fb7ddd581257d3d0c2706d72523dc10178a0653d","unresolved":false,"context_lines":[{"line_number":263,"context_line":""},{"line_number":264,"context_line":"        if not self.payload:"},{"line_number":265,"context_line":"            raise exceptions.NoPayloadException"},{"line_number":266,"context_line":"        if isinstance(self.payload, (list, int)):"},{"line_number":267,"context_line":"            raise exceptions.InvalidPayloadException"},{"line_number":268,"context_line":"        if self.payload_content_type:"},{"line_number":269,"context_line":"            \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_95b54c80","line":266,"in_reply_to":"9a80dd14_fe667228","updated":"2015-03-17 19:15:26.000000000","message":"Ok, so an exhaustive list of our ACCEPTED types (for PY2) are:\n\nisinstance(self.payload, [str, bytes, unicode])\n\nFor PY3 \u0027unicode\u0027 isn\u0027t valid (as it is just str), so we\u0027d leave that out?\n\nIs this better than relying on six to match the content type below?","commit_id":"94e49a4c1618bf320a03e0dc4664b989001554b2"}],"functionaltests/client/v1/functional/test_secrets.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"56bfeaead2d1217e33b8bb8e12636d36925461c4","unresolved":false,"context_lines":[{"line_number":273,"context_line":"        self.assertEqual(test_model.payload, get_resp.payload)"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"    @utils.parameterized_dataset({"},{"line_number":276,"context_line":"        \u0027list\u0027: [[\u0027boom\u0027]],"},{"line_number":277,"context_line":"        \u0027int\u0027: [123]"},{"line_number":278,"context_line":"    })"},{"line_number":279,"context_line":"    @testcase.attr(\u0027negative\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_23dbae7e","line":276,"updated":"2015-03-17 08:30:52.000000000","message":"Do we check for tuples or dicts while we\u0027re at it?","commit_id":"94e49a4c1618bf320a03e0dc4664b989001554b2"},{"author":{"_account_id":11970,"name":"Chelsea Winfree","email":"chelsea.winfree@gmail.com","username":"chellygel"},"change_message_id":"8760e4c62fa766b8bfe45860f4a2cfaeca3646bb","unresolved":false,"context_lines":[{"line_number":273,"context_line":"        self.assertEqual(test_model.payload, get_resp.payload)"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"    @utils.parameterized_dataset({"},{"line_number":276,"context_line":"        \u0027list\u0027: [[\u0027boom\u0027]],"},{"line_number":277,"context_line":"        \u0027int\u0027: [123]"},{"line_number":278,"context_line":"    })"},{"line_number":279,"context_line":"    @testcase.attr(\u0027negative\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_43c5023c","line":276,"in_reply_to":"9a80dd14_23dbae7e","updated":"2015-03-17 08:44:24.000000000","message":"Will be in next patchset for sure. Iw ill bring this up for discussion w/ team.","commit_id":"94e49a4c1618bf320a03e0dc4664b989001554b2"}]}