)]}'
{"README.rst":[{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"197fce355eebe69e3e5566c96d324a333ad6b661","unresolved":false,"context_lines":[{"line_number":164,"context_line":"      secret get     Retrieve a secret by providing its URI."},{"line_number":165,"context_line":"      secret list    List secrets."},{"line_number":166,"context_line":"      secret store   Store a secret in Barbican."},{"line_number":167,"context_line":"      secret update  Update a secret with no Payload in Barbican."},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"* License: Apache License, Version 2.0"},{"line_number":170,"context_line":"* Documentation: http://docs.openstack.org/developer/python-barbicanclient"}],"source_content_type":"text/x-rst","patch_set":28,"id":"fa1b9901_527cca71","line":167,"updated":"2015-08-25 09:19:36.000000000","message":"nit: payload without the capital P","commit_id":"e651b1b21bc727158753fc22b5d374d571fe1e65"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"5b1b8a6d8364722783a088fa632cee0fd21f8606","unresolved":false,"context_lines":[{"line_number":164,"context_line":"      secret get     Retrieve a secret by providing its URI."},{"line_number":165,"context_line":"      secret list    List secrets."},{"line_number":166,"context_line":"      secret store   Store a secret in Barbican."},{"line_number":167,"context_line":"      secret update  Update a secret with no Payload in Barbican."},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"* License: Apache License, Version 2.0"},{"line_number":170,"context_line":"* Documentation: http://docs.openstack.org/developer/python-barbicanclient"}],"source_content_type":"text/x-rst","patch_set":28,"id":"fa1b9901_9e901def","line":167,"in_reply_to":"fa1b9901_527cca71","updated":"2015-08-25 14:57:36.000000000","message":"Done","commit_id":"e651b1b21bc727158753fc22b5d374d571fe1e65"}],"barbicanclient/barbican_cli/secrets.py":[{"author":{"_account_id":6783,"name":"Nathan Reller","email":"nathan.s.reller@gmail.com","username":"rellerreller"},"change_message_id":"b68cf52f41b8795281066f888a3591e85989e610","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        parser \u003d super(UpdateSecret, self).get_parser(prog_name)"},{"line_number":79,"context_line":"        parser.add_argument(\u0027URI\u0027, help\u003d\u0027The URI reference for the secret.\u0027)"},{"line_number":80,"context_line":"        parser.add_argument(\u0027--payload\u0027, \u0027-p\u0027,"},{"line_number":81,"context_line":"                            help\u003d\u0027the unencrypted secret; if provided, \u0027"},{"line_number":82,"context_line":"                                 \u0027you must also provide a \u0027"},{"line_number":83,"context_line":"                                 \u0027payload_content_type\u0027)"},{"line_number":84,"context_line":"        parser.add_argument(\u0027--payload_content_type\u0027, \u0027-t\u0027,"}],"source_content_type":"text/x-python","patch_set":15,"id":"9a41bdd9_425a62f3","line":81,"updated":"2015-07-15 19:26:23.000000000","message":"This must be provided, correct?","commit_id":"351cfbda002eb8af728d5205dfdad6391a37c0df"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"1a4bb2af630e2fe6c277f5f135e9cdb3d069774b","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        parser \u003d super(UpdateSecret, self).get_parser(prog_name)"},{"line_number":79,"context_line":"        parser.add_argument(\u0027URI\u0027, help\u003d\u0027The URI reference for the secret.\u0027)"},{"line_number":80,"context_line":"        parser.add_argument(\u0027--payload\u0027, \u0027-p\u0027,"},{"line_number":81,"context_line":"                            help\u003d\u0027the unencrypted secret; if provided, \u0027"},{"line_number":82,"context_line":"                                 \u0027you must also provide a \u0027"},{"line_number":83,"context_line":"                                 \u0027payload_content_type\u0027)"},{"line_number":84,"context_line":"        parser.add_argument(\u0027--payload_content_type\u0027, \u0027-t\u0027,"}],"source_content_type":"text/x-python","patch_set":15,"id":"3a50d1a3_748fb0cc","line":81,"in_reply_to":"9a41bdd9_425a62f3","updated":"2015-07-20 22:19:57.000000000","message":"payload is always required!!","commit_id":"351cfbda002eb8af728d5205dfdad6391a37c0df"},{"author":{"_account_id":6783,"name":"Nathan Reller","email":"nathan.s.reller@gmail.com","username":"rellerreller"},"change_message_id":"b68cf52f41b8795281066f888a3591e85989e610","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        parser.add_argument(\u0027--payload_content_type\u0027, \u0027-t\u0027,"},{"line_number":85,"context_line":"                            help\u003d\u0027the type/format of the provided \u0027"},{"line_number":86,"context_line":"                                 \u0027secret data; \"text/plain\" is assumed to be \u0027"},{"line_number":87,"context_line":"                                 \u0027UTF-8; required when --payload is \u0027"},{"line_number":88,"context_line":"                                 \u0027supplied.\u0027)"},{"line_number":89,"context_line":"        parser.add_argument(\u0027--payload_content_encoding\u0027, \u0027-e\u0027,"},{"line_number":90,"context_line":"                            help\u003d\u0027required if --payload-content-type is \u0027"}],"source_content_type":"text/x-python","patch_set":15,"id":"9a41bdd9_0271ba75","line":87,"updated":"2015-07-15 19:26:23.000000000","message":"This must be provided, correct?","commit_id":"351cfbda002eb8af728d5205dfdad6391a37c0df"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"1a4bb2af630e2fe6c277f5f135e9cdb3d069774b","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        parser.add_argument(\u0027--payload_content_type\u0027, \u0027-t\u0027,"},{"line_number":85,"context_line":"                            help\u003d\u0027the type/format of the provided \u0027"},{"line_number":86,"context_line":"                                 \u0027secret data; \"text/plain\" is assumed to be \u0027"},{"line_number":87,"context_line":"                                 \u0027UTF-8; required when --payload is \u0027"},{"line_number":88,"context_line":"                                 \u0027supplied.\u0027)"},{"line_number":89,"context_line":"        parser.add_argument(\u0027--payload_content_encoding\u0027, \u0027-e\u0027,"},{"line_number":90,"context_line":"                            help\u003d\u0027required if --payload-content-type is \u0027"}],"source_content_type":"text/x-python","patch_set":15,"id":"3a50d1a3_94b11c92","line":87,"in_reply_to":"9a41bdd9_0271ba75","updated":"2015-07-20 22:19:57.000000000","message":"payload_content_type always required!!","commit_id":"351cfbda002eb8af728d5205dfdad6391a37c0df"},{"author":{"_account_id":6783,"name":"Nathan Reller","email":"nathan.s.reller@gmail.com","username":"rellerreller"},"change_message_id":"8899b0a0de8c53e59c1aefca83dfc747d91eb575","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    def get_parser(self, prog_name):"},{"line_number":78,"context_line":"        parser \u003d super(UpdateSecret, self).get_parser(prog_name)"},{"line_number":79,"context_line":"        parser.add_argument(\u0027URI\u0027, help\u003d\u0027The URI reference for the secret.\u0027)"},{"line_number":80,"context_line":"        parser.add_argument(\u0027--payload\u0027, \u0027-p\u0027,"},{"line_number":81,"context_line":"                            help\u003d\u0027the unencrypted secret; if provided, \u0027"},{"line_number":82,"context_line":"                                 \u0027you must also provide a \u0027"},{"line_number":83,"context_line":"                                 \u0027payload_content_type\u0027)"}],"source_content_type":"text/x-python","patch_set":17,"id":"3a50d1a3_df119b05","line":80,"updated":"2015-07-22 13:33:58.000000000","message":"If payload and payload_content_type are required then why not make the command\n\n`barbican secret update \u003curi\u003e \u003cpayload\u003e \u003cpayload_content_type\u003e [payload_content_encoding]`\n\nThis would remove the flag component from a couple of the items that are required.","commit_id":"fb20a24773cbf93ac5c7baacd0c97ec85752df7e"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"e6dc0cdd6a424b4e7ca163becf1c15b516dc0346","unresolved":false,"context_lines":[{"line_number":88,"context_line":"                                 \u0027supplied.\u0027)"},{"line_number":89,"context_line":"        parser.add_argument(\u0027--payload_content_encoding\u0027, \u0027-e\u0027,"},{"line_number":90,"context_line":"                            help\u003d\u0027required if --payload-content-type is \u0027"},{"line_number":91,"context_line":"                                 \u0027\"application/octet-stream\".\u0027)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        return parser"},{"line_number":94,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"3a50d1a3_5c31d958","line":91,"updated":"2015-07-23 12:15:39.000000000","message":"IIRC this one is not applicable any more.","commit_id":"2358cd79a86603d3ee58f88e3d2dd536081149e7"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"1dd1c635f58167fb2fb17577d51b63abaed33b2f","unresolved":false,"context_lines":[{"line_number":88,"context_line":"                                 \u0027supplied.\u0027)"},{"line_number":89,"context_line":"        parser.add_argument(\u0027--payload_content_encoding\u0027, \u0027-e\u0027,"},{"line_number":90,"context_line":"                            help\u003d\u0027required if --payload-content-type is \u0027"},{"line_number":91,"context_line":"                                 \u0027\"application/octet-stream\".\u0027)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        return parser"},{"line_number":94,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"3a50d1a3_e901f705","line":91,"in_reply_to":"3a50d1a3_5c31d958","updated":"2015-07-23 16:53:19.000000000","message":"Hello Juan, So now we just input the payload content type as application/octet-stream and no payload_content_encoding and the secret will be added without error? Please explain.\n\nIf so I can remove all the payload_content_encoding lookups in the client.\n\nThanks","commit_id":"2358cd79a86603d3ee58f88e3d2dd536081149e7"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"5fdc9ac955079ad89f657e486b14006d6614339f","unresolved":false,"context_lines":[{"line_number":88,"context_line":"                                 \u0027supplied.\u0027)"},{"line_number":89,"context_line":"        parser.add_argument(\u0027--payload_content_encoding\u0027, \u0027-e\u0027,"},{"line_number":90,"context_line":"                            help\u003d\u0027required if --payload-content-type is \u0027"},{"line_number":91,"context_line":"                                 \u0027\"application/octet-stream\".\u0027)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        return parser"},{"line_number":94,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"3a50d1a3_50e3dc33","line":91,"in_reply_to":"3a50d1a3_e901f705","updated":"2015-07-23 21:02:13.000000000","message":"Looked Deeper into the code and just removed this.\nNo worries.","commit_id":"2358cd79a86603d3ee58f88e3d2dd536081149e7"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"251576aad75a7c7492b1230a31139543a4017fe7","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"class UpdateSecret(show.ShowOne):"},{"line_number":75,"context_line":"    \"\"\"Update a secret with no Payload in Barbican.\"\"\""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def get_parser(self, prog_name):"},{"line_number":78,"context_line":"        parser \u003d super(UpdateSecret, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":26,"id":"1a4dcd0f_af76bca1","line":75,"updated":"2015-08-21 19:21:52.000000000","message":"nit: payload doesn\u0027t need to be capitalized","commit_id":"cf6f0e00873dcd007dbe9897080cb388f29b708d"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"447e2faaf50920e6d8db656db82f76b4b2755089","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"class UpdateSecret(show.ShowOne):"},{"line_number":75,"context_line":"    \"\"\"Update a secret with no Payload in Barbican.\"\"\""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def get_parser(self, prog_name):"},{"line_number":78,"context_line":"        parser \u003d super(UpdateSecret, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":26,"id":"fa1b9901_02e707e5","line":75,"in_reply_to":"1a4dcd0f_af76bca1","updated":"2015-08-24 15:26:47.000000000","message":"Done","commit_id":"cf6f0e00873dcd007dbe9897080cb388f29b708d"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"251576aad75a7c7492b1230a31139543a4017fe7","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        parser \u003d super(UpdateSecret, self).get_parser(prog_name)"},{"line_number":79,"context_line":"        parser.add_argument(\u0027URI\u0027, help\u003d\u0027The URI reference for the secret.\u0027)"},{"line_number":80,"context_line":"        parser.add_argument(\u0027payload\u0027,"},{"line_number":81,"context_line":"                            help\u003d\u0027the unencrypted secret\u0027)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        return parser"},{"line_number":84,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"1a4dcd0f_cfa0e8f6","line":81,"updated":"2015-08-21 19:21:52.000000000","message":"nit: this could fit on the previous line","commit_id":"cf6f0e00873dcd007dbe9897080cb388f29b708d"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"447e2faaf50920e6d8db656db82f76b4b2755089","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        parser \u003d super(UpdateSecret, self).get_parser(prog_name)"},{"line_number":79,"context_line":"        parser.add_argument(\u0027URI\u0027, help\u003d\u0027The URI reference for the secret.\u0027)"},{"line_number":80,"context_line":"        parser.add_argument(\u0027payload\u0027,"},{"line_number":81,"context_line":"                            help\u003d\u0027the unencrypted secret\u0027)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        return parser"},{"line_number":84,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"fa1b9901_42797ffb","line":81,"in_reply_to":"1a4dcd0f_cfa0e8f6","updated":"2015-08-24 15:26:47.000000000","message":"Done","commit_id":"cf6f0e00873dcd007dbe9897080cb388f29b708d"}],"barbicanclient/client.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"e05ca750b04aff65e9cf0fa769f8ffbbfa7433ac","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        if not path[-1] \u003d\u003d \u0027/\u0027:"},{"line_number":80,"context_line":"            path +\u003d \u0027/\u0027"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        return super(_HTTPClient, self).put(path, *args, **kwargs)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    def _get_raw(self, path, *args, **kwargs):"},{"line_number":85,"context_line":"        return self.request(path, \u0027GET\u0027, *args, **kwargs).content"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba3cc151_4f5ddd13","line":82,"updated":"2015-07-01 21:05:32.000000000","message":"Should this also return the .json() representation, in line with the other functions? Is a json response to a PUT something valid/expected, or would we expect to never receive a json body?","commit_id":"6ebb3b2f2cf6f39a335ce46101543796a7f20302"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"4ff5c2ed0cd81a57a3d2c6aa7b22f5fb15efaad4","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        if not path[-1] \u003d\u003d \u0027/\u0027:"},{"line_number":80,"context_line":"            path +\u003d \u0027/\u0027"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        return super(_HTTPClient, self).put(path, *args, **kwargs)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    def _get_raw(self, path, *args, **kwargs):"},{"line_number":85,"context_line":"        return self.request(path, \u0027GET\u0027, *args, **kwargs).content"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba3cc151_8d664db9","line":82,"in_reply_to":"ba3cc151_4f5ddd13","updated":"2015-07-03 02:57:52.000000000","message":"The response does not return any JSON according to http://docs.openstack.org/developer/barbican/api/reference/secrets.html. If I use .json() I receive a simplejson.scanner.JSONDecodeError: Expecting value: line 1 column 1 (char 0) error.","commit_id":"6ebb3b2f2cf6f39a335ce46101543796a7f20302"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"1fec77867ba2fac36fd234394118e72790af54ad","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        return super(_HTTPClient, self).post(path, *args, **kwargs).json()"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def put(self, path, *args, **kwargs):"},{"line_number":79,"context_line":"        if not path[-1] \u003d\u003d \u0027/\u0027:"},{"line_number":80,"context_line":"            path +\u003d \u0027/\u0027"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        return super(_HTTPClient, self).put(path, *args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba3cc151_e77ac623","line":79,"updated":"2015-07-08 19:57:05.000000000","message":"make this a private function:\n\n  def _fix_path(path)\n    if not path[-1] \u003d\u003d \u0027/\u0027:\n      path +\u003d \u0027/\u0027\n    return path\n\nand use it for lines 72-73 and 79-80","commit_id":"faa88601b5869d4896969d06edaf10f4c32a6b23"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"43250aa4e79e10fe961a9e89707b681565762389","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        return super(_HTTPClient, self).post(path, *args, **kwargs).json()"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def put(self, path, *args, **kwargs):"},{"line_number":79,"context_line":"        if not path[-1] \u003d\u003d \u0027/\u0027:"},{"line_number":80,"context_line":"            path +\u003d \u0027/\u0027"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        return super(_HTTPClient, self).put(path, *args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba3cc151_4449f75e","line":79,"in_reply_to":"ba3cc151_e77ac623","updated":"2015-07-09 18:37:05.000000000","message":"Good Idea","commit_id":"faa88601b5869d4896969d06edaf10f4c32a6b23"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"f1208a879a78eec3d616bb452e42cf920d6330c5","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        return super(_HTTPClient, self).post(path, *args, **kwargs).json()"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def put(self, path, *args, **kwargs):"},{"line_number":83,"context_line":"        path \u003d self._fix_path(path)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        return super(_HTTPClient, self).put(path, *args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba3cc151_d375bd97","line":82,"updated":"2015-07-09 20:54:40.000000000","message":"Removed, since nothing is returned and post does not need to be altered.","commit_id":"5baaf5b8a9a19a75a8563fdc1db159d0c30d7f95"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"997fc9e909ed7562f4025fb8b8c77ef9dd7e0cce","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        return super(_HTTPClient, self).post(path, *args, **kwargs).json()"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def put(self, path, *args, **kwargs):"},{"line_number":83,"context_line":"        path \u003d self._fix_path(path)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        return super(_HTTPClient, self).put(path, *args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba3cc151_13efa5e9","line":82,"in_reply_to":"ba3cc151_d375bd97","updated":"2015-07-09 20:55:27.000000000","message":"correction-\u003eput instead of post....","commit_id":"5baaf5b8a9a19a75a8563fdc1db159d0c30d7f95"},{"author":{"_account_id":6783,"name":"Nathan Reller","email":"nathan.s.reller@gmail.com","username":"rellerreller"},"change_message_id":"b68cf52f41b8795281066f888a3591e85989e610","unresolved":false,"context_lines":[{"line_number":52,"context_line":"            # If provided we\u0027ll include the project ID in all requests."},{"line_number":53,"context_line":"            self._default_headers \u003d {\u0027X-Project-Id\u0027: project_id}"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def _fix_path(self, path):"},{"line_number":56,"context_line":"        if not path[-1] \u003d\u003d \u0027/\u0027:"},{"line_number":57,"context_line":"            path +\u003d \u0027/\u0027"},{"line_number":58,"context_line":"        return path"}],"source_content_type":"text/x-python","patch_set":15,"id":"9a41bdd9_9f752133","line":55,"updated":"2015-07-15 19:26:23.000000000","message":"nit: do Barbican private methods usually go at end of class definition?\n\nNo -1 just wondering about consensus of community.","commit_id":"351cfbda002eb8af728d5205dfdad6391a37c0df"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"1a4bb2af630e2fe6c277f5f135e9cdb3d069774b","unresolved":false,"context_lines":[{"line_number":52,"context_line":"            # If provided we\u0027ll include the project ID in all requests."},{"line_number":53,"context_line":"            self._default_headers \u003d {\u0027X-Project-Id\u0027: project_id}"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def _fix_path(self, path):"},{"line_number":56,"context_line":"        if not path[-1] \u003d\u003d \u0027/\u0027:"},{"line_number":57,"context_line":"            path +\u003d \u0027/\u0027"},{"line_number":58,"context_line":"        return path"}],"source_content_type":"text/x-python","patch_set":15,"id":"9a41bdd9_09d311d6","line":55,"in_reply_to":"9a41bdd9_9f752133","updated":"2015-07-20 22:19:57.000000000","message":"True, all the private methods are towards the bottom. I moved mine so that it conforms to the community standards.","commit_id":"351cfbda002eb8af728d5205dfdad6391a37c0df"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"e6dc0cdd6a424b4e7ca163becf1c15b516dc0346","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    def _fix_path(self, path):"},{"line_number":78,"context_line":"        if not path[-1] \u003d\u003d \u0027/\u0027:"},{"line_number":79,"context_line":"            path +\u003d \u0027/\u0027"},{"line_number":80,"context_line":"        return path"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def _get_raw(self, path, *args, **kwargs):"},{"line_number":83,"context_line":"        return self.request(path, \u0027GET\u0027, *args, **kwargs).content"}],"source_content_type":"text/x-python","patch_set":18,"id":"3a50d1a3_7c4db5c2","line":80,"updated":"2015-07-23 12:15:39.000000000","message":"wouldn\u0027t this be needed for a \"put\" function also? Since that\u0027s what you\u0027re using for the secret.update function that you defined in the secrets.py file.","commit_id":"2358cd79a86603d3ee58f88e3d2dd536081149e7"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"1dd1c635f58167fb2fb17577d51b63abaed33b2f","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    def _fix_path(self, path):"},{"line_number":78,"context_line":"        if not path[-1] \u003d\u003d \u0027/\u0027:"},{"line_number":79,"context_line":"            path +\u003d \u0027/\u0027"},{"line_number":80,"context_line":"        return path"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def _get_raw(self, path, *args, **kwargs):"},{"line_number":83,"context_line":"        return self.request(path, \u0027GET\u0027, *args, **kwargs).content"}],"source_content_type":"text/x-python","patch_set":18,"id":"3a50d1a3_4f526b36","line":80,"in_reply_to":"3a50d1a3_7c4db5c2","updated":"2015-07-23 16:53:19.000000000","message":"put is not needed here since it does not return anything.\npost returns a json.","commit_id":"2358cd79a86603d3ee58f88e3d2dd536081149e7"},{"author":{"_account_id":17579,"name":"Elvin Tubillara","email":"edtubill@us.ibm.com","username":"edtubill"},"change_message_id":"7e074fcb6f263cacb4ad8ae1f52131a75b6b0400","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        return super(_HTTPClient, self).get(*args, **kwargs).json()"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def post(self, path, *args, **kwargs):"},{"line_number":73,"context_line":"        path \u003d self._fix_path(path)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        return super(_HTTPClient, self).post(path, *args, **kwargs).json()"}],"source_content_type":"text/x-python","patch_set":29,"id":"fa1b9901_11015b38","line":72,"updated":"2015-08-25 18:50:52.000000000","message":"Is this refactoring really needed? I guess it\u0027s fine if in the future another rest method needs the path fix.","commit_id":"34256de82d61a7030204a715dd2901dddb46c8e9"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"106f25d28988103012a73956ada11195e798d9c8","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        return super(_HTTPClient, self).get(*args, **kwargs).json()"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def post(self, path, *args, **kwargs):"},{"line_number":73,"context_line":"        path \u003d self._fix_path(path)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        return super(_HTTPClient, self).post(path, *args, **kwargs).json()"}],"source_content_type":"text/x-python","patch_set":29,"id":"fa1b9901_81118e06","line":72,"in_reply_to":"fa1b9901_11015b38","updated":"2015-08-25 19:33:19.000000000","message":"We can leave this as is in case PUT or any other REST call needs to be overwritten in the future.","commit_id":"34256de82d61a7030204a715dd2901dddb46c8e9"}],"barbicanclient/secrets.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"e05ca750b04aff65e9cf0fa769f8ffbbfa7433ac","unresolved":false,"context_lines":[{"line_number":269,"context_line":"        }"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"        if not self.payload:"},{"line_number":272,"context_line":"            raise exceptions.PayloadException(\"Missing Payload\")"},{"line_number":273,"context_line":"        if not isinstance(self.payload, (six.text_type, six.binary_type)):"},{"line_number":274,"context_line":"            raise exceptions.PayloadException(\"Invalid Payload Type\")"},{"line_number":275,"context_line":"        if self.payload_content_type or self.payload_content_encoding:"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba3cc151_4fbf1daa","line":272,"updated":"2015-07-01 21:05:32.000000000","message":"So, I would assume this needs to be removed?","commit_id":"6ebb3b2f2cf6f39a335ce46101543796a7f20302"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"4ff5c2ed0cd81a57a3d2c6aa7b22f5fb15efaad4","unresolved":false,"context_lines":[{"line_number":269,"context_line":"        }"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"        if not self.payload:"},{"line_number":272,"context_line":"            raise exceptions.PayloadException(\"Missing Payload\")"},{"line_number":273,"context_line":"        if not isinstance(self.payload, (six.text_type, six.binary_type)):"},{"line_number":274,"context_line":"            raise exceptions.PayloadException(\"Invalid Payload Type\")"},{"line_number":275,"context_line":"        if self.payload_content_type or self.payload_content_encoding:"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba3cc151_5a3a4b9a","line":272,"in_reply_to":"ba3cc151_4fbf1daa","updated":"2015-07-03 02:57:52.000000000","message":"Done","commit_id":"6ebb3b2f2cf6f39a335ce46101543796a7f20302"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"e05ca750b04aff65e9cf0fa769f8ffbbfa7433ac","unresolved":false,"context_lines":[{"line_number":454,"context_line":"        if not payload:"},{"line_number":455,"context_line":"            raise ValueError(\u0027payload is required.\u0027)"},{"line_number":456,"context_line":"        if not payload_content_type:"},{"line_number":457,"context_line":"            raise ValueError(\u0027payload_content_type is required.\u0027)"},{"line_number":458,"context_line":""},{"line_number":459,"context_line":"        headers \u003d {\u0027content-type\u0027: payload_content_type}"},{"line_number":460,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ba3cc151_0f3ef58b","line":457,"updated":"2015-07-01 21:05:32.000000000","message":"None of these `if` checks SHOULD be required, as the arguments are non-optional. If the user physically passes in a None, that\u0027s their own problem. It don\u0027t think it is standard practice to validate this in Python. Was there a specific reason you added these?","commit_id":"6ebb3b2f2cf6f39a335ce46101543796a7f20302"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"4ff5c2ed0cd81a57a3d2c6aa7b22f5fb15efaad4","unresolved":false,"context_lines":[{"line_number":454,"context_line":"        if not payload:"},{"line_number":455,"context_line":"            raise ValueError(\u0027payload is required.\u0027)"},{"line_number":456,"context_line":"        if not payload_content_type:"},{"line_number":457,"context_line":"            raise ValueError(\u0027payload_content_type is required.\u0027)"},{"line_number":458,"context_line":""},{"line_number":459,"context_line":"        headers \u003d {\u0027content-type\u0027: payload_content_type}"},{"line_number":460,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ba3cc151_9484290b","line":457,"in_reply_to":"ba3cc151_0f3ef58b","updated":"2015-07-03 02:57:52.000000000","message":"True, when this function is run it performs a PUT, and if parameters are missing, an internal server error will be sent. I was wanting to describe what the exact problem was to the user. I will remove so that it follow the standard of this project.","commit_id":"6ebb3b2f2cf6f39a335ce46101543796a7f20302"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"1fec77867ba2fac36fd234394118e72790af54ad","unresolved":false,"context_lines":[{"line_number":209,"context_line":"        self._mode \u003d value"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    @payload.setter"},{"line_number":212,"context_line":"    # @immutable_after_save"},{"line_number":213,"context_line":"    def payload(self, value):"},{"line_number":214,"context_line":"        self._payload \u003d value"},{"line_number":215,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"ba3cc151_c796a24b","line":212,"updated":"2015-07-08 19:57:05.000000000","message":"bleh, don\u0027t leave commented out decorators around","commit_id":"faa88601b5869d4896969d06edaf10f4c32a6b23"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"43250aa4e79e10fe961a9e89707b681565762389","unresolved":false,"context_lines":[{"line_number":209,"context_line":"        self._mode \u003d value"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    @payload.setter"},{"line_number":212,"context_line":"    # @immutable_after_save"},{"line_number":213,"context_line":"    def payload(self, value):"},{"line_number":214,"context_line":"        self._payload \u003d value"},{"line_number":215,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"ba3cc151_7352f4df","line":212,"in_reply_to":"ba3cc151_c796a24b","updated":"2015-07-09 18:37:05.000000000","message":"gotcha","commit_id":"faa88601b5869d4896969d06edaf10f4c32a6b23"},{"author":{"_account_id":14926,"name":"Jeff Feng","email":"jianhua@us.ibm.com","username":"jhfeng"},"change_message_id":"8c5cb9911b97191f2fa6b9a31e9a55694e9f28e2","unresolved":false,"context_lines":[{"line_number":438,"context_line":"        :param str payload_content_type: DEPRECATED: Content type to use for"},{"line_number":439,"context_line":"            payload decryption. Setting this can lead to unexpected results."},{"line_number":440,"context_line":"            See Launchpad Bug #1419166."},{"line_number":441,"context_line":"        :returns: Secret object retrieved from Barbican"},{"line_number":442,"context_line":"        :raises barbicanclient.exceptions.HTTPAuthError: 401 Responses"},{"line_number":443,"context_line":"        :raises barbicanclient.exceptions.HTTPClientError: 4xx Responses"},{"line_number":444,"context_line":"        :raises barbicanclient.exceptions.HTTPServerError: 5xx Responses"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba3cc151_0d0eeb8b","line":441,"updated":"2015-07-08 20:58:23.000000000","message":"Incorrect parameters here.\n1) missing input payload_content_encoding\n2) do you really have return for this function ?\n3) if payload_content_type is deprecated, should we avoid to use it ?","commit_id":"faa88601b5869d4896969d06edaf10f4c32a6b23"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"43250aa4e79e10fe961a9e89707b681565762389","unresolved":false,"context_lines":[{"line_number":438,"context_line":"        :param str payload_content_type: DEPRECATED: Content type to use for"},{"line_number":439,"context_line":"            payload decryption. Setting this can lead to unexpected results."},{"line_number":440,"context_line":"            See Launchpad Bug #1419166."},{"line_number":441,"context_line":"        :returns: Secret object retrieved from Barbican"},{"line_number":442,"context_line":"        :raises barbicanclient.exceptions.HTTPAuthError: 401 Responses"},{"line_number":443,"context_line":"        :raises barbicanclient.exceptions.HTTPClientError: 4xx Responses"},{"line_number":444,"context_line":"        :raises barbicanclient.exceptions.HTTPServerError: 5xx Responses"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba3cc151_c4dae74a","line":441,"in_reply_to":"ba3cc151_0d0eeb8b","updated":"2015-07-09 18:37:05.000000000","message":"I fixed all these:\n\n1.) Payload content encoding has been added.\n2.) Function does not need to be returned.\n3.) Not deprecated, it is still needed.","commit_id":"faa88601b5869d4896969d06edaf10f4c32a6b23"},{"author":{"_account_id":6783,"name":"Nathan Reller","email":"nathan.s.reller@gmail.com","username":"rellerreller"},"change_message_id":"b68cf52f41b8795281066f888a3591e85989e610","unresolved":false,"context_lines":[{"line_number":180,"context_line":"            try:"},{"line_number":181,"context_line":"                self._fetch_payload()"},{"line_number":182,"context_line":"            except ValueError:"},{"line_number":183,"context_line":"                return \u0027NO PAYLOAD HAS BEEN SETUP\u0027"},{"line_number":184,"context_line":"        return self._payload"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    @name.setter"}],"source_content_type":"text/x-python","patch_set":15,"id":"9a41bdd9_bf1a65c4","line":183,"updated":"2015-07-15 19:26:23.000000000","message":"Why not return None instead of this string?","commit_id":"351cfbda002eb8af728d5205dfdad6391a37c0df"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"1a4bb2af630e2fe6c277f5f135e9cdb3d069774b","unresolved":false,"context_lines":[{"line_number":180,"context_line":"            try:"},{"line_number":181,"context_line":"                self._fetch_payload()"},{"line_number":182,"context_line":"            except ValueError:"},{"line_number":183,"context_line":"                return \u0027NO PAYLOAD HAS BEEN SETUP\u0027"},{"line_number":184,"context_line":"        return self._payload"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    @name.setter"}],"source_content_type":"text/x-python","patch_set":15,"id":"9a41bdd9_89df21d5","line":183,"in_reply_to":"9a41bdd9_bf1a65c4","updated":"2015-07-20 22:19:57.000000000","message":"Makes more sense!!","commit_id":"351cfbda002eb8af728d5205dfdad6391a37c0df"},{"author":{"_account_id":6783,"name":"Nathan Reller","email":"nathan.s.reller@gmail.com","username":"rellerreller"},"change_message_id":"b68cf52f41b8795281066f888a3591e85989e610","unresolved":false,"context_lines":[{"line_number":268,"context_line":"        }"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"        if self.payload \u003d\u003d \u0027\u0027:"},{"line_number":271,"context_line":"            raise exceptions.PayloadException(\"Invalid Payload Type\")"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"        if not isinstance(self.payload, (six.text_type, six.binary_type)):"},{"line_number":274,"context_line":"            if self.payload is not None:"}],"source_content_type":"text/x-python","patch_set":15,"id":"9a41bdd9_5f4d5998","line":271,"updated":"2015-07-15 19:26:23.000000000","message":"I think this exception is a little confusing because the type is ok because string, but I think you are really saying a payload must contain \u003e 0 bytes.","commit_id":"351cfbda002eb8af728d5205dfdad6391a37c0df"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"1a4bb2af630e2fe6c277f5f135e9cdb3d069774b","unresolved":false,"context_lines":[{"line_number":268,"context_line":"        }"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"        if self.payload \u003d\u003d \u0027\u0027:"},{"line_number":271,"context_line":"            raise exceptions.PayloadException(\"Invalid Payload Type\")"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"        if not isinstance(self.payload, (six.text_type, six.binary_type)):"},{"line_number":274,"context_line":"            if self.payload is not None:"}],"source_content_type":"text/x-python","patch_set":15,"id":"9a41bdd9_e9102d5b","line":271,"in_reply_to":"9a41bdd9_5f4d5998","updated":"2015-07-20 22:19:57.000000000","message":"The code below on line 273 covers all strings. But it needs to fail at an empty string. What would you suggest to do for this change? Can a payload be a space?","commit_id":"351cfbda002eb8af728d5205dfdad6391a37c0df"},{"author":{"_account_id":6783,"name":"Nathan Reller","email":"nathan.s.reller@gmail.com","username":"rellerreller"},"change_message_id":"b68cf52f41b8795281066f888a3591e85989e610","unresolved":false,"context_lines":[{"line_number":271,"context_line":"            raise exceptions.PayloadException(\"Invalid Payload Type\")"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"        if not isinstance(self.payload, (six.text_type, six.binary_type)):"},{"line_number":274,"context_line":"            if self.payload is not None:"},{"line_number":275,"context_line":"                raise exceptions.PayloadException(\"Invalid Payload Type\")"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"        if self.payload_content_type or self.payload_content_encoding:"}],"source_content_type":"text/x-python","patch_set":15,"id":"9a41bdd9_ffaead2c","line":274,"updated":"2015-07-15 19:26:23.000000000","message":"nit: can combine with and statement.","commit_id":"351cfbda002eb8af728d5205dfdad6391a37c0df"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"1a4bb2af630e2fe6c277f5f135e9cdb3d069774b","unresolved":false,"context_lines":[{"line_number":271,"context_line":"            raise exceptions.PayloadException(\"Invalid Payload Type\")"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"        if not isinstance(self.payload, (six.text_type, six.binary_type)):"},{"line_number":274,"context_line":"            if self.payload is not None:"},{"line_number":275,"context_line":"                raise exceptions.PayloadException(\"Invalid Payload Type\")"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"        if self.payload_content_type or self.payload_content_encoding:"}],"source_content_type":"text/x-python","patch_set":15,"id":"9a41bdd9_49c279ea","line":274,"in_reply_to":"9a41bdd9_ffaead2c","updated":"2015-07-20 22:19:57.000000000","message":"Done","commit_id":"351cfbda002eb8af728d5205dfdad6391a37c0df"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"efcc856da25c24498c79feab3212a9a8a286997d","unresolved":false,"context_lines":[{"line_number":281,"context_line":"            \u0027expiration\u0027: self.expiration"},{"line_number":282,"context_line":"        }"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"        if self.payload \u003d\u003d \u0027\u0027:"},{"line_number":285,"context_line":"            raise exceptions.PayloadException(\"Invalid Payload Type\")"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"        if not isinstance(self.payload, (six.text_type, six.binary_type)) \\"}],"source_content_type":"text/x-python","patch_set":22,"id":"3a50d1a3_1078f48e","line":284,"updated":"2015-07-23 21:02:07.000000000","message":"Maybe there\u0027s a better way of doing this?\nAny Suggestions.","commit_id":"b915ff2ace020273f86cc991a17ece743a2a7098"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"f327a65a29113f8309a09635d21f142ba5d61114","unresolved":false,"context_lines":[{"line_number":281,"context_line":"            \u0027expiration\u0027: self.expiration"},{"line_number":282,"context_line":"        }"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"        if self.payload \u003d\u003d \u0027\u0027:"},{"line_number":285,"context_line":"            raise exceptions.PayloadException(\"Invalid Payload Type\")"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"        if not isinstance(self.payload, (six.text_type, six.binary_type)) \\"}],"source_content_type":"text/x-python","patch_set":22,"id":"1a4dcd0f_1b5dae14","line":284,"in_reply_to":"3a50d1a3_1078f48e","updated":"2015-08-06 19:22:47.000000000","message":"Not sure this test is necessary anymore.  See comment below.","commit_id":"b915ff2ace020273f86cc991a17ece743a2a7098"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"f327a65a29113f8309a09635d21f142ba5d61114","unresolved":false,"context_lines":[{"line_number":285,"context_line":"            raise exceptions.PayloadException(\"Invalid Payload Type\")"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"        if not isinstance(self.payload, (six.text_type, six.binary_type)) \\"},{"line_number":288,"context_line":"                and self.payload is not None:"},{"line_number":289,"context_line":"            raise exceptions.PayloadException(\"Invalid Payload Type\")"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"        if self.payload_content_type or self.payload_content_encoding:"}],"source_content_type":"text/x-python","patch_set":22,"id":"1a4dcd0f_3b9aeab9","line":288,"updated":"2015-08-06 19:22:47.000000000","message":"This can be changed to cover both this and the above test:\n\n    if self.payload and not isinstance(self.payload, (six.text_type, six.binary_type)):\n\nAlso, try to avoid backslashes for line continuation.  For example here, you can close the parenthesis in the next line to avoid it.","commit_id":"b915ff2ace020273f86cc991a17ece743a2a7098"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"db16a24d1450516a6afaae233da8fdaf990ca05c","unresolved":false,"context_lines":[{"line_number":285,"context_line":"            raise exceptions.PayloadException(\"Invalid Payload Type\")"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"        if not isinstance(self.payload, (six.text_type, six.binary_type)) \\"},{"line_number":288,"context_line":"                and self.payload is not None:"},{"line_number":289,"context_line":"            raise exceptions.PayloadException(\"Invalid Payload Type\")"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"        if self.payload_content_type or self.payload_content_encoding:"}],"source_content_type":"text/x-python","patch_set":22,"id":"1a4dcd0f_51af9729","line":288,"in_reply_to":"1a4dcd0f_3b9aeab9","updated":"2015-08-06 20:27:31.000000000","message":"Good Point, just changed this!","commit_id":"b915ff2ace020273f86cc991a17ece743a2a7098"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"efcc856da25c24498c79feab3212a9a8a286997d","unresolved":false,"context_lines":[{"line_number":289,"context_line":"            raise exceptions.PayloadException(\"Invalid Payload Type\")"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"        if self.payload_content_type or self.payload_content_encoding:"},{"line_number":292,"context_line":"            \"\"\""},{"line_number":293,"context_line":"            Setting the payload_content_type and payload_content_encoding"},{"line_number":294,"context_line":"            manually is deprecated.  This clause of the if statement is here"},{"line_number":295,"context_line":"            for backwards compatibility and should be removed in a future"}],"source_content_type":"text/x-python","patch_set":22,"id":"3a50d1a3_30b8902a","line":292,"updated":"2015-07-23 21:02:07.000000000","message":"Leaving self.payload_content_encoding here since it is being deprecated. I removed payload_content_encoding from the CLI command","commit_id":"b915ff2ace020273f86cc991a17ece743a2a7098"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"86d1490433a31fd5fb48bf40f2bbf00b7e7a3eb7","unresolved":false,"context_lines":[{"line_number":321,"context_line":""},{"line_number":322,"context_line":"        LOG.debug(\"Request body: {0}\".format(secret_dict))"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"        # Save, store secret_ref and return"},{"line_number":325,"context_line":"        response \u003d self._api.post(self._entity, json\u003dsecret_dict)"},{"line_number":326,"context_line":"        if response:"},{"line_number":327,"context_line":"            self._secret_ref \u003d response.get(\u0027secret_ref\u0027)"}],"source_content_type":"text/x-python","patch_set":22,"id":"1a4dcd0f_db7f46de","line":324,"updated":"2015-08-06 19:32:13.000000000","message":"# This could be overloaded\nif self.secret_ref:\n   # we know that it\u0027s an update\n   self._api.put(...)\nelse:\n   self._api.post(...)","commit_id":"b915ff2ace020273f86cc991a17ece743a2a7098"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"f327a65a29113f8309a09635d21f142ba5d61114","unresolved":false,"context_lines":[{"line_number":328,"context_line":"        return self.secret_ref"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"    def update(self, payload\u003dNone, payload_content_type\u003dNone,"},{"line_number":331,"context_line":"               payload_content_encoding\u003dNone):"},{"line_number":332,"context_line":"        \"\"\""},{"line_number":333,"context_line":"        Updates the secret in Barbican."},{"line_number":334,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":22,"id":"1a4dcd0f_7b25d259","line":331,"updated":"2015-08-06 19:22:47.000000000","message":"Why add a new method, instead of overloading save() ?","commit_id":"b915ff2ace020273f86cc991a17ece743a2a7098"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"f327a65a29113f8309a09635d21f142ba5d61114","unresolved":false,"context_lines":[{"line_number":453,"context_line":"        )"},{"line_number":454,"context_line":""},{"line_number":455,"context_line":"    def update(self, secret_ref, payload\u003dNone, payload_content_type\u003dNone,"},{"line_number":456,"context_line":"               payload_content_encoding\u003dNone):"},{"line_number":457,"context_line":"        \"\"\""},{"line_number":458,"context_line":"        Update an existing Secret from Barbican"},{"line_number":459,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"1a4dcd0f_fbf002cb","line":456,"updated":"2015-08-06 19:22:47.000000000","message":"Same question as above.  Why add a new method?","commit_id":"b915ff2ace020273f86cc991a17ece743a2a7098"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"a4027247abd8d57afa5a8035be2561736a8a425f","unresolved":false,"context_lines":[{"line_number":281,"context_line":"            \u0027expiration\u0027: self.expiration"},{"line_number":282,"context_line":"        }"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"        if self.payload \u003d\u003d \u0027\u0027:"},{"line_number":285,"context_line":"            raise exceptions.PayloadException(\"Invalid Payload Type\")"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"        if self.payload is not None and not isinstance(self.payload,"}],"source_content_type":"text/x-python","patch_set":25,"id":"1a4dcd0f_761e1b0d","line":284,"updated":"2015-08-07 16:05:28.000000000","message":"\"self.payload\" is needed because:\n\n\u003e\u003e\u003e print isinstance(\u0027\u0027, (six.binary_type))\nTrue\n\ntherefore it will skip the failure.","commit_id":"93d6c1e76b1b85c620e8bb03e2f8f053dcf88361"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"a4027247abd8d57afa5a8035be2561736a8a425f","unresolved":false,"context_lines":[{"line_number":284,"context_line":"        if self.payload \u003d\u003d \u0027\u0027:"},{"line_number":285,"context_line":"            raise exceptions.PayloadException(\"Invalid Payload Type\")"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"        if self.payload is not None and not isinstance(self.payload,"},{"line_number":288,"context_line":"                                                       (six.text_type,"},{"line_number":289,"context_line":"                                                        six.binary_type)):"},{"line_number":290,"context_line":"            raise exceptions.PayloadException(\"Invalid Payload Type\")"}],"source_content_type":"text/x-python","patch_set":25,"id":"1a4dcd0f_56a67fae","line":287,"updated":"2015-08-07 16:05:28.000000000","message":"\"self. payload is not None\" is needed because:\n\n\u003e\u003e\u003e a \u003d 0\n\u003e\u003e\u003e not a\nTrue\n\ntherefore \"if self.payload\" will return False.","commit_id":"93d6c1e76b1b85c620e8bb03e2f8f053dcf88361"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"251576aad75a7c7492b1230a31139543a4017fe7","unresolved":false,"context_lines":[{"line_number":187,"context_line":"        if self._payload is None and self.secret_ref is not None:"},{"line_number":188,"context_line":"            try:"},{"line_number":189,"context_line":"                self._fetch_payload()"},{"line_number":190,"context_line":"            except ValueError:"},{"line_number":191,"context_line":"                return None"},{"line_number":192,"context_line":"        return self._payload"},{"line_number":193,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"1a4dcd0f_6fe514da","line":190,"updated":"2015-08-21 19:21:52.000000000","message":"Could you log the message?  It might be confusing for people trying to debug if they keep getting None and not an error if something goes wrong.","commit_id":"cf6f0e00873dcd007dbe9897080cb388f29b708d"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"447e2faaf50920e6d8db656db82f76b4b2755089","unresolved":false,"context_lines":[{"line_number":187,"context_line":"        if self._payload is None and self.secret_ref is not None:"},{"line_number":188,"context_line":"            try:"},{"line_number":189,"context_line":"                self._fetch_payload()"},{"line_number":190,"context_line":"            except ValueError:"},{"line_number":191,"context_line":"                return None"},{"line_number":192,"context_line":"        return self._payload"},{"line_number":193,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"fa1b9901_ff25d05b","line":190,"in_reply_to":"1a4dcd0f_6fe514da","updated":"2015-08-24 15:26:47.000000000","message":"Added a debug message.\n\nIn line 249, if a value error is raised user will know  if:\n\u0027Secret has no encrypted data to decrypt.\u0027\nor\n\"Must specify decrypt content-type as \"\n                             \"secret does not specify a \u0027default\u0027 \"\n                             \"content-type.\"\nSince they are part of the ValueError.","commit_id":"cf6f0e00873dcd007dbe9897080cb388f29b708d"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"251576aad75a7c7492b1230a31139543a4017fe7","unresolved":false,"context_lines":[{"line_number":282,"context_line":"        }"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"        if self.payload \u003d\u003d \u0027\u0027:"},{"line_number":285,"context_line":"            raise exceptions.PayloadException(\"Invalid Payload Type\")"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"        if self.payload is not None and not isinstance(self.payload,"},{"line_number":288,"context_line":"                                                       (six.text_type,"}],"source_content_type":"text/x-python","patch_set":26,"id":"1a4dcd0f_0f4330b0","line":285,"updated":"2015-08-21 19:21:52.000000000","message":"A payload can be None, but it can\u0027t be an empty string?  Can you please change the Exception message to be something more along the lines of \"Invalid Payload: Cannot Be Empty String\"","commit_id":"cf6f0e00873dcd007dbe9897080cb388f29b708d"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"447e2faaf50920e6d8db656db82f76b4b2755089","unresolved":false,"context_lines":[{"line_number":282,"context_line":"        }"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"        if self.payload \u003d\u003d \u0027\u0027:"},{"line_number":285,"context_line":"            raise exceptions.PayloadException(\"Invalid Payload Type\")"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"        if self.payload is not None and not isinstance(self.payload,"},{"line_number":288,"context_line":"                                                       (six.text_type,"}],"source_content_type":"text/x-python","patch_set":26,"id":"fa1b9901_ff8150fc","line":285,"in_reply_to":"1a4dcd0f_0f4330b0","updated":"2015-08-24 15:26:47.000000000","message":"Done","commit_id":"cf6f0e00873dcd007dbe9897080cb388f29b708d"},{"author":{"_account_id":1091,"name":"Arun Kant","email":"arukant@cisco.com","username":"arunkant-uws"},"change_message_id":"f10ac7139858c27d2cc597d39f8f31b689319ecd","unresolved":false,"context_lines":[{"line_number":469,"context_line":"            raise ValueError(\u0027secret_ref is required.\u0027)"},{"line_number":470,"context_line":""},{"line_number":471,"context_line":"        headers \u003d {\u0027content-type\u0027: \u0027text/plain\u0027}"},{"line_number":472,"context_line":""},{"line_number":473,"context_line":"        self._api.put(secret_ref,"},{"line_number":474,"context_line":"                      headers\u003dheaders,"},{"line_number":475,"context_line":"                      data\u003dpayload)"}],"source_content_type":"text/x-python","patch_set":26,"id":"fa1b9901_ef2fa1a5","line":472,"updated":"2015-08-21 18:24:17.000000000","message":"Do we need to check if payload content is indeed text and not binary like above check 341-346 as we are setting header assuming its text.","commit_id":"cf6f0e00873dcd007dbe9897080cb388f29b708d"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"447e2faaf50920e6d8db656db82f76b4b2755089","unresolved":false,"context_lines":[{"line_number":469,"context_line":"            raise ValueError(\u0027secret_ref is required.\u0027)"},{"line_number":470,"context_line":""},{"line_number":471,"context_line":"        headers \u003d {\u0027content-type\u0027: \u0027text/plain\u0027}"},{"line_number":472,"context_line":""},{"line_number":473,"context_line":"        self._api.put(secret_ref,"},{"line_number":474,"context_line":"                      headers\u003dheaders,"},{"line_number":475,"context_line":"                      data\u003dpayload)"}],"source_content_type":"text/x-python","patch_set":26,"id":"fa1b9901_9f4934ba","line":472,"in_reply_to":"fa1b9901_ef2fa1a5","updated":"2015-08-24 15:26:47.000000000","message":"Done","commit_id":"cf6f0e00873dcd007dbe9897080cb388f29b708d"},{"author":{"_account_id":1091,"name":"Arun Kant","email":"arukant@cisco.com","username":"arunkant-uws"},"change_message_id":"fa079add867e55bd305900f767db9c5b08cdf282","unresolved":false,"context_lines":[{"line_number":470,"context_line":"        if not secret_ref:"},{"line_number":471,"context_line":"            raise ValueError(\u0027secret_ref is required.\u0027)"},{"line_number":472,"context_line":""},{"line_number":473,"context_line":"        if type(self.payload) is six.binary_type:"},{"line_number":474,"context_line":"            headers \u003d {\u0027content-type\u0027: \"application/octet-stream\"}"},{"line_number":475,"context_line":"        elif type(self.payload) is six.text_type:"},{"line_number":476,"context_line":"            headers \u003d {\u0027content-type\u0027: \"text/plain\"}"}],"source_content_type":"text/x-python","patch_set":27,"id":"fa1b9901_a1a884dc","line":473,"updated":"2015-08-25 00:16:14.000000000","message":"I don\u0027t see payload attribute (self.payload) defined on SecretManager. I will think this will fail if this logic is executed. May be add test to make sure that?","commit_id":"2fd76948289cf287e668f31c17c78aede93bae62"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"255e3f2033d46196db121eb02cfb58a4e67d4d02","unresolved":false,"context_lines":[{"line_number":470,"context_line":"        if not secret_ref:"},{"line_number":471,"context_line":"            raise ValueError(\u0027secret_ref is required.\u0027)"},{"line_number":472,"context_line":""},{"line_number":473,"context_line":"        if type(self.payload) is six.binary_type:"},{"line_number":474,"context_line":"            headers \u003d {\u0027content-type\u0027: \"application/octet-stream\"}"},{"line_number":475,"context_line":"        elif type(self.payload) is six.text_type:"},{"line_number":476,"context_line":"            headers \u003d {\u0027content-type\u0027: \"text/plain\"}"}],"source_content_type":"text/x-python","patch_set":27,"id":"fa1b9901_d8b6c9db","line":473,"in_reply_to":"fa1b9901_a1a884dc","updated":"2015-08-25 03:29:47.000000000","message":"You\u0027re right. It does not have the payload attribute. It should just be payload which is being passed.","commit_id":"2fd76948289cf287e668f31c17c78aede93bae62"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"197fce355eebe69e3e5566c96d324a333ad6b661","unresolved":false,"context_lines":[{"line_number":188,"context_line":"            try:"},{"line_number":189,"context_line":"                self._fetch_payload()"},{"line_number":190,"context_line":"            except ValueError:"},{"line_number":191,"context_line":"                LOG.debug(\"Secret does not contain a payload\")"},{"line_number":192,"context_line":"                return None"},{"line_number":193,"context_line":"        return self._payload"},{"line_number":194,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"fa1b9901_52412a0a","line":191,"updated":"2015-08-25 09:19:36.000000000","message":"I think this should be a warning instead of a debug message.","commit_id":"e651b1b21bc727158753fc22b5d374d571fe1e65"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"5b1b8a6d8364722783a088fa632cee0fd21f8606","unresolved":false,"context_lines":[{"line_number":188,"context_line":"            try:"},{"line_number":189,"context_line":"                self._fetch_payload()"},{"line_number":190,"context_line":"            except ValueError:"},{"line_number":191,"context_line":"                LOG.debug(\"Secret does not contain a payload\")"},{"line_number":192,"context_line":"                return None"},{"line_number":193,"context_line":"        return self._payload"},{"line_number":194,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"fa1b9901_7e6989f8","line":191,"in_reply_to":"fa1b9901_52412a0a","updated":"2015-08-25 14:57:36.000000000","message":"Done","commit_id":"e651b1b21bc727158753fc22b5d374d571fe1e65"}],"barbicanclient/tests/test_client.py":[{"author":{"_account_id":11561,"name":"Dave McCowan","email":"dmccowan@cisco.com","username":"dave-mccowan"},"change_message_id":"9d688d23817e9d52ad2231a1ade1b8996ffc33fa","unresolved":false,"context_lines":[{"line_number":136,"context_line":"    def test_put_checks_status_code(self):"},{"line_number":137,"context_line":"        self.httpclient._check_status_code \u003d mock.MagicMock()"},{"line_number":138,"context_line":"        self.httpclient.put(self.href, data\u003d\u0027test\u0027)"},{"line_number":139,"context_line":"        self.httpclient._check_status_code.assert_called()"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"class WhenTestingClientGet(TestClient):"}],"source_content_type":"text/x-python","patch_set":12,"id":"9a41bdd9_e2e2db2e","line":139,"updated":"2015-07-14 17:36:00.000000000","message":"This method does not exist.  use .assert_has_calls([]) instead.\n\nThe new version of mock throws an error on this, while the old version of mock failed silently.","commit_id":"5da5268bad48e38364d4f072c42a2dde243a5c19"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"8197511bf2cd82a9ec0ef47345125ab0ac9f320e","unresolved":false,"context_lines":[{"line_number":136,"context_line":"    def test_put_checks_status_code(self):"},{"line_number":137,"context_line":"        self.httpclient._check_status_code \u003d mock.MagicMock()"},{"line_number":138,"context_line":"        self.httpclient.put(self.href, data\u003d\u0027test\u0027)"},{"line_number":139,"context_line":"        self.httpclient._check_status_code.assert_called()"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"class WhenTestingClientGet(TestClient):"}],"source_content_type":"text/x-python","patch_set":12,"id":"9a41bdd9_c12d5496","line":139,"in_reply_to":"9a41bdd9_e2e2db2e","updated":"2015-07-14 18:42:45.000000000","message":"Altered this in all instances. Thanks!!","commit_id":"5da5268bad48e38364d4f072c42a2dde243a5c19"},{"author":{"_account_id":11561,"name":"Dave McCowan","email":"dmccowan@cisco.com","username":"dave-mccowan"},"change_message_id":"3991b57fe4e0cfaba1f9befd27969767dc9aaff4","unresolved":false,"context_lines":[{"line_number":144,"context_line":"    def test_get_checks_status_code(self):"},{"line_number":145,"context_line":"        self.httpclient._check_status_code \u003d mock.MagicMock()"},{"line_number":146,"context_line":"        self.httpclient.get(self.href)"},{"line_number":147,"context_line":"        self.assertTrue(self.httpclient._check_status_code.called)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    def test_get_raw_uses_href_as_is(self):"},{"line_number":150,"context_line":"        self.httpclient._get_raw(self.href, headers\u003dself.headers)"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a41bdd9_e7ef48e7","side":"PARENT","line":147,"updated":"2015-07-14 18:59:27.000000000","message":"assert_has_calls([])","commit_id":"3fcc07f49c0c1b83115cc8dd4e498485e0c08373"},{"author":{"_account_id":11561,"name":"Dave McCowan","email":"dmccowan@cisco.com","username":"dave-mccowan"},"change_message_id":"3991b57fe4e0cfaba1f9befd27969767dc9aaff4","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        self.httpclient._check_status_code \u003d mock.MagicMock()"},{"line_number":165,"context_line":"        self.httpclient._get_raw(self.href, headers\u003dself.headers)"},{"line_number":166,"context_line":"        self.assertTrue(self.httpclient._check_status_code.called)"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"class WhenTestingClientDelete(TestClient):"},{"line_number":170,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"9a41bdd9_c7c1e455","side":"PARENT","line":167,"updated":"2015-07-14 18:59:27.000000000","message":"assert_has_calls([])","commit_id":"3fcc07f49c0c1b83115cc8dd4e498485e0c08373"},{"author":{"_account_id":11561,"name":"Dave McCowan","email":"dmccowan@cisco.com","username":"dave-mccowan"},"change_message_id":"3991b57fe4e0cfaba1f9befd27969767dc9aaff4","unresolved":false,"context_lines":[{"line_number":194,"context_line":"    def test_delete_checks_status_code(self):"},{"line_number":195,"context_line":"        self.httpclient._check_status_code \u003d mock.MagicMock()"},{"line_number":196,"context_line":"        self.httpclient.delete(self.href)"},{"line_number":197,"context_line":"        self.assertTrue(self.httpclient._check_status_code.called)"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"class WhenTestingCheckStatusCodes(TestClient):"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a41bdd9_67b25808","side":"PARENT","line":197,"updated":"2015-07-14 18:59:27.000000000","message":"assert_has_calls([])","commit_id":"3fcc07f49c0c1b83115cc8dd4e498485e0c08373"},{"author":{"_account_id":11561,"name":"Dave McCowan","email":"dmccowan@cisco.com","username":"dave-mccowan"},"change_message_id":"3991b57fe4e0cfaba1f9befd27969767dc9aaff4","unresolved":false,"context_lines":[{"line_number":105,"context_line":"    def test_post_checks_status_code(self):"},{"line_number":106,"context_line":"        self.httpclient._check_status_code \u003d mock.MagicMock()"},{"line_number":107,"context_line":"        self.httpclient.post(path\u003d\u0027secrets\u0027, json\u003d{\u0027test_data\u0027: \u0027test\u0027})"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"class WhenTestingClientPut(TestClient):"},{"line_number":111,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"9a41bdd9_07682c86","line":108,"updated":"2015-07-14 18:59:27.000000000","message":"instead of deleting these checks, they should also be assert_has_calls([])","commit_id":"ce379a5943a7c4f518e2289fd0699c948e626497"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"4af8e7daddd645be4b78cb65e953fdfa8932afd2","unresolved":false,"context_lines":[{"line_number":105,"context_line":"    def test_post_checks_status_code(self):"},{"line_number":106,"context_line":"        self.httpclient._check_status_code \u003d mock.MagicMock()"},{"line_number":107,"context_line":"        self.httpclient.post(path\u003d\u0027secrets\u0027, json\u003d{\u0027test_data\u0027: \u0027test\u0027})"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"class WhenTestingClientPut(TestClient):"},{"line_number":111,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"9a41bdd9_6742586a","line":108,"in_reply_to":"9a41bdd9_07682c86","updated":"2015-07-14 19:09:19.000000000","message":"Ooops, I think I removed them by mistake. Thanks.","commit_id":"ce379a5943a7c4f518e2289fd0699c948e626497"}],"barbicanclient/tests/test_secrets.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"e05ca750b04aff65e9cf0fa769f8ffbbfa7433ac","unresolved":false,"context_lines":[{"line_number":197,"context_line":"        attributes \u003d ["},{"line_number":198,"context_line":"            \"name\", \"expiration\", \"algorithm\", \"bit_length\", \"mode\", \"payload\","},{"line_number":199,"context_line":"            \"payload_content_type\", \"payload_content_encoding\""},{"line_number":200,"context_line":"        ]"},{"line_number":201,"context_line":"        for attr in attributes:"},{"line_number":202,"context_line":"            try:"},{"line_number":203,"context_line":"                setattr(secret, attr, \"test\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba3cc151_ef05d179","line":200,"updated":"2015-07-01 21:05:32.000000000","message":"This test will need to change, as payload will now be mutable after storing secrets.","commit_id":"6ebb3b2f2cf6f39a335ce46101543796a7f20302"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"e05ca750b04aff65e9cf0fa769f8ffbbfa7433ac","unresolved":false,"context_lines":[{"line_number":377,"context_line":"        self.responses.post(self.entity_base + \u0027/\u0027, json\u003ddata)"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"        secret \u003d self.manager.create()"},{"line_number":380,"context_line":"        # wont work since error will be thrown if payload is not set"},{"line_number":381,"context_line":"        secret.store()"},{"line_number":382,"context_line":""},{"line_number":383,"context_line":"        # This literal will have type(unicode) in Python 2, but will have"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba3cc151_4fedddb5","line":380,"updated":"2015-07-01 21:05:32.000000000","message":"So, fixing that is your next step, I assume.","commit_id":"6ebb3b2f2cf6f39a335ce46101543796a7f20302"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"950ecdb9c09c28d53afdc80a42a22c4403152094","unresolved":false,"context_lines":[{"line_number":195,"context_line":""},{"line_number":196,"context_line":"        # Verify that attributes are immutable after store."},{"line_number":197,"context_line":"        attributes \u003d ["},{"line_number":198,"context_line":"            \"name\", \"expiration\", \"algorithm\", \"bit_length\", \"mode\", \"payload\","},{"line_number":199,"context_line":"            \"payload_content_type\", \"payload_content_encoding\""},{"line_number":200,"context_line":"        ]"},{"line_number":201,"context_line":"        for attr in attributes:"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_3a091832","line":198,"updated":"2015-07-07 15:47:32.000000000","message":"Removed payload, since it is mutable and does not need to be tested to be immutable.","commit_id":"396bba3bd5cd23e792cdc29b4dcec8f7c168eb82"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"1fec77867ba2fac36fd234394118e72790af54ad","unresolved":false,"context_lines":[{"line_number":382,"context_line":"        # This literal will have type(unicode) in Python 2, but will have"},{"line_number":383,"context_line":"        # type(str) in Python 3.  It is six.text_type in both cases."},{"line_number":384,"context_line":"        text_payload \u003d u\u0027time for an ice cold \\U0001f37a\u0027"},{"line_number":385,"context_line":"        secret.update(text_payload, \u0027text/plain\u0027)"},{"line_number":386,"context_line":""},{"line_number":387,"context_line":"        secret_req \u003d json.loads(self.responses.last_request.text)"},{"line_number":388,"context_line":"        self.assertEqual(text_payload, secret_req[\u0027payload\u0027])"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba3cc151_67a796bd","line":385,"updated":"2015-07-08 19:57:05.000000000","message":"include a mock for update\n\n  self.response.put(self.entity_base + \u0027/\u0027, json\u003dNone)\n\nsomething like that, not sure what to put there for 204 No Content return value.","commit_id":"faa88601b5869d4896969d06edaf10f4c32a6b23"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"43250aa4e79e10fe961a9e89707b681565762389","unresolved":false,"context_lines":[{"line_number":382,"context_line":"        # This literal will have type(unicode) in Python 2, but will have"},{"line_number":383,"context_line":"        # type(str) in Python 3.  It is six.text_type in both cases."},{"line_number":384,"context_line":"        text_payload \u003d u\u0027time for an ice cold \\U0001f37a\u0027"},{"line_number":385,"context_line":"        secret.update(text_payload, \u0027text/plain\u0027)"},{"line_number":386,"context_line":""},{"line_number":387,"context_line":"        secret_req \u003d json.loads(self.responses.last_request.text)"},{"line_number":388,"context_line":"        self.assertEqual(text_payload, secret_req[\u0027payload\u0027])"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba3cc151_aaa205fa","line":385,"in_reply_to":"ba3cc151_67a796bd","updated":"2015-07-09 18:37:05.000000000","message":"Having trouble with this, getting error: No mock address: PUT http://localhost:9311/v1/secrets/abcd1234-eabc-5678-9abc-abcdef012345/","commit_id":"faa88601b5869d4896969d06edaf10f4c32a6b23"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"1fec77867ba2fac36fd234394118e72790af54ad","unresolved":false,"context_lines":[{"line_number":416,"context_line":"        self.responses.get(self.entity_href, json\u003ddata)"},{"line_number":417,"context_line":"        secret \u003d self.manager.get(secret_ref\u003dself.entity_href)"},{"line_number":418,"context_line":""},{"line_number":419,"context_line":"        try:"},{"line_number":420,"context_line":"            secret.payload"},{"line_number":421,"context_line":"            self.fail(\"didn\u0027t raise a ValueError exception\")"},{"line_number":422,"context_line":"        except ValueError:"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba3cc151_c7cf827d","line":419,"updated":"2015-07-08 19:57:05.000000000","message":"looks like this needs to be updated if you plan on changing the behaviour of secrets.py","commit_id":"faa88601b5869d4896969d06edaf10f4c32a6b23"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"43250aa4e79e10fe961a9e89707b681565762389","unresolved":false,"context_lines":[{"line_number":416,"context_line":"        self.responses.get(self.entity_href, json\u003ddata)"},{"line_number":417,"context_line":"        secret \u003d self.manager.get(secret_ref\u003dself.entity_href)"},{"line_number":418,"context_line":""},{"line_number":419,"context_line":"        try:"},{"line_number":420,"context_line":"            secret.payload"},{"line_number":421,"context_line":"            self.fail(\"didn\u0027t raise a ValueError exception\")"},{"line_number":422,"context_line":"        except ValueError:"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba3cc151_f2e362d6","line":419,"in_reply_to":"ba3cc151_c7cf827d","updated":"2015-07-09 18:37:05.000000000","message":"Since now a blank secret cam be created, I changed it to the default string of that secret.","commit_id":"faa88601b5869d4896969d06edaf10f4c32a6b23"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"1fec77867ba2fac36fd234394118e72790af54ad","unresolved":false,"context_lines":[{"line_number":429,"context_line":""},{"line_number":430,"context_line":"        secret \u003d self.manager.get(secret_ref\u003dself.entity_href)"},{"line_number":431,"context_line":"        try:"},{"line_number":432,"context_line":"            secret.payload"},{"line_number":433,"context_line":"            self.fail(\"didn\u0027t raise a ValueError exception\")"},{"line_number":434,"context_line":"        except ValueError:"},{"line_number":435,"context_line":"            pass"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba3cc151_87c5fa5c","line":432,"updated":"2015-07-08 19:57:05.000000000","message":"same comment as above, you should assert that secret.payload is equal to something, probably self.entity_ref.payload","commit_id":"faa88601b5869d4896969d06edaf10f4c32a6b23"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"43250aa4e79e10fe961a9e89707b681565762389","unresolved":false,"context_lines":[{"line_number":429,"context_line":""},{"line_number":430,"context_line":"        secret \u003d self.manager.get(secret_ref\u003dself.entity_href)"},{"line_number":431,"context_line":"        try:"},{"line_number":432,"context_line":"            secret.payload"},{"line_number":433,"context_line":"            self.fail(\"didn\u0027t raise a ValueError exception\")"},{"line_number":434,"context_line":"        except ValueError:"},{"line_number":435,"context_line":"            pass"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba3cc151_52bc8eba","line":432,"in_reply_to":"ba3cc151_87c5fa5c","updated":"2015-07-09 18:37:05.000000000","message":"Since now a blank secret cam be created, I changed it to the default string of that secret.","commit_id":"faa88601b5869d4896969d06edaf10f4c32a6b23"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"e1bf653e4bd0407d66269163643f68a701ba299d","unresolved":false,"context_lines":[{"line_number":384,"context_line":"        text_payload \u003d u\u0027time for an ice cold \\U0001f37a\u0027"},{"line_number":385,"context_line":""},{"line_number":386,"context_line":"        self.responses.put(self.entity_href,status_code\u003d204)"},{"line_number":387,"context_line":"        secret.update(self.entity_href,"},{"line_number":388,"context_line":"                      text_payload,"},{"line_number":389,"context_line":"                      \u0027text/plain\u0027)"},{"line_number":390,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"ba3cc151_ddd14e58","line":387,"updated":"2015-07-09 20:08:06.000000000","message":"looks like this line is causing the failure\n\nrequests_mock.exceptions.NoMockAddress: No mock address: PUT http://localhost:9311/v1/secrets/abcd1234-eabc-5678-9abc-abcdef012345/\n\nmight want to put a debugging prompt and check what selt.entity_href is, and why self.responses.put isn\u0027t mocking it properly.","commit_id":"5baaf5b8a9a19a75a8563fdc1db159d0c30d7f95"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"f1208a879a78eec3d616bb452e42cf920d6330c5","unresolved":false,"context_lines":[{"line_number":384,"context_line":"        text_payload \u003d u\u0027time for an ice cold \\U0001f37a\u0027"},{"line_number":385,"context_line":""},{"line_number":386,"context_line":"        self.responses.put(self.entity_href,status_code\u003d204)"},{"line_number":387,"context_line":"        secret.update(self.entity_href,"},{"line_number":388,"context_line":"                      text_payload,"},{"line_number":389,"context_line":"                      \u0027text/plain\u0027)"},{"line_number":390,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"ba3cc151_13e56536","line":387,"in_reply_to":"ba3cc151_ddd14e58","updated":"2015-07-09 20:54:40.000000000","message":"Found the error. Thanks!!","commit_id":"5baaf5b8a9a19a75a8563fdc1db159d0c30d7f95"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"e6dc0cdd6a424b4e7ca163becf1c15b516dc0346","unresolved":false,"context_lines":[{"line_number":381,"context_line":""},{"line_number":382,"context_line":"        # This literal will have type(unicode) in Python 2, but will have"},{"line_number":383,"context_line":"        # type(str) in Python 3.  It is six.text_type in both cases."},{"line_number":384,"context_line":"        text_payload \u003d u\u0027time for an ice cold \\U0001f37a\u0027"},{"line_number":385,"context_line":""},{"line_number":386,"context_line":"        self.responses.put(self.entity_href, status_code\u003d204)"},{"line_number":387,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"3a50d1a3_1c6fd1fc","line":384,"updated":"2015-07-23 12:15:39.000000000","message":"For this case you could actually do:\n\nsix.u(\u0027time for an ice cold \\U0001f37a\u0027)","commit_id":"2358cd79a86603d3ee58f88e3d2dd536081149e7"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"1dd1c635f58167fb2fb17577d51b63abaed33b2f","unresolved":false,"context_lines":[{"line_number":381,"context_line":""},{"line_number":382,"context_line":"        # This literal will have type(unicode) in Python 2, but will have"},{"line_number":383,"context_line":"        # type(str) in Python 3.  It is six.text_type in both cases."},{"line_number":384,"context_line":"        text_payload \u003d u\u0027time for an ice cold \\U0001f37a\u0027"},{"line_number":385,"context_line":""},{"line_number":386,"context_line":"        self.responses.put(self.entity_href, status_code\u003d204)"},{"line_number":387,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"3a50d1a3_0ed9c956","line":384,"in_reply_to":"3a50d1a3_1c6fd1fc","updated":"2015-07-23 16:53:19.000000000","message":"six is an unresolved reference since it is not being imported. \nI am just using text_payload \u003d u\u0027time for an ice cold \\U0001f37a\u0027 to follow how the other unit tests are done.","commit_id":"2358cd79a86603d3ee58f88e3d2dd536081149e7"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"e6dc0cdd6a424b4e7ca163becf1c15b516dc0346","unresolved":false,"context_lines":[{"line_number":422,"context_line":"        self.responses.get(self.entity_href, json\u003ddata)"},{"line_number":423,"context_line":"        secret \u003d self.manager.get(secret_ref\u003dself.entity_href)"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"        self.assertEqual(secret.payload, None)"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"    def test_should_fail_decrypt_no_default_content_type(self):"},{"line_number":428,"context_line":"        content_types_dict \u003d {\u0027no-default\u0027: \u0027application/octet-stream\u0027}"}],"source_content_type":"text/x-python","patch_set":18,"id":"3a50d1a3_3750a60a","line":425,"updated":"2015-07-23 12:15:39.000000000","message":"you could use self.assertIsNone(secret.payload)","commit_id":"2358cd79a86603d3ee58f88e3d2dd536081149e7"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"1dd1c635f58167fb2fb17577d51b63abaed33b2f","unresolved":false,"context_lines":[{"line_number":422,"context_line":"        self.responses.get(self.entity_href, json\u003ddata)"},{"line_number":423,"context_line":"        secret \u003d self.manager.get(secret_ref\u003dself.entity_href)"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"        self.assertEqual(secret.payload, None)"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"    def test_should_fail_decrypt_no_default_content_type(self):"},{"line_number":428,"context_line":"        content_types_dict \u003d {\u0027no-default\u0027: \u0027application/octet-stream\u0027}"}],"source_content_type":"text/x-python","patch_set":18,"id":"3a50d1a3_c3a3bafe","line":425,"in_reply_to":"3a50d1a3_3750a60a","updated":"2015-07-23 16:53:19.000000000","message":"Done","commit_id":"2358cd79a86603d3ee58f88e3d2dd536081149e7"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"e6dc0cdd6a424b4e7ca163becf1c15b516dc0346","unresolved":false,"context_lines":[{"line_number":430,"context_line":"        self.responses.get(self.entity_href, json\u003ddata)"},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"        secret \u003d self.manager.get(secret_ref\u003dself.entity_href)"},{"line_number":433,"context_line":"        self.assertEqual(secret.payload, None)"},{"line_number":434,"context_line":""},{"line_number":435,"context_line":"    def test_should_fail_delete_no_href(self):"},{"line_number":436,"context_line":"        self.assertRaises(ValueError, self.manager.delete, None)"}],"source_content_type":"text/x-python","patch_set":18,"id":"3a50d1a3_5753f216","line":433,"updated":"2015-07-23 12:15:39.000000000","message":"same here","commit_id":"2358cd79a86603d3ee58f88e3d2dd536081149e7"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"1dd1c635f58167fb2fb17577d51b63abaed33b2f","unresolved":false,"context_lines":[{"line_number":430,"context_line":"        self.responses.get(self.entity_href, json\u003ddata)"},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"        secret \u003d self.manager.get(secret_ref\u003dself.entity_href)"},{"line_number":433,"context_line":"        self.assertEqual(secret.payload, None)"},{"line_number":434,"context_line":""},{"line_number":435,"context_line":"    def test_should_fail_delete_no_href(self):"},{"line_number":436,"context_line":"        self.assertRaises(ValueError, self.manager.delete, None)"}],"source_content_type":"text/x-python","patch_set":18,"id":"3a50d1a3_23a13ef8","line":433,"in_reply_to":"3a50d1a3_5753f216","updated":"2015-07-23 16:53:19.000000000","message":"Done","commit_id":"2358cd79a86603d3ee58f88e3d2dd536081149e7"}],"doc/source/cli_usage.rst":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"1e50558b6c14ddd895fb23cd0b8ab7841290a8d6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"lCLI Usage"},{"line_number":2,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":".. code-block:: bash"}],"source_content_type":"text/x-rst","patch_set":19,"id":"3a50d1a3_649989c3","line":1,"updated":"2015-07-23 17:14:19.000000000","message":"undo this change? you added a 1.","commit_id":"9c08f939cd2f7f7a6c43d2f284b59b2e7ae8b4e6"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"edcee44c9abb8f0ee3e91cbe72858c624c6cd3ae","unresolved":false,"context_lines":[{"line_number":1,"context_line":"lCLI Usage"},{"line_number":2,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":".. code-block:: bash"}],"source_content_type":"text/x-rst","patch_set":19,"id":"3a50d1a3_7a3fe0b3","line":1,"in_reply_to":"3a50d1a3_649989c3","updated":"2015-07-23 17:55:29.000000000","message":"Done","commit_id":"9c08f939cd2f7f7a6c43d2f284b59b2e7ae8b4e6"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"1e50558b6c14ddd895fb23cd0b8ab7841290a8d6","unresolved":false,"context_lines":[{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    $ barbican secret update http://localhost:9311/v1/secrets/a70a45d8-4076-42a2-b111-8893d3b92a3e my_payload text/plain"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"In order for a secret to be updated it must not contain a payload.``my_payload``"},{"line_number":169,"context_line":"will be added with ``text/plain`` as the the payload content type."},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"Secret List"}],"source_content_type":"text/x-rst","patch_set":19,"id":"3a50d1a3_a43f9185","line":168,"updated":"2015-07-23 17:14:19.000000000","message":"add a space after period","commit_id":"9c08f939cd2f7f7a6c43d2f284b59b2e7ae8b4e6"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"edcee44c9abb8f0ee3e91cbe72858c624c6cd3ae","unresolved":false,"context_lines":[{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    $ barbican secret update http://localhost:9311/v1/secrets/a70a45d8-4076-42a2-b111-8893d3b92a3e my_payload text/plain"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"In order for a secret to be updated it must not contain a payload.``my_payload``"},{"line_number":169,"context_line":"will be added with ``text/plain`` as the the payload content type."},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"Secret List"}],"source_content_type":"text/x-rst","patch_set":19,"id":"3a50d1a3_5a446448","line":168,"in_reply_to":"3a50d1a3_a43f9185","updated":"2015-07-23 17:55:29.000000000","message":"Done","commit_id":"9c08f939cd2f7f7a6c43d2f284b59b2e7ae8b4e6"},{"author":{"_account_id":1091,"name":"Arun Kant","email":"arukant@cisco.com","username":"arunkant-uws"},"change_message_id":"f10ac7139858c27d2cc597d39f8f31b689319ecd","unresolved":false,"context_lines":[{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    $ barbican secret update http://localhost:9311/v1/secrets/a70a45d8-4076-42a2-b111-8893d3b92a3e my_payload text/plain"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"In order for a secret to be updated it must not contain a payload. ``my_payload``"},{"line_number":168,"context_line":"will be added with ``text/plain`` as the the payload content type."},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"Secret List"}],"source_content_type":"text/x-rst","patch_set":26,"id":"fa1b9901_2f4d99c4","line":167,"updated":"2015-08-21 18:24:17.000000000","message":"s/must not contain /must contain / ?\n\nIs above sample correct as its providing content-type as last argument which does not seems to be supported and needed.","commit_id":"cf6f0e00873dcd007dbe9897080cb388f29b708d"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"447e2faaf50920e6d8db656db82f76b4b2755089","unresolved":false,"context_lines":[{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    $ barbican secret update http://localhost:9311/v1/secrets/a70a45d8-4076-42a2-b111-8893d3b92a3e my_payload text/plain"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"In order for a secret to be updated it must not contain a payload. ``my_payload``"},{"line_number":168,"context_line":"will be added with ``text/plain`` as the the payload content type."},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"Secret List"}],"source_content_type":"text/x-rst","patch_set":26,"id":"fa1b9901_1f23e4a8","line":167,"in_reply_to":"fa1b9901_2f4d99c4","updated":"2015-08-24 15:26:47.000000000","message":"Good catch!!\nRemoved the payload-content-type and made it easier to understand","commit_id":"cf6f0e00873dcd007dbe9897080cb388f29b708d"}],"functionaltests/cli/v1/behaviors/secret_behaviors.py":[{"author":{"_account_id":17579,"name":"Elvin Tubillara","email":"edtubill@us.ibm.com","username":"edtubill"},"change_message_id":"7e074fcb6f263cacb4ad8ae1f52131a75b6b0400","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"        :param secret_href the href to the secret to update."},{"line_number":34,"context_line":"        :param payload the payload to put into the secret."},{"line_number":35,"context_line":"        :param payload_content_type the payload content type."},{"line_number":36,"context_line":"        \"\"\""},{"line_number":37,"context_line":"        argv \u003d [\u0027secret\u0027, \u0027update\u0027]"},{"line_number":38,"context_line":"        self.add_auth_and_endpoint(argv)"}],"source_content_type":"text/x-python","patch_set":29,"id":"fa1b9901_1bdf316a","line":35,"updated":"2015-08-25 18:50:52.000000000","message":"The documentation does not match the actual variables","commit_id":"34256de82d61a7030204a715dd2901dddb46c8e9"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"106f25d28988103012a73956ada11195e798d9c8","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"        :param secret_href the href to the secret to update."},{"line_number":34,"context_line":"        :param payload the payload to put into the secret."},{"line_number":35,"context_line":"        :param payload_content_type the payload content type."},{"line_number":36,"context_line":"        \"\"\""},{"line_number":37,"context_line":"        argv \u003d [\u0027secret\u0027, \u0027update\u0027]"},{"line_number":38,"context_line":"        self.add_auth_and_endpoint(argv)"}],"source_content_type":"text/x-python","patch_set":29,"id":"fa1b9901_8143ce12","line":35,"in_reply_to":"fa1b9901_1bdf316a","updated":"2015-08-25 19:33:19.000000000","message":"This will all be phased out and removed once: https://review.openstack.org/#/c/196876/ is added.","commit_id":"34256de82d61a7030204a715dd2901dddb46c8e9"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"269eed9521677c4af81ab76e71404a07ae688d9b","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"        :param secret_href the href to the secret to update."},{"line_number":34,"context_line":"        :param payload the payload to put into the secret."},{"line_number":35,"context_line":"        :param payload_content_type the payload content type."},{"line_number":36,"context_line":"        \"\"\""},{"line_number":37,"context_line":"        argv \u003d [\u0027secret\u0027, \u0027update\u0027]"},{"line_number":38,"context_line":"        self.add_auth_and_endpoint(argv)"}],"source_content_type":"text/x-python","patch_set":29,"id":"fa1b9901_8128ae34","line":35,"in_reply_to":"fa1b9901_8143ce12","updated":"2015-08-25 19:34:55.000000000","message":"Whoops, I mean https://review.openstack.org/#/c/213414/ as the link...","commit_id":"34256de82d61a7030204a715dd2901dddb46c8e9"}],"functionaltests/client/v1/functional/test_secrets.py":[{"author":{"_account_id":6783,"name":"Nathan Reller","email":"nathan.s.reller@gmail.com","username":"rellerreller"},"change_message_id":"b68cf52f41b8795281066f888a3591e85989e610","unresolved":false,"context_lines":[{"line_number":166,"context_line":"        test_model.payload_content_encoding \u003d None"},{"line_number":167,"context_line":"        test_model.payload_content_type \u003d None"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"        self.assertEqual(test_model.payload, None)"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    @testcase.attr(\u0027negative\u0027)"},{"line_number":172,"context_line":"    def test_secret_get_secret_doesnt_exist(self):"}],"source_content_type":"text/x-python","patch_set":15,"id":"9a41bdd9_823dca90","line":169,"updated":"2015-07-15 19:26:23.000000000","message":"I would like to see a test where you store a secret with no payload and then call update with a new payload.","commit_id":"351cfbda002eb8af728d5205dfdad6391a37c0df"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"1a4bb2af630e2fe6c277f5f135e9cdb3d069774b","unresolved":false,"context_lines":[{"line_number":166,"context_line":"        test_model.payload_content_encoding \u003d None"},{"line_number":167,"context_line":"        test_model.payload_content_type \u003d None"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"        self.assertEqual(test_model.payload, None)"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    @testcase.attr(\u0027negative\u0027)"},{"line_number":172,"context_line":"    def test_secret_get_secret_doesnt_exist(self):"}],"source_content_type":"text/x-python","patch_set":15,"id":"3a50d1a3_b7cd3a5f","line":169,"in_reply_to":"9a41bdd9_823dca90","updated":"2015-07-20 22:19:57.000000000","message":"Done","commit_id":"351cfbda002eb8af728d5205dfdad6391a37c0df"}]}