)]}'
{"barbicanclient/osc_plugin.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"b478a706ccbe57a5307235cf6a661d859aa48846","unresolved":false,"context_lines":[{"line_number":20,"context_line":"API_VERSION_OPTION \u003d \u0027os_key_manager_api_version\u0027"},{"line_number":21,"context_line":"API_NAME \u003d \u0027barbicanclient\u0027"},{"line_number":22,"context_line":"API_VERSIONS \u003d {"},{"line_number":23,"context_line":"    \u00271\u0027: \u0027barbicanclient.v1.client.Client\u0027,"},{"line_number":24,"context_line":"}"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_c4afe3e1","line":23,"updated":"2015-07-07 06:20:09.000000000","message":"should be v1 since it\u0027s v1 here: https://github.com/openstack/python-barbicanclient/blob/master/barbicanclient/client.py#L33","commit_id":"642d4a06341bd02129ed85e417e8c2d083621109"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"b478a706ccbe57a5307235cf6a661d859aa48846","unresolved":false,"context_lines":[{"line_number":36,"context_line":"                        metavar\u003d\u0027\u003cbarbican-url\u003e\u0027,"},{"line_number":37,"context_line":"                        default\u003dclient.env(\u0027BARBICAN_ENDPOINT\u0027),"},{"line_number":38,"context_line":"                        help\u003d\u0027Defaults to env[BARBICAN_ENDPOINT].\u0027)"},{"line_number":39,"context_line":"    parser.add_argument(\u0027--key-manager-api-version\u0027,"},{"line_number":40,"context_line":"                        metavar\u003d\u0027\u003ckey-manager-api-version\u003e\u0027,"},{"line_number":41,"context_line":"                        default\u003dclient.env("},{"line_number":42,"context_line":"                            \u0027OS_KEY_MANAGER_API_VERSION\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_24232fa9","line":39,"updated":"2015-07-07 06:20:09.000000000","message":"this should be prefixed with os-","commit_id":"642d4a06341bd02129ed85e417e8c2d083621109"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"e8fdf43c298cc9379248f54d5c2641ff5aab71b7","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"OSC_DEFAULT_VERSION \u003d \u00271\u0027"},{"line_number":21,"context_line":"API_VERSION_OPTION \u003d \u0027os_key_manager_api_version\u0027"},{"line_number":22,"context_line":"API_NAME \u003d \u0027barbicanclient\u0027"},{"line_number":23,"context_line":"API_VERSIONS \u003d {"},{"line_number":24,"context_line":"    \u00271\u0027: \u0027barbicanclient.client.Client\u0027,"},{"line_number":25,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba3cc151_549fe502","line":22,"updated":"2015-07-07 15:50:19.000000000","message":"we try to not use the project name for the API name\n\n  API_NAME \u003d \"key_manager\"\n\nhttps://github.com/openstack/python-openstackclient/blob/master/setup.cfg#L43","commit_id":"f07dd94e400a74cc1bab77a5221cfb15fbf74909"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"e6176e7c85b09b9518eed7e0cfa58a8f01a0a1c4","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"OSC_DEFAULT_VERSION \u003d \u00271\u0027"},{"line_number":21,"context_line":"API_VERSION_OPTION \u003d \u0027os_key_manager_api_version\u0027"},{"line_number":22,"context_line":"API_NAME \u003d \u0027key_manager\u0027"},{"line_number":23,"context_line":"API_VERSIONS \u003d {"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a50d1a3_c0973038","line":20,"updated":"2015-07-23 15:41:54.000000000","message":"Use DEFAULT_API_VERSION here, the plugin setup will start looking for this soon. (https://review.openstack.org/#/c/204508/)","commit_id":"dd174e2abc49ac1873a3025ef0613246af4f04c5"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"69b5996ec70e97021bf4490e42c3f4f189a26f3d","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"OSC_DEFAULT_VERSION \u003d \u00271\u0027"},{"line_number":21,"context_line":"API_VERSION_OPTION \u003d \u0027os_key_manager_api_version\u0027"},{"line_number":22,"context_line":"API_NAME \u003d \u0027key_manager\u0027"},{"line_number":23,"context_line":"API_VERSIONS \u003d {"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a50d1a3_6e4e4d3c","line":20,"in_reply_to":"3a50d1a3_c0973038","updated":"2015-07-23 15:55:19.000000000","message":"Done","commit_id":"dd174e2abc49ac1873a3025ef0613246af4f04c5"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"0a49f0d8d7dcd3b083e4e9584f26927789a3f68c","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#   under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"import logging"},{"line_number":16,"context_line":"from barbicanclient import client"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"3a50d1a3_70a13f93","line":16,"updated":"2015-07-23 18:45:16.000000000","message":"separate these two as one is standard lib, the other is local","commit_id":"8926a9593efac199aacf251f5be1cb894a0ebef6"},{"author":{"_account_id":1091,"name":"Arun Kant","email":"arukant@cisco.com","username":"arunkant-uws"},"change_message_id":"e3abd25566d1f5b20a53d7bae69528bc11273058","unresolved":false,"context_lines":[{"line_number":39,"context_line":"                            \u0027OS_KEY_MANAGER_API_VERSION\u0027,"},{"line_number":40,"context_line":"                            default\u003dDEFAULT_API_VERSION),"},{"line_number":41,"context_line":"                        help\u003d(\u0027Barbican API version, default\u003d\u0027 +"},{"line_number":42,"context_line":"                              OSC_DEFAULT_VERSION +"},{"line_number":43,"context_line":"                              \u0027 (Env: OS_KEY_MANAGER_API_VERSION)\u0027))"},{"line_number":44,"context_line":"    return parser"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a50d1a3_091ea36f","line":42,"updated":"2015-07-23 16:16:55.000000000","message":"In help, is it supposed to be DEFAULT_API_VERSION instead of OSC_DEFAULT_VERSION as its changed from last patch.","commit_id":"8926a9593efac199aacf251f5be1cb894a0ebef6"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"0a49f0d8d7dcd3b083e4e9584f26927789a3f68c","unresolved":false,"context_lines":[{"line_number":39,"context_line":"                            \u0027OS_KEY_MANAGER_API_VERSION\u0027,"},{"line_number":40,"context_line":"                            default\u003dDEFAULT_API_VERSION),"},{"line_number":41,"context_line":"                        help\u003d(\u0027Barbican API version, default\u003d\u0027 +"},{"line_number":42,"context_line":"                              OSC_DEFAULT_VERSION +"},{"line_number":43,"context_line":"                              \u0027 (Env: OS_KEY_MANAGER_API_VERSION)\u0027))"},{"line_number":44,"context_line":"    return parser"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a50d1a3_f0bb0fc2","line":42,"updated":"2015-07-23 18:45:16.000000000","message":"yep, this needs updating","commit_id":"8926a9593efac199aacf251f5be1cb894a0ebef6"},{"author":{"_account_id":9234,"name":"Steve Heyman","email":"steve@heyman.com","username":"hockeynut"},"change_message_id":"c71ca6be5e3a7a1095e06cf1c56b1ba93c6b99c6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#   Copyright 2015 Ericsson AB"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#   Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#   not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":15,"id":"ba15a1d1_8bb8c476","line":1,"updated":"2015-09-23 15:30:21.000000000","message":"Ericsson?  :-)","commit_id":"1063eaa63246a46a04715a87b4e1a764be69b4eb"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"e41667c6b891d2663e36559f2c02ec1f9a09484c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#   Copyright 2015 Ericsson AB"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#   Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#   not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":15,"id":"ba15a1d1_c2fafd76","line":1,"in_reply_to":"ba15a1d1_8bb8c476","updated":"2015-09-24 09:02:00.000000000","message":"Haha yup, this commit has been pending for THAT long.","commit_id":"1063eaa63246a46a04715a87b4e1a764be69b4eb"}],"functionaltests/cli/v1/behaviors/container_behaviors.py":[{"author":{"_account_id":6783,"name":"Nathan Reller","email":"nathan.s.reller@gmail.com","username":"rellerreller"},"change_message_id":"48897d55be4dc3975c86458d21a90db19c16c888","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"        :param container_href the href to the container to delete"},{"line_number":32,"context_line":"        \"\"\""},{"line_number":33,"context_line":"        argv \u003d [\u0027secret\u0027, \u0027container\u0027, \u0027delete\u0027]"},{"line_number":34,"context_line":"        self.add_auth_and_endpoint(argv)"},{"line_number":35,"context_line":"        argv.extend([container_href])"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"9a41bdd9_6af8d87b","line":33,"updated":"2015-07-14 21:18:15.000000000","message":"Why does this need secret now? Do any of the other behaviors need to change?\n\nI\u0027m still getting caught up to speed on this stuff.","commit_id":"09aa5e9c3a9c2db1b858159b8b818db81bc9835a"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"409a92d32313b7ca2d0530ec109e5c46b4211b7a","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"        :param container_href the href to the container to delete"},{"line_number":32,"context_line":"        \"\"\""},{"line_number":33,"context_line":"        argv \u003d [\u0027secret\u0027, \u0027container\u0027, \u0027delete\u0027]"},{"line_number":34,"context_line":"        self.add_auth_and_endpoint(argv)"},{"line_number":35,"context_line":"        argv.extend([container_href])"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"9a41bdd9_c6dc6175","line":33,"in_reply_to":"9a41bdd9_6af8d87b","updated":"2015-07-15 11:18:54.000000000","message":"This is because there is already the concept of containers in the openstack cli. So in order to make a clear distinction. I made this a \"secret container\". Also, In a comment above I mentioned that this is of course open for discussion, and suggestions are very welcome. IIRC I also changed the orders to secret orders. This is visible from the change in setup.cfg","commit_id":"09aa5e9c3a9c2db1b858159b8b818db81bc9835a"},{"author":{"_account_id":6783,"name":"Nathan Reller","email":"nathan.s.reller@gmail.com","username":"rellerreller"},"change_message_id":"e71d5823dd2ecd00e44066bce3d04c4216cc00dc","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"        :param container_href the href to the container to delete"},{"line_number":32,"context_line":"        \"\"\""},{"line_number":33,"context_line":"        argv \u003d [\u0027secret\u0027, \u0027container\u0027, \u0027delete\u0027]"},{"line_number":34,"context_line":"        self.add_auth_and_endpoint(argv)"},{"line_number":35,"context_line":"        argv.extend([container_href])"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"9a41bdd9_eb436611","line":33,"in_reply_to":"9a41bdd9_c6dc6175","updated":"2015-07-15 13:23:45.000000000","message":"Ah, thanks for explaining.","commit_id":"09aa5e9c3a9c2db1b858159b8b818db81bc9835a"}],"requirements.txt":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"b9e30d225fe38cb08c7e4b3bc518dda5d11e36b2","unresolved":false,"context_lines":[{"line_number":10,"context_line":"oslo.i18n\u003e\u003d1.5.0 # Apache-2.0"},{"line_number":11,"context_line":"oslo.serialization\u003e\u003d1.4.0 # Apache-2.0"},{"line_number":12,"context_line":"oslo.utils\u003e\u003d1.6.0 # Apache-2.0"},{"line_number":13,"context_line":"python-openstackclient\u003e\u003d1.0.0"}],"source_content_type":"text/plain","patch_set":1,"id":"ba3cc151_ed3eae28","line":13,"updated":"2015-07-06 15:00:04.000000000","message":"should be \u003e\u003d1.0.3\n\nalso, you shouldn\u0027t need to require this if you\u0027re just making a pluin","commit_id":"642d4a06341bd02129ed85e417e8c2d083621109"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"e8fdf43c298cc9379248f54d5c2641ff5aab71b7","unresolved":false,"context_lines":[{"line_number":10,"context_line":"oslo.i18n\u003e\u003d1.5.0 # Apache-2.0"},{"line_number":11,"context_line":"oslo.serialization\u003e\u003d1.4.0 # Apache-2.0"},{"line_number":12,"context_line":"oslo.utils\u003e\u003d1.6.0 # Apache-2.0"},{"line_number":13,"context_line":"python-openstackclient\u003e\u003d1.0.3"}],"source_content_type":"text/plain","patch_set":7,"id":"ba3cc151_8f231aa7","line":13,"updated":"2015-07-07 15:50:19.000000000","message":"you actually don\u0027t need to specify this, as long as OSC is installed on the target machine, the setup will create entry points","commit_id":"f07dd94e400a74cc1bab77a5221cfb15fbf74909"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"e380c3ac922d279a81086cd3e672158a7d550003","unresolved":false,"context_lines":[{"line_number":10,"context_line":"oslo.i18n\u003e\u003d1.5.0 # Apache-2.0"},{"line_number":11,"context_line":"oslo.serialization\u003e\u003d1.4.0 # Apache-2.0"},{"line_number":12,"context_line":"oslo.utils\u003e\u003d1.6.0 # Apache-2.0"},{"line_number":13,"context_line":"python-openstackclient\u003e\u003d1.0.3"}],"source_content_type":"text/plain","patch_set":7,"id":"ba3cc151_2f420e3f","line":13,"in_reply_to":"ba3cc151_8f231aa7","updated":"2015-07-07 15:52:04.000000000","message":"Alright, I\u0027ll add this to test-requirements.txt instead","commit_id":"f07dd94e400a74cc1bab77a5221cfb15fbf74909"}],"setup.cfg":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"b9e30d225fe38cb08c7e4b3bc518dda5d11e36b2","unresolved":false,"context_lines":[{"line_number":30,"context_line":"openstack.cli.extension \u003d"},{"line_number":31,"context_line":"    barbicanclient \u003d barbicanclient.osc_plugin"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"openstack.barbicanclient.v1 \u003d"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    secret_order_create \u003d barbicanclient.barbican_cli.orders:CreateOrder"},{"line_number":36,"context_line":"    secret_order_delete \u003d barbicanclient.barbican_cli.orders:DeleteOrder"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"ba3cc151_5772c7ae","line":33,"updated":"2015-07-06 15:00:04.000000000","message":"just a side note here, not sure what your deprecation policy is, but you may want to have both entries for some period of time before swapping one of the other","commit_id":"642d4a06341bd02129ed85e417e8c2d083621109"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"b478a706ccbe57a5307235cf6a661d859aa48846","unresolved":false,"context_lines":[{"line_number":30,"context_line":"openstack.cli.extension \u003d"},{"line_number":31,"context_line":"    barbicanclient \u003d barbicanclient.osc_plugin"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"openstack.barbicanclient.v1 \u003d"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    secret_order_create \u003d barbicanclient.barbican_cli.orders:CreateOrder"},{"line_number":36,"context_line":"    secret_order_delete \u003d barbicanclient.barbican_cli.orders:DeleteOrder"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"ba3cc151_c4dda371","line":33,"updated":"2015-07-07 06:20:09.000000000","message":"running `openstack secret list --debug` is giving me some results..\n\nDEBUG: openstackclient.shell barbicanclient API version v1, cmd group openstack.barbicanclient.vv1\n\nnote the double v","commit_id":"642d4a06341bd02129ed85e417e8c2d083621109"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"e8fdf43c298cc9379248f54d5c2641ff5aab71b7","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    barbican \u003d barbicanclient.barbican:main"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"openstack.cli.extension \u003d"},{"line_number":31,"context_line":"    barbicanclient \u003d barbicanclient.osc_plugin"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"openstack.barbicanclient.v1 \u003d"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":7,"id":"ba3cc151_546da502","line":31,"updated":"2015-07-07 15:50:19.000000000","message":"use API name\n\n  key_manager \u003d barbicanclient.osc_plugin","commit_id":"f07dd94e400a74cc1bab77a5221cfb15fbf74909"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"e8fdf43c298cc9379248f54d5c2641ff5aab71b7","unresolved":false,"context_lines":[{"line_number":30,"context_line":"openstack.cli.extension \u003d"},{"line_number":31,"context_line":"    barbicanclient \u003d barbicanclient.osc_plugin"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"openstack.barbicanclient.v1 \u003d"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    secret_order_create \u003d barbicanclient.barbican_cli.orders:CreateOrder"},{"line_number":36,"context_line":"    secret_order_delete \u003d barbicanclient.barbican_cli.orders:DeleteOrder"}],"source_content_type":"text/x-ttcn-cfg","patch_set":7,"id":"ba3cc151_d481b590","line":33,"updated":"2015-07-07 15:50:19.000000000","message":"use API name\n\n  openstack.key_manager.v1","commit_id":"f07dd94e400a74cc1bab77a5221cfb15fbf74909"}]}