)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9234,"name":"Steve Heyman","email":"steve@heyman.com","username":"hockeynut"},"change_message_id":"c7f88f68f3507148e1b68fdd004a93850c5bc5ff","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Remove test behaviors abstraction for secrets smoke tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Will remove the test behaviors abstraction from secrets smoke"},{"line_number":10,"context_line":"tests. Tests will be rewritten to use the barbican-client directly."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Id6c96c966bf811e281a5b33d7a720b6af41a132c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da20952f_fb49a28f","line":10,"updated":"2015-08-26 19:35:49.000000000","message":"Why are we doing this?","commit_id":"eb730bef16376ea629b4d81d83649436ee917689"},{"author":{"_account_id":6783,"name":"Nathan Reller","email":"nathan.s.reller@gmail.com","username":"rellerreller"},"change_message_id":"79bb6513b153bba1efa8c49cdf302e88f8fa82f5","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Remove test behaviors abstraction for secrets smoke tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Will remove the test behaviors abstraction from secrets smoke"},{"line_number":10,"context_line":"tests. Tests will be rewritten to use the barbican-client directly."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Id6c96c966bf811e281a5b33d7a720b6af41a132c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da20952f_feece72a","line":10,"in_reply_to":"da20952f_7648495c","updated":"2015-08-27 23:34:47.000000000","message":"I like the idea of using barbican client. To me that is a better test.\n\nIs there any reason to keep the behaviors?","commit_id":"eb730bef16376ea629b4d81d83649436ee917689"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"1891f20f375b06b2c6575213200c7f605e0461d4","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Remove test behaviors abstraction for secrets smoke tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Will remove the test behaviors abstraction from secrets smoke"},{"line_number":10,"context_line":"tests. Tests will be rewritten to use the barbican-client directly."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Id6c96c966bf811e281a5b33d7a720b6af41a132c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da20952f_7648495c","line":10,"in_reply_to":"da20952f_fb49a28f","updated":"2015-08-26 19:41:33.000000000","message":"Hey Steve, checkout:\n\nhttps://blueprints.launchpad.net/python-barbicanclient/+spec/remove-test-behaviors\n\nThe behaviors folders aren\u0027t needed since we can use barbican-client directly.","commit_id":"eb730bef16376ea629b4d81d83649436ee917689"}],"functionaltests/client/v1/smoke/test_secrets.py":[{"author":{"_account_id":11561,"name":"Dave McCowan","email":"dmccowan@cisco.com","username":"dave-mccowan"},"change_message_id":"e7fc5813211cda140bb3017d3354148f80c4d86a","unresolved":false,"context_lines":[{"line_number":170,"context_line":""},{"line_number":171,"context_line":"        self.assertEqual(len(secret_list), limit)"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    def _delete_all_secrets(self):"},{"line_number":174,"context_line":"        \"\"\"Helper method to delete all secrets used for testing\"\"\""},{"line_number":175,"context_line":"        for secret_ref in self.created_secrets:"},{"line_number":176,"context_line":"            self.barbicanclient.secrets.delete(secret_ref)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_dad79821","line":173,"updated":"2015-08-28 10:31:52.000000000","message":"Let\u0027s make this a common method.  Copying and customizing code for each test suite makes me sad.","commit_id":"a6db6a1431c644561bbb033f99c185b60addb2ea"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"01ea93a2206fb9d49b6dfe716a45222ed43125a1","unresolved":false,"context_lines":[{"line_number":170,"context_line":""},{"line_number":171,"context_line":"        self.assertEqual(len(secret_list), limit)"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    def _delete_all_secrets(self):"},{"line_number":174,"context_line":"        \"\"\"Helper method to delete all secrets used for testing\"\"\""},{"line_number":175,"context_line":"        for secret_ref in self.created_secrets:"},{"line_number":176,"context_line":"            self.barbicanclient.secrets.delete(secret_ref)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_e29cf3c1","line":173,"in_reply_to":"da20952f_dad79821","updated":"2015-08-30 22:43:35.000000000","message":"Great Suggestion, please see:\nhttps://review.openstack.org/#/c/218396/9","commit_id":"a6db6a1431c644561bbb033f99c185b60addb2ea"}]}
