)]}'
{"barbicanclient/barbican_cli/secrets.py":[{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"c4ff3accee706859029d6ad22f0b907cabbeb0b0","unresolved":false,"context_lines":[{"line_number":119,"context_line":"    def take_action(self, args):"},{"line_number":120,"context_line":"        obj_list \u003d self.app.client_manager.key_manager.secrets.list("},{"line_number":121,"context_line":"            args.limit, args.offset, args.name, args.algorithm, args.mode,"},{"line_number":122,"context_line":"            args.bit_length)"},{"line_number":123,"context_line":"        return secrets.Secret._list_objects(obj_list)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a26ad4f_4e09e994","line":122,"updated":"2015-10-27 18:07:39.000000000","message":"could you explicitly name the parameters insteads? Even if it looks more verbose it would be less prone to errors and more readable.\n\nSomething such as\n\nobj_list \u003d self.app.client_manager.key_manager.secrets.list(\n\tlimit\u003dargs.limit, offset\u003dargs.offset, name\u003dargs.name,\n        algorithm\u003dargs.algorithm mode\u003dargs.mode, bits\u003dargs.bit_length)","commit_id":"794dd7b7974e1972c716518fd0447706efe1f43f"},{"author":{"_account_id":15274,"name":"Christopher Solis","email":"cnsolis@us.ibm.com","username":"cplusone"},"change_message_id":"d8b8324a92a5bf83064fc033008ade8bc5e38684","unresolved":false,"context_lines":[{"line_number":119,"context_line":"    def take_action(self, args):"},{"line_number":120,"context_line":"        obj_list \u003d self.app.client_manager.key_manager.secrets.list("},{"line_number":121,"context_line":"            args.limit, args.offset, args.name, args.algorithm, args.mode,"},{"line_number":122,"context_line":"            args.bit_length)"},{"line_number":123,"context_line":"        return secrets.Secret._list_objects(obj_list)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a26ad4f_6e9385fb","line":122,"in_reply_to":"1a26ad4f_4e09e994","updated":"2015-10-27 18:19:31.000000000","message":"Ah. That\u0027s a great idea. I will do it now.","commit_id":"794dd7b7974e1972c716518fd0447706efe1f43f"}]}