)]}'
{"barbicanclient/barbican_cli/secrets.py":[{"author":{"_account_id":17579,"name":"Elvin Tubillara","email":"edtubill@us.ibm.com","username":"edtubill"},"change_message_id":"36b075a459a5d373740214a684d03af13ac6e199","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                                 \u0027 list (default: %(default)s).\u0027)"},{"line_number":117,"context_line":"        parser.add_argument(\u0027--acl_only\u0027, \u0027-k\u0027, default\u003dNone,"},{"line_number":118,"context_line":"                            help\u003d\u0027acl filter for the list\u0027"},{"line_number":119,"context_line":"                            \u0027 (default: %(default)s).\u0027)"},{"line_number":120,"context_line":"        return parser"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    def take_action(self, args):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a26ad4f_da0678cd","line":119,"updated":"2015-11-02 19:56:58.000000000","message":"just curious: how was \"-k\" decided?","commit_id":"aabedb7a424873fc661803c72e8b70cb50ba4e64"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"b87f4e6a3323274d258a0dd149aa48be5cf82090","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                                 \u0027 list (default: %(default)s).\u0027)"},{"line_number":117,"context_line":"        parser.add_argument(\u0027--acl_only\u0027, \u0027-k\u0027, default\u003dNone,"},{"line_number":118,"context_line":"                            help\u003d\u0027acl filter for the list\u0027"},{"line_number":119,"context_line":"                            \u0027 (default: %(default)s).\u0027)"},{"line_number":120,"context_line":"        return parser"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    def take_action(self, args):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a26ad4f_1b014805","line":119,"in_reply_to":"1a26ad4f_1862ae3e","updated":"2015-11-03 06:10:12.000000000","message":"I would rather leave it without the short version.","commit_id":"aabedb7a424873fc661803c72e8b70cb50ba4e64"},{"author":{"_account_id":15274,"name":"Christopher Solis","email":"cnsolis@us.ibm.com","username":"cplusone"},"change_message_id":"164a06b51f47c521a88f48ac729e80c35ae5cec5","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                                 \u0027 list (default: %(default)s).\u0027)"},{"line_number":117,"context_line":"        parser.add_argument(\u0027--acl_only\u0027, \u0027-k\u0027, default\u003dNone,"},{"line_number":118,"context_line":"                            help\u003d\u0027acl filter for the list\u0027"},{"line_number":119,"context_line":"                            \u0027 (default: %(default)s).\u0027)"},{"line_number":120,"context_line":"        return parser"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    def take_action(self, args):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa80f949_b4e78c3f","line":119,"in_reply_to":"1a26ad4f_1b014805","updated":"2015-11-03 22:51:15.000000000","message":"I like the idea of leaving it without the short version. That way there is no confusion. It is not consistent with the rest of the client however if that\u0027s okay. I can\u0027t change it to -c as already mentioned in my second comment.","commit_id":"aabedb7a424873fc661803c72e8b70cb50ba4e64"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"7d74d8c4cf290f905cc2646f7e6ea4fbb72bc7fa","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                                 \u0027 list (default: %(default)s).\u0027)"},{"line_number":117,"context_line":"        parser.add_argument(\u0027--acl_only\u0027, \u0027-k\u0027, default\u003dNone,"},{"line_number":118,"context_line":"                            help\u003d\u0027acl filter for the list\u0027"},{"line_number":119,"context_line":"                            \u0027 (default: %(default)s).\u0027)"},{"line_number":120,"context_line":"        return parser"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    def take_action(self, args):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a26ad4f_1862ae3e","line":119,"in_reply_to":"1a26ad4f_7a7644d8","updated":"2015-11-03 05:51:18.000000000","message":"I\u0027d say change it to \"-c\" since the letter is in \"acl_only\".","commit_id":"aabedb7a424873fc661803c72e8b70cb50ba4e64"},{"author":{"_account_id":15274,"name":"Christopher Solis","email":"cnsolis@us.ibm.com","username":"cplusone"},"change_message_id":"f0543a8555a5c446100cd3d5a57b10eb91fa926d","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                                 \u0027 list (default: %(default)s).\u0027)"},{"line_number":117,"context_line":"        parser.add_argument(\u0027--acl_only\u0027, \u0027-k\u0027, default\u003dNone,"},{"line_number":118,"context_line":"                            help\u003d\u0027acl filter for the list\u0027"},{"line_number":119,"context_line":"                            \u0027 (default: %(default)s).\u0027)"},{"line_number":120,"context_line":"        return parser"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    def take_action(self, args):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a26ad4f_7a7644d8","line":119,"in_reply_to":"1a26ad4f_da0678cd","updated":"2015-11-02 20:18:15.000000000","message":"-a, -l, -o, -n, were all taken and I couldn\u0027t use -c because of an error. I\u0027m open to changing it.","commit_id":"aabedb7a424873fc661803c72e8b70cb50ba4e64"}],"barbicanclient/secrets.py":[{"author":{"_account_id":17579,"name":"Elvin Tubillara","email":"edtubill@us.ibm.com","username":"edtubill"},"change_message_id":"c6b72f227d8343d7863b5e2ea8db8f19b1f22ae8","unresolved":false,"context_lines":[{"line_number":573,"context_line":"            params[\u0027mode\u0027] \u003d mode"},{"line_number":574,"context_line":"        if bits \u003e 0:"},{"line_number":575,"context_line":"            params[\u0027bits\u0027] \u003d bits"},{"line_number":576,"context_line":"        if acl_only:"},{"line_number":577,"context_line":"            params[\u0027acl_only\u0027] \u003d acl_only"},{"line_number":578,"context_line":""},{"line_number":579,"context_line":"        response \u003d self._api.get(self._entity, params\u003dparams)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a8ffd7b_2e826b01","line":576,"updated":"2015-11-24 19:42:38.000000000","message":"If the server is expecting a string, then pass the string here based on if --acl_only was set.","commit_id":"8f84431183ec3913671418bfecff46a5a35d895f"},{"author":{"_account_id":10281,"name":"Priti Desai","email":"pdesai@us.ibm.com","username":"priti_desai"},"change_message_id":"14e37a883b40297bb7bdb98da52809b6989b4111","unresolved":false,"context_lines":[{"line_number":541,"context_line":"        self._api.delete(secret_ref)"},{"line_number":542,"context_line":""},{"line_number":543,"context_line":"    def list(self, limit\u003d10, offset\u003d0, name\u003dNone, algorithm\u003dNone,"},{"line_number":544,"context_line":"             mode\u003dNone, bits\u003d0, acl_only\u003dNone):"},{"line_number":545,"context_line":"        \"\"\""},{"line_number":546,"context_line":"        List Secrets for the project"},{"line_number":547,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9a8ffd7b_f47752d2","line":544,"updated":"2015-11-24 20:39:52.000000000","message":"Please set it to False instead of None.","commit_id":"093fa2bb5a013db997922bab862159658f224989"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"e2e89a0c047e9233e9a58d873ae37002024524cd","unresolved":false,"context_lines":[{"line_number":541,"context_line":"        self._api.delete(secret_ref)"},{"line_number":542,"context_line":""},{"line_number":543,"context_line":"    def list(self, limit\u003d10, offset\u003d0, name\u003dNone, algorithm\u003dNone,"},{"line_number":544,"context_line":"             mode\u003dNone, bits\u003d0, acl_only\u003dNone):"},{"line_number":545,"context_line":"        \"\"\""},{"line_number":546,"context_line":"        List Secrets for the project"},{"line_number":547,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9a8ffd7b_ff208b4b","line":544,"in_reply_to":"9a8ffd7b_f47752d2","updated":"2015-11-24 20:47:37.000000000","message":"Agreed","commit_id":"093fa2bb5a013db997922bab862159658f224989"},{"author":{"_account_id":15274,"name":"Christopher Solis","email":"cnsolis@us.ibm.com","username":"cplusone"},"change_message_id":"ee38f3f2b2ff001c2f52c72416c8a11f31a1fa6a","unresolved":false,"context_lines":[{"line_number":541,"context_line":"        self._api.delete(secret_ref)"},{"line_number":542,"context_line":""},{"line_number":543,"context_line":"    def list(self, limit\u003d10, offset\u003d0, name\u003dNone, algorithm\u003dNone,"},{"line_number":544,"context_line":"             mode\u003dNone, bits\u003d0, acl_only\u003dNone):"},{"line_number":545,"context_line":"        \"\"\""},{"line_number":546,"context_line":"        List Secrets for the project"},{"line_number":547,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9a8ffd7b_1a1ebd0c","line":544,"in_reply_to":"9a8ffd7b_ff208b4b","updated":"2015-11-24 21:06:45.000000000","message":"Done","commit_id":"093fa2bb5a013db997922bab862159658f224989"}],"functionaltests/cli/v1/behaviors/secret_behaviors.py":[{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"032b3c5584569799814beee5f9649ddbe1f13ef0","unresolved":false,"context_lines":[{"line_number":129,"context_line":"    def list_secrets(self, acl_only\u003dFalse):"},{"line_number":130,"context_line":"        \"\"\" List secrets"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        :param acl_only if True then add \"--acl_only \u0027true\u0027\" to get only secrets"},{"line_number":133,"context_line":"        that contain the user on the acl"},{"line_number":134,"context_line":"        :return: a list of secrets"},{"line_number":135,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"ba8a016a_f9931959","line":132,"updated":"2015-11-19 16:07:47.000000000","message":"add \":\" after param acl_only","commit_id":"8f84431183ec3913671418bfecff46a5a35d895f"},{"author":{"_account_id":15274,"name":"Christopher Solis","email":"cnsolis@us.ibm.com","username":"cplusone"},"change_message_id":"4b7b27f7f5aa3dc511e0b16703b46400cfe72567","unresolved":false,"context_lines":[{"line_number":129,"context_line":"    def list_secrets(self, acl_only\u003dFalse):"},{"line_number":130,"context_line":"        \"\"\" List secrets"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        :param acl_only if True then add \"--acl_only \u0027true\u0027\" to get only secrets"},{"line_number":133,"context_line":"        that contain the user on the acl"},{"line_number":134,"context_line":"        :return: a list of secrets"},{"line_number":135,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"ba8a016a_ff49b931","line":132,"in_reply_to":"ba8a016a_f9931959","updated":"2015-11-19 16:23:25.000000000","message":"I don\u0027t think that\u0027s necessary because all other functions in this class don\u0027t put that. I\u0027m just trying to be consistent with the other function comments.","commit_id":"8f84431183ec3913671418bfecff46a5a35d895f"}],"functionaltests/cli/v1/smoke/test_secret.py":[{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"89c0741793bde6fa57f24923e6ca935e1eec8d9c","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        # User retrieves 0 secrets with them on the ACL"},{"line_number":117,"context_line":"        secret_list \u003d self.secret_behaviors.list_secrets(acl_only\u003dTrue)"},{"line_number":118,"context_line":"        self.assertEqual(len(secret_list), 0)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    @testcase.attr(\u0027positive\u0027)"},{"line_number":121,"context_line":"    def test_secret_delete(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_054c0fc6","line":118,"updated":"2015-11-17 06:27:23.000000000","message":"It would probably be appropriate to explicitly show, before this, that 5 secrets were actually stored in the database. So I would prefer there being another list_secrets with acl_only\u003dFalse, and asserting that there\u0027s 5 secrets in the database. For the sake of completeness.","commit_id":"3afbe703cf7c033fe607ba1c201e522760ed3bbe"},{"author":{"_account_id":15274,"name":"Christopher Solis","email":"cnsolis@us.ibm.com","username":"cplusone"},"change_message_id":"bf9bb1b00aac286a59b341d35b66220dfe50e63f","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        # User retrieves 0 secrets with them on the ACL"},{"line_number":117,"context_line":"        secret_list \u003d self.secret_behaviors.list_secrets(acl_only\u003dTrue)"},{"line_number":118,"context_line":"        self.assertEqual(len(secret_list), 0)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    @testcase.attr(\u0027positive\u0027)"},{"line_number":121,"context_line":"    def test_secret_delete(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_8eb6c588","line":118,"in_reply_to":"ba8a016a_054c0fc6","updated":"2015-11-17 15:58:26.000000000","message":"Ah. Good Idea. I\u0027ll add that.","commit_id":"3afbe703cf7c033fe607ba1c201e522760ed3bbe"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"6ca8c4a9bbf8854a864e0809a3ea734fc3f31b21","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        # Retrieve 0 secrets with user on the ACL"},{"line_number":120,"context_line":"        secret_list \u003d self.secret_behaviors.list_secrets(acl_only\u003dTrue)"},{"line_number":121,"context_line":"        self.assertEqual(len(secret_list), 0)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    @testcase.attr(\u0027positive\u0027)"},{"line_number":124,"context_line":"    def test_secret_delete(self):"},{"line_number":125,"context_line":"        secret_href \u003d self.secret_behaviors.store_secret()"}],"source_content_type":"text/x-python","patch_set":8,"id":"dada55a8_19abe51f","line":122,"updated":"2016-07-25 10:54:49.000000000","message":"While I understand that this is a client test, its not really a test as to whether secrets with the user in the acl list are actually retrieved.\n\nA better test would be to actually create some secrets where the user is added to the acl list, and show that these secrets are retrieved.","commit_id":"0bd3fd7cb5f87fb1b48a4f4dac8f93734866ed69"}]}