)]}'
{"barbicanclient/barbican_cli/secrets.py":[{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"d574b7af5159a0baece676c8f03e6777982dcfba","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        parser.add_argument(\u0027--payload\u0027, \u0027-p\u0027, default\u003dNone,"},{"line_number":82,"context_line":"                            help\u003d\u0027the unencrypted secret\u0027)"},{"line_number":83,"context_line":"        parser.add_argument(\u0027--file-path\u0027, \u0027-f\u0027, default\u003dNone,"},{"line_number":84,"context_line":"                            help\u003d\u0027the path to a file containing a payload\u0027)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        return parser"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_2ff22ad3","line":84,"updated":"2015-11-10 07:07:37.000000000","message":"you could do something as the following, to validate and open the file https://docs.python.org/3/library/argparse.html#type","commit_id":"0935eb0655c0daca20d4f46fe896bfc50bde8101"}],"barbicanclient/common/utils.py":[{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"4e92ba7a7d13cd69dda53902ea089dee6d786506","unresolved":false,"context_lines":[{"line_number":23,"context_line":"        return blob"},{"line_number":24,"context_line":"    except IOError:"},{"line_number":25,"context_line":"        msg \u003d \"Error occurred trying to read from file %s\""},{"line_number":26,"context_line":"        raise exceptions.PayloadException(msg % blob_file)"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a8ffd7b_a6ff4d00","line":26,"updated":"2015-11-25 08:02:03.000000000","message":"uhm... I would rather not override this exception here. I think the standard python exception that\u0027s thrown is actually more informative than this.","commit_id":"48212b3868aeec846d749df04624b25514ba4c59"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"08c1ed88dca91eb0a2dca8ec00f1b8be03698865","unresolved":false,"context_lines":[{"line_number":23,"context_line":"        return blob"},{"line_number":24,"context_line":"    except IOError:"},{"line_number":25,"context_line":"        msg \u003d \"Error occurred trying to read from file %s\""},{"line_number":26,"context_line":"        raise exceptions.PayloadException(msg % blob_file)"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a8ffd7b_b3fb977a","line":26,"in_reply_to":"9a8ffd7b_38ab561f","updated":"2015-11-27 07:02:15.000000000","message":"Just getting rid of the try/catch works. The way exceptions are handled in barbicanclient, it won\u0027t print a stacktrace unless de --debug flag is specified.\n\nSo, without the try... catch, it will look like this:\n\n$ barbican secret update --file-path unexistant_file http://localhost:9311/v1/4ee78262-f489-4bda-8e60-2f2603656d6b\n[Errno 2] No such file or directory: \u0027unexistant_file\u0027\n\nWhich is easier to figure out rather than just seeing there was an error, but not knowing if it was that the file doesn\u0027t exist, or if the file permissions were not appropriate, for instance:\n\n$ sudo chmod 600 root_file.txt \n$ ls -l root_file.txt \n-rw-------. 1 root root 0 Nov 27 08:59 root_file.txt\n$ barbican secret update --file-path root_file.txt http://localhost:9311/v1/4ee78262-f489-4bda-8e60-2f2603656d6b\n[Errno 13] Permission denied: \u0027root_file.txt\u0027","commit_id":"48212b3868aeec846d749df04624b25514ba4c59"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"8d1a901b8ac6db19adff4cb0fe7d44c24dbd3fd4","unresolved":false,"context_lines":[{"line_number":23,"context_line":"        return blob"},{"line_number":24,"context_line":"    except IOError:"},{"line_number":25,"context_line":"        msg \u003d \"Error occurred trying to read from file %s\""},{"line_number":26,"context_line":"        raise exceptions.PayloadException(msg % blob_file)"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a8ffd7b_38ab561f","line":26,"in_reply_to":"9a8ffd7b_a6ff4d00","updated":"2015-11-25 16:54:13.000000000","message":"That works, should I just have a pass after the except or is there anything more specific that should be done, logging, etc.","commit_id":"48212b3868aeec846d749df04624b25514ba4c59"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"af8ff9a467434aabfae08ed742f97f8baa818423","unresolved":false,"context_lines":[{"line_number":23,"context_line":"        return blob"},{"line_number":24,"context_line":"    except IOError:"},{"line_number":25,"context_line":"        msg \u003d \"Error occurred trying to read from file %s\""},{"line_number":26,"context_line":"        raise exceptions.PayloadException(msg % blob_file)"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a8ffd7b_dec71794","line":26,"in_reply_to":"9a8ffd7b_b3fb977a","updated":"2015-11-28 03:08:57.000000000","message":"Gotcha, that works perfect!!","commit_id":"48212b3868aeec846d749df04624b25514ba4c59"}],"barbicanclient/secrets.py":[{"author":{"_account_id":17579,"name":"Elvin Tubillara","email":"edtubill@us.ibm.com","username":"edtubill"},"change_message_id":"cd8aa0a218580405072d9239f9d06c4711eef1c0","unresolved":false,"context_lines":[{"line_number":484,"context_line":""},{"line_number":485,"context_line":"        # Payload should only be specified through input or file, not both"},{"line_number":486,"context_line":"        if payload and file_path:"},{"line_number":487,"context_line":"            raise exceptions.HTTPClientError(\u0027Cannot specify both payload \u0027"},{"line_number":488,"context_line":"                                             \u0027and file-path\u0027)"},{"line_number":489,"context_line":"        # Payload or file_path must be input"},{"line_number":490,"context_line":"        if not (payload or file_path):"}],"source_content_type":"text/x-python","patch_set":3,"id":"da85f559_63333863","line":487,"updated":"2015-11-11 04:43:18.000000000","message":"Why are we raising exceptions.HTTPClientError? We don\u0027t actually get a response from the server.","commit_id":"7f6fcf805b7141921c4bf46fb8ecceb7ef0799d2"},{"author":{"_account_id":17579,"name":"Elvin Tubillara","email":"edtubill@us.ibm.com","username":"edtubill"},"change_message_id":"cd8aa0a218580405072d9239f9d06c4711eef1c0","unresolved":false,"context_lines":[{"line_number":488,"context_line":"                                             \u0027and file-path\u0027)"},{"line_number":489,"context_line":"        # Payload or file_path must be input"},{"line_number":490,"context_line":"        if not (payload or file_path):"},{"line_number":491,"context_line":"            raise exceptions.HTTPClientError(\u0027Please specify either payload \u0027"},{"line_number":492,"context_line":"                                             \u0027or file-path\u0027)"},{"line_number":493,"context_line":""},{"line_number":494,"context_line":"        if file_path:"}],"source_content_type":"text/x-python","patch_set":3,"id":"da85f559_03458cb1","line":491,"updated":"2015-11-11 04:43:18.000000000","message":"Same here.","commit_id":"7f6fcf805b7141921c4bf46fb8ecceb7ef0799d2"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"1e17497b9657d534b6e639d4c72c34af5bf88858","unresolved":false,"context_lines":[{"line_number":487,"context_line":"            try:"},{"line_number":488,"context_line":"                payload \u003d blob"},{"line_number":489,"context_line":"            except ValueError as e:"},{"line_number":490,"context_line":"                raise exceptions.PayloadException(e)"},{"line_number":491,"context_line":""},{"line_number":492,"context_line":"        if type(payload) is six.binary_type:"},{"line_number":493,"context_line":"            headers \u003d {\u0027content-type\u0027: \"application/octet-stream\"}"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba8a016a_bf7c4e21","line":490,"updated":"2015-11-16 17:00:14.000000000","message":"maybe I\u0027m missing something, but why would this raise a ValueError?","commit_id":"30b1abef572798945297e6cd6d40492291783a05"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"e3240ba383439c584ee40d15f1691c5317d783cf","unresolved":false,"context_lines":[{"line_number":487,"context_line":"            try:"},{"line_number":488,"context_line":"                payload \u003d blob"},{"line_number":489,"context_line":"            except ValueError as e:"},{"line_number":490,"context_line":"                raise exceptions.PayloadException(e)"},{"line_number":491,"context_line":""},{"line_number":492,"context_line":"        if type(payload) is six.binary_type:"},{"line_number":493,"context_line":"            headers \u003d {\u0027content-type\u0027: \"application/octet-stream\"}"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba8a016a_a248b55c","line":490,"in_reply_to":"ba8a016a_bf7c4e21","updated":"2015-11-16 17:42:13.000000000","message":"Hey Juan you are right, this is not needed here. I got ahead of myself. It will be for when the user must pass a json file.\n\nFor example:\n\ntry:\n     payload \u003d  json.loads(blob)\nexcept ValueError as e:\n     raise exceptions.PayloadException(e)","commit_id":"30b1abef572798945297e6cd6d40492291783a05"}],"barbicanclient/tests/test_utils.py":[{"author":{"_account_id":15274,"name":"Christopher Solis","email":"cnsolis@us.ibm.com","username":"cplusone"},"change_message_id":"405f110d2e1ab7a7e650420ccd26ff7380a25deb","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    @testtools.testcase.attr(\u0027positive\u0027)"},{"line_number":27,"context_line":"    def test_read_blob_file_contents(self):"},{"line_number":28,"context_line":"        with tempfile.NamedTemporaryFile(delete\u003dTrue) as test_file:"},{"line_number":29,"context_line":"            test_file.write(\u0027This is a Secret!\u0027.encode(\u0027utf-8\u0027))"},{"line_number":30,"context_line":"            file_path \u003d test_file.name"},{"line_number":31,"context_line":"            test_file.flush()"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"dae33548_007a4e24","line":29,"updated":"2016-02-15 19:33:04.000000000","message":"Can you make\u0027This is a Secret!\u0027 a single variable. Makes it easier to make sure they are testing the exact same thing.","commit_id":"78d5b71c1a5500944efadbdfe7d3ff449e8f8b0e"}],"functionaltests/cli/v1/smoke/test_secret.py":[{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"c013b086f2b1e003dc7465f43426fe584ec54d18","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        self.assertEqual(payload, payload_update)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    @testcase.attr(\u0027positive\u0027)"},{"line_number":103,"context_line":"    def test_secret_update_from_file(self):"},{"line_number":104,"context_line":"        secret_href \u003d self.secret_behaviors.store_secret("},{"line_number":105,"context_line":"            payload\u003dNone)"},{"line_number":106,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_1490fa94","line":103,"updated":"2015-11-06 21:15:59.000000000","message":"Not sure if this is the right way of testing this. Haven\u0027t seen file input tested before.","commit_id":"ae615ffa800a2defaac6667a724fe280718b9476"},{"author":{"_account_id":17579,"name":"Elvin Tubillara","email":"edtubill@us.ibm.com","username":"edtubill"},"change_message_id":"aa6b1f7eb05620bbb97479c482339e555f7c69d4","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        secret_href \u003d self.secret_behaviors.store_secret("},{"line_number":106,"context_line":"            payload\u003dNone)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        # create temporary file for testing"},{"line_number":109,"context_line":"        test_file \u003d tempfile.NamedTemporaryFile(delete\u003dFalse)"},{"line_number":110,"context_line":"        test_file.write(\u0027This is a Secret!\u0027)"},{"line_number":111,"context_line":"        test_file.close()"}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_82b86876","line":108,"updated":"2015-11-11 22:31:41.000000000","message":"It looks like the file does not get cleaned up.","commit_id":"41f75549cadf93ba16e8d243bd32fbf1b11b15d0"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"0c5d61b38bfbd1618376251054883b85cd1f1395","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        secret_href \u003d self.secret_behaviors.store_secret("},{"line_number":106,"context_line":"            payload\u003dNone)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        # create temporary file for testing"},{"line_number":109,"context_line":"        test_file \u003d tempfile.NamedTemporaryFile(delete\u003dFalse)"},{"line_number":110,"context_line":"        test_file.write(\u0027This is a Secret!\u0027)"},{"line_number":111,"context_line":"        test_file.close()"}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_4d286333","line":108,"in_reply_to":"da85f559_2de16d2d","updated":"2015-11-12 05:45:40.000000000","message":"or use it as a context manager like presented here: https://docs.python.org/3/library/tempfile.html#examples","commit_id":"41f75549cadf93ba16e8d243bd32fbf1b11b15d0"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"31f6a6d59cb8c416e78a6e1f3f5a6b4d5857e057","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        secret_href \u003d self.secret_behaviors.store_secret("},{"line_number":106,"context_line":"            payload\u003dNone)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        # create temporary file for testing"},{"line_number":109,"context_line":"        test_file \u003d tempfile.NamedTemporaryFile(delete\u003dFalse)"},{"line_number":110,"context_line":"        test_file.write(\u0027This is a Secret!\u0027)"},{"line_number":111,"context_line":"        test_file.close()"}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_ed2917e7","line":108,"in_reply_to":"da85f559_4d286333","updated":"2015-11-12 05:56:11.000000000","message":"Good idea, thanks Juan!","commit_id":"41f75549cadf93ba16e8d243bd32fbf1b11b15d0"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"f10bd74817a7446c40f03d26ce1f032cb06494b0","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        secret_href \u003d self.secret_behaviors.store_secret("},{"line_number":106,"context_line":"            payload\u003dNone)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        # create temporary file for testing"},{"line_number":109,"context_line":"        test_file \u003d tempfile.NamedTemporaryFile(delete\u003dFalse)"},{"line_number":110,"context_line":"        test_file.write(\u0027This is a Secret!\u0027)"},{"line_number":111,"context_line":"        test_file.close()"}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_2de16d2d","line":108,"in_reply_to":"da85f559_82b86876","updated":"2015-11-11 22:36:32.000000000","message":"Will make delete\u003dTrue and move the test_file.close() to after it is used.","commit_id":"41f75549cadf93ba16e8d243bd32fbf1b11b15d0"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"7ce1abf2a1c07e7eae3c5b52f83894eba9bd6b5b","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        secret_href \u003d self.secret_behaviors.store_secret("},{"line_number":106,"context_line":"            payload\u003dNone)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        # create temporary file for testing"},{"line_number":109,"context_line":"        test_file \u003d tempfile.NamedTemporaryFile(delete\u003dFalse)"},{"line_number":110,"context_line":"        test_file.write(\u0027This is a Secret!\u0027)"},{"line_number":111,"context_line":"        test_file.close()"}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_10cd9484","line":108,"in_reply_to":"da85f559_903d0491","updated":"2015-11-12 06:21:53.000000000","message":"weren\u0027t you using a NamedTemporary file? you can get the actual path from there, even if using a context manager.","commit_id":"41f75549cadf93ba16e8d243bd32fbf1b11b15d0"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"bf5e5f6a7bcf1db797809c0a68f2e3da3ca59385","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        secret_href \u003d self.secret_behaviors.store_secret("},{"line_number":106,"context_line":"            payload\u003dNone)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        # create temporary file for testing"},{"line_number":109,"context_line":"        test_file \u003d tempfile.NamedTemporaryFile(delete\u003dFalse)"},{"line_number":110,"context_line":"        test_file.write(\u0027This is a Secret!\u0027)"},{"line_number":111,"context_line":"        test_file.close()"}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_903d0491","line":108,"in_reply_to":"da85f559_ed2917e7","updated":"2015-11-12 06:17:03.000000000","message":"So using TemporaryFile won\u0027t work since we need an actual path. We need tempfile.NamedTemporaryFile(delete\u003dFalse) which mimics the behavior of https://docs.python.org/3/library/tempfile.html#tempfile.mktemp\n\nWhat I can do is os.unlink(f.name) after the file is used.","commit_id":"41f75549cadf93ba16e8d243bd32fbf1b11b15d0"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"6422bf08d4ef98ef68c7f0b6f212ee9b44140fab","unresolved":false,"context_lines":[{"line_number":107,"context_line":"            payload\u003dNone)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"        # create temporary file for testing"},{"line_number":110,"context_line":"        test_file \u003d tempfile.NamedTemporaryFile(delete\u003dFalse)"},{"line_number":111,"context_line":"        test_file.write(\u0027This is a Secret!\u0027)"},{"line_number":112,"context_line":"        test_file.close()"},{"line_number":113,"context_line":"        file_path \u003d test_file.name"}],"source_content_type":"text/x-python","patch_set":7,"id":"da85f559_10a27499","line":110,"updated":"2015-11-12 06:23:45.000000000","message":"I still don\u0027t see why you can\u0027t use a NamedTemporaryFile as a context manager and thus avoid using the os.unlink","commit_id":"7761f87dda1979c5f2df7e36d49ddd0cafdbd965"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"903a05caa5c24a1a52a82e67663da5ff92da35d9","unresolved":false,"context_lines":[{"line_number":107,"context_line":"            payload\u003dNone)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"        # create temporary file for testing"},{"line_number":110,"context_line":"        test_file \u003d tempfile.NamedTemporaryFile(delete\u003dFalse)"},{"line_number":111,"context_line":"        test_file.write(\u0027This is a Secret!\u0027)"},{"line_number":112,"context_line":"        test_file.close()"},{"line_number":113,"context_line":"        file_path \u003d test_file.name"}],"source_content_type":"text/x-python","patch_set":7,"id":"da85f559_309e9807","line":110,"in_reply_to":"da85f559_10a27499","updated":"2015-11-12 06:38:52.000000000","message":"It won\u0027t work unless I set NamedTemporaryFile(), passing it the delete\u003dFalse. Since it is passed as False then the file won\u0027t be deleted after close.\n\nSo the following code:\nwith tempfile.NamedTemporaryFile() as test_file:\n            test_file.write(\u0027This is a Secret!\u0027)\n            file_path \u003d test_file.name\n            payload \u003d utils_.read_blob_file_contents(file_path)\n            self.secret_behaviors.update_secret_from_file(secret_href,\n                                                          file_path)\n\nwill produce:\n_StringException: Traceback (most recent call last):\n  File \"/opt/stack/python-barbicanclient/functionaltests/cli/v1/smoke/test_secret.py\", line 118, in test_secret_update_from_file\n    payload_update \u003d self.secret_behaviors.get_secret_payload(secret_href)\n  File \"/opt/stack/python-barbicanclient/functionaltests/cli/v1/behaviors/secret_behaviors.py\", line 139, in get_secret_payload\n    secret \u003d secret_data[\u0027Payload\u0027]\nKeyError: \u0027Payload\u0027\n\nI can do something like:with tempfile.NamedTemporaryFile(delete\u003dFalse) as test_file:\n            test_file.write(\u0027This is a Secret!\u0027)\n            file_path \u003d test_file.name\n        payload \u003d utils_.read_blob_file_contents(file_path)\n        self.secret_behaviors.update_secret_from_file(secret_href,\n                                                      file_path)\n\nto remove the test_file.close(), but I still need to do os.unlink to remove the file.","commit_id":"7761f87dda1979c5f2df7e36d49ddd0cafdbd965"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"f38f8572c3e59d3ac2d746dc51c6ee9c38f23e9b","unresolved":false,"context_lines":[{"line_number":107,"context_line":"            payload\u003dNone)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"        # create temporary file for testing"},{"line_number":110,"context_line":"        test_file \u003d tempfile.NamedTemporaryFile(delete\u003dFalse)"},{"line_number":111,"context_line":"        test_file.write(\u0027This is a Secret!\u0027)"},{"line_number":112,"context_line":"        test_file.close()"},{"line_number":113,"context_line":"        file_path \u003d test_file.name"}],"source_content_type":"text/x-python","patch_set":7,"id":"da85f559_627aedbe","line":110,"in_reply_to":"da85f559_1231f859","updated":"2015-11-12 17:51:08.000000000","message":"Thanks Elvin, that worked.","commit_id":"7761f87dda1979c5f2df7e36d49ddd0cafdbd965"},{"author":{"_account_id":17579,"name":"Elvin Tubillara","email":"edtubill@us.ibm.com","username":"edtubill"},"change_message_id":"beb32638e39f8807206e430559246c3e1aa4f15e","unresolved":false,"context_lines":[{"line_number":107,"context_line":"            payload\u003dNone)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"        # create temporary file for testing"},{"line_number":110,"context_line":"        test_file \u003d tempfile.NamedTemporaryFile(delete\u003dFalse)"},{"line_number":111,"context_line":"        test_file.write(\u0027This is a Secret!\u0027)"},{"line_number":112,"context_line":"        test_file.close()"},{"line_number":113,"context_line":"        file_path \u003d test_file.name"}],"source_content_type":"text/x-python","patch_set":7,"id":"da85f559_1231f859","line":110,"in_reply_to":"da85f559_309e9807","updated":"2015-11-12 16:10:46.000000000","message":"Can you try using delete\u003dTrue,\nand I think to do the first example you also need test_file.flush() right after test_file.write().","commit_id":"7761f87dda1979c5f2df7e36d49ddd0cafdbd965"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"83ac014efa11539064ef04677b6f85534341bbd7","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from functionaltests.cli.base import CmdLineTestCase"},{"line_number":20,"context_line":"from functionaltests.cli.v1.behaviors.secret_behaviors import SecretBehaviors"},{"line_number":21,"context_line":"from functionaltests.common import keys"},{"line_number":22,"context_line":"from functionaltests import utils"},{"line_number":23,"context_line":"from testtools import testcase"},{"line_number":24,"context_line":"from barbicanclient.common import utils as utils_"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"9a8ffd7b_91036673","line":22,"updated":"2015-11-25 07:56:46.000000000","message":"will change utils to test_utils","commit_id":"69e42d7bcc3c7f4ae6c66a89700ed5aa650ae543"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"83ac014efa11539064ef04677b6f85534341bbd7","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from functionaltests.common import keys"},{"line_number":22,"context_line":"from functionaltests import utils"},{"line_number":23,"context_line":"from testtools import testcase"},{"line_number":24,"context_line":"from barbicanclient.common import utils as utils_"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"@utils.parameterized_test_case"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a8ffd7b_71e7e2e4","line":24,"updated":"2015-11-25 07:56:46.000000000","message":"will change utils_ to utils","commit_id":"69e42d7bcc3c7f4ae6c66a89700ed5aa650ae543"}]}
