)]}'
{"barbicanclient/tests/test_containers.py":[{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"e5b85ac9f99492d6d78874ece2c07721cfd11bd0","unresolved":false,"context_lines":[{"line_number":466,"context_line":"        data \u003d {\"containers\": [container_resp for v in range(3)]}"},{"line_number":467,"context_line":"        self.responses.get(self.entity_base, json\u003ddata)"},{"line_number":468,"context_line":""},{"line_number":469,"context_line":"        delete_secret_name \u003d data.get(\"containers\")[0].get(\"secret_refs\")[0]"},{"line_number":470,"context_line":"        del delete_secret_name[\"name\"]"},{"line_number":471,"context_line":""},{"line_number":472,"context_line":"        containers_list \u003d self.manager.list(limit\u003d10, offset\u003d5)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_5ad37ad5","line":469,"updated":"2016-01-10 21:55:23.000000000","message":"I don\u0027t particularly like the way this is being done. Another developer in the future may not know why this is being done. It also remove\u0027s the name from all 3 containers.\n\nBefore del call:\n{\u0027containers\u0027: [{\u0027status\u0027: \u0027ACTIVE\u0027, \u0027name\u0027: \u0027Self destruction sequence\u0027, \u0027created\u0027: \u00272016-01-10 21:50:17.824387\u0027, \u0027container_ref\u0027: \u0027http://localhost:9311/v1/containers/abcd1234-eabc-5678-9abc-abcdef012345\u0027, \u0027secret_refs\u0027: [{\u0027secret_ref\u0027: \u0027http://barbican/v1/secrets/a73b62e4-eee2-4169-9a14-b8bb4da71d87\u0027, \u0027name\u0027: \u0027thing1\u0027}], \u0027type\u0027: \u0027generic\u0027}, {\u0027status\u0027: \u0027ACTIVE\u0027, \u0027name\u0027: \u0027Self destruction sequence\u0027, \u0027created\u0027: \u00272016-01-10 21:50:17.824387\u0027, \u0027container_ref\u0027: \u0027http://localhost:9311/v1/containers/abcd1234-eabc-5678-9abc-abcdef012345\u0027, \u0027secret_refs\u0027: [{\u0027secret_ref\u0027: \u0027http://barbican/v1/secrets/a73b62e4-eee2-4169-9a14-b8bb4da71d87\u0027, \u0027name\u0027: \u0027thing1\u0027}], \u0027type\u0027: \u0027generic\u0027}, {\u0027status\u0027: \u0027ACTIVE\u0027, \u0027name\u0027: \u0027Self destruction sequence\u0027, \u0027created\u0027: \u00272016-01-10 21:50:17.824387\u0027, \u0027container_ref\u0027: \u0027http://localhost:9311/v1/containers/abcd1234-eabc-5678-9abc-abcdef012345\u0027, \u0027secret_refs\u0027: [{\u0027secret_ref\u0027: \u0027http://barbican/v1/secrets/a73b62e4-eee2-4169-9a14-b8bb4da71d87\u0027, \u0027name\u0027: \u0027thing1\u0027}], \u0027type\u0027: \u0027generic\u0027}]}\n\nAfter del call:\n{\u0027containers\u0027: [{\u0027status\u0027: \u0027ACTIVE\u0027, \u0027name\u0027: \u0027Self destruction sequence\u0027, \u0027created\u0027: \u00272016-01-10 21:50:17.824387\u0027, \u0027container_ref\u0027: \u0027http://localhost:9311/v1/containers/abcd1234-eabc-5678-9abc-abcdef012345\u0027, \u0027secret_refs\u0027: [{\u0027secret_ref\u0027: \u0027http://barbican/v1/secrets/a73b62e4-eee2-4169-9a14-b8bb4da71d87\u0027}], \u0027type\u0027: \u0027generic\u0027}, {\u0027status\u0027: \u0027ACTIVE\u0027, \u0027name\u0027: \u0027Self destruction sequence\u0027, \u0027created\u0027: \u00272016-01-10 21:50:17.824387\u0027, \u0027container_ref\u0027: \u0027http://localhost:9311/v1/containers/abcd1234-eabc-5678-9abc-abcdef012345\u0027, \u0027secret_refs\u0027: [{\u0027secret_ref\u0027: \u0027http://barbican/v1/secrets/a73b62e4-eee2-4169-9a14-b8bb4da71d87\u0027}], \u0027type\u0027: \u0027generic\u0027}, {\u0027status\u0027: \u0027ACTIVE\u0027, \u0027name\u0027: \u0027Self destruction sequence\u0027, \u0027created\u0027: \u00272016-01-10 21:50:17.824387\u0027, \u0027container_ref\u0027: \u0027http://localhost:9311/v1/containers/abcd1234-eabc-5678-9abc-abcdef012345\u0027, \u0027secret_refs\u0027: [{\u0027secret_ref\u0027: \u0027http://barbican/v1/secrets/a73b62e4-eee2-4169-9a14-b8bb4da71d87\u0027}], \u0027type\u0027: \u0027generic\u0027}]}\n\nMy suggestion is to just add a \u0027new container dict\u0027 to \u0027data\u0027 that doesn\u0027t have a name. Then update the asserts. Makes it easy for a developer to know what is going on.","commit_id":"4dc729c78d5716f568009996273774da2e1395e1"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"ace4e579916a6ac0c4ebe220bff6bec7504cae6a","unresolved":false,"context_lines":[{"line_number":481,"context_line":"    def test_should_get_list_when_secret_ref_without_name(self):"},{"line_number":482,"context_line":"        container_resp \u003d self.container.get_dict(self.entity_href)"},{"line_number":483,"context_line":"        del container_resp.get(\"secret_refs\")[0][\"name\"]"},{"line_number":484,"context_line":"        data \u003d {\"containers\": [container_resp for v in range(3)]}"},{"line_number":485,"context_line":"        self.responses.get(self.entity_base, json\u003ddata)"},{"line_number":486,"context_line":"        containers_list \u003d self.manager.list(limit\u003d10, offset\u003d5)"},{"line_number":487,"context_line":"        self.assertTrue(len(containers_list) \u003d\u003d 3)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba63e191_d021c9b5","line":484,"updated":"2016-01-19 21:21:48.000000000","message":"after del call:\n\n{\u0027containers\u0027: [{\u0027status\u0027: \u0027ACTIVE\u0027, \u0027name\u0027: \u0027Self destruction sequence\u0027, \u0027created\u0027: \u00272016-01-19 19:39:23.804729\u0027, \u0027container_ref\u0027: \u0027http://localhost:9311/v1/containers/abcd1234-eabc-5678-9abc-abcdef012345\u0027, \u0027secret_refs\u0027: [{\u0027secret_ref\u0027: \u0027http://barbican/v1/secrets/a73b62e4-eee2-4169-9a14-b8bb4da71d87\u0027}], \u0027type\u0027: \u0027generic\u0027}, {\u0027status\u0027: \u0027ACTIVE\u0027, \u0027name\u0027: \u0027Self destruction sequence\u0027, \u0027created\u0027: \u00272016-01-19 19:39:23.804729\u0027, \u0027container_ref\u0027: \u0027http://localhost:9311/v1/containers/abcd1234-eabc-5678-9abc-abcdef012345\u0027, \u0027secret_refs\u0027: [{\u0027secret_ref\u0027: \u0027http://barbican/v1/secrets/a73b62e4-eee2-4169-9a14-b8bb4da71d87\u0027}], \u0027type\u0027: \u0027generic\u0027}, {\u0027status\u0027: \u0027ACTIVE\u0027, \u0027name\u0027: \u0027Self destruction sequence\u0027, \u0027created\u0027: \u00272016-01-19 19:39:23.804729\u0027, \u0027container_ref\u0027: \u0027http://localhost:9311/v1/containers/abcd1234-eabc-5678-9abc-abcdef012345\u0027, \u0027secret_refs\u0027: [{\u0027secret_ref\u0027: \u0027http://barbican/v1/secrets/a73b62e4-eee2-4169-9a14-b8bb4da71d87\u0027}], \u0027type\u0027: \u0027generic\u0027}]}","commit_id":"3f356bfd5191255a9a71863d3a3ee6fb7e56e44e"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"ace4e579916a6ac0c4ebe220bff6bec7504cae6a","unresolved":false,"context_lines":[{"line_number":483,"context_line":"        del container_resp.get(\"secret_refs\")[0][\"name\"]"},{"line_number":484,"context_line":"        data \u003d {\"containers\": [container_resp for v in range(3)]}"},{"line_number":485,"context_line":"        self.responses.get(self.entity_base, json\u003ddata)"},{"line_number":486,"context_line":"        containers_list \u003d self.manager.list(limit\u003d10, offset\u003d5)"},{"line_number":487,"context_line":"        self.assertTrue(len(containers_list) \u003d\u003d 3)"},{"line_number":488,"context_line":"        self.assertIsInstance(containers_list[0], containers.Container)"},{"line_number":489,"context_line":"        self.assertEqual(self.entity_href, containers_list[0].container_ref)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba63e191_f0abad87","line":486,"updated":"2016-01-19 21:21:48.000000000","message":"Just separate the lines below with a space to keep style consistent with the test above.","commit_id":"3f356bfd5191255a9a71863d3a3ee6fb7e56e44e"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"ace4e579916a6ac0c4ebe220bff6bec7504cae6a","unresolved":false,"context_lines":[{"line_number":491,"context_line":"        # Verify the correct URL was used to make the call."},{"line_number":492,"context_line":"        self.assertEqual(self.entity_base,"},{"line_number":493,"context_line":"                         self.responses.last_request.url.split(\u0027?\u0027)[0])"},{"line_number":494,"context_line":"        for k in containers_list:"},{"line_number":495,"context_line":"            for name in six.iterkeys(k._secret_refs):"},{"line_number":496,"context_line":"                self.assertIsNone(name)"},{"line_number":497,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ba63e191_7077bd3a","line":494,"updated":"2016-01-19 21:21:48.000000000","message":"Change to \"for container in containers_list\"\n\nAdd a comment on what this is doing.\n# Verify that the names of the secret_refs in the containers are None","commit_id":"3f356bfd5191255a9a71863d3a3ee6fb7e56e44e"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"ace4e579916a6ac0c4ebe220bff6bec7504cae6a","unresolved":false,"context_lines":[{"line_number":492,"context_line":"        self.assertEqual(self.entity_base,"},{"line_number":493,"context_line":"                         self.responses.last_request.url.split(\u0027?\u0027)[0])"},{"line_number":494,"context_line":"        for k in containers_list:"},{"line_number":495,"context_line":"            for name in six.iterkeys(k._secret_refs):"},{"line_number":496,"context_line":"                self.assertIsNone(name)"},{"line_number":497,"context_line":""},{"line_number":498,"context_line":"    def test_should_fail_get_invalid_container(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba63e191_502f19f6","line":495,"updated":"2016-01-19 21:21:48.000000000","message":"container._secret_refs","commit_id":"3f356bfd5191255a9a71863d3a3ee6fb7e56e44e"}]}
