)]}'
{"id":"openstack%2Fpython-barbicanclient~305594","triplet_id":"openstack%2Fpython-barbicanclient~master~I9d0b2d04662b3a7399603b9eff20d9daf406e069","project":"openstack/python-barbicanclient","branch":"master","hashtags":[],"change_id":"I9d0b2d04662b3a7399603b9eff20d9daf406e069","subject":"Fixed python-barbicanclient functional tests.","status":"MERGED","created":"2016-04-14 03:22:48.000000000","updated":"2016-05-16 06:54:06.000000000","submitted":"2016-05-16 06:54:06.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"7f93e76e56c37f79b1f321485652273f07fd6183","_number":305594,"virtual_id_number":305594,"owner":{"_account_id":17536,"name":"Max Abidi","email":"max_abidi@yahoo.com","username":"Max_a"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2016-05-16 06:54:05.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},{"value":0,"_account_id":6783,"name":"Nathan Reller","email":"nathan.s.reller@gmail.com","username":"rellerreller"},{"value":0,"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-05-16 06:26:40.000000000","_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},{"value":2,"date":"2016-04-21 00:14:31.000000000","_account_id":6783,"name":"Nathan Reller","email":"nathan.s.reller@gmail.com","username":"rellerreller"},{"value":1,"date":"2016-04-22 19:13:09.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-05-16 06:26:40.000000000","_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},{"value":0,"_account_id":6783,"name":"Nathan Reller","email":"nathan.s.reller@gmail.com","username":"rellerreller"},{"value":0,"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6783,"name":"Nathan Reller","email":"nathan.s.reller@gmail.com","username":"rellerreller"},{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-04-21 00:14:31.000000000","updated_by":{"_account_id":6783,"name":"Nathan Reller","email":"nathan.s.reller@gmail.com","username":"rellerreller"},"reviewer":{"_account_id":6783,"name":"Nathan Reller","email":"nathan.s.reller@gmail.com","username":"rellerreller"},"state":"REVIEWER"},{"updated":"2016-04-22 19:13:09.000000000","updated_by":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"reviewer":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"state":"REVIEWER"},{"updated":"2016-05-16 06:26:40.000000000","updated_by":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"reviewer":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"state":"REVIEWER"},{"updated":"2016-05-16 06:54:05.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"9a9c46eabacafe800bd61c4f5b9a762495bc246d","author":{"_account_id":17536,"name":"Max Abidi","email":"max_abidi@yahoo.com","username":"Max_a"},"date":"2016-04-14 03:22:48.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9a260377a37d35c01d1b3fd24e40b9db16b66bac","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-04-14 03:48:11.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-barbicanclient-docs http://docs-draft.openstack.org/94/305594/1/check/gate-python-barbicanclient-docs/ed29aca//doc/build/html/ : SUCCESS in 2m 41s\n- gate-python-barbicanclient-pep8 http://logs.openstack.org/94/305594/1/check/gate-python-barbicanclient-pep8/201aabf/ : SUCCESS in 2m 28s\n- gate-python-barbicanclient-python27 http://logs.openstack.org/94/305594/1/check/gate-python-barbicanclient-python27/96c0634/ : SUCCESS in 1m 46s\n- gate-python-barbicanclient-python34 http://logs.openstack.org/94/305594/1/check/gate-python-barbicanclient-python34/52a4975/ : SUCCESS in 1m 49s\n- gate-python-barbicanclient-pypy http://logs.openstack.org/94/305594/1/check/gate-python-barbicanclient-pypy/4e74dac/ : SUCCESS in 8m 03s (non-voting)\n- check-osc-plugins http://logs.openstack.org/94/305594/1/check/check-osc-plugins/c7ca233/ : SUCCESS in 3m 37s (non-voting)\n- gate-python-barbicanclient-devstack-dsvm http://logs.openstack.org/94/305594/1/check/gate-python-barbicanclient-devstack-dsvm/49b0809/ : SUCCESS in 24m 30s","accounts_in_message":[],"_revision_number":1},{"id":"24c0ce01d42f01ebeb21a228ed8f4503a082983c","author":{"_account_id":6783,"name":"Nathan Reller","email":"nathan.s.reller@gmail.com","username":"rellerreller"},"date":"2016-04-20 13:16:50.000000000","message":"Patch Set 1: Code-Review+1\n\nMax, have you verified that this works with KMIP and does fix the problem? I don\u0027t have time at the moment to run the tests.\n\nIf the tests fail then you might want to keep base64 encoding and set the content encoding for that. We have seen errors where the \u0027\\n\u0027 character in PEM files caused issues. That\u0027s why we typically base64 encode everything.","accounts_in_message":[],"_revision_number":1},{"id":"566234e156d292e85eea974085fd4f1adf5b6279","author":{"_account_id":17536,"name":"Max Abidi","email":"max_abidi@yahoo.com","username":"Max_a"},"date":"2016-04-20 18:17:05.000000000","message":"Patch Set 1:\n\nHi Nathan,\nYes I was verified the test case is passing in both backends (KMIP and DB). The issue is that KMIP module does the base64 encoding again on the payload.","accounts_in_message":[],"_revision_number":1},{"id":"d768c28eacd1e8652ed86384deb00cd1f750fbe4","author":{"_account_id":6783,"name":"Nathan Reller","email":"nathan.s.reller@gmail.com","username":"rellerreller"},"date":"2016-04-21 00:14:31.000000000","message":"Patch Set 1: Code-Review+2\n\nAs an FYI we are submitting patches to add a KMIP secret store gate check for Barbican code base. If you want you might be interested in that for setting up a gate check with the client.","accounts_in_message":[],"_revision_number":1},{"id":"3e65664e2db697f47e068fe8f2cc477db12f12a2","author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"date":"2016-04-21 05:05:56.000000000","message":"Patch Set 1: Code-Review+1\n\nThis makes sense, the barbicanclient should be doing the base64 encoding, not the test itself. On the other hand, I am not +2ing because I would prefer this to be checked witht he KMIP gate that\u0027s coming. On the other hand, I don\u0027t know why we don\u0027t have a dogtag gate for the barbicanclient tests :/ gotta fix that","accounts_in_message":[],"_revision_number":1},{"id":"2aa4b4e2cb4da0b6d45d384b3f47e387c1738e43","author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"date":"2016-04-22 19:13:09.000000000","message":"Patch Set 1: Code-Review+1\n\n@Oz, good point about waiting til a KMIP gate, but I don\u0027t think we\u0027re planning to enable it for python-barbicanclient?\n@Nate, what do you think?","accounts_in_message":[],"_revision_number":1},{"id":"5aa8697345f8617dfb950694082e6a986799cbfc","author":{"_account_id":17536,"name":"Max Abidi","email":"max_abidi@yahoo.com","username":"Max_a"},"date":"2016-04-26 17:27:15.000000000","message":"Patch Set 1:\n\nHi @Nate,\nAs Kaitlin mentioned, are we planning to have KMIP gate for python-barbicanclient?","accounts_in_message":[],"_revision_number":1},{"id":"48a85f941f72af8a556209288c043cde3fab758e","author":{"_account_id":17536,"name":"Max Abidi","email":"max_abidi@yahoo.com","username":"Max_a"},"date":"2016-05-12 18:03:42.000000000","message":"Patch Set 1:\n\nHi @Kaitlin, any idea on when KMIP gate would be available? Thanks.","accounts_in_message":[],"_revision_number":1},{"id":"4008d071b6dba62904c8ae4fe63ce3c45fd44a61","author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"date":"2016-05-12 18:10:19.000000000","message":"Patch Set 1:\n\n@Max, the KMIP gate for barbican should be enabled when https://review.openstack.org/#/c/307820/5 is merged.  However, that\u0027s for barbican, not necessarily for python-barbicanclient.","accounts_in_message":[],"_revision_number":1},{"id":"0de63d4d199d13ed144a880abe35680a61e9f7a6","author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"date":"2016-05-16 06:26:40.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"e50349b28e0c933c671c68d92160b454f0914f03","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-05-16 06:26:45.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"27752ac8aa71cc450c6d788b20b61ccfc456052e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-05-16 06:54:05.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-barbicanclient-docs http://docs-draft.openstack.org/94/305594/1/gate/gate-python-barbicanclient-docs/771dd21//doc/build/html/ : SUCCESS in 2m 51s\n- gate-python-barbicanclient-pep8 http://logs.openstack.org/94/305594/1/gate/gate-python-barbicanclient-pep8/0a9f2b4/ : SUCCESS in 2m 01s\n- gate-python-barbicanclient-python27 http://logs.openstack.org/94/305594/1/gate/gate-python-barbicanclient-python27/5fb062b/ : SUCCESS in 2m 23s\n- gate-python-barbicanclient-python34 http://logs.openstack.org/94/305594/1/gate/gate-python-barbicanclient-python34/ffdf73b/ : SUCCESS in 1m 45s\n- gate-python-barbicanclient-devstack-dsvm http://logs.openstack.org/94/305594/1/gate/gate-python-barbicanclient-devstack-dsvm/2393f36/ : SUCCESS in 25m 42s","accounts_in_message":[],"_revision_number":1},{"id":"b96453ea066e8d0d77814b6625dd7c8e9cc0ef61","date":"2016-05-16 06:54:06.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"d6d5f8600916222a6ac61a9cc9ded486b5ed0b06","revisions":{"d6d5f8600916222a6ac61a9cc9ded486b5ed0b06":{"kind":"REWORK","_number":1,"created":"2016-04-14 03:22:48.000000000","uploader":{"_account_id":17536,"name":"Max Abidi","email":"max_abidi@yahoo.com","username":"Max_a"},"ref":"refs/changes/94/305594/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-barbicanclient","ref":"refs/changes/94/305594/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-barbicanclient refs/changes/94/305594/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-barbicanclient refs/changes/94/305594/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-barbicanclient refs/changes/94/305594/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-barbicanclient refs/changes/94/305594/1"}}},"commit":{"parents":[{"commit":"8d3b5b3b7bcdc6d174d862c7e4ceec6e84c8fede","subject":"Fix argument order for assertEqual to (exp, obs)","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-barbicanclient/commit/8d3b5b3b7bcdc6d174d862c7e4ceec6e84c8fede"}]}],"author":{"name":"Max Abidi","email":"max_abidi@yahoo.com","date":"2016-04-14 03:11:58.000000000","tz":-420},"committer":{"name":"Max Abidi","email":"max_abidi@yahoo.com","date":"2016-04-14 03:22:33.000000000","tz":-420},"subject":"Fixed python-barbicanclient functional tests.","message":"Fixed python-barbicanclient functional tests.\n\nWhen using KMIP backend, some barbican client functional\ntests failed in payload length validation. Fixed the test case\npayload data.\n\nChange-Id: I9d0b2d04662b3a7399603b9eff20d9daf406e069\nCloses-Bug: #1570166\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-barbicanclient/commit/d6d5f8600916222a6ac61a9cc9ded486b5ed0b06"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-barbicanclient/commit/d6d5f8600916222a6ac61a9cc9ded486b5ed0b06"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}