)]}'
{"barbicanclient/acls.py":[{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"97f5575b1bb12b53541208375a801fa7e57f9e40","unresolved":false,"context_lines":[{"line_number":31,"context_line":"class ACLFormatter(formatter.EntityFormatter):"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    columns \u003d (\"operation_type\","},{"line_number":34,"context_line":"               \"project_access\","},{"line_number":35,"context_line":"               \"users\","},{"line_number":36,"context_line":"               \"created\","},{"line_number":37,"context_line":"               \"updated\","}],"source_content_type":"text/x-python","patch_set":8,"id":"9a30ddce_591362b8","line":34,"updated":"2017-03-09 01:27:42.000000000","message":"functionaltests/cli/v1/smoke/test_acl.py still references \"Project Access\" and \"Users\"","commit_id":"a5cdc59058edcf6ad5a0fb8e98b3081a3cd8ff6b"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"5c7965a205fd7daa584a0b3a05ccfa2fb3b2fd5c","unresolved":false,"context_lines":[{"line_number":31,"context_line":"class ACLFormatter(formatter.EntityFormatter):"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    columns \u003d (\"operation_type\","},{"line_number":34,"context_line":"               \"project_access\","},{"line_number":35,"context_line":"               \"users\","},{"line_number":36,"context_line":"               \"created\","},{"line_number":37,"context_line":"               \"updated\","}],"source_content_type":"text/x-python","patch_set":8,"id":"ffe62b97_2b39a940","line":34,"in_reply_to":"9a30ddce_591362b8","updated":"2017-03-23 21:12:28.000000000","message":"Good catch, thanks for the review!","commit_id":"a5cdc59058edcf6ad5a0fb8e98b3081a3cd8ff6b"},{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"88562c8102ee56798407acd7e057a22c604fa6c5","unresolved":false,"context_lines":[{"line_number":154,"context_line":"    def _validate_users_type(self):"},{"line_number":155,"context_line":"        if self.users and not (type(self.users) is list or"},{"line_number":156,"context_line":"                               type(self.users) is set):"},{"line_number":157,"context_line":"            raise ValueError(\u0027Users value is expected to be provided\u0027"},{"line_number":158,"context_line":"                             \u0027 as list/set.\u0027)"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"ffe62b97_7347754d","line":157,"updated":"2017-03-24 21:42:12.000000000","message":"NIT: Since we\u0027re updating reference names, should we change \"Users\" to \"users\"?","commit_id":"4bad77e94898ea47c06db100795de2f6b9bb5f0d"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"ab5cf1334ffd70c94f238402b00ccabee31185b3","unresolved":false,"context_lines":[{"line_number":154,"context_line":"    def _validate_users_type(self):"},{"line_number":155,"context_line":"        if self.users and not (type(self.users) is list or"},{"line_number":156,"context_line":"                               type(self.users) is set):"},{"line_number":157,"context_line":"            raise ValueError(\u0027Users value is expected to be provided\u0027"},{"line_number":158,"context_line":"                             \u0027 as list/set.\u0027)"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"ffe62b97_6422d402","line":157,"in_reply_to":"ffe62b97_7347754d","updated":"2017-03-27 14:57:30.000000000","message":"Done","commit_id":"4bad77e94898ea47c06db100795de2f6b9bb5f0d"},{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"bfbbf43c2c431e1d0b0131da76175d0f0ed2cb67","unresolved":false,"context_lines":[{"line_number":298,"context_line":"            op_type \u003d per_op_acl.operation_type"},{"line_number":299,"context_line":"            acl_data \u003d {}"},{"line_number":300,"context_line":"            if per_op_acl.project_access is not None:"},{"line_number":301,"context_line":"                acl_data[\u0027project-access\u0027] \u003d per_op_acl.project_access"},{"line_number":302,"context_line":"            if per_op_acl.users is not None:"},{"line_number":303,"context_line":"                acl_data[\u0027users\u0027] \u003d per_op_acl.users"},{"line_number":304,"context_line":"            acl_dict[op_type] \u003d acl_data"}],"source_content_type":"text/x-python","patch_set":10,"id":"ffe62b97_d9b5f47f","line":301,"range":{"start_line":301,"start_character":26,"end_line":301,"end_character":40},"updated":"2017-03-28 00:58:45.000000000","message":"Should this be updated to `project_access`?","commit_id":"f02c838c95df3c46f3ac1d69fbc69a9ce5f8e5a0"}],"barbicanclient/cas.py":[{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"88562c8102ee56798407acd7e057a22c604fa6c5","unresolved":false,"context_lines":[{"line_number":204,"context_line":"        :raises barbicanclient.exceptions.HTTPClientError: 4xx Responses"},{"line_number":205,"context_line":"        :raises barbicanclient.exceptions.HTTPServerError: 5xx Responses"},{"line_number":206,"context_line":"        \"\"\""},{"line_number":207,"context_line":"        LOG.debug(\"Getting ca - CA href: {0}\".format(ca_ref))"},{"line_number":208,"context_line":"        base.validate_ref(ca_ref, \u0027CA\u0027)"},{"line_number":209,"context_line":"        return CA("},{"line_number":210,"context_line":"            api\u003dself._api,"}],"source_content_type":"text/x-python","patch_set":9,"id":"ffe62b97_33a0cdf4","line":207,"updated":"2017-03-24 21:42:12.000000000","message":"NIT: Since we\u0027re updating reference names, do we want to update \"CA href\" to \"ca_ref\"?","commit_id":"4bad77e94898ea47c06db100795de2f6b9bb5f0d"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"ab5cf1334ffd70c94f238402b00ccabee31185b3","unresolved":false,"context_lines":[{"line_number":204,"context_line":"        :raises barbicanclient.exceptions.HTTPClientError: 4xx Responses"},{"line_number":205,"context_line":"        :raises barbicanclient.exceptions.HTTPServerError: 5xx Responses"},{"line_number":206,"context_line":"        \"\"\""},{"line_number":207,"context_line":"        LOG.debug(\"Getting ca - CA href: {0}\".format(ca_ref))"},{"line_number":208,"context_line":"        base.validate_ref(ca_ref, \u0027CA\u0027)"},{"line_number":209,"context_line":"        return CA("},{"line_number":210,"context_line":"            api\u003dself._api,"}],"source_content_type":"text/x-python","patch_set":9,"id":"ffe62b97_441d90bb","line":207,"in_reply_to":"ffe62b97_33a0cdf4","updated":"2017-03-27 14:57:30.000000000","message":"Done","commit_id":"4bad77e94898ea47c06db100795de2f6b9bb5f0d"}],"barbicanclient/orders.py":[{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"88562c8102ee56798407acd7e057a22c604fa6c5","unresolved":false,"context_lines":[{"line_number":79,"context_line":"                \"asymmetric\","},{"line_number":80,"context_line":"                self.container_ref,"},{"line_number":81,"context_line":"                \"\","},{"line_number":82,"context_line":"                self.created,"},{"line_number":83,"context_line":"                self.status,"},{"line_number":84,"context_line":"                self.error_status_code,"},{"line_number":85,"context_line":"                self.error_reason"}],"source_content_type":"text/x-python","patch_set":9,"id":"ffe62b97_93e67944","line":82,"updated":"2017-03-24 21:42:12.000000000","message":"This should be left as `created`, in case `self.created` does not exist","commit_id":"4bad77e94898ea47c06db100795de2f6b9bb5f0d"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"ab5cf1334ffd70c94f238402b00ccabee31185b3","unresolved":false,"context_lines":[{"line_number":79,"context_line":"                \"asymmetric\","},{"line_number":80,"context_line":"                self.container_ref,"},{"line_number":81,"context_line":"                \"\","},{"line_number":82,"context_line":"                self.created,"},{"line_number":83,"context_line":"                self.status,"},{"line_number":84,"context_line":"                self.error_status_code,"},{"line_number":85,"context_line":"                self.error_reason"}],"source_content_type":"text/x-python","patch_set":9,"id":"ffe62b97_64777404","line":82,"in_reply_to":"ffe62b97_93e67944","updated":"2017-03-27 14:57:30.000000000","message":"Yeah, this was a bad rebase.  Thanks!","commit_id":"4bad77e94898ea47c06db100795de2f6b9bb5f0d"},{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"88562c8102ee56798407acd7e057a22c604fa6c5","unresolved":false,"context_lines":[{"line_number":105,"context_line":"                \"certificate\","},{"line_number":106,"context_line":"                self.container_ref,"},{"line_number":107,"context_line":"                \"\","},{"line_number":108,"context_line":"                self.created,"},{"line_number":109,"context_line":"                self.status,"},{"line_number":110,"context_line":"                self.error_status_code,"},{"line_number":111,"context_line":"                self.error_reason"}],"source_content_type":"text/x-python","patch_set":9,"id":"ffe62b97_f3d02553","line":108,"updated":"2017-03-24 21:42:12.000000000","message":"This should be left as `created`, in case `self.created` does not exist","commit_id":"4bad77e94898ea47c06db100795de2f6b9bb5f0d"},{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"88562c8102ee56798407acd7e057a22c604fa6c5","unresolved":false,"context_lines":[{"line_number":402,"context_line":"        :raises barbicanclient.exceptions.HTTPClientError: 4xx Responses"},{"line_number":403,"context_line":"        :raises barbicanclient.exceptions.HTTPServerError: 5xx Responses"},{"line_number":404,"context_line":"        \"\"\""},{"line_number":405,"context_line":"        LOG.debug(\"Getting order - Order href: {0}\".format(order_ref))"},{"line_number":406,"context_line":"        base.validate_ref(order_ref, \u0027Order\u0027)"},{"line_number":407,"context_line":"        try:"},{"line_number":408,"context_line":"            response \u003d self._api.get(order_ref)"}],"source_content_type":"text/x-python","patch_set":9,"id":"ffe62b97_7319b577","line":405,"updated":"2017-03-24 21:42:12.000000000","message":"NIT: Since we\u0027re updating reference names, do we want to be logging \"order_ref\", rather than \"Order href\"?","commit_id":"4bad77e94898ea47c06db100795de2f6b9bb5f0d"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"ab5cf1334ffd70c94f238402b00ccabee31185b3","unresolved":false,"context_lines":[{"line_number":402,"context_line":"        :raises barbicanclient.exceptions.HTTPClientError: 4xx Responses"},{"line_number":403,"context_line":"        :raises barbicanclient.exceptions.HTTPServerError: 5xx Responses"},{"line_number":404,"context_line":"        \"\"\""},{"line_number":405,"context_line":"        LOG.debug(\"Getting order - Order href: {0}\".format(order_ref))"},{"line_number":406,"context_line":"        base.validate_ref(order_ref, \u0027Order\u0027)"},{"line_number":407,"context_line":"        try:"},{"line_number":408,"context_line":"            response \u003d self._api.get(order_ref)"}],"source_content_type":"text/x-python","patch_set":9,"id":"ffe62b97_047d48e6","line":405,"in_reply_to":"ffe62b97_7319b577","updated":"2017-03-27 14:57:30.000000000","message":"Done","commit_id":"4bad77e94898ea47c06db100795de2f6b9bb5f0d"}],"functionaltests/cli/v1/behaviors/secret_behaviors.py":[{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"503c96704e1a5ac7a0c487431917014da131cb7a","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        self.secret_hrefs_to_delete \u003d []"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def update_secret(self,"},{"line_number":29,"context_line":"                      secret_href,"},{"line_number":30,"context_line":"                      payload):"},{"line_number":31,"context_line":"        \"\"\" Update a secret"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa6399be_9896ea92","line":29,"range":{"start_line":29,"start_character":22,"end_line":29,"end_character":33},"updated":"2016-10-19 04:53:28.000000000","message":"For consistency we should rename all \"secret_href\" to \"secret_ref\".","commit_id":"ecef5cdfa30965e691ad5c959dc9d093e5fe022d"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"a84f40dfb872bc08a9e756af3a62b3cc447046b7","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        self.secret_hrefs_to_delete \u003d []"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def update_secret(self,"},{"line_number":29,"context_line":"                      secret_href,"},{"line_number":30,"context_line":"                      payload):"},{"line_number":31,"context_line":"        \"\"\" Update a secret"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa6399be_49f1b869","line":29,"range":{"start_line":29,"start_character":22,"end_line":29,"end_character":33},"in_reply_to":"fa6399be_9896ea92","updated":"2016-10-19 23:59:45.000000000","message":"We can refactor these in a separate patch.  My main concern for this patch is being able to use the \"--column\" flag using the same field names as the api.","commit_id":"ecef5cdfa30965e691ad5c959dc9d093e5fe022d"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"503c96704e1a5ac7a0c487431917014da131cb7a","unresolved":false,"context_lines":[{"line_number":30,"context_line":"                      payload):"},{"line_number":31,"context_line":"        \"\"\" Update a secret"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"        :param secret_href the href to the secret to update."},{"line_number":34,"context_line":"        :param payload the payload to put into the secret."},{"line_number":35,"context_line":"        :param payload_content_type the payload content type."},{"line_number":36,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa6399be_38ecfe28","line":33,"range":{"start_line":33,"start_character":15,"end_line":33,"end_character":26},"updated":"2016-10-19 04:53:28.000000000","message":"Same for the documentation.","commit_id":"ecef5cdfa30965e691ad5c959dc9d093e5fe022d"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"11b3ed1e508e03288d6a0c9f256696f3686be8da","unresolved":false,"context_lines":[{"line_number":122,"context_line":"            secret \u003d stdout.rstrip()"},{"line_number":123,"context_line":"        else:"},{"line_number":124,"context_line":"            secret_data \u003d self._prettytable_to_dict(stdout)"},{"line_number":125,"context_line":"            secret \u003d secret_data[\u0027Payload\u0027]"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        return secret"},{"line_number":128,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa6399be_78b91679","line":125,"updated":"2016-10-19 05:09:55.000000000","message":"Also for a future item we can change \u0027Payload\u0027 to \u0027payload\u0027. This would involve changing the key name in the cli code right here: https://github.com/openstack/python-barbicanclient/blob/091d823712f6c727971e01d4946fd63648580433/barbicanclient/barbican_cli/secrets.py#L67-L68","commit_id":"ecef5cdfa30965e691ad5c959dc9d093e5fe022d"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"a84f40dfb872bc08a9e756af3a62b3cc447046b7","unresolved":false,"context_lines":[{"line_number":122,"context_line":"            secret \u003d stdout.rstrip()"},{"line_number":123,"context_line":"        else:"},{"line_number":124,"context_line":"            secret_data \u003d self._prettytable_to_dict(stdout)"},{"line_number":125,"context_line":"            secret \u003d secret_data[\u0027Payload\u0027]"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        return secret"},{"line_number":128,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa6399be_e9fc4c40","line":125,"in_reply_to":"fa6399be_78b91679","updated":"2016-10-19 23:59:45.000000000","message":"Done","commit_id":"ecef5cdfa30965e691ad5c959dc9d093e5fe022d"}]}