)]}'
{"barbicanclient/barbican_cli/secrets.py":[{"author":{"_account_id":21797,"name":"Jeremy Liu","display_name":"Jeremy Liu","username":"liujiong"},"change_message_id":"224d2ae0e8a1309947aeb6b039b28d1d058ff89a","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                                 \u0027 the value of the payload\u0027,"},{"line_number":56,"context_line":"                            action\u003d\u0027store_true\u0027)"},{"line_number":57,"context_line":"        parser.add_argument(\u0027--payload_content_type\u0027, \u0027-t\u0027,"},{"line_number":58,"context_line":"                            default\u003d\u0027text/plain\u0027,"},{"line_number":59,"context_line":"                            help\u003d\u0027the content type of the decrypted\u0027"},{"line_number":60,"context_line":"                                 \u0027 secret (default: %(default)s.\u0027)"},{"line_number":61,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_39d68b4f","side":"PARENT","line":58,"range":{"start_line":58,"start_character":28,"end_line":58,"end_character":49},"updated":"2016-10-20 08:49:51.000000000","message":"Why the default value is removed?","commit_id":"35549fa08ad7d9e79bd0ea394dc5c18477e4bdde"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"94b422ad9bc83832fe48506bc70249513270cf7d","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                                 \u0027 the value of the payload\u0027,"},{"line_number":56,"context_line":"                            action\u003d\u0027store_true\u0027)"},{"line_number":57,"context_line":"        parser.add_argument(\u0027--payload_content_type\u0027, \u0027-t\u0027,"},{"line_number":58,"context_line":"                            default\u003d\u0027text/plain\u0027,"},{"line_number":59,"context_line":"                            help\u003d\u0027the content type of the decrypted\u0027"},{"line_number":60,"context_line":"                                 \u0027 secret (default: %(default)s.\u0027)"},{"line_number":61,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_32b93216","side":"PARENT","line":58,"range":{"start_line":58,"start_character":28,"end_line":58,"end_character":49},"in_reply_to":"fa6399be_39d68b4f","updated":"2016-10-20 17:31:51.000000000","message":"Content Types have a long and confusing history in the project.  The current best practice is to not use this flag in the CLI.  The default of \"text/plain\" is incorrect for all secret types except for the \"passphrase\" type.  I think it\u0027s better to default to None let the client code sort out the content-type instead of defaulting to one that is likely to be incorrect.","commit_id":"35549fa08ad7d9e79bd0ea394dc5c18477e4bdde"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"9d039c8fc206bb2779257c0175f6df9995bae82a","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        parser.add_argument(\u0027--file\u0027, \u0027-F\u0027, metavar\u003d\u0027\u003cfilename\u003e\u0027,"},{"line_number":50,"context_line":"                            help\u003d\u0027if specified, save the payload to a file \u0027"},{"line_number":51,"context_line":"                                 \u0027with the given name.\u0027)"},{"line_number":52,"context_line":"        # payload_content_type is deprecated"},{"line_number":53,"context_line":"        parser.add_argument(\u0027--payload_content_type\u0027, \u0027-t\u0027,"},{"line_number":54,"context_line":"                            help\u003d\u0027the content type of the decrypted\u0027"},{"line_number":55,"context_line":"                                 \u0027 secret (default: %(default)s.\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_f8189477","line":52,"updated":"2016-10-20 04:16:47.000000000","message":"Add this to the help as well.","commit_id":"f239451c7410c7c68ed0d5b8219268dc494f53e9"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"94b422ad9bc83832fe48506bc70249513270cf7d","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        parser.add_argument(\u0027--file\u0027, \u0027-F\u0027, metavar\u003d\u0027\u003cfilename\u003e\u0027,"},{"line_number":50,"context_line":"                            help\u003d\u0027if specified, save the payload to a file \u0027"},{"line_number":51,"context_line":"                                 \u0027with the given name.\u0027)"},{"line_number":52,"context_line":"        # payload_content_type is deprecated"},{"line_number":53,"context_line":"        parser.add_argument(\u0027--payload_content_type\u0027, \u0027-t\u0027,"},{"line_number":54,"context_line":"                            help\u003d\u0027the content type of the decrypted\u0027"},{"line_number":55,"context_line":"                                 \u0027 secret (default: %(default)s.\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_950bc5d5","line":52,"in_reply_to":"fa6399be_f8189477","updated":"2016-10-20 17:31:51.000000000","message":"Done","commit_id":"f239451c7410c7c68ed0d5b8219268dc494f53e9"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"9d039c8fc206bb2779257c0175f6df9995bae82a","unresolved":false,"context_lines":[{"line_number":163,"context_line":"        parser.add_argument(\u0027--expiration\u0027, \u0027-x\u0027,"},{"line_number":164,"context_line":"                            help\u003d\u0027the expiration time for the secret in \u0027"},{"line_number":165,"context_line":"                                 \u0027ISO 8601 format.\u0027)"},{"line_number":166,"context_line":"        parser.add_argument(\u0027--file\u0027, \u0027-F\u0027, metavar\u003d\u0027\u003cfilename\u003e\u0027,"},{"line_number":167,"context_line":"                            help\u003d\u0027file containing the secret payload\u0027)"},{"line_number":168,"context_line":"        return parser"},{"line_number":169,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_780c843b","line":166,"range":{"start_line":166,"start_character":39,"end_line":166,"end_character":41},"updated":"2016-10-20 04:16:47.000000000","message":"Can we do lowercase f for consistency?","commit_id":"f239451c7410c7c68ed0d5b8219268dc494f53e9"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"94b422ad9bc83832fe48506bc70249513270cf7d","unresolved":false,"context_lines":[{"line_number":163,"context_line":"        parser.add_argument(\u0027--expiration\u0027, \u0027-x\u0027,"},{"line_number":164,"context_line":"                            help\u003d\u0027the expiration time for the secret in \u0027"},{"line_number":165,"context_line":"                                 \u0027ISO 8601 format.\u0027)"},{"line_number":166,"context_line":"        parser.add_argument(\u0027--file\u0027, \u0027-F\u0027, metavar\u003d\u0027\u003cfilename\u003e\u0027,"},{"line_number":167,"context_line":"                            help\u003d\u0027file containing the secret payload\u0027)"},{"line_number":168,"context_line":"        return parser"},{"line_number":169,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_12534ee3","line":166,"range":{"start_line":166,"start_character":39,"end_line":166,"end_character":41},"in_reply_to":"fa6399be_590c1fec","updated":"2016-10-20 17:31:51.000000000","message":"Lower case \"-f\" is already taken by the --format flag.  I can either leave it as \"-F\" or not have a short flag at all like the \"openstack image save --file\" command.","commit_id":"f239451c7410c7c68ed0d5b8219268dc494f53e9"},{"author":{"_account_id":21797,"name":"Jeremy Liu","display_name":"Jeremy Liu","username":"liujiong"},"change_message_id":"224d2ae0e8a1309947aeb6b039b28d1d058ff89a","unresolved":false,"context_lines":[{"line_number":163,"context_line":"        parser.add_argument(\u0027--expiration\u0027, \u0027-x\u0027,"},{"line_number":164,"context_line":"                            help\u003d\u0027the expiration time for the secret in \u0027"},{"line_number":165,"context_line":"                                 \u0027ISO 8601 format.\u0027)"},{"line_number":166,"context_line":"        parser.add_argument(\u0027--file\u0027, \u0027-F\u0027, metavar\u003d\u0027\u003cfilename\u003e\u0027,"},{"line_number":167,"context_line":"                            help\u003d\u0027file containing the secret payload\u0027)"},{"line_number":168,"context_line":"        return parser"},{"line_number":169,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_590c1fec","line":166,"range":{"start_line":166,"start_character":39,"end_line":166,"end_character":41},"in_reply_to":"fa6399be_780c843b","updated":"2016-10-20 08:49:51.000000000","message":"Agree with Fernando.","commit_id":"f239451c7410c7c68ed0d5b8219268dc494f53e9"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"9d039c8fc206bb2779257c0175f6df9995bae82a","unresolved":false,"context_lines":[{"line_number":167,"context_line":"                            help\u003d\u0027file containing the secret payload\u0027)"},{"line_number":168,"context_line":"        return parser"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    def take_action(self, args):"},{"line_number":171,"context_line":"        if args.payload and args.file:"},{"line_number":172,"context_line":"            raise ValueError(\u0027ERROR: You must specify --payload or --file, \u0027"},{"line_number":173,"context_line":"                             \u0027not both.\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_983a38cc","line":170,"updated":"2016-10-20 04:16:47.000000000","message":"Instead of having this function it can be done with the cleaner `add_mutually_exclusive_group` function. See https://review.openstack.org/#/c/242635/23/barbicanclient/barbican_cli/secrets.py","commit_id":"f239451c7410c7c68ed0d5b8219268dc494f53e9"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"94b422ad9bc83832fe48506bc70249513270cf7d","unresolved":false,"context_lines":[{"line_number":167,"context_line":"                            help\u003d\u0027file containing the secret payload\u0027)"},{"line_number":168,"context_line":"        return parser"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    def take_action(self, args):"},{"line_number":171,"context_line":"        if args.payload and args.file:"},{"line_number":172,"context_line":"            raise ValueError(\u0027ERROR: You must specify --payload or --file, \u0027"},{"line_number":173,"context_line":"                             \u0027not both.\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_55a84d77","line":170,"in_reply_to":"fa6399be_983a38cc","updated":"2016-10-20 17:31:51.000000000","message":"Done","commit_id":"f239451c7410c7c68ed0d5b8219268dc494f53e9"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"9d039c8fc206bb2779257c0175f6df9995bae82a","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        if args.payload and args.file:"},{"line_number":172,"context_line":"            raise ValueError(\u0027ERROR: You must specify --payload or --file, \u0027"},{"line_number":173,"context_line":"                             \u0027not both.\u0027)"},{"line_number":174,"context_line":"        if args.file:"},{"line_number":175,"context_line":"            with open(args.file, \u0027rb\u0027) as f:"},{"line_number":176,"context_line":"                data \u003d f.read()"},{"line_number":177,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_785ac42b","line":174,"updated":"2016-10-20 04:16:47.000000000","message":"I would add any file operations to utils so we can use the same code in other areas.","commit_id":"f239451c7410c7c68ed0d5b8219268dc494f53e9"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"94b422ad9bc83832fe48506bc70249513270cf7d","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        if args.payload and args.file:"},{"line_number":172,"context_line":"            raise ValueError(\u0027ERROR: You must specify --payload or --file, \u0027"},{"line_number":173,"context_line":"                             \u0027not both.\u0027)"},{"line_number":174,"context_line":"        if args.file:"},{"line_number":175,"context_line":"            with open(args.file, \u0027rb\u0027) as f:"},{"line_number":176,"context_line":"                data \u003d f.read()"},{"line_number":177,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_752c7102","line":174,"in_reply_to":"fa6399be_785ac42b","updated":"2016-10-20 17:31:51.000000000","message":"I think it would be better to keep it here until this code is needed elsewhere.  Putting this in utils sounds like premature optimization.","commit_id":"f239451c7410c7c68ed0d5b8219268dc494f53e9"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"927da9231e28dd60ec12eae4404dd9b6f6800094","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def take_action(self, args):"},{"line_number":62,"context_line":"        if args.payload_content_type:"},{"line_number":63,"context_line":"            _LOG.warning(\"DEPRECATION WARNING: --payload_content_type is\""},{"line_number":64,"context_line":"                         \"deprecated and will be removed in a future release.\")"},{"line_number":65,"context_line":"        if args.decrypt or args.payload or args.file:"},{"line_number":66,"context_line":"            entity \u003d self.app.client_manager.key_manager.secrets.get("}],"source_content_type":"text/x-python","patch_set":4,"id":"fa6399be_384750bd","line":63,"updated":"2016-10-20 18:01:44.000000000","message":"Do we really need to log this? What log does this go to?","commit_id":"b96f0b6a057e88fcefa3d072ca3334180db3c387"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"f1d766d1a0ca756dd8c350234d98c980aa3e5029","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def take_action(self, args):"},{"line_number":62,"context_line":"        if args.payload_content_type:"},{"line_number":63,"context_line":"            _LOG.warning(\"DEPRECATION WARNING: --payload_content_type is\""},{"line_number":64,"context_line":"                         \"deprecated and will be removed in a future release.\")"},{"line_number":65,"context_line":"        if args.decrypt or args.payload or args.file:"},{"line_number":66,"context_line":"            entity \u003d self.app.client_manager.key_manager.secrets.get("}],"source_content_type":"text/x-python","patch_set":4,"id":"da6895a0_7955e71b","line":63,"in_reply_to":"fa6399be_384750bd","updated":"2016-10-20 18:33:58.000000000","message":"The log goes to stderr.  I think logging deprecations is the first step for removal.","commit_id":"b96f0b6a057e88fcefa3d072ca3334180db3c387"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"927da9231e28dd60ec12eae4404dd9b6f6800094","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        parser \u003d super(StoreSecret, self).get_parser(prog_name)"},{"line_number":141,"context_line":"        parser.add_argument(\u0027--name\u0027, \u0027-n\u0027,"},{"line_number":142,"context_line":"                            help\u003d\u0027a human-friendly name.\u0027)"},{"line_number":143,"context_line":"                parser.add_argument(\u0027--secret-type\u0027, \u0027-s\u0027, default\u003d\u0027opaque\u0027,"},{"line_number":144,"context_line":"                            help\u003d\u0027the secret type; must be one of symmetric, \u0027"},{"line_number":145,"context_line":"                                 \u0027public, private, certificate, passphrase, \u0027"},{"line_number":146,"context_line":"                                 \u0027opaque (default)\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa6399be_d8e9f4b8","line":143,"updated":"2016-10-20 18:01:44.000000000","message":"Indented too much","commit_id":"b96f0b6a057e88fcefa3d072ca3334180db3c387"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"927da9231e28dd60ec12eae4404dd9b6f6800094","unresolved":false,"context_lines":[{"line_number":163,"context_line":"        parser.add_argument(\u0027--expiration\u0027, \u0027-x\u0027,"},{"line_number":164,"context_line":"                            help\u003d\u0027the expiration time for the secret in \u0027"},{"line_number":165,"context_line":"                                 \u0027ISO 8601 format.\u0027)"},{"line_number":166,"context_line":"        payload_params \u003d parser.add_mutually_exclusive_group(required\u003dFalse)"},{"line_number":167,"context_line":"        payload_params.add_argument(\u0027--payload\u0027, \u0027-p\u0027,"},{"line_number":168,"context_line":"                                    help\u003d\u0027the unencrypted secret data.\u0027)"},{"line_number":169,"context_line":"        payload_params.add_argument(\u0027--file\u0027, \u0027-F\u0027, metavar\u003d\u0027\u003cfilename\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa6399be_78de2812","line":166,"updated":"2016-10-20 18:01:44.000000000","message":"Nice","commit_id":"b96f0b6a057e88fcefa3d072ca3334180db3c387"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"f1d766d1a0ca756dd8c350234d98c980aa3e5029","unresolved":false,"context_lines":[{"line_number":163,"context_line":"        parser.add_argument(\u0027--expiration\u0027, \u0027-x\u0027,"},{"line_number":164,"context_line":"                            help\u003d\u0027the expiration time for the secret in \u0027"},{"line_number":165,"context_line":"                                 \u0027ISO 8601 format.\u0027)"},{"line_number":166,"context_line":"        payload_params \u003d parser.add_mutually_exclusive_group(required\u003dFalse)"},{"line_number":167,"context_line":"        payload_params.add_argument(\u0027--payload\u0027, \u0027-p\u0027,"},{"line_number":168,"context_line":"                                    help\u003d\u0027the unencrypted secret data.\u0027)"},{"line_number":169,"context_line":"        payload_params.add_argument(\u0027--file\u0027, \u0027-F\u0027, metavar\u003d\u0027\u003cfilename\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"da6895a0_d93a73e7","line":166,"in_reply_to":"fa6399be_78de2812","updated":"2016-10-20 18:33:58.000000000","message":"Yeah, thanks for the tip!","commit_id":"b96f0b6a057e88fcefa3d072ca3334180db3c387"}]}
