)]}'
{"barbicanclient/secrets.py":[{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"3c12425efc2d5b33e9942c2339d5e5284384c88d","unresolved":false,"context_lines":[{"line_number":543,"context_line":"            raise ValueError(\u0027secret_ref is required.\u0027)"},{"line_number":544,"context_line":"        self._api.delete(secret_ref)"},{"line_number":545,"context_line":""},{"line_number":546,"context_line":"    def list(self, limit\u003d10, offset\u003d0, name\u003dNone, algorithm\u003dNone, mode\u003dNone,"},{"line_number":547,"context_line":"             bits\u003d0, secret_type\u003dNone, created\u003dNone, updated\u003dNone,"},{"line_number":548,"context_line":"             expiration\u003dNone, sort\u003dNone):"},{"line_number":549,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a3905b3_12023c0a","line":546,"range":{"start_line":546,"start_character":8,"end_line":546,"end_character":12},"updated":"2017-01-24 01:18:16.000000000","message":"Should we also add `acl_only` and `user_id` to the filter?","commit_id":"582b189e9cb6552dfb3cf43c17200b5c9a618bd3"},{"author":{"_account_id":21797,"name":"Jeremy Liu","display_name":"Jeremy Liu","email":"liujiong.cc@gmail.com","username":"liujiong"},"change_message_id":"493ddaddf25ae66310721d4b858e264539f5b6d6","unresolved":false,"context_lines":[{"line_number":558,"context_line":"        :param algorithm: Algorithm filter for the list"},{"line_number":559,"context_line":"        :param mode: Mode filter for the list"},{"line_number":560,"context_line":"        :param bits: Bits filter for the list"},{"line_number":561,"context_line":"        :param secret_type: Secret type filter for the list"},{"line_number":562,"context_line":"        :param created: Created time filter for the list"},{"line_number":563,"context_line":"        :param updated: Updated time filter for the list"},{"line_number":564,"context_line":"        :param expiration: Expiration time filter for the list"},{"line_number":565,"context_line":"        :param sort: Determines the sorted order of the returned list"},{"line_number":566,"context_line":"        :returns: list of Secret objects that satisfy the provided filter"},{"line_number":567,"context_line":"            criteria."},{"line_number":568,"context_line":"        :rtype: list"}],"source_content_type":"text/x-python","patch_set":13,"id":"ba2be162_a4e47b0d","line":565,"range":{"start_line":561,"start_character":0,"end_line":565,"end_character":69},"updated":"2017-03-01 10:08:09.000000000","message":"Do we need to provide more detailed messages here to explain those params? e.g. the type and format of created/updated/expiration/sort","commit_id":"064e7e89cf249c7b13bf23aac81f3dfba18be891"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"6b5267b0fa1cca7f8782d3710868e463218a3c91","unresolved":false,"context_lines":[{"line_number":558,"context_line":"        :param algorithm: Algorithm filter for the list"},{"line_number":559,"context_line":"        :param mode: Mode filter for the list"},{"line_number":560,"context_line":"        :param bits: Bits filter for the list"},{"line_number":561,"context_line":"        :param secret_type: Secret type filter for the list"},{"line_number":562,"context_line":"        :param created: Created time filter for the list"},{"line_number":563,"context_line":"        :param updated: Updated time filter for the list"},{"line_number":564,"context_line":"        :param expiration: Expiration time filter for the list"},{"line_number":565,"context_line":"        :param sort: Determines the sorted order of the returned list"},{"line_number":566,"context_line":"        :returns: list of Secret objects that satisfy the provided filter"},{"line_number":567,"context_line":"            criteria."},{"line_number":568,"context_line":"        :rtype: list"}],"source_content_type":"text/x-python","patch_set":13,"id":"9a30ddce_04513936","line":565,"range":{"start_line":561,"start_character":0,"end_line":565,"end_character":69},"in_reply_to":"ba2be162_a4e47b0d","updated":"2017-03-10 13:59:48.000000000","message":"Done","commit_id":"064e7e89cf249c7b13bf23aac81f3dfba18be891"}],"functionaltests/client/v1/functional/test_secrets.py":[{"author":{"_account_id":21797,"name":"Jeremy Liu","display_name":"Jeremy Liu","email":"liujiong.cc@gmail.com","username":"liujiong"},"change_message_id":"51c9f2f2239478f8bc6e4ef0362d5d80d67faeea","unresolved":false,"context_lines":[{"line_number":795,"context_line":"        },"},{"line_number":796,"context_line":"    })"},{"line_number":797,"context_line":"    @testcase.attr(\u0027positive\u0027)"},{"line_number":798,"context_line":"    def test_secret_list_with_filter(self, secret_1_dict, secret_2_dict,"},{"line_number":799,"context_line":"                                     query_dict):"},{"line_number":800,"context_line":"        secret_1 \u003d self.barbicanclient.secrets.create(**secret_1_dict)"},{"line_number":801,"context_line":"        secret_1_ref \u003d self.cleanup.add_entity(secret_1)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6eadb0_b36cd99d","line":798,"range":{"start_line":798,"start_character":8,"end_line":798,"end_character":36},"updated":"2016-12-13 06:31:51.000000000","message":"Do we need adding test cases for the other filters like created/updated/expiration?","commit_id":"582b189e9cb6552dfb3cf43c17200b5c9a618bd3"},{"author":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"change_message_id":"e7344e794b576fa714c2886c989032991d6492b9","unresolved":false,"context_lines":[{"line_number":795,"context_line":"        },"},{"line_number":796,"context_line":"    })"},{"line_number":797,"context_line":"    @testcase.attr(\u0027positive\u0027)"},{"line_number":798,"context_line":"    def test_secret_list_with_filter(self, secret_1_dict, secret_2_dict,"},{"line_number":799,"context_line":"                                     query_dict):"},{"line_number":800,"context_line":"        secret_1 \u003d self.barbicanclient.secrets.create(**secret_1_dict)"},{"line_number":801,"context_line":"        secret_1_ref \u003d self.cleanup.add_entity(secret_1)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a3c09a3_deadc689","line":798,"range":{"start_line":798,"start_character":8,"end_line":798,"end_character":36},"in_reply_to":"1a6eadb0_b36cd99d","updated":"2017-01-13 17:34:34.000000000","message":"Sort as well I think.","commit_id":"582b189e9cb6552dfb3cf43c17200b5c9a618bd3"},{"author":{"_account_id":21797,"name":"Jeremy Liu","display_name":"Jeremy Liu","email":"liujiong.cc@gmail.com","username":"liujiong"},"change_message_id":"493ddaddf25ae66310721d4b858e264539f5b6d6","unresolved":false,"context_lines":[{"line_number":879,"context_line":"        secret_1_ref \u003d self.cleanup.add_entity(secret_1)"},{"line_number":880,"context_line":"        self.assertIsNotNone(secret_1_ref)"},{"line_number":881,"context_line":"        payload \u003d \"gF6+lLoF3ohA9aPRpt+6bQ\u003d\u003d\""},{"line_number":882,"context_line":"        #payload_content_type \u003d \"application/octet-stream\""},{"line_number":883,"context_line":"        #secret_1.payload \u003d payload"},{"line_number":884,"context_line":"        #secret_1.payload_content_type \u003d payload_content_type"},{"line_number":885,"context_line":"        #secret_1.expiration \u003d expiration_1"},{"line_number":886,"context_line":"        #secret_1.update()"},{"line_number":887,"context_line":"        self.barbicanclient.secrets.update(secret_1_ref, payload)"},{"line_number":888,"context_line":""},{"line_number":889,"context_line":"        time.sleep(1)"}],"source_content_type":"text/x-python","patch_set":13,"id":"ba2be162_c4816f91","line":886,"range":{"start_line":882,"start_character":0,"end_line":886,"end_character":26},"updated":"2017-03-01 10:08:09.000000000","message":"The code block is unused, can they be removed ?","commit_id":"064e7e89cf249c7b13bf23aac81f3dfba18be891"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"6b5267b0fa1cca7f8782d3710868e463218a3c91","unresolved":false,"context_lines":[{"line_number":879,"context_line":"        secret_1_ref \u003d self.cleanup.add_entity(secret_1)"},{"line_number":880,"context_line":"        self.assertIsNotNone(secret_1_ref)"},{"line_number":881,"context_line":"        payload \u003d \"gF6+lLoF3ohA9aPRpt+6bQ\u003d\u003d\""},{"line_number":882,"context_line":"        #payload_content_type \u003d \"application/octet-stream\""},{"line_number":883,"context_line":"        #secret_1.payload \u003d payload"},{"line_number":884,"context_line":"        #secret_1.payload_content_type \u003d payload_content_type"},{"line_number":885,"context_line":"        #secret_1.expiration \u003d expiration_1"},{"line_number":886,"context_line":"        #secret_1.update()"},{"line_number":887,"context_line":"        self.barbicanclient.secrets.update(secret_1_ref, payload)"},{"line_number":888,"context_line":""},{"line_number":889,"context_line":"        time.sleep(1)"}],"source_content_type":"text/x-python","patch_set":13,"id":"9a30ddce_c47c81b7","line":886,"range":{"start_line":882,"start_character":0,"end_line":886,"end_character":26},"in_reply_to":"ba2be162_c4816f91","updated":"2017-03-10 13:59:48.000000000","message":"Done","commit_id":"064e7e89cf249c7b13bf23aac81f3dfba18be891"},{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"7ee53c6c9694219101d80a9bb9b58e5a2f9b625a","unresolved":false,"context_lines":[{"line_number":894,"context_line":"        query_dict \u003d {date_type: time_to_search_1}"},{"line_number":895,"context_line":"        secret_list \u003d self.barbicanclient.secrets.list(**query_dict)"},{"line_number":896,"context_line":""},{"line_number":897,"context_line":"        self.assertEqual(1, len(secret_list))"},{"line_number":898,"context_line":""},{"line_number":899,"context_line":"        # Search for secrets with time \u003c secret 2, i.e. secret 1"},{"line_number":900,"context_line":"        query_dict \u003d {date_type: \u0027lt:\u0027 + time_to_search_2}"}],"source_content_type":"text/x-python","patch_set":15,"id":"5ff73747_d6c1fc55","line":897,"range":{"start_line":897,"start_character":8,"end_line":897,"end_character":45},"updated":"2017-04-28 21:14:41.000000000","message":"Instead of just verifying whether only one item was returned, would it be better to also verify that the correct item was returned (that is, secret 1)?","commit_id":"7ad162938eedb366193dd9d326adf143aca72d8d"},{"author":{"_account_id":21797,"name":"Jeremy Liu","display_name":"Jeremy Liu","email":"liujiong.cc@gmail.com","username":"liujiong"},"change_message_id":"0cdc0556373f6ac13248afb1df72e271db60d8e4","unresolved":false,"context_lines":[{"line_number":895,"context_line":"        secret_list \u003d self.barbicanclient.secrets.list(**query_dict)"},{"line_number":896,"context_line":""},{"line_number":897,"context_line":"        self.assertEqual(1, len(secret_list))"},{"line_number":898,"context_line":"\tself.assertEqual(secret_1_ref, secret_list[0].secret_ref)"},{"line_number":899,"context_line":""},{"line_number":900,"context_line":"        # Search for secrets with time \u003c secret 2, i.e. secret 1"},{"line_number":901,"context_line":"        query_dict \u003d {date_type: \u0027lt:\u0027 + time_to_search_2}"}],"source_content_type":"text/x-python","patch_set":16,"id":"5ff73747_0f5b9af5","line":898,"range":{"start_line":898,"start_character":0,"end_line":898,"end_character":1},"updated":"2017-05-02 09:13:26.000000000","message":"tab, pep8 just tests barbicanclient directory :(","commit_id":"ae3efdfb4fb9bf5c0c843007043249b98414ef31"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"14665bd54fc77c8386191a9ac29e5f68132d8394","unresolved":false,"context_lines":[{"line_number":895,"context_line":"        secret_list \u003d self.barbicanclient.secrets.list(**query_dict)"},{"line_number":896,"context_line":""},{"line_number":897,"context_line":"        self.assertEqual(1, len(secret_list))"},{"line_number":898,"context_line":"\tself.assertEqual(secret_1_ref, secret_list[0].secret_ref)"},{"line_number":899,"context_line":""},{"line_number":900,"context_line":"        # Search for secrets with time \u003c secret 2, i.e. secret 1"},{"line_number":901,"context_line":"        query_dict \u003d {date_type: \u0027lt:\u0027 + time_to_search_2}"}],"source_content_type":"text/x-python","patch_set":16,"id":"ff0f0b1f_6860c133","line":898,"range":{"start_line":898,"start_character":0,"end_line":898,"end_character":1},"in_reply_to":"5ff73747_0f5b9af5","updated":"2017-05-17 18:30:33.000000000","message":"Done","commit_id":"ae3efdfb4fb9bf5c0c843007043249b98414ef31"},{"author":{"_account_id":21797,"name":"Jeremy Liu","display_name":"Jeremy Liu","email":"liujiong.cc@gmail.com","username":"liujiong"},"change_message_id":"0cdc0556373f6ac13248afb1df72e271db60d8e4","unresolved":false,"context_lines":[{"line_number":917,"context_line":"        self.assertEqual(1, len(secret_list))"},{"line_number":918,"context_line":"        self.assertEqual(secret_2_ref, secret_list[0].secret_ref)"},{"line_number":919,"context_line":""},{"line_number":920,"context_line":"        # Search for secrets with time \u003e\u003d secret 2, i.e. both secrets"},{"line_number":921,"context_line":"        query_dict \u003d {date_type: \u0027gte:\u0027 + time_to_search_1}"},{"line_number":922,"context_line":"        secret_list \u003d self.barbicanclient.secrets.list(**query_dict)"},{"line_number":923,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"5ff73747_6f869e68","line":920,"range":{"start_line":920,"start_character":42,"end_line":920,"end_character":50},"updated":"2017-05-02 09:13:26.000000000","message":"should be secret 1\n\nAlso is it necessary to test \"time \u003c secret 1\" and \"time \u003e secret 2\", which should return an empty list?","commit_id":"ae3efdfb4fb9bf5c0c843007043249b98414ef31"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"14665bd54fc77c8386191a9ac29e5f68132d8394","unresolved":false,"context_lines":[{"line_number":917,"context_line":"        self.assertEqual(1, len(secret_list))"},{"line_number":918,"context_line":"        self.assertEqual(secret_2_ref, secret_list[0].secret_ref)"},{"line_number":919,"context_line":""},{"line_number":920,"context_line":"        # Search for secrets with time \u003e\u003d secret 2, i.e. both secrets"},{"line_number":921,"context_line":"        query_dict \u003d {date_type: \u0027gte:\u0027 + time_to_search_1}"},{"line_number":922,"context_line":"        secret_list \u003d self.barbicanclient.secrets.list(**query_dict)"},{"line_number":923,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"ff0f0b1f_48b17d8f","line":920,"range":{"start_line":920,"start_character":42,"end_line":920,"end_character":50},"in_reply_to":"5ff73747_6f869e68","updated":"2017-05-17 18:30:33.000000000","message":"Done","commit_id":"ae3efdfb4fb9bf5c0c843007043249b98414ef31"}]}