)]}'
{"barbicanclient/tests/test_orders.py":[{"author":{"_account_id":21797,"name":"Jeremy Liu","display_name":"Jeremy Liu","email":"liujiong.cc@gmail.com","username":"liujiong"},"change_message_id":"7b4366e80878bc0494f7a469c2cbbd72806cdefb","unresolved":false,"context_lines":[{"line_number":216,"context_line":"        self.responses.post(self.entity_base + \u0027/\u0027, json\u003ddata)"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"        passphrase \u003d str(uuid.uuid4())"},{"line_number":219,"context_line":"        order \u003d orders.AsymmetricOrder("},{"line_number":220,"context_line":"            api\u003dself.manager._api,"},{"line_number":221,"context_line":"            name\u003d\u0027name\u0027,"},{"line_number":222,"context_line":"            algorithm\u003d\u0027algorithm\u0027,"},{"line_number":223,"context_line":"            payload_content_type\u003d\u0027payload_content_type\u0027,"},{"line_number":224,"context_line":"            passphrase\u003dpassphrase,"},{"line_number":225,"context_line":"        )"},{"line_number":226,"context_line":"        order_href \u003d order.submit()"},{"line_number":227,"context_line":"        self.assertEqual(self.entity_href, order_href)"},{"line_number":228,"context_line":"        self.assertEqual(order.pass_phrase, passphrase)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_1a0c24eb","line":225,"range":{"start_line":219,"start_character":0,"end_line":225,"end_character":9},"updated":"2016-12-12 15:04:29.000000000","message":"Why not following line#189?","commit_id":"740b7b361c4b4a7ad9b8936623e914df72e97193"},{"author":{"_account_id":21797,"name":"Jeremy Liu","display_name":"Jeremy Liu","email":"liujiong.cc@gmail.com","username":"liujiong"},"change_message_id":"d6b754bd496f672b6c91767797d0a6b74c8ffe94","unresolved":false,"context_lines":[{"line_number":216,"context_line":"        self.responses.post(self.entity_base + \u0027/\u0027, json\u003ddata)"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"        passphrase \u003d str(uuid.uuid4())"},{"line_number":219,"context_line":"        order \u003d orders.AsymmetricOrder("},{"line_number":220,"context_line":"            api\u003dself.manager._api,"},{"line_number":221,"context_line":"            name\u003d\u0027name\u0027,"},{"line_number":222,"context_line":"            algorithm\u003d\u0027algorithm\u0027,"},{"line_number":223,"context_line":"            payload_content_type\u003d\u0027payload_content_type\u0027,"},{"line_number":224,"context_line":"            passphrase\u003dpassphrase,"},{"line_number":225,"context_line":"        )"},{"line_number":226,"context_line":"        order_href \u003d order.submit()"},{"line_number":227,"context_line":"        self.assertEqual(self.entity_href, order_href)"},{"line_number":228,"context_line":"        self.assertEqual(order.pass_phrase, passphrase)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_b3cb181e","line":225,"range":{"start_line":219,"start_character":0,"end_line":225,"end_character":9},"in_reply_to":"1a6eadb0_93361cb3","updated":"2016-12-12 15:14:47.000000000","message":"I agree, should be this way.","commit_id":"740b7b361c4b4a7ad9b8936623e914df72e97193"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"07a87fb88cbcf872a2babb0a988fda8adbf60d86","unresolved":false,"context_lines":[{"line_number":216,"context_line":"        self.responses.post(self.entity_base + \u0027/\u0027, json\u003ddata)"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"        passphrase \u003d str(uuid.uuid4())"},{"line_number":219,"context_line":"        order \u003d orders.AsymmetricOrder("},{"line_number":220,"context_line":"            api\u003dself.manager._api,"},{"line_number":221,"context_line":"            name\u003d\u0027name\u0027,"},{"line_number":222,"context_line":"            algorithm\u003d\u0027algorithm\u0027,"},{"line_number":223,"context_line":"            payload_content_type\u003d\u0027payload_content_type\u0027,"},{"line_number":224,"context_line":"            passphrase\u003dpassphrase,"},{"line_number":225,"context_line":"        )"},{"line_number":226,"context_line":"        order_href \u003d order.submit()"},{"line_number":227,"context_line":"        self.assertEqual(self.entity_href, order_href)"},{"line_number":228,"context_line":"        self.assertEqual(order.pass_phrase, passphrase)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_93361cb3","line":225,"range":{"start_line":219,"start_character":0,"end_line":225,"end_character":9},"in_reply_to":"3a71b18c_1a0c24eb","updated":"2016-12-12 15:09:43.000000000","message":"That\u0027s the intent of this test, to use this interface as well. These interfaces are actually used by other projects (e.g. heat) and it was changed, as mentioned in the commit message. Thus, the need to test it. Testing the helper function which only uses one parameter (passphrase without the underscore) wouldn\u0027t test what\u0027s actually being changed here.","commit_id":"740b7b361c4b4a7ad9b8936623e914df72e97193"},{"author":{"_account_id":21797,"name":"Jeremy Liu","display_name":"Jeremy Liu","email":"liujiong.cc@gmail.com","username":"liujiong"},"change_message_id":"0c467d928eeb3c851e2e0106c41e481ae8dcaa0b","unresolved":false,"context_lines":[{"line_number":225,"context_line":"        )"},{"line_number":226,"context_line":"        order_href \u003d order.submit()"},{"line_number":227,"context_line":"        self.assertEqual(self.entity_href, order_href)"},{"line_number":228,"context_line":"        self.assertEqual(order.pass_phrase, passphrase)"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"    def test_create_asymmetric_order_w_legacy_pass_phrase_param(self):"},{"line_number":231,"context_line":"        data \u003d {\u0027order_ref\u0027: self.entity_href}"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_16775ad5","line":228,"range":{"start_line":228,"start_character":8,"end_line":228,"end_character":55},"updated":"2016-12-12 15:34:57.000000000","message":"Just to be strict, the order of arguments should be exchanged.","commit_id":"740b7b361c4b4a7ad9b8936623e914df72e97193"},{"author":{"_account_id":21797,"name":"Jeremy Liu","display_name":"Jeremy Liu","email":"liujiong.cc@gmail.com","username":"liujiong"},"change_message_id":"0c467d928eeb3c851e2e0106c41e481ae8dcaa0b","unresolved":false,"context_lines":[{"line_number":241,"context_line":"        )"},{"line_number":242,"context_line":"        order_href \u003d order.submit()"},{"line_number":243,"context_line":"        self.assertEqual(self.entity_href, order_href)"},{"line_number":244,"context_line":"        self.assertEqual(order.pass_phrase, passphrase)"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"class WhenTestingOrderManager(OrdersTestCase):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_d643226b","line":244,"range":{"start_line":244,"start_character":8,"end_line":244,"end_character":55},"updated":"2016-12-12 15:34:57.000000000","message":"ditto","commit_id":"740b7b361c4b4a7ad9b8936623e914df72e97193"}]}