)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":21797,"name":"Jeremy Liu","display_name":"Jeremy Liu","email":"liujiong.cc@gmail.com","username":"liujiong"},"change_message_id":"7ccd90d0cf1c6749c465e6f32a8b2257fcc603bd","unresolved":false,"context_lines":[{"line_number":11,"context_line":"were being deleted from the lists as the list was being iterated"},{"line_number":12,"context_line":"over."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Incldes general clean-up of the entities being created and deleted."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I87d0ef93505ee46ab8314a2562b5d4ab59717649"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da36d5c6_3d82abc8","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":7},"updated":"2017-02-25 05:37:47.000000000","message":"typo?","commit_id":"4071903e22440e786046e72e6c943d0a6bc81f89"}],"functionaltests/cli/v1/behaviors/container_behaviors.py":[{"author":{"_account_id":21797,"name":"Jeremy Liu","display_name":"Jeremy Liu","email":"liujiong.cc@gmail.com","username":"liujiong"},"change_message_id":"7ccd90d0cf1c6749c465e6f32a8b2257fcc603bd","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        \"\"\"Delete all containers that we created\"\"\""},{"line_number":93,"context_line":"        # Create a copy of the list -- otherwise delete_container will remove"},{"line_number":94,"context_line":"        # items from the list as we are iterating over it"},{"line_number":95,"context_line":"        containers_to_delete \u003d list(self.container_hrefs_to_delete)"},{"line_number":96,"context_line":"        for href in containers_to_delete:"},{"line_number":97,"context_line":"            self.delete_container(href)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da36d5c6_bd769b03","line":95,"range":{"start_line":95,"start_character":8,"end_line":95,"end_character":67},"updated":"2017-02-25 05:37:47.000000000","message":"Good catch and follow the processing in acl_behaviors.\nhttps://github.com/openstack/python-barbicanclient/blob/master/functionaltests/cli/v1/behaviors/acl_behaviors.py#L194","commit_id":"4071903e22440e786046e72e6c943d0a6bc81f89"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"4341c8d831bc7f198f01d277ba558cb580128cc1","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        \"\"\"Delete all containers that we created\"\"\""},{"line_number":93,"context_line":"        # Create a copy of the list -- otherwise delete_container will remove"},{"line_number":94,"context_line":"        # items from the list as we are iterating over it"},{"line_number":95,"context_line":"        containers_to_delete \u003d list(self.container_hrefs_to_delete)"},{"line_number":96,"context_line":"        for href in containers_to_delete:"},{"line_number":97,"context_line":"            self.delete_container(href)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a1ff146_db3777ae","line":95,"range":{"start_line":95,"start_character":8,"end_line":95,"end_character":67},"in_reply_to":"da36d5c6_bd769b03","updated":"2017-03-15 20:08:22.000000000","message":"acl_behaviors is already fine because [entry for entry in self.acl_entity_set] is creating a copy of the list and iterating over it","commit_id":"4071903e22440e786046e72e6c943d0a6bc81f89"},{"author":{"_account_id":19554,"name":"Nam","email":"namnh68@fsoft.com.vn","username":"namnh"},"change_message_id":"74c8c98ccc80246f2688243022a17cbbf37d8157","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        \"\"\"Delete all containers that we created\"\"\""},{"line_number":93,"context_line":"        # Create a copy of the list -- otherwise delete_container will remove"},{"line_number":94,"context_line":"        # items from the list as we are iterating over it"},{"line_number":95,"context_line":"        containers_to_delete \u003d list(self.container_hrefs_to_delete)"},{"line_number":96,"context_line":"        for href in containers_to_delete:"},{"line_number":97,"context_line":"            self.delete_container(href)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a1ced50_031a536e","line":97,"range":{"start_line":95,"start_character":8,"end_line":97,"end_character":39},"updated":"2017-03-21 02:56:53.000000000","message":"In my option, it is better if we can use like this. For more pythonic\n\"\"\"\nfor href in self.container_hrefs_to_delete[::]:\n    self.delete_container(href)\n\"\"\"","commit_id":"22b3002fbc25d48ba2db3242d0898dff6c1a533e"},{"author":{"_account_id":9234,"name":"Steve Heyman","email":"steve@heyman.com","username":"hockeynut"},"change_message_id":"177f47dd998ec9ba35511add22c88ca5601391fb","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        \"\"\"Delete all containers that we created\"\"\""},{"line_number":93,"context_line":"        # Create a copy of the list -- otherwise delete_container will remove"},{"line_number":94,"context_line":"        # items from the list as we are iterating over it"},{"line_number":95,"context_line":"        containers_to_delete \u003d list(self.container_hrefs_to_delete)"},{"line_number":96,"context_line":"        for href in containers_to_delete:"},{"line_number":97,"context_line":"            self.delete_container(href)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_e60b76d3","line":97,"range":{"start_line":95,"start_character":8,"end_line":97,"end_character":39},"in_reply_to":"1a1ced50_031a536e","updated":"2017-03-27 21:17:03.000000000","message":"I prefer the original - clearer, easier to read.  Agreed this is a bit more pythonic, but at the expense of clarity.","commit_id":"22b3002fbc25d48ba2db3242d0898dff6c1a533e"}],"functionaltests/cli/v1/behaviors/secret_behaviors.py":[{"author":{"_account_id":19554,"name":"Nam","email":"namnh68@fsoft.com.vn","username":"namnh"},"change_message_id":"74c8c98ccc80246f2688243022a17cbbf37d8157","unresolved":false,"context_lines":[{"line_number":143,"context_line":"        \"\"\"Delete all secrets that we created\"\"\""},{"line_number":144,"context_line":"        # Create a copy of the list -- otherwise delete_secret will remove"},{"line_number":145,"context_line":"        # items from the list as we are iterating over it"},{"line_number":146,"context_line":"        secrets_to_delete \u003d list(self.secret_hrefs_to_delete)"},{"line_number":147,"context_line":"        for href in secrets_to_delete:"},{"line_number":148,"context_line":"            self.delete_secret(href)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a1ced50_432a8b7f","line":148,"range":{"start_line":146,"start_character":8,"end_line":148,"end_character":36},"updated":"2017-03-21 02:56:53.000000000","message":"dito","commit_id":"22b3002fbc25d48ba2db3242d0898dff6c1a533e"}]}