)]}'
{"barbicanclient/secrets.py":[{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"437cbeeb6290ebf31576f9d68994df2dba68bd30","unresolved":false,"context_lines":[{"line_number":464,"context_line":"        \"\"\""},{"line_number":465,"context_line":"        LOG.debug(\"Getting secret - Secret href: {0}\".format(secret_ref))"},{"line_number":466,"context_line":"        base.validate_ref(secret_ref, \u0027Secret\u0027)"},{"line_number":467,"context_line":"        if not secret_ref:"},{"line_number":468,"context_line":"            raise ValueError(\u0027secret_ref is required.\u0027)"},{"line_number":469,"context_line":""},{"line_number":470,"context_line":"        if type(payload_content_type) is six.binary_type:"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba2be162_2e441a48","line":467,"updated":"2017-03-06 15:08:34.000000000","message":"I would move this if-statement to the top of the get method, so as to avoid errors if LOG.debug tries to access a non-existent secret_ref","commit_id":"fae5485c6ab8da337305635e663c71210bc8a9ce"},{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"437cbeeb6290ebf31576f9d68994df2dba68bd30","unresolved":false,"context_lines":[{"line_number":465,"context_line":"        LOG.debug(\"Getting secret - Secret href: {0}\".format(secret_ref))"},{"line_number":466,"context_line":"        base.validate_ref(secret_ref, \u0027Secret\u0027)"},{"line_number":467,"context_line":"        if not secret_ref:"},{"line_number":468,"context_line":"            raise ValueError(\u0027secret_ref is required.\u0027)"},{"line_number":469,"context_line":""},{"line_number":470,"context_line":"        if type(payload_content_type) is six.binary_type:"},{"line_number":471,"context_line":"            headers \u003d {\u0027content-type\u0027: \"application/octet-stream\"}"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba2be162_ce637eaf","line":468,"updated":"2017-03-06 15:08:34.000000000","message":"NIT: Clarify error message: \"Secret reference is required.\"","commit_id":"fae5485c6ab8da337305635e663c71210bc8a9ce"},{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"437cbeeb6290ebf31576f9d68994df2dba68bd30","unresolved":false,"context_lines":[{"line_number":472,"context_line":"        elif type(payload_content_type) is six.text_type:"},{"line_number":473,"context_line":"            headers \u003d {\u0027content-type\u0027: \"text/plain\"}"},{"line_number":474,"context_line":"        else:"},{"line_number":475,"context_line":"            raise exceptions.PayloadException(\"Invalid Payload Type\")"},{"line_number":476,"context_line":""},{"line_number":477,"context_line":"        return Secret("},{"line_number":478,"context_line":"            api\u003dself._api,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba2be162_ce17fea0","line":475,"updated":"2017-03-06 15:08:34.000000000","message":"This implies that calls to get() must specify a payload_content_type. This should not be not be the case, as the payload_content_type should be set to the default content_type if not specified (line 185). Furthermore, the method documentation indicates that setting the payload_content_type is deprecated, as it can lead to unexpected results.","commit_id":"fae5485c6ab8da337305635e663c71210bc8a9ce"},{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"6340c06729e54cb76a9eda29b93e39acdd7a51c7","unresolved":false,"context_lines":[{"line_number":473,"context_line":"        elif type(payload_content_type) is six.text_type:"},{"line_number":474,"context_line":"            headers \u003d {\u0027content-type\u0027: \"text/plain\"}"},{"line_number":475,"context_line":"        else:"},{"line_number":476,"context_line":"            raise exceptions.PayloadException(\"Invalid Payload content type\")"},{"line_number":477,"context_line":""},{"line_number":478,"context_line":"        return Secret("},{"line_number":479,"context_line":"            api\u003dself._api,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a30ddce_b948de88","line":476,"updated":"2017-03-09 01:31:47.000000000","message":"Are we sure we want to raise a PayloadException if the payload content type is not six.binary_type or six.text_type? According to the note at the top of this method, setting payload_content_type has been deprecated, so None may be a valid value.","commit_id":"54bf44dce746aed6b29a7326894f699c8fc5a820"},{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"1ae06bf4da3d54b9f6f30e99fa9f2f39935b54cb","unresolved":false,"context_lines":[{"line_number":473,"context_line":"        elif type(payload_content_type) is six.text_type:"},{"line_number":474,"context_line":"            headers \u003d {\u0027content-type\u0027: \"text/plain\"}"},{"line_number":475,"context_line":"        else:"},{"line_number":476,"context_line":"            raise exceptions.PayloadException(\"NONE\")"},{"line_number":477,"context_line":""},{"line_number":478,"context_line":"        return Secret("},{"line_number":479,"context_line":"            api\u003dself._api,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a30ddce_cc5dbb48","line":476,"updated":"2017-03-09 14:58:36.000000000","message":"This is still raising a PayloadException and does not take into account a NONE payload_content_type","commit_id":"8447faf674c6403cd7966102817bffbc74ff0543"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"2f5b915a325dc9e75691b5b1b28f343e92d65ff2","unresolved":false,"context_lines":[{"line_number":464,"context_line":"        \"\"\""},{"line_number":465,"context_line":""},{"line_number":466,"context_line":"        if not secret_ref:"},{"line_number":467,"context_line":"            raise ValueError(\u0027Secret reference is required.\u0027)"},{"line_number":468,"context_line":"        LOG.debug(\"Getting secret - Secret href: {0}\".format(secret_ref))"},{"line_number":469,"context_line":"        base.validate_ref(secret_ref, \u0027Secret\u0027)"},{"line_number":470,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a25e98e_755252df","line":467,"range":{"start_line":467,"start_character":29,"end_line":467,"end_character":61},"updated":"2017-03-13 19:49:09.000000000","message":"I\u0027d argue that you should change this back to how you originally had it: \u0027secret_ref is required.\u0027  That\u0027s the language the rest of the methods use.","commit_id":"c315073cd1028cb5b6ea3e7276a2b4b3529bb908"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"2f5b915a325dc9e75691b5b1b28f343e92d65ff2","unresolved":false,"context_lines":[{"line_number":469,"context_line":"        base.validate_ref(secret_ref, \u0027Secret\u0027)"},{"line_number":470,"context_line":""},{"line_number":471,"context_line":"        if type(payload_content_type) is six.binary_type:"},{"line_number":472,"context_line":"            headers \u003d {\u0027content-type\u0027: \"application/octet-stream\"}"},{"line_number":473,"context_line":"        elif type(payload_content_type) is six.text_type:"},{"line_number":474,"context_line":"            headers \u003d {\u0027content-type\u0027: \"text/plain\"}"},{"line_number":475,"context_line":"        else:"},{"line_number":476,"context_line":"            raise NotImplementedError"},{"line_number":477,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a25e98e_b5620aac","line":474,"range":{"start_line":472,"start_character":12,"end_line":474,"end_character":52},"updated":"2017-03-13 19:49:09.000000000","message":"These headers values are not used anywhere.","commit_id":"c315073cd1028cb5b6ea3e7276a2b4b3529bb908"},{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"c2519b47593d200fd7036d5cbafc541b083a8ec8","unresolved":false,"context_lines":[{"line_number":472,"context_line":"            headers \u003d {\u0027content-type\u0027: \"application/octet-stream\"}"},{"line_number":473,"context_line":"        elif type(payload_content_type) is six.text_type:"},{"line_number":474,"context_line":"            headers \u003d {\u0027content-type\u0027: \"text/plain\"}"},{"line_number":475,"context_line":"        else:"},{"line_number":476,"context_line":"            raise NotImplementedError"},{"line_number":477,"context_line":""},{"line_number":478,"context_line":"        return Secret("}],"source_content_type":"text/x-python","patch_set":6,"id":"9a30ddce_82615ed5","line":475,"updated":"2017-03-13 15:05:01.000000000","message":"Why do we need to throw an exception if the content-type is not six.binary_type or six.text_type?","commit_id":"c315073cd1028cb5b6ea3e7276a2b4b3529bb908"},{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"c2519b47593d200fd7036d5cbafc541b083a8ec8","unresolved":false,"context_lines":[{"line_number":473,"context_line":"        elif type(payload_content_type) is six.text_type:"},{"line_number":474,"context_line":"            headers \u003d {\u0027content-type\u0027: \"text/plain\"}"},{"line_number":475,"context_line":"        else:"},{"line_number":476,"context_line":"            raise NotImplementedError"},{"line_number":477,"context_line":""},{"line_number":478,"context_line":"        return Secret("},{"line_number":479,"context_line":"            api\u003dself._api,"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a30ddce_222272a3","line":476,"updated":"2017-03-13 15:05:01.000000000","message":"We shouldn\u0027t be raising a NotImplementedError in an implemented method","commit_id":"c315073cd1028cb5b6ea3e7276a2b4b3529bb908"}]}
