)]}'
{"barbicanclient/v1/containers.py":[{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"90a8db244cb3f3f93b1aa8782892f764b1a2ae4c","unresolved":false,"context_lines":[{"line_number":793,"context_line":""},{"line_number":794,"context_line":"    def create_dsa(self, name\u003dNone, public_key\u003dNone, private_key\u003dNone,"},{"line_number":795,"context_line":"                   private_key_passphrase\u003dNone):"},{"line_number":796,"context_line":"        \"\"\"Factory method for `RSAContainer` objects"},{"line_number":797,"context_line":""},{"line_number":798,"context_line":"        `RSAContainer` objects returned by this method have not yet been"},{"line_number":799,"context_line":"        stored in Barbican."},{"line_number":800,"context_line":""},{"line_number":801,"context_line":"        :param name: A friendly name for the RSAContainer"},{"line_number":802,"context_line":"        :param public_key: Secret object containing a Public Key"},{"line_number":803,"context_line":"        :param private_key: Secret object containing a Private Key"},{"line_number":804,"context_line":"        :param private_key_passphrase: Secret object containing a passphrase"},{"line_number":805,"context_line":"        :returns: RSAContainer"},{"line_number":806,"context_line":"        :rtype: :class:`barbicanclient.v1.containers.RSAContainer`"},{"line_number":807,"context_line":"        :raises barbicanclient.exceptions.HTTPAuthError: 401 Responses"},{"line_number":808,"context_line":"        :raises barbicanclient.exceptions.HTTPClientError: 4xx Responses"},{"line_number":809,"context_line":"        :raises barbicanclient.exceptions.HTTPServerError: 5xx Responses"},{"line_number":810,"context_line":"        \"\"\""},{"line_number":811,"context_line":"        return DSAContainer("},{"line_number":812,"context_line":"            api\u003dself._api,"}],"source_content_type":"text/x-python","patch_set":1,"id":"df7087c5_30ae9ee7","line":809,"range":{"start_line":796,"start_character":8,"end_line":809,"end_character":72},"updated":"2018-03-20 15:53:46.000000000","message":"The comments here still refer to RSA containers.  Which does raise the point though - how are RSA Containers and DSA containers different from each other?  Because if they are not - does it make sense to have a common AsymmetricKeyContainer to reduce the code repetition?","commit_id":"d3c2216baf426eeea12ae0cf2aa9163ac2f9bac1"},{"author":{"_account_id":25571,"name":"Rajat Sharma","email":"rajat.sharma@india.nec.com","username":"rajat29"},"change_message_id":"a68aef3db82db6252f1f9cc732d90625958ae552","unresolved":false,"context_lines":[{"line_number":793,"context_line":""},{"line_number":794,"context_line":"    def create_dsa(self, name\u003dNone, public_key\u003dNone, private_key\u003dNone,"},{"line_number":795,"context_line":"                   private_key_passphrase\u003dNone):"},{"line_number":796,"context_line":"        \"\"\"Factory method for `RSAContainer` objects"},{"line_number":797,"context_line":""},{"line_number":798,"context_line":"        `RSAContainer` objects returned by this method have not yet been"},{"line_number":799,"context_line":"        stored in Barbican."},{"line_number":800,"context_line":""},{"line_number":801,"context_line":"        :param name: A friendly name for the RSAContainer"},{"line_number":802,"context_line":"        :param public_key: Secret object containing a Public Key"},{"line_number":803,"context_line":"        :param private_key: Secret object containing a Private Key"},{"line_number":804,"context_line":"        :param private_key_passphrase: Secret object containing a passphrase"},{"line_number":805,"context_line":"        :returns: RSAContainer"},{"line_number":806,"context_line":"        :rtype: :class:`barbicanclient.v1.containers.RSAContainer`"},{"line_number":807,"context_line":"        :raises barbicanclient.exceptions.HTTPAuthError: 401 Responses"},{"line_number":808,"context_line":"        :raises barbicanclient.exceptions.HTTPClientError: 4xx Responses"},{"line_number":809,"context_line":"        :raises barbicanclient.exceptions.HTTPServerError: 5xx Responses"},{"line_number":810,"context_line":"        \"\"\""},{"line_number":811,"context_line":"        return DSAContainer("},{"line_number":812,"context_line":"            api\u003dself._api,"}],"source_content_type":"text/x-python","patch_set":1,"id":"df7087c5_1e835b06","line":809,"range":{"start_line":796,"start_character":8,"end_line":809,"end_character":72},"in_reply_to":"df7087c5_30ae9ee7","updated":"2018-03-21 04:19:09.000000000","message":"Agreed on the point that we can have a common AsymmetricKeyContainer, and I am working on that to.","commit_id":"d3c2216baf426eeea12ae0cf2aa9163ac2f9bac1"}]}
