)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"318d7af3b936baed72e4d55e98c0cc4e258aefe9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"97ad0812_42bc0a1d","updated":"2022-05-17 13:36:53.000000000","message":"Thanks for the patch, it looks grea except for a couple of minor issues.","commit_id":"d48f56c4c0a8f3df535ef40631a1f05cde4824bb"}],"barbicanclient/tests/v1/test_secrets.py":[{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"318d7af3b936baed72e4d55e98c0cc4e258aefe9","unresolved":true,"context_lines":[{"line_number":117,"context_line":"        self.assertNotEqual(binary_payload, secret_req[\u0027payload\u0027])"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    def test_should_store_text_type_as_text_plain(self):"},{"line_number":120,"context_line":"        \"\"\"We use bytes as the canonical text type.\"\"\""},{"line_number":121,"context_line":"        data \u003d {\u0027secret_ref\u0027: self.entity_href}"},{"line_number":122,"context_line":"        self.responses.post(self.entity_base + \u0027/\u0027, json\u003ddata)"},{"line_number":123,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"166a44ef_2b3cd95d","line":120,"range":{"start_line":120,"start_character":18,"end_line":120,"end_character":23},"updated":"2022-05-17 13:36:53.000000000","message":"s/bytes/unicode strings/","commit_id":"d48f56c4c0a8f3df535ef40631a1f05cde4824bb"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1e1466103e3f26980244a24a83812856f841dc60","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        self.assertNotEqual(binary_payload, secret_req[\u0027payload\u0027])"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    def test_should_store_text_type_as_text_plain(self):"},{"line_number":120,"context_line":"        \"\"\"We use bytes as the canonical text type.\"\"\""},{"line_number":121,"context_line":"        data \u003d {\u0027secret_ref\u0027: self.entity_href}"},{"line_number":122,"context_line":"        self.responses.post(self.entity_base + \u0027/\u0027, json\u003ddata)"},{"line_number":123,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"0dbae8fe_d28d653e","line":120,"range":{"start_line":120,"start_character":18,"end_line":120,"end_character":23},"in_reply_to":"166a44ef_2b3cd95d","updated":"2022-05-17 14:02:19.000000000","message":"Done. I made it \u0027unicode string\u0027 because I think that would be more appropriate as a class name.","commit_id":"d48f56c4c0a8f3df535ef40631a1f05cde4824bb"}],"barbicanclient/v1/orders.py":[{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"318d7af3b936baed72e4d55e98c0cc4e258aefe9","unresolved":true,"context_lines":[{"line_number":112,"context_line":"        return data"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"class Order(object, metaclass\u003dabc.ABCMeta):"},{"line_number":116,"context_line":"    \"\"\"Base order object to hold common functionality"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    This should be considered an abstract class that should not be"}],"source_content_type":"text/x-python","patch_set":1,"id":"de98972b_81cf8696","line":115,"range":{"start_line":115,"start_character":12,"end_line":115,"end_character":20},"updated":"2022-05-17 13:36:53.000000000","message":"object is not necessary here.","commit_id":"d48f56c4c0a8f3df535ef40631a1f05cde4824bb"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"db5c8e900539c173b5b5918a79718a769c33c000","unresolved":true,"context_lines":[{"line_number":112,"context_line":"        return data"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"class Order(object, metaclass\u003dabc.ABCMeta):"},{"line_number":116,"context_line":"    \"\"\"Base order object to hold common functionality"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    This should be considered an abstract class that should not be"}],"source_content_type":"text/x-python","patch_set":1,"id":"674148dd_87b78e29","line":115,"range":{"start_line":115,"start_character":12,"end_line":115,"end_character":20},"in_reply_to":"020d571d_b002b40b","updated":"2022-05-17 14:59:01.000000000","message":"Sounds good to me.","commit_id":"d48f56c4c0a8f3df535ef40631a1f05cde4824bb"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e90e9490c4872b6750cccb8bc161560d969d027c","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        return data"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"class Order(object, metaclass\u003dabc.ABCMeta):"},{"line_number":116,"context_line":"    \"\"\"Base order object to hold common functionality"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    This should be considered an abstract class that should not be"}],"source_content_type":"text/x-python","patch_set":1,"id":"e95cb6be_fa308cf4","line":115,"range":{"start_line":115,"start_character":12,"end_line":115,"end_character":20},"in_reply_to":"674148dd_87b78e29","updated":"2022-05-18 01:59:11.000000000","message":"Done","commit_id":"d48f56c4c0a8f3df535ef40631a1f05cde4824bb"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1e1466103e3f26980244a24a83812856f841dc60","unresolved":true,"context_lines":[{"line_number":112,"context_line":"        return data"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"class Order(object, metaclass\u003dabc.ABCMeta):"},{"line_number":116,"context_line":"    \"\"\"Base order object to hold common functionality"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    This should be considered an abstract class that should not be"}],"source_content_type":"text/x-python","patch_set":1,"id":"020d571d_b002b40b","line":115,"range":{"start_line":115,"start_character":12,"end_line":115,"end_character":20},"in_reply_to":"de98972b_81cf8696","updated":"2022-05-17 14:02:19.000000000","message":"We can remove it but I tend to leave that now because the other classes defined in this repo still inherit object.\n\nWe can remove all inheritances as a follow up. What do you think ?","commit_id":"d48f56c4c0a8f3df535ef40631a1f05cde4824bb"}]}