)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"a65d49eb4a5fbccf1adf4348647bd40582babe53","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"ddf98253_5cea4506","updated":"2022-11-30 13:21:19.000000000","message":"This looks much better. Just small comment as discussed.","commit_id":"44c9530d757b7d7e9163e533a8b19548415b4fbe"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"c402a36c82442cb48ca0d47a8b8f9dcca91c6eec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"79956c14_afa0b8bb","updated":"2022-12-01 11:24:55.000000000","message":"Looks good now.  Of course, the tests here will have to change when we make the changes we discussed when no version is requested and the server only supports version 1.0 instead of version 1.1.","commit_id":"ed284e225a520ac31ce41523d4d28413214bd13a"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"c71bd36dbe7fecd600f7bc574dc32c34a56bfac4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"1095e6b2_341da82f","updated":"2023-01-16 12:10:29.000000000","message":"The unit tests are failing because the contents of the microversion header is \"key-manager 1,1\" (comma instead of a dot)","commit_id":"0e03ba84ffa6f97184d9efd8b0545c752a0f980b"}],"barbicanclient/tests/test_client.py":[{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"994374293f35ef485f17510c71b6e0df9177f365","unresolved":true,"context_lines":[{"line_number":70,"context_line":"    }"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"def mock_response_return(response\u003dSTABLE_RESPONSE):"},{"line_number":74,"context_line":"    response_mock \u003d mock.MagicMock()"},{"line_number":75,"context_line":"    response_mock.json.return_value \u003d response"},{"line_number":76,"context_line":"    return response_mock"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f7f506b_4cbf8cc1","line":73,"range":{"start_line":73,"start_character":4,"end_line":73,"end_character":24},"updated":"2022-11-25 10:02:02.000000000","message":"can we make this a little more descriptive -- maybe mock_version_response ?","commit_id":"22ea5b68281f0cb58603fecde3c9085dead0fd09"},{"author":{"_account_id":34120,"name":"Andre Aranha","display_name":"afariasa","email":"afariasa@redhat.com","username":"afariasa"},"change_message_id":"41a9560d822a9ebb6055ff41fefc37d4f04980f5","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    }"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"def mock_response_return(response\u003dSTABLE_RESPONSE):"},{"line_number":74,"context_line":"    response_mock \u003d mock.MagicMock()"},{"line_number":75,"context_line":"    response_mock.json.return_value \u003d response"},{"line_number":76,"context_line":"    return response_mock"}],"source_content_type":"text/x-python","patch_set":4,"id":"54ed0eb0_af6aff58","line":73,"range":{"start_line":73,"start_character":4,"end_line":73,"end_character":24},"in_reply_to":"3f7f506b_4cbf8cc1","updated":"2022-11-28 15:46:48.000000000","message":"Done","commit_id":"22ea5b68281f0cb58603fecde3c9085dead0fd09"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"994374293f35ef485f17510c71b6e0df9177f365","unresolved":true,"context_lines":[{"line_number":390,"context_line":"        self.client \u003d client.Client(endpoint\u003dself.endpoint,"},{"line_number":391,"context_line":"                                    project_id\u003dself.project_id)"},{"line_number":392,"context_line":""},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"class WhenTestingClientMicroversion(TestClient):"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"    def _mock_session(self, versioned_endpoint, response\u003dSTABLE_RESPONSE):"}],"source_content_type":"text/x-python","patch_set":4,"id":"08a06e48_ef479214","line":393,"updated":"2022-11-25 10:02:02.000000000","message":"This is a good start - but its a little difficult to understand the cases that are being tested.  I think we just need to revise the names of the tests and the variable names to make the cases more explicit.\n\nIf I understand this patch correctly, you are essentially validating the _is_supported_microversion() method.  That method has some client side validation (does the client support the requested microversion?)  and some server side validation (does the server support the requested microversion?)\n\nAccordingly, some tests that are clearer would have parameters like:\n\nrequested_version\nclient_supported_versions  (or max, min)\nserver_supported_versions  (or max, min)\n\nAnd then have tests to test combinations accordingly.  This will help us ensure we\u0027re testing the right behavior.","commit_id":"22ea5b68281f0cb58603fecde3c9085dead0fd09"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"c402a36c82442cb48ca0d47a8b8f9dcca91c6eec","unresolved":false,"context_lines":[{"line_number":390,"context_line":"        self.client \u003d client.Client(endpoint\u003dself.endpoint,"},{"line_number":391,"context_line":"                                    project_id\u003dself.project_id)"},{"line_number":392,"context_line":""},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"class WhenTestingClientMicroversion(TestClient):"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"    def _mock_session(self, versioned_endpoint, response\u003dSTABLE_RESPONSE):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5b4d8867_0e66d53d","line":393,"in_reply_to":"08a06e48_ef479214","updated":"2022-12-01 11:24:55.000000000","message":"Done","commit_id":"22ea5b68281f0cb58603fecde3c9085dead0fd09"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"994374293f35ef485f17510c71b6e0df9177f365","unresolved":true,"context_lines":[{"line_number":423,"context_line":"            \"microversion\": \"v1\""},{"line_number":424,"context_line":"        }"},{"line_number":425,"context_line":""},{"line_number":426,"context_line":"        print(\"THE MICROVERSION\")"},{"line_number":427,"context_line":"        print(microversion)"},{"line_number":428,"context_line":"        if microversion:"},{"line_number":429,"context_line":"            kwargs[\"microversion\"] \u003d microversion"},{"line_number":430,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"c292b800_41da511e","line":427,"range":{"start_line":426,"start_character":5,"end_line":427,"end_character":27},"updated":"2022-11-25 10:02:02.000000000","message":"debug?","commit_id":"22ea5b68281f0cb58603fecde3c9085dead0fd09"},{"author":{"_account_id":34120,"name":"Andre Aranha","display_name":"afariasa","email":"afariasa@redhat.com","username":"afariasa"},"change_message_id":"600d60479643585821c4a18861bf711c2b7bb161","unresolved":false,"context_lines":[{"line_number":423,"context_line":"            \"microversion\": \"v1\""},{"line_number":424,"context_line":"        }"},{"line_number":425,"context_line":""},{"line_number":426,"context_line":"        print(\"THE MICROVERSION\")"},{"line_number":427,"context_line":"        print(microversion)"},{"line_number":428,"context_line":"        if microversion:"},{"line_number":429,"context_line":"            kwargs[\"microversion\"] \u003d microversion"},{"line_number":430,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"14c1b949_109fc223","line":427,"range":{"start_line":426,"start_character":5,"end_line":427,"end_character":27},"in_reply_to":"c292b800_41da511e","updated":"2022-11-28 15:48:15.000000000","message":"Done","commit_id":"22ea5b68281f0cb58603fecde3c9085dead0fd09"},{"author":{"_account_id":35125,"name":"Mauricio Harley","email":"mharley@redhat.com","username":"mharley-rh"},"change_message_id":"daa6a999a399f3562b985d0addb82929f05eb1fe","unresolved":true,"context_lines":[{"line_number":22,"context_line":"from barbicanclient import client"},{"line_number":23,"context_line":"from barbicanclient import exceptions"},{"line_number":24,"context_line":"from barbicanclient.exceptions import UnsupportedVersion"},{"line_number":25,"context_line":"from barbicanclient.tests.utils import get_server_supported_versions"},{"line_number":26,"context_line":"from barbicanclient.tests.utils import get_version_endpoint"},{"line_number":27,"context_line":"from barbicanclient.tests.utils import mock_session"},{"line_number":28,"context_line":"from barbicanclient.tests.utils import mock_session_get"},{"line_number":29,"context_line":"from barbicanclient.tests.utils import mock_session_get_endpoint"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"_DEFAULT_MICROVERSION \u003d (1, 1)"}],"source_content_type":"text/x-python","patch_set":7,"id":"4f23a787_07958933","line":29,"range":{"start_line":25,"start_character":0,"end_line":29,"end_character":64},"updated":"2022-12-01 12:06:22.000000000","message":"For the sole purpose of saving lines, shouldn\u0027t we use parenthesis here?\n\nfrom barbicanclient.tests.utils import (get_server_imported_versions, mock_session, ...)","commit_id":"a405173fb14b5b285f3f68c051732b6216f4decd"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"b8f791cb16b8613a82292803b187d76d0ce7c309","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from barbicanclient import client"},{"line_number":23,"context_line":"from barbicanclient import exceptions"},{"line_number":24,"context_line":"from barbicanclient.exceptions import UnsupportedVersion"},{"line_number":25,"context_line":"from barbicanclient.tests.utils import get_server_supported_versions"},{"line_number":26,"context_line":"from barbicanclient.tests.utils import get_version_endpoint"},{"line_number":27,"context_line":"from barbicanclient.tests.utils import mock_session"},{"line_number":28,"context_line":"from barbicanclient.tests.utils import mock_session_get"},{"line_number":29,"context_line":"from barbicanclient.tests.utils import mock_session_get_endpoint"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"_DEFAULT_MICROVERSION \u003d (1, 1)"}],"source_content_type":"text/x-python","patch_set":7,"id":"29e02950_b5c6f439","line":29,"range":{"start_line":25,"start_character":0,"end_line":29,"end_character":64},"in_reply_to":"4f23a787_07958933","updated":"2022-12-02 10:22:16.000000000","message":"I think it\u0027s still the convention to do it like this and in alphabetical order, otherwise it will fail linter checks in most projects. The imports are also divided into 3 sections, with std libraries, other libraries, and internal imports in the last one.","commit_id":"a405173fb14b5b285f3f68c051732b6216f4decd"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"b8f791cb16b8613a82292803b187d76d0ce7c309","unresolved":true,"context_lines":[{"line_number":458,"context_line":"            UnsupportedVersion, client.Client, session\u003dsess,"},{"line_number":459,"context_line":"            endpoint\u003dself.endpoint, microversion\u003drequested_version)"},{"line_number":460,"context_line":""},{"line_number":461,"context_line":"    def test_passes_with_stable_server_version(self):"},{"line_number":462,"context_line":"        requested_version \u003d \"1.0\""},{"line_number":463,"context_line":"        server_max_version \u003d None"},{"line_number":464,"context_line":"        server_min_version \u003d None"}],"source_content_type":"text/x-python","patch_set":10,"id":"f78e5758_93d8c2c9","line":461,"updated":"2022-12-02 10:22:16.000000000","message":"We also discussed a scenario when there is no requested version, in which case it would choose 1.1 or 1.0 depending on what\u0027s available. Which patch/gerrit review will be implementing this?","commit_id":"44c9530d757b7d7e9163e533a8b19548415b4fbe"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"8b7bc663eb8375d5c6014dd03672465794d03552","unresolved":true,"context_lines":[{"line_number":458,"context_line":"            UnsupportedVersion, client.Client, session\u003dsess,"},{"line_number":459,"context_line":"            endpoint\u003dself.endpoint, microversion\u003drequested_version)"},{"line_number":460,"context_line":""},{"line_number":461,"context_line":"    def test_passes_with_stable_server_version(self):"},{"line_number":462,"context_line":"        requested_version \u003d \"1.0\""},{"line_number":463,"context_line":"        server_max_version \u003d None"},{"line_number":464,"context_line":"        server_min_version \u003d None"}],"source_content_type":"text/x-python","patch_set":10,"id":"6b92a54a_bf6be217","line":461,"in_reply_to":"f78e5758_93d8c2c9","updated":"2023-01-05 13:11:37.000000000","message":"We still need to make sure this happens","commit_id":"44c9530d757b7d7e9163e533a8b19548415b4fbe"}],"barbicanclient/v1/client.py":[{"author":{"_account_id":35125,"name":"Mauricio Harley","email":"mharley@redhat.com","username":"mharley-rh"},"change_message_id":"daa6a999a399f3562b985d0addb82929f05eb1fe","unresolved":true,"context_lines":[{"line_number":41,"context_line":"        `barbicanclient.client.Client`.  It\u0027s recommended to use that"},{"line_number":42,"context_line":"        function instead of making instances of this class directly."},{"line_number":43,"context_line":"        \"\"\""},{"line_number":44,"context_line":"        microversion \u003d kwargs.pop(\u0027microversion\u0027, \u00271.1\u0027) or \u00271.1\u0027"},{"line_number":45,"context_line":"        if not self._is_supported_microversion("},{"line_number":46,"context_line":"            session,"},{"line_number":47,"context_line":"            kwargs.get(\u0027endpoint\u0027),"}],"source_content_type":"text/x-python","patch_set":7,"id":"98677543_1a118951","line":44,"range":{"start_line":44,"start_character":56,"end_line":44,"end_character":65},"updated":"2022-12-01 12:06:22.000000000","message":"Why is this \"or\" necessary, since \"1.1\" is already being provided as alternative result for the pop() method?\n\nReference:  https://python-reference.readthedocs.io/en/latest/docs/dict/pop.html","commit_id":"a405173fb14b5b285f3f68c051732b6216f4decd"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"a65d49eb4a5fbccf1adf4348647bd40582babe53","unresolved":true,"context_lines":[{"line_number":41,"context_line":"        `barbicanclient.client.Client`.  It\u0027s recommended to use that"},{"line_number":42,"context_line":"        function instead of making instances of this class directly."},{"line_number":43,"context_line":"        \"\"\""},{"line_number":44,"context_line":"        microversion \u003d kwargs.pop(\u0027microversion\u0027, \u00271.1\u0027) or \u00271.1\u0027"},{"line_number":45,"context_line":"        if not self._is_supported_microversion("},{"line_number":46,"context_line":"            session,"},{"line_number":47,"context_line":"            kwargs.get(\u0027endpoint\u0027),"}],"source_content_type":"text/x-python","patch_set":10,"id":"ed059d51_990c20aa","line":44,"updated":"2022-11-30 13:21:19.000000000","message":"as discussed, comment needed to explain this.","commit_id":"44c9530d757b7d7e9163e533a8b19548415b4fbe"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"c402a36c82442cb48ca0d47a8b8f9dcca91c6eec","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        `barbicanclient.client.Client`.  It\u0027s recommended to use that"},{"line_number":42,"context_line":"        function instead of making instances of this class directly."},{"line_number":43,"context_line":"        \"\"\""},{"line_number":44,"context_line":"        microversion \u003d kwargs.pop(\u0027microversion\u0027, \u00271.1\u0027) or \u00271.1\u0027"},{"line_number":45,"context_line":"        if not self._is_supported_microversion("},{"line_number":46,"context_line":"            session,"},{"line_number":47,"context_line":"            kwargs.get(\u0027endpoint\u0027),"}],"source_content_type":"text/x-python","patch_set":10,"id":"4fec91d4_7b5bd0e0","line":44,"in_reply_to":"ed059d51_990c20aa","updated":"2022-12-01 11:24:55.000000000","message":"Done","commit_id":"44c9530d757b7d7e9163e533a8b19548415b4fbe"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"d2be3655fd761d1ae639f9d3a5d83ee105849929","unresolved":true,"context_lines":[{"line_number":95,"context_line":"                version\u003dversion"},{"line_number":96,"context_line":"            )"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        resp \u003d discover.get_version_data("},{"line_number":99,"context_line":"            session, endpoint,"},{"line_number":100,"context_line":"            version_header\u003d\u0027key-manager \u0027 + microversion)"},{"line_number":101,"context_line":"        if resp:"},{"line_number":102,"context_line":"            resp \u003d resp[0]"},{"line_number":103,"context_line":"            status \u003d resp[\u0027status\u0027].upper()"}],"source_content_type":"text/x-python","patch_set":17,"id":"e04245cf_54b35201","line":100,"range":{"start_line":98,"start_character":8,"end_line":100,"end_character":57},"updated":"2023-01-05 10:21:01.000000000","message":"This is worth documenting here.  If we request a microversion that the server does not provide (like 1.9 for instance), does the server throw a UnsupportedVersion exception?","commit_id":"4e320c784452bf1a9dcfb47e8f5d9e519186e570"},{"author":{"_account_id":34120,"name":"Andre Aranha","display_name":"afariasa","email":"afariasa@redhat.com","username":"afariasa"},"change_message_id":"007ab83526bae1ccce041723093c4b6b93f5786f","unresolved":false,"context_lines":[{"line_number":95,"context_line":"                version\u003dversion"},{"line_number":96,"context_line":"            )"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        resp \u003d discover.get_version_data("},{"line_number":99,"context_line":"            session, endpoint,"},{"line_number":100,"context_line":"            version_header\u003d\u0027key-manager \u0027 + microversion)"},{"line_number":101,"context_line":"        if resp:"},{"line_number":102,"context_line":"            resp \u003d resp[0]"},{"line_number":103,"context_line":"            status \u003d resp[\u0027status\u0027].upper()"}],"source_content_type":"text/x-python","patch_set":17,"id":"02a66c11_e1bc3ab2","line":100,"range":{"start_line":98,"start_character":8,"end_line":100,"end_character":57},"in_reply_to":"920f81f4_4c77f3cd","updated":"2023-01-13 16:42:09.000000000","message":"Done","commit_id":"4e320c784452bf1a9dcfb47e8f5d9e519186e570"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"92f204d22318f29f0031529fbdc3636d2fdd00b6","unresolved":true,"context_lines":[{"line_number":95,"context_line":"                version\u003dversion"},{"line_number":96,"context_line":"            )"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        resp \u003d discover.get_version_data("},{"line_number":99,"context_line":"            session, endpoint,"},{"line_number":100,"context_line":"            version_header\u003d\u0027key-manager \u0027 + microversion)"},{"line_number":101,"context_line":"        if resp:"},{"line_number":102,"context_line":"            resp \u003d resp[0]"},{"line_number":103,"context_line":"            status \u003d resp[\u0027status\u0027].upper()"}],"source_content_type":"text/x-python","patch_set":17,"id":"920f81f4_4c77f3cd","line":100,"range":{"start_line":98,"start_character":8,"end_line":100,"end_character":57},"in_reply_to":"e04245cf_54b35201","updated":"2023-01-05 12:50:39.000000000","message":"The server responds with 406 Not Acceptable when you ask for the 1.9 version, this is the documented behavior [1]. I don\u0027t see UnsupportedVersion declared anywhere in keystoneauth, so it wouldn\u0027t throw that.\n\n[1] https://docs.openstack.org/barbican/latest/api/microversions.html#client-interaction","commit_id":"4e320c784452bf1a9dcfb47e8f5d9e519186e570"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"d2be3655fd761d1ae639f9d3a5d83ee105849929","unresolved":true,"context_lines":[{"line_number":112,"context_line":"                min_ver \u003d \u00271.0\u0027"},{"line_number":113,"context_line":"                max_ver \u003d \u00271.0\u0027"},{"line_number":114,"context_line":"            else:"},{"line_number":115,"context_line":"                # any other status will have a min/max"},{"line_number":116,"context_line":"                min_ver \u003d resp[\u0027min_version\u0027]"},{"line_number":117,"context_line":"                max_ver \u003d resp[\u0027max_version\u0027]"},{"line_number":118,"context_line":"            return discover.version_between(min_ver, max_ver, microversion)"}],"source_content_type":"text/x-python","patch_set":17,"id":"7b5aaddf_8be01293","line":115,"range":{"start_line":115,"start_character":16,"end_line":115,"end_character":54},"updated":"2023-01-05 10:21:01.000000000","message":"I\u0027m trying to understand how we get to this point?  What effect does the version_header parameter have on the call above?","commit_id":"4e320c784452bf1a9dcfb47e8f5d9e519186e570"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"da311662ec2c10e741e8c52bad658883d8f52626","unresolved":true,"context_lines":[{"line_number":112,"context_line":"                min_ver \u003d \u00271.0\u0027"},{"line_number":113,"context_line":"                max_ver \u003d \u00271.0\u0027"},{"line_number":114,"context_line":"            else:"},{"line_number":115,"context_line":"                # any other status will have a min/max"},{"line_number":116,"context_line":"                min_ver \u003d resp[\u0027min_version\u0027]"},{"line_number":117,"context_line":"                max_ver \u003d resp[\u0027max_version\u0027]"},{"line_number":118,"context_line":"            return discover.version_between(min_ver, max_ver, microversion)"}],"source_content_type":"text/x-python","patch_set":17,"id":"a0ed2ee5_51d331d9","line":115,"range":{"start_line":115,"start_character":16,"end_line":115,"end_character":54},"in_reply_to":"0adbac4f_e6aa6e50","updated":"2023-01-05 12:56:52.000000000","message":"Without the microversion, barbican, for backward compatibility returns an older output format, so for example, the following is the output without the microversion header:\n\u003e \n\u003e {\n\u003e   \"versions\": {\n\u003e     \"values\": [\n\u003e       {\n\u003e         \"id\": \"v1\",\n\u003e         \"status\": \"stable\",\n\u003e         \"links\": [\n\u003e           {\n\u003e             \"rel\": \"self\",\n\u003e             \"href\": \"http://localhost:9311/v1/\"\n\u003e           },\n\u003e           {\n\u003e             \"rel\": \"describedby\",\n\u003e             \"type\": \"text/html\",\n\u003e             \"href\": \"https://docs.openstack.org/\"\n\u003e           }\n\u003e         ],\n\u003e         \"media-types\": [\n\u003e           {\n\u003e             \"base\": \"application/json\",\n\u003e             \"type\": \"application/vnd.openstack.key-manager-v1+json\"\n\u003e           }\n\u003e         ]\n\u003e       }\n\u003e     ]\n\u003e   }\n\u003e }\n\u003e \n\u003e \n\nThis would presumably fall above into the first if clause.","commit_id":"4e320c784452bf1a9dcfb47e8f5d9e519186e570"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"92f204d22318f29f0031529fbdc3636d2fdd00b6","unresolved":true,"context_lines":[{"line_number":112,"context_line":"                min_ver \u003d \u00271.0\u0027"},{"line_number":113,"context_line":"                max_ver \u003d \u00271.0\u0027"},{"line_number":114,"context_line":"            else:"},{"line_number":115,"context_line":"                # any other status will have a min/max"},{"line_number":116,"context_line":"                min_ver \u003d resp[\u0027min_version\u0027]"},{"line_number":117,"context_line":"                max_ver \u003d resp[\u0027max_version\u0027]"},{"line_number":118,"context_line":"            return discover.version_between(min_ver, max_ver, microversion)"}],"source_content_type":"text/x-python","patch_set":17,"id":"0adbac4f_e6aa6e50","line":115,"range":{"start_line":115,"start_character":16,"end_line":115,"end_character":54},"in_reply_to":"7b5aaddf_8be01293","updated":"2023-01-05 12:50:39.000000000","message":"These are the versions part of the response from the new Barbican server:\n\nubuntu@afariasa-ubuntu-barbican:~$ curl -H \u0027OpenStack-API-Version: key-manager 1.1\u0027 http://localhost:9311 | jq\n{\n  \"versions\": [\n    {\n      \"id\": \"v1\",\n      \"status\": \"CURRENT\",\n      \"min_version\": \"1.0\",\n      \"max_version\": \"1.1\",\n      \"links\": [\n        {\n          \"rel\": \"self\",\n          \"href\": \"http://localhost:9311/v1/\"\n        },\n        {\n          \"rel\": \"describedby\",\n          \"type\": \"text/html\",\n          \"href\": \"https://docs.openstack.org/\"\n        }\n      ]\n    }\n  ]\n}","commit_id":"4e320c784452bf1a9dcfb47e8f5d9e519186e570"}]}